GitLab

This CL is part of the effort to improve performance of the password manager
settings. In particular, this CL fixes layout thrashing in the
updateOriginsEliding_ code. Prior to this change the code was first reading
style information from the DOM and then changing it in a loop.

This change creates a canvas element that is not part of the DOM.
It then uses the canvas to do the text measurements, thus avoiding the
repainting of the DOM. In the end, it writes the final obtained string in the
DOM, and thus does not change the display of the saved passwords.

Reference: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/measureText

BUG=651049
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2439453005
Cr-Commit-Position: refs/heads/master@{#427028}

This CL instroduces a new class MemoryCoordinatorProxy that is the proxy
of MemoryCoordinator in content/browser. MemoryCoordinator::
GetCurrentMemoryState to get the current memory state is now not
accessible by some MemoryCoordinatorClients, and MemoryCoordinatorProxy
offers the proxy function to access this.

This is used to get the current memory state by e.g. TabLoader in
chrome/browser or components in net.

BUG=639700

Review-Url: https://codereview.chromium.org/2434353003
Cr-Commit-Position: refs/heads/master@{#427027}

* ColorInputType and RangeInputType
  They don't need to override InputType::setValue(), and should override
  InputTypeView::didSetValue() instead. It makes code simpler.

* HTMLInputElement::setValueInternal()
  Removed unused TextFieldEventBehavior argument, and rename the function to
  setNonAttributeValue().
  Make sure this is only for ValueMode::kValue.

* TextFieldInputType::setValue()
  Don't call InputType::setValue(), and call setNonAttributeValue() directly.

* InputType::setValue()
  Make sure this is only for ValueMode::kValue.

This CL has no behavior changes.

Review-Url: https://codereview.chromium.org/2435973002
Cr-Commit-Position: refs/heads/master@{#427026}

Cr-Commit-Position: refs/heads/master@{#427025}

For cleanup, this CL makes WorkerThread inherit WebThread::TaskObserver and
removes WorkerMicrotaskRunner that is used for observing WebThread activities
and forwarding them to WorkerThread.

BUG=n/a

Review-Url: https://codereview.chromium.org/2440063002
Cr-Commit-Position: refs/heads/master@{#427024}

Sometimes ImeTest failed because it failed to click node. We suspect it's
because the screen is locked. So we add assertion to check whether that's
the case.

BUG=628964

Review-Url: https://codereview.chromium.org/2440353002
Cr-Commit-Position: refs/heads/master@{#427023}

The AssociatedURLLoader is derived from the WebURLLoader interface while
WebURLLoaderImpl is also derived from it. WebURLLoaderImpl is an API to
use the resource dispatcher and net stack beyond it. AssociatedURLLoader
is a wrapper for the DocumentThreadableLoader logic which implements
CORS, etc. defined in the Fetch Standard. They're not as-is. Even
looking at the API, there're clear differences e.g. the
WebURLLoaderOptions is specific to the AssociatedURLLoader.

This unnecessary inheritance has been causing confusion when reading
the code. We should remove this inheritance.

R=bbudge@chromium.org,jochen@chromium.org,kinuko@chromium.org,raymes@chromium.org,dalecurtis@chromium.org,mmenke@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2399463007
Cr-Commit-Position: refs/heads/master@{#427022}

BUG=504347
TBR=scottmg

Review-Url: https://codereview.chromium.org/2442903002
Cr-Commit-Position: refs/heads/master@{#427021}

Removed PassRefPtr copy constructor.

Added move wraps for remaining PassRefPtr copies (newly introduced).

BUG=640449

Review-Url: https://codereview.chromium.org/2437883002
Cr-Commit-Position: refs/heads/master@{#427020}

Old:
assert_true: should move from XXX to YYY expected true got false

New (actually in one line):
assert_equals: Focus should move forward from XXX to YYY
expected Element node <input id="YYY"></input> but
got Element node <input id="ZZZ">

Review-Url: https://codereview.chromium.org/2430313003
Cr-Commit-Position: refs/heads/master@{#427019}

When exiting the function because cannot open "oom_adj" file, not close the file handle "dirfd".

BUG=n/a

Review-Url: https://codereview.chromium.org/2419383008
Cr-Commit-Position: refs/heads/master@{#427018}

This CL expands WebsiteSettings histograms so that we can track actions
broken down by each of the following omnibox states:
- valid HTTPS url
- HTTPS URL that has been downgraded because of e.g. mixed content
- HTTPS URL that is marked dangerous (e.g. broken HTTPS or malware)
- HTTP URL that is marked dangerous (e.g. malware)
- HTTP URL that has a "Not secure" warning in the omnibox

BUG=647566

Review-Url: https://codereview.chromium.org/2434083002
Cr-Commit-Position: refs/heads/master@{#427017}

This patch makes |editingIgnoresContents()| as global function instead of
static member function of template class |EditingStratgegy| since it doesn't
use template parameter to simplify code for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2441693004
Cr-Commit-Position: refs/heads/master@{#427016}

Before this CL, MessagePort/ServiceWorker/Client can send an ArrayBuffer with
copy semantics, but it cannot send an ArrayBuffer with move semantics even if
it's specified as a transferable object.

  // Copy semantics.
  port.postMessage(arrayBuffer);

  // Move semantics. Currently, this doesn't work and shows a warning message
  // instead. See https://codereview.chromium.org/1301953002
  port.postMessage(arrayBuffer, [arrayBuffer]);

After this CL, they emulate move semantics by copy-and-neuter semantics that
sends an ArrayBuffer by copy semantics and neuters the original ArrayBuffer.

<Context of this change>

Because of Chromium's multi-process architecture, a target object can be in a
different process from a sender object. This makes it difficult to support
zero-copy transfer (move semantics) because it needs to stride over process
memory boundaries. Using shared memory is a possible solution, but that seems to
need architectual changes and introduce complexity. Therefore, as a stopgap, we
support sending a transferable ArrayBuffer with copy-and-neuter semantics.

See this document for more details:
https://docs.google.com/document/d/17o_cjtc3Gk5cDZhoUc37EyhhvBb4wMlCROJvoC2Aokg/edit#

BUG=334408, 511119

Review-Url: https://codereview.chromium.org/2414333003
Cr-Commit-Position: refs/heads/master@{#427015}

Convertion from sRGB to 8-bit linear is going to reduce the
precision of the texture, and the downsampling will do the
same thing. We should set texture internalformat to rgba32f
to optimize precision.

BUG=634519
TEST=conformance2/textures/misc/tex-srgb-mipmap.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2420813002
Cr-Commit-Position: refs/heads/master@{#427014}

This patch changes --mojo-service-worker to --disable-mojo-service-worker.
Let's try mojo for the service worker.

BUG=629701

Review-Url: https://codereview.chromium.org/2436223004
Cr-Commit-Position: refs/heads/master@{#427013}

BUG=555865

Review-Url: https://codereview.chromium.org/2444703002
Cr-Commit-Position: refs/heads/master@{#427012}

This CL add a Mojo IPC for synchronous resource loading, and plumps it
from content::ResourceDispatcher to content::ResourceDispatcherHost.

BUG=603396

Review-Url: https://codereview.chromium.org/2390983003
Cr-Commit-Position: refs/heads/master@{#427011}

As mentioned at https://crbug.com/602693#c17 and https://crbug.com/657869,
'[ Skip ]' in TestExpectations cannot be overwritten by WPTTestExpectations.
This patch changes '[ Skip ]' to '[ Failure ]' by default in TestExpectations
in order to run the w3c tests on WPTServe bots.

BUG=602693,453190,624278,617886,571722,618616
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests -f -t Debug imported/wpt/service-workers
TEST=./third_party/WebKit/Tools/Scripts/run-webkit-tests --enable-wptserve -f -t Debug imported/wpt/service-workers

Review-Url: https://codereview.chromium.org/2441963002
Cr-Commit-Position: refs/heads/master@{#427010}

Follow up patch that adds a new fake adapter that finishes a gatt operation
after a connect is called and adds tests that uses it.

Previous patch: http://crrev.com/2443473003

BUG=608538

Review-Url: https://codereview.chromium.org/2438963002
Cr-Commit-Position: refs/heads/master@{#427009}

Using update-w3c-deps in Chromium 14341400.

I ran update-w3c-deps and updated expectations and baselines manually on Friday last week since w3c-test-autoroller failed.

Review-Url: https://codereview.chromium.org/2434563008
Cr-Commit-Position: refs/heads/master@{#427008}

Rejects characteristic.readValue if the frame is not connected or if
the frame disconnects during the operation.

The new adapter has a Health Thermometer service with a measurement interval
characteristic. We use this characteristic because it the only standard
characteristic that supports Read, Write and Notify.

Reconnection tests in follow up patch: http://crrev.com/2438963002

BUG=608538

Review-Url: https://codereview.chromium.org/2443473003
Cr-Commit-Position: refs/heads/master@{#427007}

BUG=None
NO_DEPENDENCY_CHECKS=true

Review-Url: https://codereview.chromium.org/2418043003
Cr-Commit-Position: refs/heads/master@{#427006}

Currently, with HBD, if you navigate to https://get.adobe.com/flashplayer and
click "Download", it will trigger the Run Flash prompt. We should ignore
navigations if the source URL is the Flash download page itself.

BUG=656062

Review-Url: https://codereview.chromium.org/2435933002
Cr-Commit-Position: refs/heads/master@{#427005}

This is a non-urgent minor change in `webkit-patch rebaseline-cl` that would make it a little less verbose. Right now when you run `webkit-patch rebaseline-cl` by default it prints the list of tests to rebaseline twice: once before starting, listing specific builds, and once when actually downloading baselines.

After this CL, the more specific information (which builds are used) is only printed when --verbose is passed, and the default behavior is less verbose.

Review-Url: https://codereview.chromium.org/2438393002
Cr-Commit-Position: refs/heads/master@{#427004}

When quic_client is executed with --disable-certificate-verification,
it crashes with segmentation fault due to SCT check in
ProofVerifierChromium. Instead, FakeProofVerifier is added in order to
pass VerifyProof when a certification verification is disabled.

BUG=

Review-Url: https://codereview.chromium.org/2441053002
Cr-Commit-Position: refs/heads/master@{#427003}

https://chromium.googlesource.com/chromium/src/+/97e3ea432

BUG=650083
TBR=robhogan@gmail.com

Review URL: https://codereview.chromium.org/2443833002 .

Cr-Commit-Position: refs/heads/master@{#427002}

This CL renames VideoCaptureHostTest to VideoCaptureTest, since it
really is an integration test of a bunch of classes, as detailed in
the class-comments.  I've tried a few times to disentangle this
mess, in which VideoCaptureHost references MediaStreamManager knowing
that the latter is a singleton; MediaStreamManager publicly allows
everyone to access its VideoCaptureManager; VideoCaptureManager
is a concrete class owning pairs of VideoCaptureController -
VideoCaptureDevice; and VideoCaptureController uses via naked pointer
VideoCaptureHosts.  Not worth it for this unit test.

BUG=651897

Review-Url: https://chromiumcodereview.appspot.com/2435393003
Cr-Commit-Position: refs/heads/master@{#427001}

This patch fixes the timeline scrollbar offset for the canvas timeline
experiment.

R=dgozman
BUG=653738

Review-Url: https://chromiumcodereview.appspot.com/2438683004
Cr-Commit-Position: refs/heads/master@{#427000}

The enum definitions in our schemas can either be in the form of a list
value with string entries (e.g. "enum": ["foo", "bar", "baz"]) or in the
form of a dictionary with a name entry (e.g. "enum": [{"name": "foo"}]).

Adjust ArgumentSpec to account for the latter, and add tests.

BUG=653596

Review-Url: https://chromiumcodereview.appspot.com/2439263003
Cr-Commit-Position: refs/heads/master@{#426999}

Add zlib dependency in third_party/freetype2/BUILD.gn, as it is
already done in third_party/freetype-android/BUILD.gn to fix the
following compilation error:

  ../../src/third_party/freetype2/src/src/gzip/ftgzip.c:49:18: fatal
    error: zlib.h: No such file or directory

BUG=none

Review-Url: https://chromiumcodereview.appspot.com/2442733003
Cr-Commit-Position: refs/heads/master@{#426998}

The progression is seen in fast/text/ellipsis-at-edge-of-rtl-text-in-ltr-flow.html
and fast/css/text-overflow-input.html. We also now show an exta character of
text before the ellipsis where space is available.

BUG=650083

Review-Url: https://chromiumcodereview.appspot.com/2392433002
Cr-Commit-Position: refs/heads/master@{#426997}

Adds a new 'media_remoting' watchlist and cleans-up several miu@-owned
lists (due to file adds/moves/renames).

Review-Url: https://chromiumcodereview.appspot.com/2444693002
Cr-Commit-Position: refs/heads/master@{#426996}

Once the builder is added only the:
NGConstraintSpace(NGWritingMode, NGDirection, NGPhysicalConstraintSpace*)

should remain, this mirrors the NGFragment constructor which is just a "view"
on top of the NGPhysicalFragment.

This mirrors:
NGFragment(NGWritingMode, NGDirection, NGPhysicalFragment*)

BUG=635619

Review-Url: https://chromiumcodereview.appspot.com/2442123002
Cr-Commit-Position: refs/heads/master@{#426995}

With this CL, SequencedWorkerPool generates an event in the "toplevel"
category when it runs a task. This is the same behavior as MessageLoop,
TaskScheduler and WorkerPool.

BUG=611818

Review-Url: https://chromiumcodereview.appspot.com/2429863002
Cr-Commit-Position: refs/heads/master@{#426994}

BUG=648391

Review-Url: https://chromiumcodereview.appspot.com/2416293002
Cr-Commit-Position: refs/heads/master@{#426993}

Cr-Commit-Position: refs/heads/master@{#426992}

Revert of Move Layout Tree Construction code into Element::rebuildLayoutTree() (patchset #12 id:240001 of https://codereview.chromium.org/2398293003/ )

Reason for revert:
Suspected to cause crbug.com/658322.

Original issue's description:
> Move Layout Tree Construction code into Element::rebuildLayoutTree()
>
> This patch uses the two dirty bits (NeedsReattachLayoutTree and
> ChildNeedsReattachLayoutTree) on Node and adds the relevant
> getters/setters for them.
>
> It makes rebuildLayoutTree() public to be accessed in Document.cpp.
>
> It also moves reattachWhitespaceSiblingsIfNeeded() to rebuildLayoutTree() and
> uses dirtyBits to call either reattachLayoutTree() on node itself or call
> rebuildLayoutTree() on children nodes.
>
> Also added some comments explaining some design decisions. Will be removed
> upon completion of separation.
>
> BUG=595137
>
> Committed: https://crrev.com/09b7a8cf0647abca732b3718987a629d12a67fee
> Cr-Commit-Position: refs/heads/master@{#426353}

TBR=esprehn@chromium.org,bugsnash@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=595137

Review-Url: https://chromiumcodereview.appspot.com/2439973005
Cr-Commit-Position: refs/heads/master@{#426991}

Because of the cast of the RHS, |u|, a copy would be generated, with
code and cycle bloat as the result. In some cases this can even have
prevented inlining. Particularly nasty examples:

 bool compareEqual(const Vector<LengthPoint>&, const Vector<LengthPoint>&) [210 bytes]
 bool compareEqual(const Vector<CSSPropertyID>&, const Vector<CSSPropertyID>&) [274 bytes]
 bool compareEqual(const Vector<GridTrackSize>&, const Vector<GridTrackSize>&) [182 bytes]
 bool compareEqual(const HashMap<String, GridArea>&, const HashMap<String, GridArea>&) [308 bytes]
 bool compareEqual(const TransformOperations&, const TransformOperations&) [441 bytes]
 bool compareEqual(const LengthBox&, const LengthBox&) [249 bytes]

Remove the U->T cast in compareEqual to avoid the copies. Nothing seems
to require this coercion (anymore?) This eliminates the above symbols
entirely. A total binary size reduction of >30k (x86-64; non-official) also
indicates even the simpler cases/types may have benefited.

Review-Url: https://chromiumcodereview.appspot.com/2438353002
Cr-Commit-Position: refs/heads/master@{#426990}

We were storing the index in the DOM for the grid items
in m_gridItemsIndexesMap. However, we can already store the index
following the order-modified document order.

This allows us to simplify the sorter in painting,
as we don't need to check the order property now,
just simply use the stored index.

No new tests, as it's already covered by current tests.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://chromiumcodereview.appspot.com/2438253003
Cr-Commit-Position: refs/heads/master@{#426989}