GitLab

Font::CanShapeWordByWord() depends on font face specific data, and
hence, will be invalidated after a font face is loaded.

This patch moves the computation and caching from Font to
FontFallbackList, so that we don't need to invalidate Font for the data
after loading a font face.

This is preparation for crrev.com/c/1952189 that reduces invalidations
after font loading.

Bug: 441925
Change-Id: I605ffbc3981a56f6653cb32d5415b291b03f3b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026594
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736639}

Tests that involve clicking a link that results in a redirect were
failing with committed interstitials enabled. This CL changes the
check used to catch that case.

Bug: 1046832
Change-Id: Ib57bf24307b58b8441250aa448c271066e8b8ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028299Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736638}

Bug: none
Change-Id: I4ee105f45fb6f362e1e218e509aff98a6c48b839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026912
Auto-Submit: Andrew Moylan <amoylan@chromium.org>
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736637}

Bug: internal b/138682004
Change-Id: Ifcdb6af2ae4f55f723d2c7b793878ba17f7edb9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029195Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736636}

The omnibox uses BitmapFetcher to get Entity Suggestion images.

For on-focus suggestions, sometimes the images are included inline with
the Suggest results as data: URLs. This currently fails to render,
because BitmapFetcher cannot handle them.

This CL makes BitmapFetcher handle them and includes a test.

I implemented this functionality as part of BitmapFetcher instead of
further upstream, because there are multiple callers to BitmapFetcher
that may also run into this gotcha in the future, and it would be
unfortunate if they each had to write their own code to handle data:
URLs.

Bug: 1015174
Change-Id: Ibb68f0d0efdcaa8107d486dd88e3e3ccb50e2b84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017962Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736635}

The manager had only a single owner (StoragePartitionImpl) so there
was no reason it needed to be refcounted. Change ownership to be
unique_ptr.

Change-Id: Iea1895ecc41cb9614ef0f5624a6b0cfbc037e6bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028121
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736634}

AddSharedLocalizedStrings is removed and string providing functions
for shared components must be called explicitly from now on.
A11y strings that are shared by the top level A11y pages are
copied back into browser and os settings.  CaptionSubpage strings
remain in the shared string provider because the component itself
is shared by both browser and os settings.

Bug: 967888
Change-Id: I03af35e6577320ab75e1e859fb7ba8243f1cf757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028730
Auto-Submit: Regan Hsu <hsuregan@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736633}

In case of timeouts recipe utils try to kill test-runner process but
if timer.timeout is not exceeded, recipe call will be blocked.

It may be a cause of missing output folder since test_runner
not finished properly.

Fixed: 1011979
Change-Id: If0c0760036bb76567fe2ec625b4ee1b5831cae71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998998
Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736632}

These objects are not used when the passthrough command decoder is in
use.  This saves several GPU memory allocations in TextureManager for
default and black textures.

Saves ~2 MB per context.

BUG=1046613
BUG=1030835

Change-Id: I66c6acf28580742bc313d8cf79de80f7f7d98305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028291
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736631}

Bad message reporting has generally been allowed in Android WebView
crash keys, but the actual "mojo-message-error" key was omitted from the
whitelist. That makes it virtually impossible to debug bad Mojo message
crashes from WebView crash reports.

This whitelists the appropriate key.

Bug: 949005
Change-Id: I82ebd831732738385a5212349c04327412b57a40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028125Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#736630}

View information was not being removed from the current layout on view
removal, even though the current layout may have been calculated on the
most recent animation frame, previous to the view being removed.

In the worst case, this could cause a use-after-free if the view is
deleted on remove.

Now we remove both fade infos and current layout elements if they
correspond to the removed view.

Bug: 1046393
Change-Id: I364a2c604d0ae122540a170eec133d5d020b76e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027174
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736629}

https://skia.googlesource.com/skia.git/+log/8a46f7664675..d0a0c59c80b0

git log 8a46f7664675..d0a0c59c80b0 --date=short --first-parent --format='%ad %ae %s'
2020-01-29 nifong@google.com Return summaries of all layers for display
2020-01-29 egdaniel@google.com Use views throughout gpu blur code.

Created with:
  gclient setdep -r src/third_party/skia@d0a0c59c80b0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC reed@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: reed@google.com
Change-Id: I77ddaa643acbe4e7cbf08433fb9cae83ff8e5c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028864Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736628}

This CL changes GPU AC enabling to use a feature. It also removes the
flag from chrome://flags.

Bug: 807249
Change-Id: Ia0ace7865fbde135a4209b4b2f34ad809bd596cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025928Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Forshaw <forshaw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736627}

This CL updates the extension InstallLimiter to continue with deferred
or incoming extension installations when all external providers are
ready and all file sizes for incoming installations have been
determined. This prevents us from waiting the full 5s delay for large
(>1MB) extensions from being installed in case there are no other
smaller extensions to wait for.

Bug: 1046302
Change-Id: If98c6ee1b6ae1843efe884301676066ee15107a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023830
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736626}

This CL partially revives the logic from crrev.com/c/1471251 :
[omnibox] Eliminate side-button Pedal suggestion mode

Note that only the match handling part is restored and the code for
handling the Pedals button is ignored. The is due to the conditional
nature of application of this logic. When the button row feature is
enabled, we will use the button row on the triggering suggestion to
show the pedal on the same suggestion. When disabled, the existing
dedicated Pedal suggestion logic will be kept.

For now, the button row work is in progress, and until the row is
actually presented, enabling both Pedals and the row will
effectively hide the pedal in the triggering suggestion.

Bug: 1046523
Change-Id: Iacb1e02158ee054b877dd0095f3ddd3a0b533b1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027900
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736625}

Metrics are prolong on 4 releases ~1/2 years to M85.

Bug: 1037196, 1037195, 1037192, 1037191
Change-Id: I9741549353cec1d7b4e20d6230db36a5db2d3752
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027808Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736624}

It will be used in subsequent CL to reset state when the user removes
the value in a password field and no credentials to save anymore.

Bug:1042196

Change-Id: I9198d7338d66c21f4e97414caf271ae20ad9c1bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022645
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736623}

Bug: 1044306, 1042491, 1040177, 1042911
Change-Id: I37021bfce8f2d6a9b7bcd39df0a3d23eae0b6707
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028858
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736622}

In crrev.com/c/1965273 we started setting the CSS :target on the
document to the found match. However, this dirties style and may require
a lifecycle update, causing the computation of the highlight and scroll
rects to DCHECK. This patch adds a call to UpdateStyleAndLayout after
setting the target.

Bug: 1045117
Change-Id: Ic6648665ef7e7d1e9fba47a6bac0741803257269
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017562Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Nick Burris <nburris@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736621}

This applies the Theme.BrowserUI style to WebLayer, which is necessary
for things like js alert dialogs to look right.

    are including styles in
    //third_party/android_deps:com_android_support_design_java
    in WebView to support WebLayer UI, the onResourcesLoaded function
    increased in size to perform the package ID transform needed for
    WebView on those resources.

Binary-Size: Filed bug to track: http://crbug.com/1044234. Now that we
Bug: 1025256
Change-Id: If647a3f61e7b9d73ca30cc6dda4d612e392a669b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005671
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736620}

Just a rename. It was never really opaque to begin with.

Change-Id: Icebf4bcd53f1ee086c0479c912d2943478754c65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028862
Auto-Submit: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736619}

Register them in ChromePreferenceKeys and use SharedPreferencesManager
consistently instead of SharedPreferences directly.

Bug: 1022108
Change-Id: I696158b3391df4fe37a4ccab43e9e9e2a38424f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994097
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736618}

In turn, the compiler can then figure out some constants that are
declared extern are actually unused, so delete them,

2020 version of https://crrev.com/589575.

Change-Id: I7d98698f5124e8cd3f2f20611ea7e12b0f64e666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024507
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736617}

Adding empty implementations for:
 + AddAccountSigninCoordinator
 + AdvancedSettingsSigninCoordinator
 + UserSigninCoordinator

Related to crrev.com/c/2025547
Based on design: http://go/chrome-ios-signin-migration

Bug: 971989
Change-Id: Id14dc1ab0cfb18985332cc0c6aac021f4d439673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025353
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736616}

The type was refcounted, but only ever had a single owner
(StoragePartitionImpl). Change the ownership to unique_ptr and
slightly simplify the class.

Change-Id: Ic649dde3619fda849e1f9ccf0301a42eea4a7b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028651
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736615}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/82c1b418e2fb..f79f1d6d964c

git log 82c1b418e2fb..f79f1d6d964c --date=short --first-parent --format='%ad %ae %s'
2020-01-29 lomitch@microsoft.com Roll protocol changes for LayerTree.getCompositingReasons.

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@f79f1d6d964c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:946860
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8a322a09560ede932c5d50a57260002564121423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028860Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736614}

Browser now owns the Tabs. DCHECKs are added for the Android side, as the
Android side should always add/remove tests before destroying them.

BUG=1046406
TEST=covered by tests

Change-Id: I55660c528ae85224e42747446dab54e15ab307f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028297Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736613}

Bug: 1004441
Change-Id: Ia7d65837befbcc88f98c23e7644d6c2739bb0f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028172
Auto-Submit: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736612}

TBR=gambard@chromium.org

Bug: 1046978
Change-Id: If9c277062f710704baf798874f4cce8a0d454ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029229Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736611}

Change-Id: I7cbd8b04cc9246cd1c1495b207c4ff9a3fdb4b12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028665Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736610}

handling metrics."

The external protocol dialog class recorded metrics that fall under
the purview of the intent handling metrics class, so it has been
moved to be under that class structure. The original change caused
compile failures and was reverted, this one should be fixed.

BUG=1046611

TBR=djacobo@chromium.org
TBR reviewers:
djacobo: please review the changes to
         chrome/browser/chromeos/arc/intent_helper/
         arc_external_protocol_dialog.*

Change-Id: If47a6306f7baddb834585113736d4b8b2485f3d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027007
Commit-Queue: Alex Linker <ajlinker@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736609}

Bug: 1030399
Change-Id: Ia71eab69aba53f6548e48cede43bb5d29f868bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028157
Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736608}

Change-Id: Ie8ba0b911176f00be1b1cb77c0fedfe09ce229a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008288
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736607}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3796f09f..a4dcd39d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I631a5b55c968b8b98994745dc49336180f516e6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028668Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736606}

This is a step in the direction of letting each shelf component be a
little more independent for its layout and animation dynamics instead
of relying on the shelf layout manager.

Bug: 1040177, 1042911, 1044306
Change-Id: Ia06b72abc5c6e7575489abaf9a9efc0e90e4a840
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028163Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736605}

BUG=1011065

Change-Id: If4ddd178da9ec019623d50b3f77372be39ae487e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025884Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736604}

https://pdfium.googlesource.com/pdfium.git/+log/94294b48c239..1bb1301a369d

git log 94294b48c239..1bb1301a369d --date=short --first-parent --format='%ad %ae %s'
2020-01-29 thestig@chromium.org Refactor code into GetJpxDecodeAction().
2020-01-29 thestig@chromium.org Use FX_SAFE_INT32 in more places.
2020-01-29 thestig@chromium.org Updated libtiff from 4.0.10 to 4.1.0.
2020-01-29 tsepez@chromium.org Remove class CFX_GlobalArray.

Created with:
  gclient setdep -r src/third_party/pdfium@1bb1301a369d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1012369
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: Id0f957613b889dac93fe76ee6c951ccefc43fa3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028664Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#736603}

Bug: 1046482
Change-Id: Ia9465e9e79ea1c992cb755ac83e676cee02e5039
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025747Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736602}

Making the eligibility variables configurable via finch. This'll allow
us to alter these parameters independently of Chrome's release schedule.

Doc: go/roti-chrome-design
Bug: 1042087, 1041598
Change-Id: Iaf97b0ea4efdda30204596e74f6da2494aef3860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015983
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#736601}

Some client code modify prefs with .commit() instead of .apply(),
which causes the changes to be immediately committed to disk.

Bug: 1022108
Change-Id: Icda8655f0552da3c7adcb5c549397deaa943f471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018146Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736600}