- 26 Sep, 2019 40 commits
-
-
Henrique Nakashima authored
Bug: 995916 Change-Id: Ic874d6287e224da3277cff98457604617f5a64dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814919 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#700390}
-
Yue Li authored
Copied from email thread: EnableRequireVoiceMatchVerification option is intended to be used independent of whether or not the user has speaker id models on-device (i.e. Libassistant ignores that option if user has no SID model). The downside of conditionally enabling it would be: If the speech pipeline is already running when that option is set, the change won't take effect until next Speech pipeline restart (b/120241931). Bug: b/120241931 Test: Manual Test Change-Id: I0deef204ef5c6dd9ee36acbb5074d1a2e47731c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824676Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#700389}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b4ffe881cdd7..ee8ee2f10366 git log b4ffe881cdd7..ee8ee2f10366 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 henrika@webrtc.org Avoids update of WebRTC.Audio.SourceMatchesRecordingSession for Android < N 2019-09-26 sprang@webrtc.org Prepares RtpSenderVideo for batch forwarding of generated packets 2019-09-26 nisse@webrtc.org Report payload byte counts in PC-level quality tests Created with: gclient setdep -r src/third_party/webrtc@ee8ee2f10366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I38b2436719273b6b081cb43f6f6fbc54be6fd3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826866Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700388}
-
Amr Aboelkher authored
A device policy which controls the select to speak accessibility feature on the login screen.The policy can be applied as a recommended or mandatory policy. Test: 1. Set the login_screen_select_to_speak_enabled policy to True, open System Tray => "Accessibility", check that "Select-to-Speak" is displayed with a green check in the login screen. 2. Set the policy to False, open System Tray, check that "Select-to-Speak" is not displayed in the login screen. Bug: 552439 Change-Id: I86bfea61ccf3cac74934f17181c260d5649e04c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816558 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#700387}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 045ed7eb. With Chromium commits locally applied on WPT: 561a338c "Convert SensorProvider client to use BrowserInterfaceBroker" b5630d76 "Convert NFC client to use BrowserInterfaceBroker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib126001e6ac2eaf2343c70dde2665eee664b1696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827612Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700386}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d58b3ef67609..8f223cdf4c24 git log d58b3ef67609..8f223cdf4c24 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 lalitm@google.com Merge "trace_processor: add help command about json metrics being supported" 2019-09-26 fmayer@google.com Merge "Fix segfault in StackProfileTracker." 2019-09-26 lalitm@google.com Merge "trace_processor: optimize bitvector implementation" 2019-09-26 lalitm@google.com Merge "trace_processor: add better unittests and more benchmarks for bitvector" 2019-09-26 lalitm@google.com perfetto: fix formatting nit for internal code style Created with: gclient setdep -r src/third_party/perfetto@8f223cdf4c24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I118a4bc40f20a9e24c3ba447adb0d402fb8e6871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827493Reviewed-by:
-
Jazz Xu authored
Change scrub bar color to #8AB4F8, 100% opacity for played, 30% for remaining track. Bug: 1008228 Change-Id: I1cbc1c80bb3bcdd2bf450bfde90be3b07007c382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825792 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#700384}
-
dpapad authored
This is necessary to allow migrating the PDF viewer from Polymer2 to Polymer3, since the latter uses generated files. Added automated test. Can also verify manually as follows 1) Visit chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/elements/shared-vars.m.js 2) Should see the contents of the generated file. Bug: 1005029 Change-Id: I762672a0078f00b62500391f2d880d5e6432befe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814840 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#700383}
-
Zhenyao Mo authored
In many situations the same GPU on different OEM devices manifest different behaviors, so it's important to switch from 2-part identification of a GPU (vendor_id, device_id) to 4-part: (vendor_id, device_id, sub_sys_id, revision) This is the first CL. This adds the fields to GPUInfo and add the info collection and wire the info to about:gpu page. BUG=1006960 TEST=gpu_unittests, about:gpu R=sunnyps@chromium.org,dcheng@chromium.org Change-Id: Ia8623cdf842ec8eb899a018c26c9267fb9a2c880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824457 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#700382}
-
Clark DuVall authored
It's possible the AppCacheQuotaClient's callback is holding the last reference to QuotaManager, which means QuotaManager gets destroyed when those callbacks are run. This causes AppCacheQuotaClient to be destroyed when it is still executing code in NotifyAppCacheDestroyed. Bug: 1003298 Change-Id: I07afe921c10f34c9bdee8c020b7194e659337281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827490 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#700381}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1ab7b6816f57..983111f039f6 git log 1ab7b6816f57..983111f039f6 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 qyearsley@chromium.org Add `git cl try --retry-failed` Created with: gclient setdep -r src/third_party/depot_tools@983111f039f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:985887 Change-Id: Ifea864280c2ae2acc8cdfb61d9944c2daaf42f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827492Reviewed-by:
-
Denis Kuznetsov authored
Variables are conditionally set depending on media size. Bug: 1000606 Change-Id: Iae4ec877910814541cd57c6ce3ffda0620d0a9b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827295Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#700379}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I8bce88cb7d2c28717011452f84c24a3f89beae67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826650Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#700378}
-
Thomas Anderson authored
This reverts commit 7df96a78. Reason for revert: Causing build failure on Linux Builder (dbg)(32): https://ci.chromium.org/p/chromium/builders/ci/Linux%20Builder%20%28dbg%29%2832%29/121638 Original change's description: > Remove sorting_context_id from cc::Layer and calling code. > > This code is not used now that BlinkGenPropertyTrees has launched. > > Bug: 993936,1008483 > > Change-Id: Ia253725e327c5d115c95e341f7791539e881cc9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817318 > Auto-Submit: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700372} TBR=wangxianzhu@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org,masonfreed@chromium.org,michaelludwig@google.com Change-Id: I0145691722859f20dc99aabee84db432caf2cbe7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993936, 1008483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827253Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700377}
-
Xianzhu Wang authored
- Force compositing for backdrop-filters. We probably won't support non-composited backdrop-filters because it depends on viz renderers. - Paint empty display item for backdrop-filter to ensure a paint chunk which will create the composited backdrop-filter layer. Bug: 923429 Change-Id: Ib2afbde2c4ad3a485049b25ee63d6537f675ade6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824317 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#700376}
-
Raul Tambre authored
Conversion was done automatically using "2to3 -w -f except". This is backwards compatible with Python 2. There are no intended behavioural changes. Bug: 941669 Change-Id: I00e5acf46cdf0999c5e2f6e8e85e55e2fc611eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815871 Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#700375}
-
Ben Wagner authored
The third_party/expat directory has had a checked in copy of bits of libexpat. This has make updating quite difficult and blame more or less impossible. Move to using expat from DEPS to make rolling easier and more verifiable. This change should be build only and is not expected to actually change the source compiled. Bug: chromium:1004341 Change-Id: I7fd74ddb97e8f5302bd4dfe9b24a1bd20821cf55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822703Reviewed-by:
-
Yuly Novikov authored
Pixel_Video_BackdropFilter on GL and Vulkan Pixel_Video_Context_Loss_VP9 on GL - already suppressed on Vulkan, but maybe for a different reason TBR=jonross Bug: 1008450, 1008456 Change-Id: I89c211af2efcaaf05cb7a5dbd0c50b485a1f9321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827820Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#700373}
-
Chris Harrelson authored
This code is not used now that BlinkGenPropertyTrees has launched. Bug: 993936,1008483 Change-Id: Ia253725e327c5d115c95e341f7791539e881cc9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817318 Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#700372}
-
Joey Arhar authored
Screenshot: https://imgur.com/UiJ8BhH Change-Id: I0a9b9440073b864516723400ebe73ca3d2c71f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799700 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#700371}
-
Yves Arrouye authored
This will be helpful e.g. when trying to match logs with behavior as reported e.g. in crbug.com/1002617 (where logs don't match with the customer story but we can't be 100% sure). We log usin LOG(WARNING) as we expect the first auth to work, so this is an exceptional condition. Bug: chromium:1002617 Test: N/A Change-Id: I4366445f9691e527218b907c5ce1debd19f37aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827937 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#700370}
-
David Maunder authored
This component aggregates client side tab suggestions for closing tabs. Bug: 1005385 Change-Id: I797b983737441edd4f8e1a155ea94708219765c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811717 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700369}
-
Shimi Zhang authored
See the corresponding AndroidX change: http://aosp/1099421 Bug: 918065 Change-Id: Iad8cd0cd273235de1105f04844891494f793af1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745462 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#700368}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/30d3c8afe19c..072466ad1fab git log 30d3c8afe19c..072466ad1fab --date=short --no-merges --format='%ad %ae %s' 2019-09-26 amaiorano@google.com Add swiftshader_optimized_debug_build gn arg Created with: gclient setdep -r src/third_party/swiftshader@072466ad1fab If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140251624 Change-Id: Ife341a8079ea5e736765c517f62b145ebcdcca3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827486Reviewed-by:
-
Moe Ahmadi authored
This method is almost identical to HistoryService::DeleteURL and nothing about it makes it suitable for testing only. Change-Id: I5516c6fb514b72b9fb22f7b9cba34fdaf6001b00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825466Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#700366}
-
Joey Arhar authored
This fixes a small issue where blocked request cookies aren't shown if there were no request cookies in the first place. It also fixes a spacing issue with the list of cookies in "Malformed Response Cookies" Screenshots before: https://imgur.com/SeCHwKm Screenshots after: https://imgur.com/M3NKlqQ Bug: 856777 Change-Id: I1a2039b535869f16280fd74a9ba7f1dfcdced160 Change-Id: I165ac29eaafb8a74c3483238bd42c5aca1e91555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795316 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
After https://crrev.com/c/1776854 the extension-related browser-side checks should be a superset of renderer-side checks and we should be able to start removing extension-related renderer-side checks like ShouldFork. Bug: 1003957, 883549 Change-Id: I2954ab641b8234c2b3b18db69bf04caae437e989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809814Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#700364}
-
Alex Keng authored
This change updates the SVGs (used by <color>) to use system colors so it render correctly in high contrast mode. Test: web_tests/fast/forms/controls-new-ui-high-contrast/color-picker.html Bug: 994219 Change-Id: Ia2d597cd8016a79afe2a72f50a518099e531f4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826290 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#700363}
-
Xiaoqian Dai authored
|window_values| is not needed for kDragWindowToHomeOrOverview case. Bug: 997885 Change-Id: I950d62a53421ccf91c20d73c54c76c71689fbeff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825479 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Mark Pearson authored
TBR=isherman Change-Id: Ie1a9cb60a136b93c9f22c67fec8d538c69962b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827676 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700361}
-
Bin Du authored
Record thread types of ThreadPool* threads using the newly added THREAD_POOL_THREAD enum type, GpuMemory* threads using the newly added GPU_MEMORY_THREAD enum type, and Compositor/[0-9]+ thread using the existing COMPOSITOR_THREAD. BUG=b:130928904 Change-Id: I2f39cb84ee73658c84185d1e0b2e3513edb014d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816302 Commit-Queue: Bin Du <dubin@google.com> Reviewed-by:
Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#700360}
-
Kurt Horimoto authored
- Move ivar underscores from suffix to prefix. - Move protocol declarations to .mm file. - Move ivars to properties where appropriate. - Reorder code in .mm to match protocol declaration order and added pragmas. Bug: none Change-Id: I47eddb9ad8669dd6f6d68da867d8e136c913c2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824294 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#700359}
-
Christopher Grant authored
This reverts commit 7ca339e3. Reason for revert: Broke test targets in some builds. https://build.chromium.org/p/chromium.android/builders/Android%20arm64%20Builder%20%28dbg%29/builds/39819 Original change's description: > Modules: Introduce a generic DFM native library loading system > > DFMs that include both Java and native code will probably use JNI. This > change introduces a reusable mechanism to load the native library and > register its JNI methods. > > Key points: > > - There are 3 build variants supported: > 1. Production builds with lld-generated partitions. > 2. Component build (with feature code in a component). > 3. Fallback release build (feature code in the main library) > > - For consistency, explicit JNI registration is done in both > ChromeModern and Monochrome. > > - The Test Dummy module is moved over to use this new system. VR will > join the fun in a follow-on change. > > - Currently, modules must supply an explicit JNI registration method. > Common code will locate this method and call it, at the appropriate > time, on behalf of the module. > > Bug: 870055 > Change-Id: Id400ff00b4be65f71536a4acffdfcf93cc3bea58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822846 > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700276} TBR=cjgrant@chromium.org,agrieve@chromium.org,tiborg@chromium.org Change-Id: Ia5f504c0da25c85805a8521991c6eed8eac15267 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827245Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#700358}
-
John Lee authored
This CL copies over a SVG version of the tab alert indicator icons from /src/chrome/app/vector_icons/ and creates a custom element to display them. The icon dimensions have been customized for the WebUI version of the tab stirp and may change. The animations have been made to act as similar as possible with the existing implementations. Although the back-end has not yet been provided, this CL assumes there will be some mapping of TabAlertState to string, a string that will be used to update the |alert-state| property of the custom element. Note: this CL does not add theme colors for all icons (for example, the recording alert should display in red). https://i.imgur.com/dq2SARY.png Bug: 1004983 Change-Id: Ie0c20ae165bae935de1b21241815f7221351764a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825793Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#700357}
-
Jesse McKenna authored
The StackSamplingProfiler has been observed to cause crashes when running under Application Verifier, a Windows utility used to detect subtle programming errors. Samples collected by the StackSamplingProfiler while Application Verifier is running are unlikely to hold any value, as Application Verifier slows down execution significantly. Because StackSamplingProfiler and Application Verifier are not compatible, this change detects whether Application Verifier is running, and does not start up StackSamplingProfiler if so. This is not expected to impact data collection, as Application Verifier is used only by a few developers. Bug: 1004989 Change-Id: I014b3cee440e99d832ae8d84a03fe70777676a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783735 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700356}
-
Mohammad Refaat authored
Change RequestContextGetter to use CookieStoreIOS for web_view and for web shell. This is needed so i can remove NSHTTPCookieStorage and CookieStoreIOSPersistent and also to remove CookieMonster entirely from Chrome for iOS Bug: 989554 Change-Id: I2e2bf61a6638b47796c90c7012d1ac689960316e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822418 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
-
Ionel Popescu authored
This change extends the key options used to open the date related pickers to also include Enter and Space. This behavior is aligned with opening the select, color popup. Tests were added to validate opening the popup with Enter/Space. Bug: 1004997 Change-Id: If61ba755aef5436d705cb3c3c28f1ebb0c787059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825935Reviewed-by:
-
Ionel Popescu authored
This CL introduces popup support for input type="time" by adding a time picker. DateTimeFieldType is introduced and DateTimeFieldElement is plumbed to containd the field type in order to inform the time popup which fields are shown in the in-page control as the popup columns should match the fields. The popup functionality is present in time_picker.js and the style in time_picker.css Test have been added to validate the new popup UI, but more tests are going to be added with further CLs that are going to extend the functionality of the popup. The following CLs are: AM/PM support, keyboard navigation, step attribute support, infinite scroll. Bug: 1004997 Change-Id: Iaeb49fe684c3be6df920ae228668dc1430fa9aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817346Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/197c3c97970b..da7bc7fa532d Created with: gclient setdep -r src-internal@da7bc7fa532d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I13d0d55f2c6fe5381eafae0808245d340da72ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827479Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700352}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3ef6d975b402..a7f82b08de68 git log 3ef6d975b402..a7f82b08de68 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 jrosenth@chromium.org gob_util: Don't use message attribute on exceptions 2019-09-26 lamontjones@chromium.org SigningTests: signer source has finished moving. 2019-09-26 vapier@chromium.org commandline: rework _ShutDownException message 2019-09-26 vapier@chromium.org run_tests: add framework for running unittests under py2 & py3 2019-09-26 frankbozar@google.com cros_flash: Use oflag=direct in dd for better performance 2019-09-26 vapier@chromium.org osutils: drop MountImagePartition 2019-09-26 vapier@chromium.org osutils: drop unused MountImageContext 2019-09-26 vapier@chromium.org cros_event: rework Failure message 2019-09-26 tcwang@google.com afdo: Fix CWP regex for kernel profiles. 2019-09-26 saklein@chromium.org Build API: Add goma config to build chrome. 2019-09-26 saklein@chromium.org service/artifacts: Strip down images being archived by default. 2019-09-26 saklein@chromium.org chroot_lib: Remove CamelCase variant of get_enter_args. 2019-09-26 yshaul@google.com Move LKGM update logic to master-release builder 2019-09-25 mikenichols@chromium.org chromeos_config: Move veyron_mighty to experimental 2019-09-25 lamontjones@chromium.org cbuildbot/commands: fix typo Created with: gclient setdep -r src/third_party/chromite@a7f82b08de68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I4b582d8d1803dc36e6c4d5b6268588df3af4aecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827640Reviewed-by:
-
