GitLab

* Remove HpackDecoder, use HpackDecoder3 instead
  in tests (should have been parametrized).
* Remove HpackHuffmanDecoder, use net::HpackHuffmanDecoder
  instead in roundtrip tests.
* Remove HpackInputStream.
* Remove decoding functionality from HpackHuffmanTable.

This CL lands server change 161943670 by bnc.

BUG=488484

Change-Id: I6d3e9464d9d919c3a475c84ac2eb665cc6a1bfff
Reviewed-on: https://chromium-review.googlesource.com/577926
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488243}

This CL is a follow up to
https://chromium-review.googlesource.com/c/563885/ and enables the Lightweight First Run Experience for unbound WebAPKs by default.

The CL removes the --enable-lightweight-fre command line flag

BUG=738133

Change-Id: I7e120e7d25af0fd0d611bf9954285ca337ba4381
Reviewed-on: https://chromium-review.googlesource.com/578489Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488242}

SpdyFrameBuilder::WriteStringPiece16() is used neither in prod nor in
tests. It is time to slay.

This CL lands server change 161972394 by diannahu.

BUG=488484

Change-Id: If0f4b9317415cd6de1933655548fda7fe3a91f93
Reviewed-on: https://chromium-review.googlesource.com/578847
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488241}

In preparation for bringing up chrome://suggestions on iOS, this CL
breaks out the guts of the //chrome implementation into
//components/suggestions.

Change-Id: Iab48d9aaf19148e4e8862586ba3b39f141d14b2e
Reviewed-on: https://chromium-review.googlesource.com/579209Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488240}

This CL changes the title and the sync settings explination strings used
in the sync confirmation dialog to match the mocks here:
https://drive.google.com/a/chromium.org/file/d/0Bw1MJ8m7U5kbVVlVeWVKZjVfTXc/view?usp=sharing

Bug: 746878
Change-Id: I50f6a18de19f5e9fe1681d1ee0f032cadb44c101
Reviewed-on: https://chromium-review.googlesource.com/575980Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488239}

This patch makes the build system for core unit tests support jumbo
builds (unity builds) which saves roughly 60 CPU minutes (5% of the
build time) on my computer. Currently jumbo is by default disabled so
this will have no direct effect unless you have
  use_jumbo_build = true
in your gn settings.

Bug: 713137
Change-Id: I376e62fb66738cba9135d02f8079d983cfe67495
Reviewed-on: https://chromium-review.googlesource.com/575055Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#488238}

This is a temporary workaround to allow the component build to work
until crbug.com/746091 is resolved. This introduces a dependency on
libc++ when use_custom_libcxx is true.

BUG=746091

Change-Id: I14ae65c0ac7d986649f5f70b47b0ad6f37ceff89
Reviewed-on: https://chromium-review.googlesource.com/578554Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488237}

When it was added, the loading indicator included a timer that would
keep it visible for 200 ms after loading finished before disappearing.
This was basically a debugging tool that felt good to have in general.
However, Clank does not appear to have such a timer, and UX hasn't asked
for it, so let's keep the code simple.

BUG=

Change-Id: I1ef639fc572539a4e8ac67ee7d54deca93520218
Reviewed-on: https://chromium-review.googlesource.com/578173Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488236}

This reverts commit 79ba4105.

Reason for revert: Likely Culprit for Android Build Error: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/44127/

Original change's description:
> Pin the Home Page Tile to the first row in the UI.
> 
> Calculates the number of columns tiles are layed out in
> at initialization and reorders the home page tile so that
> it is pinned to the first row.
> Follow-up issue: https://crbug.com/746274
> 
> BUG=732913
> 
> Change-Id: Ieeddf88e8262827c7a22787230c386fe3b43cc17
> Reviewed-on: https://chromium-review.googlesource.com/567925
> Commit-Queue: Ondrej Škopek <oskopek@google.com>
> Reviewed-by: Chris Pickel <sfiera@chromium.org>
> Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488203}

TBR=dgn@chromium.org,sfiera@chromium.org,oskopek@google.com

Change-Id: Ice8fc873ba5ecbab3fa3cabc2da28a4026084626
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 732913
Reviewed-on: https://chromium-review.googlesource.com/579070Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488235}

A series of interactive_ui_tests were disabled for ozone configurations, as
nested message loops do not work well with ozone in tests.

However nested message loops are gone from context menus. So try to reenable
them in ozone builds.

TEST=BookmakrBarViewTest, KeyboardAccessTest, MenuControllerMnemonicTest*,
MenuItemViewTestRemoveWithSubmenu*

Bug: 401304
Change-Id: I804a312c4295adc7116592a5c5dc5693f96f56ae
Reviewed-on: https://chromium-review.googlesource.com/575427Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488234}

The Goodies page has moved, so need to update the manifest to match.
Also adding in URL pattern for staging location for Goodies webpages.

BUG=chromium:741952
TEST=browser test

Change-Id: Id1f71cb4bb6a65605a6ec6ff7cefd973a9487b35
Reviewed-on: https://chromium-review.googlesource.com/577724Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488233}

Bug: 710243
Change-Id: If8fe0c711f1c5e81888fcff9190497a1319e20db
Reviewed-on: https://chromium-review.googlesource.com/577976
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488232}

Bug: 732846
Change-Id: Ic1266587516270979e7077a526b8a951cb9d1c76
Reviewed-on: https://chromium-review.googlesource.com/570425Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488231}

1. Change ProfileDownloader observer registration - it is now registered
   on-demand iff there are observers of this ProfileDataCache instance.
   It allows removing ProfileDataCache.destroy().
2. Remove FirstRunPageDelegate.getProfileDataCache() - now there's no need for
   Activity to keep track of ProfileDataCache.
3. Fix AccountSigninView - remove ProfileDataCache observer when view is
   detached from window.

Bug: 746519
Change-Id: Id2245038a507aaf09a2afec4225e5fd3a6f49c07
Reviewed-on: https://chromium-review.googlesource.com/577872
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488230}

MediaControlsOrientationLockDelegate was releasing its fullscreen screen
orientation lock when the device had been rotated to the match the
orientation of the video (and other conditions were met).

This was intended to have no immediate effect, and simply allow the user
to exit fullscreen by rotating the device away.

However it turns out that unlocking actually locks to the "default"
orientation, and e.g. for an add-to-homescreen webapp that has set its
manifest to portrait orientation, the "default" orientation would be
portrait. So unlocking when in landscape would immediately rotate to
portrait and exit fullscreen!

This patch fixes that - instead of unlocking when the device orientation
matches the video orientation, it locks to the "any" orientation which
enables accelerometer-based screen orientation auto-rotation (overriding
manifest orientations). A full unlock to "default" orientation happens
later when fullscreen is exited.

(To understand this, it's helpful to know that Chrome doesn't have a
stack of orientation locks, it's simply last write wins, with the
exception that ScreenOrientationProvider restores the manifest
orientation when unlocking == locking to "default").

Bug: 740205
Change-Id: I590b33fa45a1ab6cc44ae3b49f983ae57d41a682
Reviewed-on: https://chromium-review.googlesource.com/577849Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: John Mellor <johnme@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488229}

This is done with avoiding explicit chrome package name (using
component name instead) and using
EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER on the intent.

With this patch the redirect works, however it takes a long time for CCT to
consult ExternalNavigationHandler. This results in suboptimal UX. Same redirect
in ChromeTabbedActivity is almost instantaneous. Result is that
for _blank links CCT shows up briefly before redirecting to an external app.
In a follow up it should be investigated why it is the case and if it cannot
be improved, we might need to bypass CCT in such case, which would diverge
from existing navigation paths for _blank links in Clank.

BUG=740402

Review-Url: https://codereview.chromium.org/2969143002
Cr-Original-Original-Commit-Position: refs/heads/master@{#485831}
Committed: https://chromium.googlesource.com/chromium/src/+/727468b41b2fe48bf73983ab0c3aa2632b47d89e
Review-Url: https://codereview.chromium.org/2969143002
Cr-Original-Commit-Position: refs/heads/master@{#486275}
Committed: https://chromium.googlesource.com/chromium/src/+/4dbcecfb630ac1a2dba1910f0e429b82bf3a0b5f
Review-Url: https://codereview.chromium.org/2969143002
Cr-Commit-Position: refs/heads/master@{#488228}

Bug: 709263
Change-Id: Ibcf2f12373d211b85829ef7cb8dcf94c0f2d41fe

TBR: achuith@chromium.org
Change-Id: Ibcf2f12373d211b85829ef7cb8dcf94c0f2d41fe
Reviewed-on: https://chromium-review.googlesource.com/579468Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488227}

https://skia.googlesource.com/skia.git/+log/e32500f0642d..ff98644cb480

$ git log e32500f06..ff98644cb --date=short --no-merges --format='%ad %ae %s'
2017-07-20 caryclark Revert "Revert "Fixes from sample count change""
2017-07-20 caryclark Revert "Fixes from sample count change"

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: Iaf7a4197607e0dd5baa8258f2eb6215124aed95a
Reviewed-on: https://chromium-review.googlesource.com/579447Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488226}

This file indirectly depends on ptr_util.h inclusion in
cc/resources/single_release_callback.h, which is being removed.

Tbr: sadrul@chromium.org
Change-Id: I3fd1b38c4b8808bdb67001756b2d60416e6bb756
Reviewed-on: https://chromium-review.googlesource.com/579228Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488225}

This is a roll-back to 6.1.534. This is the most stable candidate out of the latest Canaries.

If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back.

When in doubt please try to contact the committer and reviewers of this CL before reverting it.

TBR=machenbach@chromium.org

Change-Id: I0085971a1582686954bb23521db7e13647757d3b
Reviewed-on: https://chromium-review.googlesource.com/579370Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488224}

ContextualJsonRequest can build and send a Json request to fetch
contextual suggestions.
Contextual suggestions are suggestions based on a given URL.
A unit test verifies that a valid Json request is built.

Bug: n/a
Change-Id: Ic19def03c4080b42117624e9452376abbb68ffa5
Reviewed-on: https://chromium-review.googlesource.com/577540
Commit-Queue: Andre Gaschler <gaschler@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488223}

Bug: 739832
Change-Id: I374ef05f40aea76e5c33cf73395100e04f1ee6a2
Reviewed-on: https://chromium-review.googlesource.com/576429Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Jean-François Geyelin <jif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488222}

-- by checking for NULL pointer

Check for the pending_subkey_request_ pointer,
to make sure that it's not NULL.

Bug: 746041
Change-Id: I218245faf54a34eb87b3ebb90d53d710f8b8dc48
Reviewed-on: https://chromium-review.googlesource.com/577764
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488221}

Original CL: http://crrev.com/c/577593

Fixes: Suppress lint errors for downstream targets.

TBR=mthiesse@chromium.org,agrieve@chromium.org

Bug: 739746,746409
Change-Id: Ib069fed8e77d1a55d75ae71592cea6096c46ff47
Reviewed-on: https://chromium-review.googlesource.com/577966Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488220}

With ARC, there is no garanty that PasswordController will be
deallocated before WebState.
Detach it before the end of the test.

Bug: None
Change-Id: Ib16320cba8dcb59fe79f65c633e063e29a35a614
Reviewed-on: https://chromium-review.googlesource.com/579373Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488219}

Bug: 738881
Change-Id: I74f4c504cb2fc20b710b8b5011a649c50599e8ec
Reviewed-on: https://chromium-review.googlesource.com/575981
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488218}

- Add user policy EcryptfsMigrationStrategy which controls ecryptfs
  to dircrypto cryptohome migration.
- Implement a pre-signin policy fetch mechanism which tries to fetch cached
  policy first, and if there is valid cached policy, also tries to fetch
  fresh policy.
- Wire up the pre-signin policy fetch into existing_user_controller.cc to
  decide what to do when a ecryptfs user home is detected.

Fetching cached policy is done by mounting cryptohome to a temporary
location, reading policy from there, and then unmounting.

Fetching fresh policy is done using the dm_token/client_id from the
cached policy with a fixed timeout.

TEST=unit_tests --gtest_filter=PreSigninPolicyFetcherTest*
TEST=Manual test with ecryptfs cryptohome and YAPS
BUG=722371

Change-Id: I040cf3626257447e4e0dd2c70cf2d10604cb1977
Reviewed-on: https://chromium-review.googlesource.com/564609
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488217}

TBR=jdoerrie@chromium.org

Bug: 746926
Change-Id: I888ae3eddd83ac589a6430bd9b3355d97d14b825
Reviewed-on: https://chromium-review.googlesource.com/579387Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488216}

Now, when multiple entries contain the same content, multiple
table-of-contents entries will be created, but only one data region.

As of now, en-US.pak has ~3200 entries, and 350 of them are duplicates.

For MonochromePublic.apk, shrinks uncompressed .pak size by ~130kb, and
compressed .pak size by 32kb.

BUG=738566

Review-Url: https://codereview.chromium.org/2969123002
Cr-Commit-Position: refs/heads/master@{#488215}

This CL delays the binding of a ukm::SourceID to a URL in the
PasswordFormMetricsRecorder until the recorder is destroyed. The reason for
this is that long-lived tabs/WebContents would bind the URL at creation. But by
destruction (i.e. reporting time) the binding is purged and the data is
discarded.

Bug: 732846
Change-Id: I0a7c654ddc1a866e4abbe51206f62949500b5ba9
Reviewed-on: https://chromium-review.googlesource.com/577887
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488214}

In iOS 11, WKWebView has issues (time outs) when loading request if the
view is not part of the hierarchy. The WKWebView is now added to the
hierarchy but off screen.

Bug: 738435, 739390
Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514
Reviewed-on: https://chromium-review.googlesource.com/577807
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488213}

This reverts commit 2cec5853.

Reason for revert: Likely Culprit of https://crbug.com/746941.

Original change's description:
> customtabs: Don't allow multiple background tabs concurrently.
> 
> BUG=742450
> 
> Change-Id: Ia767797d89022b862e38b7ae72949bed08d94c09
> Reviewed-on: https://chromium-review.googlesource.com/578067
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488171}

TBR=yusufo@chromium.org,lizeb@chromium.org

Change-Id: Id209518579ebc889cfe652d9eea8491a9ec909a4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 742450
Reviewed-on: https://chromium-review.googlesource.com/579390Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488212}

Bug: 729738
Change-Id: Iff0d6dcfe202cad7dfbd2b111a160e37fb7aaa7e
Reviewed-on: https://chromium-review.googlesource.com/561680Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488211}

Bug: 730031
Change-Id: I98e7b16239b75549f8df558a8dff9a5c2e6c6265
Reviewed-on: https://chromium-review.googlesource.com/576384
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488210}

MidiTaskServiceTest.RunBoundTasks failing on v1 chromecast device.
This is because the test increments the count after signaling the event,
and it results in racy results because expectation check could run
before the count is incremented.
This patch fixes this problem and is expected to solve the problem
that RunBoundTasks failing on v1 chromecast device.

Bug: 744777
Change-Id: Id318353795025adbf204be90d381fa6b696d2390
Reviewed-on: https://chromium-review.googlesource.com/575325Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488209}

TBR=olivierrobin@chromium.org
NOTRY=true

Bug: 515462
Change-Id: I7289689de14ecb1936df5eb1c24aefcb5e8cad06
Reviewed-on: https://chromium-review.googlesource.com/579428Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488208}

[ES6 modules] Reduce number of MTLs by not creating MTL for sub-graph fetch already handled somewhere else

This CL makes unbundled moment.js benchmark [1] 19x faster (3.8s -> 200ms)
[1] https://sgom.es/posts/2017-06-30-ecmascript-module-loading-can-we-unbundle-yet/

Before this CL, we instantiated ModuleTreeLinker per module graph edge (== import stmt).
For module graphs which are close to fully connected, this resulted in exponential number of ModuleTreeLinker involved.
Each ModuleTreeLinker comes w/ multiple postTask cost and memory cost, thus this resulted in slow performance and high peak memory usage.

This CL drastically reduces the ModuleTreeLinker per module graph fetch, by creating one ModuleTreeLinker at most for each module graph node (== module script) involved.
This CL introduces ModuleTreeReachedUrlSet, which is instantiated per top-level module graph fetch, and shared among all descendant sub-graph ModuleTreeLinkers.
Before creating a new ModuleTreeLinker for descendant module graph fetch, ModuleTreeLinker::FetchDescendants now consults this ModuleTreeReachedUrlSet to find if there is an existing ModuleTreeLinker instance which it can delegate the sub-graph fetch.

Credits:
- nhiroki@ for the original algorithm.
- adamk@, hiroshige@ for extensive analysis.
- adamk@, ksakamoto@ for verifying the speed up.

Bug: 722728
Change-Id: I7af4206ece3c5613a3085e7483eddbd652718981
Reviewed-on: https://chromium-review.googlesource.com/578531Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488207}

BUG=734525

Change-Id: I75e4d4aef819f859d089b38af577a56bcbca314a
Reviewed-on: https://chromium-review.googlesource.com/576034Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488206}

Also remove X-button from the domain join screen

Bug: 739283
Test: manual
Change-Id: Ib0f39ee36a9bb23d1df86c25c9cc4be6e2846582
Reviewed-on: https://chromium-review.googlesource.com/577868Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488205}

It fails consistently.
NOTRY=true
TBR=olivierrobin@chromium.org

Bug: 515462
Change-Id: If1a3d1d4711b3ca609c167e6ff4319cdcde10b82
Reviewed-on: https://chromium-review.googlesource.com/579388Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488204}