- 19 Apr, 2019 40 commits
-
-
Zhang Xiangze authored
In WebMediaPlayerMSCompositor, GetCurentFrame() no longer has side effect. This CL removes GetCurrentFrameWithoutUpdatingStatistics() and uses GetCurrentFrame() instead. This CL also removes an outdated comment. Bug: 948472 Change-Id: If18ccb69cfe47a8944bdb91a1a8cf72f91d34985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542783Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#652505}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2ab4d326364e..92d14c28e81b git log 2ab4d326364e..92d14c28e81b --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate alerts-request.js to es6 module Created with: gclient setdep -r src/third_party/catapult@92d14c28e81b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=charliea@chromium.org Change-Id: I09e7cf37cba92257bcec523e6110942d8d5b6b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575411Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652504}
-
Yoshifumi Inoue authored
This patch makes |LayoutSVGText::UpdateLayout()| to clear offset mapping cache if needed rather than in |LayoutBlockFlow::UpdateBlockLayout()|[1] to fix heap-use-after-free in |NGOffsetMapping|. Unlike other derived classes of |LayoutBlockFlow|, |LayoutSVGBlock::UpdateLayout()| doesn't call |UpdateBlockLayout()|, then |LayoutSVGBlock| holds stale offset mapping cache. [1] http://crrev.com/c/1488479 Make LayoutBlockFlowRareData to hold NGOffsetMapping for legacy layout Bug: 951218 Change-Id: Iacaa72a426cfcf9cd71495cf2c1ed6a0c6511ed9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574987 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652503}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/145ec7fa7c81..51386f4a5e8b git log 145ec7fa7c81..51386f4a5e8b --date=short --no-merges --format='%ad %ae %s' 2019-04-19 kbr@chromium.org Reland "Define and expose EGL_ANGLE_power_preference extension." Created with: gclient setdep -r src/third_party/angle@51386f4a5e8b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:2813 TBR=cwallez@chromium.org Change-Id: If1c618840fd9feca8e0ef3be05da953f1871f196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575410Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ecf68b73d5c9..b2e2edfd0377 Created with: gclient setdep -r src-internal@b2e2edfd0377 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Ieb2ee73fc3bb9f7ab7eec37490aa157ccc5cd8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575409Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652501}
-
Findit authored
This reverts commit 12b30300. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 652487 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzEyYjMwMzAwNmJiZDk0NGIzN2VhMDAxMDkwNGUzZGU4OGVkMWJkNzcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/mac-rel/4772 Sample Failed Step: compile Original change's description: > Reland "OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth" > > This is a reland of d5b00821 > > It updates //BUILD.gn and //content/public/common/BUILD.gn > in addition to the previous change to fix the dependency > problem. > > Original change's description: > > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth > > > > This CL moves bluetooth folder from public/platform/modules to > > public/mojom/ to gather mojom files to mojom folder with > > creating web_bluetooth_mojo_bindings. > > > > Bug: 919393 > > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > > Reviewed-by: John Budorick <jbudorick@chromium.org> > > Reviewed-by: Doug Turner <dougt@chromium.org> > > Reviewed-by: Colin Blundell <blundell@chromium.org> > > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#649061} > > Bug: 919393 > Change-Id: I61de3e625205e54959ad8d36c84eefa95f861035 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559368 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#652487} Change-Id: I29f9dc1cdedf6f7f6aad104a2bced4aac446b7a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575520 Cr-Commit-Position: refs/heads/master@{#652500}
-
Arthur Sonzogni authored
This reverts commit 2cd39eb0. Reason for revert: The branch cut was supposed to be yesterday, but I haven't received any confirmation is happened. To be sure revert this commit for the moment. Original change's description: > Make renderer-initiated navigation to about:blank to use the default path. > > We used to believe renderer initiated navigation from a document to > about:blank needed to happen sometimes "synchronously". This isn't the > case, a PostTask is currently used. The only real requirement is when > committing the initial empty document. > > This CL makes those navigation to use the default path instead. > > This requires a few tests to be updated: > > 1) The initiator and a few other properties needs to be properly set. There > are DCHECK in BeginNavigationInternal to enforce renderer initiated > navigation always have a defined initiator. > > 2) runtime-console-log-handle-navigate.js: In console-log-navigate, console.log > can use the 'getter' of the object several times (up to 2) to print the > object. It triggers several about:blank navigations. Since they are now going > to the browser process, they are committed later compared to the script > execution. The test became less reliable. The test was using > dp.Runtime.onceExecutionContextCreated to wait for new documents to commit, > but waiting was started potentially after the event occured. The new test is > now creating the Promise before triggering the action that will later resolve > it. The action is either creating the iframe or making use of the logXXX() > function. This is now fully reliable. > > Bug: 936696 > Change-Id: Ibf1a87f83d2e8bfd621d067f0a29a14a069384a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543258 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652493} TBR=dgozman@chromium.org,dcheng@chromium.org,nasko@chromium.org,clamy@chromium.org,alexmos@chromium.org,arthursonzogni@chromium.org Change-Id: I6a5fe676275d59027907a1c9540dfe941fab3e18 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574320Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#652499}
-
Ryo Hashimoto authored
use_real_dbus_clients=true will be used to avoid linking fakes to the shipped binary. BUG=952745 TEST=build Change-Id: I419b9b5c2460dbc9dd66fff7490d06d34ec02c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571329Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652498}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 263e7db8. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Icb769e141e801a0e6539af98581238a677f81a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574446Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652497}
-
Yuzu Saijo authored
This CL disables perfetto for leak detection for now because perfetto changed the timing of taking memory dumps and thus leak detection is not properly working any more. This is meant to be a temporary fix. Bug: 936805 Change-Id: I885e2abe074354878cae909af54c194d30e1f132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557665Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652496}
-
v.paturi authored
The classifier for SVG images is going to have to work with layout objects. So the code for the SVG classifier cannot reside in the current DarkModeImageClassifier in platform as the code in platform cannot depend on core. A separate class is implemented in core for classification of SVG images in dark mode. The current DarkModeImageClassifier is renamed to a more appropriate DarkModeBitmapImageClassifier. The SVG classifier itself is a work in progress and will be submitted in a follow-up CL. Bug: 949943 Change-Id: I135a357c333655c11e197599466c314d2f20facf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564276 Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#652495}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/805b09f92203..0e5d1bb66ad3 git log 805b09f92203..0e5d1bb66ad3 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 cepheus@frii.com clang-format correction and typo (clang format likely not complete) Created with: gclient setdep -r src/third_party/glslang/src@0e5d1bb66ad3 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibda22dac750cf4f7b4f62068062fd2c5892528ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575405Reviewed-by:
-
arthursonzogni authored
We used to believe renderer initiated navigation from a document to about:blank needed to happen sometimes "synchronously". This isn't the case, a PostTask is currently used. The only real requirement is when committing the initial empty document. This CL makes those navigation to use the default path instead. This requires a few tests to be updated: 1) The initiator and a few other properties needs to be properly set. There are DCHECK in BeginNavigationInternal to enforce renderer initiated navigation always have a defined initiator. 2) runtime-console-log-handle-navigate.js: In console-log-navigate, console.log can use the 'getter' of the object several times (up to 2) to print the object. It triggers several about:blank navigations. Since they are now going to the browser process, they are committed later compared to the script execution. The test became less reliable. The test was using dp.Runtime.onceExecutionContextCreated to wait for new documents to commit, but waiting was started potentially after the event occured. The new test is now creating the Promise before triggering the action that will later resolve it. The action is either creating the iframe or making use of the logXXX() function. This is now fully reliable. Bug: 936696 Change-Id: Ibf1a87f83d2e8bfd621d067f0a29a14a069384a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543258 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#652493}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7f8529c21699..2ab4d326364e git log 7f8529c21699..2ab4d326364e --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Migrate report-template to es6 module 2019-04-19 benjhayden@chromium.org Migrate chart-compound.js to es6 module 2019-04-19 benjhayden@chromium.org Migrate report-controls.js to es6 module Created with: gclient setdep -r src/third_party/catapult@2ab4d326364e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011,chromium:950011 TBR=oysteine@chromium.org Change-Id: Ic5cf0e87ca81eec9fe398053689824308ba5be84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575406Reviewed-by:
-
Yutaka Hirano authored
Introduce ResourceFetcherProperties::IsSubframeDeprioritizationEnabled instead. Move the priority modification logic to ResourceFetcher. We need to have a IsMainFrame branch in ResourceFetcher in order to record histograms. Once it is deprecated we should move the logic into ResourceFetcherProperties and rename the method to something like ShouldDeprioritizeRequest. Bug: 914739 Change-Id: I6627ee9fd2860a257d68f64879a1cc5875685350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570961 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#652491}
-
Keishi Hattori authored
To introduce EventLoop concept we can't have AllowUniversalAccessFromFileURLs changing midway, and so we will be making AllowUniversalAccessFromFileURLs false for web_tests by default. This CL changes iframes with dataurl to srcdoc since srcdoc allows access without AllowUniversalAccessFromFileURLs. Change-Id: Ic99ca1aaf33c37365caf7d1218f5847fd36c0409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531924Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#652490}
-
Adam Rice authored
Rename the implementation of ReadableStreamDefaultReader to ReadableStreamReader. Move the ReadableStreamReaderGeneric operations into the class. This will help prepare for the future addition of ReadableStreamBYOBReader. This CL only moves and renames code. No functional changes. BUG=902633 Change-Id: Icc42ee61886be21618ca417e1783f2a1056bc1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573558Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#652489}
-
tzik authored
name_style_converter.py used to convert "URLs" to "ur_ls", and that is used by settings_macro.h generation. Change-Id: I8289087219ae7ca3a31c8076160d48c39c1e3251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574983Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#652488}
-
Julie Jeongeun Kim authored
This is a reland of d5b00821 It updates //BUILD.gn and //content/public/common/BUILD.gn in addition to the previous change to fix the dependency problem. Original change's description: > OnionSoup: Move web_bluetooth.mojom to public/mojom/bluetooth > > This CL moves bluetooth folder from public/platform/modules to > public/mojom/ to gather mojom files to mojom folder with > creating web_bluetooth_mojo_bindings. > > Bug: 919393 > Change-Id: I42037e1c9738b03969e927dd00f6b24c2873b364 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530369 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Doug Turner <dougt@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#649061} Bug: 919393 Change-Id: I61de3e625205e54959ad8d36c84eefa95f861035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559368Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#652487}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa3c64638fba..ecf68b73d5c9 Created with: gclient setdep -r src-internal@ecf68b73d5c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:949105 TBR=fdoray@chromium.org,bsep@chromium.org,keishi@chromium.org,chanli@chromium.org Change-Id: Icd5ed364e2ba1258457cf17d897bee3fe53fb103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575380Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/342c6ea1a933..22cee9ae36b2 git log 342c6ea1a933..22cee9ae36b2 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 jiawei.shao@intel.com Enable MultisampledRenderingWithDepthTest on Windows Intel Vulkan Created with: gclient setdep -r src/third_party/dawn@22cee9ae36b2 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@chromium.org Change-Id: Ide973a3ce57b8ec5b75a16eea6983da4497eb07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575403Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a16238df3f28..7dd3889f2cf7 git log a16238df3f28..7dd3889f2cf7 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 swiftshader.regress@gmail.com Regres: Update test lists @ a16238df Created with: gclient setdep -r src/third_party/swiftshader@7dd3889f2cf7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I9445b73bd19fd80fa481b68dc237a1c340abd108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575402Reviewed-by:
-
Yao Xiao authored
and the request_initiator is the script origin. Also fixed 2 issues: - For the main resource request (serviceWorker.register(...)), it goes through FrameFetchContext::PrepareRequest() that will always set the top_frame_origin regardless whether it's from service worker. Adding a check for service worker seems to fix it. - The static function GetNetworkFactoryCallbackForTest() in embedded_worker_instance.cc returns an Optional of Callback, but the caller only checks the nullity of the Optional but not of the Callback. This sometimes is causing a crash in the test. Removing the Optional seems to fix it. Bug: 918868 Change-Id: I2a5b83d8b13b2d52310614dfb5a6dfa4d1cd620a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553948 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#652483}
-
Meilin Wang authored
This change expands the unit tests to cover the Assistant key remapping feature. Misc: fix typo and lint errors. Bug: None. Test: Local compile and run tests changed in this CL. Change-Id: I21a559a4d2cec07f581bcc3573034520c6c79c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570806 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9f474a8e0e81..7f8529c21699 git log 9f474a8e0e81..7f8529c21699 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 benjhayden@chromium.org Display median and 90th% in multi-event-sub-view Created with: gclient setdep -r src/third_party/catapult@7f8529c21699 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@chromium.org Change-Id: If6bb33f87052693a47491f230372f0a171a2f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575401Reviewed-by:
-
Yue Zhang authored
Add a layer of callback in MultiThumbnailCardProvider to fetch favicon and draw with shadowed circle background in thumbnail. Bug: 946286 Change-Id: Id4fce1c635d1f639778476730ba7cea131496376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574639 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652480}
-
liberato@chromium.org authored
This CL enables the following: - SupportedVideoDecoderConfigs are now returned from the GPU process as a map [video decoder implementation] => vector of SupportedVideoDecoderConfig for that implementation. - GpuVideoAcceleratorFactories::IsDecoderConfigSupported takes the implementation enum value as an additional argument, and checks only against that implementation's supported configs. - MojoVideoDecoder accepts an implementation enum during construction, which will be provided to the service during decoder initialization. - GpuMojoMediaClient uses the kAlternate implementation enum value to select D3D11VideoDecoder on Windows, if the experiment is currently enabled. It no longer uses FallbackVideoDecoder. - MojoDecoderFactory adds a kAlternate decoder, in addition to the kDefault decoder, on Windows if the experiment is enabled. - RTCVideoDecoderAdapter always selects the default video decoder implementation. This causes RTC on windows to use only DXVA, rather than D3D11VideoDecoder. This will be addressed as follow- up work, though likely not immediately. The main reason for this is that it lets the renderer's decoder selection algorithm see two MojoVideoDecoder instances: one for DXVA and one for D3D11VideoDecoder. This lets decoder selection and fallback happen normally for them, rather than having the fallback happen in the GPU process via FallbackVideoDecoder. Bug: 954422 Change-Id: If6f056723c11ff50327623ac8d554d9f5da9f499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534984Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#652479}
-
Kenichi Ishibashi authored
Before this CL credentials.py tried to get "Origin" header value unconditionally and resulted in an internal server error. This CL changes credentials.py so that it sets "Access-Control-Allow-Origin" only when "Origin" header is supplied. Bug: 952266 Change-Id: I804d538cc24c2fb51d0c156400425e056d51fb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575300 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Jeremy Roman authored
It's what's expected per spec, and it's more efficient. Bug: 627682 Change-Id: I5462a9c34cf9a1b6f2825e9e0c58e3c64b8c1698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575034Reviewed-by:
-
liberato@chromium.org authored
Since the enhanced unweighted tree experiment seems to give us good results compared to the weighted base / enhanced tree and base table, add unweighted variants of the base tree and table. The goal is to see if unweighted examples help more or less with the (a) base features vs enhanced features, and (b) with the table vs the decision tree. Change-Id: Ie5b5938d42f6085518662e2a198e0d8a10e92cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570702Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#652476}
-
dpapad authored
Specifically: - cr.makePublic() was not used anywhere. - cr.getUid() was only used in one place, which is being replaced by using a Map instead. - cr.createUid() is still used, but only within cr.js, and therefore there is no need to export it on the cr namespace anymore. Note that the removal of cr.makePublic() also allows removing some code from https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/ChromePass.java Bug: None Change-Id: Ie1791cfac7c9c3658dff722556850a04dda81e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575027Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#652475}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ac58e63295f0..145ec7fa7c81 git log ac58e63295f0..145ec7fa7c81 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 kainino@chromium.org Revert "Define and expose EGL_ANGLE_power_preference extension." Created with: gclient setdep -r src/third_party/angle@145ec7fa7c81 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:2813 TBR=cwallez@chromium.org Change-Id: I8a909db355d5431ccb853b96e68eedddabe9512e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574437Reviewed-by:
-
Rakina Zata Amni authored
It's possible to be in a committing state without having a commit promise resolver, if the commit is caused by activation. This causes problems with commit() calls that happen on the same frame as activation-induced commit, as it expects the resolver to exist. This CL handles that case and adds a test. Bug: 953614 Change-Id: I83ba0b6e450672588ff960389fc045be4896fe32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573425Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#652473}
-
Tao Bai authored
This case will be covered in Java integration test. Bug: 954387 Change-Id: I1b34a031d47e97fbcabd24f4363ce6ca9fe97579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574946Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#652472}
-
Keishi Hattori authored
This reverts commit 133ed70b. Reason for revert: Caused NewTabFromLinkOpensInGroup and others to fail https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20ChromiumOS%20MSan%20Tests/builds/12442 Original change's description: > [Tab Groups] Stop using TabGroupData pointers as group IDs. > > Tab groups are currently identified using TabGroupData pointers. However, > this is fragile because those pointers may not be valid forever and > because memory address may be reused. It makes more sense to use an > opaque int ID for this purpose instead. This also allows the API to > explicitly define when a group may be null or not, by using > base::Optional. Also, in a future patch, tab_strip_layout.h/cc will be > able to operate using that ID and continue to avoid knowledge of any > particular View type. > > This patch also includes some miscellaneous refactoring in > tab_strip_model_unittest.cc. > > Bug: 905491 > Change-Id: I9700a50d5fa9e4050ec2169af8e1362d11d9dade > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1562764 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Taylor Bergquist <tbergquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#652391} TBR=pkasting@chromium.org,bsep@chromium.org,tbergquist@chromium.org Change-Id: I1ede97f8791b79649fbf6d98947fbb1567d8fee2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575259Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3d140e8c. With Chromium commits locally applied on WPT: 0a8f3ffa "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e921520 "[Code Health] Remove unnecessary reference file for web test" 40465b74 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" e28269b6 "[LayoutNG/PE] Clear visual overflow for LayoutText before setting." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: raphael.kubo.da.costa@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I762bf86e2ad7c862ebaf7480c7560efb389cd2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574433Reviewed-by:
-
Chris Lu authored
UMA over Cellular feature removes kMetricsReportingWifiOnly local pref. Tests will fail if retrieving or setting occurs. Bug: 931289 Change-Id: Ibda70e02dde35f50426f6501210130a8c2834be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574837 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#652469}
-
Meilin Wang authored
This change adds a new flag in chrome://flags to enable Assistant key remapping in the keyboard settings. Bug: None. Test: local compile and manually test. Change-Id: I9708e705da6e9e012089a4559965cb2f431bd87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573002 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
-
Lily Chen authored
See https://docs.google.com/document/d/19vDLCRVP-WvWxA_YNZfhkkW6fS5A2Ea9ulJ8i8AcPAM/edit?usp=sharing for details. This CL refactors the client side of the ReportingCacheImpl. Clients, endpoint groups, and endpoints are now represented by separate structs. The cache stores each in separate maps. Endpoints are evicted if an origin exceeds the per-origin endpoint limit, or if the cache exceeds the global endpoint limit. This fixes an incorrect assumption made by the previous implementation that a given endpoint URL cannot be in multiple groups for the same origin. Bug: 912951 Change-Id: I0c548c3cf20ac57a9f17482300dd9a57a14e53b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1453109 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#652467}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/96fbe0810a3f..a16238df3f28 git log 96fbe0810a3f..a16238df3f28 --date=short --no-merges --format='%ad %ae %s' 2019-04-19 chrisforbes@google.com Add support for OpAtomicCompareExchange 2019-04-19 chrisforbes@google.com Add support atomic instructions as used with storage images 2019-04-19 chrisforbes@google.com Add support for OpImageTexelPointer Created with: gclient setdep -r src/third_party/swiftshader@a16238df3f28 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130768731,chromium:b/127472316,chromium:b/130768731,chromium:b/127472316,chromium:b/130768731 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I176d249ff7276933d0a27012a78d280db710657b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575358Reviewed-by:
-
