GitLab

This change uses native_theme_base.cc to update the styling for the checkbox native controls in dark mode.

Bug: 1099579
Change-Id: Iafb167aa2f24c304ac2292178beb4d6bdb24a451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311697Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Yu Han <yuzhehan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#791999}

When the apps grid enters cardified state, all icons are scaled down
84%. We need to scale down the folder circle proportionally, to avoid
clipping at the top edges.

Bug: 1108644
Change-Id: I95b97d6d3db15c0313a92bbffbd5f70ffb4e071e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315094Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791998}

Browser tests for the ML service is added to the Optimization Guide
path where the service will be used first.

Bug: 1108334
Change-Id: I5ec1845f9043546e89b49776e95ccdc391ea1e90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320748Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Jia Li <jiakl@google.com>
Cr-Commit-Position: refs/heads/master@{#791997}

A new script has been added to count and optionally output cycles in
package graphs. A limit to cycle size must be supplied, ideally around 5
or 6 to keep the script runtime low since the number of cycles is
exponential.

For more detailed usage, see `./count_cycles.py -h`.

Bug: 1106484
Change-Id: I01923eaab24eb3c6641a23039c80f60a0bc0e212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303054
Commit-Queue: James Long <yjlong@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791996}

This is cleaning up uses of base::Unretained(this) in the cros_healthd
service connection. There are cases where the service connection could
be destroyed before the callback returns.

Bug: chromium:1108065
Change-Id: I66639581e213cc088080de5ec407f06968b8559c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311074
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: Paul Moy <pmoy@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791995}

Bug: 1000989
Change-Id: I7ae5d8279cb46866e28a4393d8cdc0d3ae21bcd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315901Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: My Nguyen <myy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791994}

Removes unnecessary defines, chooses correct path based on
OzonePlatform feature usage.

-----

PS: Please note that this is a temp solution that will help to choose
between ozone and non-ozone X11 build. The switch that will be used
to choose the path is --enable-features=UseOzonePlatform. Once
non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how
th finch trial goes), the wrapper will be removed.

Please also note that it's impossible to build use_x11 && use_ozone
without some hacks in PlatformCursor code. The changes to that are
on their way to upstream.

----

Bug: 1085700
Change-Id: I5fced0993b55d0dedd9661d9845ff3b347b7bf4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315885Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#791993}

Select file dialogs are implemented in ash-chrome via
SelectFileDialogExtension, which requires an aura::Window owning window
for the dialog.

Top-level windows in lacros-chrome are represented in ash-chrome via
ShellSurface objects. Pass an ID for the shell surface over mojo from
lacros-chrome to ash-chrome and use it for window parenting.

The ID is a string: "org.chromium.lacros.<unguessable-token>", e.g.
"org.chromium.lacros.8B93BD96131616984961C7790B5E9A62". Lacros creates
an ID for each WaylandToplevelWindow and uses xdg_shell's set_app_id
method to set it. This is similar to how ARC++ encodes an Android
task ID in the app ID, e.g. "org.chromium.arc.12345".

The ID is sent as a string to provide future flexibility (in case we
need to encode different window types, like "lacros_popup") and because
it felt like an appropriate return type for the cross-platform method
ui::PlatformWindow::GetInternalWindowId().

Feature design doc at go/lacros-select-file

Bug: 1090587
Test: multiple simultaneous file open dialogs spawn/stack/close correctly
Change-Id: I7b2cdb934480f72f5dbb3523922d30cf5df0376a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301119
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791992}

For privacy concerns there is a push to add feature policy and Secure
Context requirements to gamepads. We are adding these behind a flag now
so that we can more easily coordinate the rollout with other browsers.

Bug: 1099544
Change-Id: Ic64ae35d74692eaf29f618f8fdbb49cf7a143751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269718
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791991}

Bug: 1109750
Change-Id: I2c2f95f427d41dfd98ec230dd4a89f0997635d3c
Tbr: apaseltiner@chromium.org, johnidel@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321399Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791990}

The implementation to use layer transforms to resize the bubble
is no longer used due to recent optimizations. Removing this code
and the extra view containers that were required for it.

Bug: 1024530
Change-Id: I71e5cecbc51011b16c0b7d0da09464ea4562eacd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318693
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791989}

Bug: b:159021439
Change-Id: Ie1cd845dc910af48d241e5193a2d39ff7e1bd106
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294940
Auto-Submit: Anand K Mistry <amistry@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791988}

The fuchsia.media.drm.ContentDecryptionModule sends an event upon the
completion of provisioning[1]. This is an indication that the CDM is
ready for use. This CL pends the CDM creation callback until after the
OnProvisioned event has been received, ensuring the CDM is ready prior
to any calls being made to it.

[1] https://fuchsia.dev/reference/fidl/fuchsia.media.drm#fuchsia.media.drm/ContentDecryptionModule.OnProvisioned

Bug: fuchsia: 13619
Change-Id: Ie119daa58610b2cab0cade14b7dbf1ef93b3dcfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315000
Commit-Queue: RJ Ascani <rjascani@google.com>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791987}

These tests were moved to a different directory in upstream WPT.
Deleting them under their old names will allow wpt-import to run and
avoid lint errors about these tests not existing under their new name.
Once import runs (and renames the tests on the chromium side), they will
be re-added to the expectations files under their new path.

TBR=rmhasan

Bug: 1110003
Change-Id: I50fedbd09a0d493d47b2765ee6d871d4395e25bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321049Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#791986}

Bug: 1105004,1105005,1105006,1105010
Change-Id: Ida229c9aa88a86891b1b5c0985bc50ae693a4ef6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307329
Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791985}

BUG=1088586

Change-Id: I9e7f546407e4a8216209201715a8c1a047512199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320066Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791984}

This CL re-enables flaky tests, the underlying issue should have been
fixed by https://crrev.com/c/2280467

Bug: 246308, 1099384
Change-Id: I76aed73aea7143b73c93aaefb2d7d1060ada4bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283396
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791983}

Change-Id: I4efd4d948cf58f697714b71233cc3122c9566c78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319340
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791982}

We're now flashing the devices as part of the LKGM CL tryjobs, so we
no longer have to confine ourselves to the compile-only bot.

Bug: 1057152
Change-Id: Iab4118f97cd65c5def6c1a0e73263c7621237811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316292Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791981}

This is part of a larger effort to force users to provide
GrDirectContext when manipulating texture-backed images.

Bug: skia:104662
Change-Id: Ic21ba05d0f13d9e597bb3eac49ac818209b1c1c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313301
Commit-Queue: Adlai Holler <adlai@google.com>
Auto-Submit: Adlai Holler <adlai@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#791980}

Change-Id: Ia91ea60c9dc239cac598153f422911ac84ca7cab
Bug: b/157458681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320070
Auto-Submit: Nick Harper <nharper@chromium.org>
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Reviewed-by: David Schinazi <dschinazi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791979}

kUserInteraction task source will align the pointer lock events with the
mouse events. It will also help spec consistency.

Bug: 1109007
Change-Id: I6426874161fc772a27640831617e70f941737b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316808Reviewed-by: James Hollyer <jameshollyer@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: James Hollyer <jameshollyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791978}

Re-enables the Telemetry minidump tests on most platforms. They were
disabled due to flakiness, but further investigation shows that the
flake rate was relatively low, and some flakes were caused by unrelated
issues, e.g. platform-wide issues.

Bug: 1084931
Change-Id: I31fab19af04faea49826dc827a45817da3de9397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318505
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791977}

Expands the FontMatchingMetrics object to record (successful or
unsuccessful) local font lookup events in a range of situations, as
enumerated in FontLookupType. The font lookup inputs (e.g. font name)
and a hash of the resulting font data are periodically published.
This will allow for measurement of the privacy impact of local font use.

This cl does not record any font lookup events associated with a binary
or remote CSSFontFaceSource. Metrics reporting in the
OffscreenFontSelector will occur in a separate cl (crrev.com/c/2197604).

Bug: 973801
Change-Id: I8304568af91fc56c1efe4087a9a7effdad234474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195493
Commit-Queue: Alex Turner <alexmt@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791976}

chops recently updated the depot_tools input_api, which makes this
possible.

input_api.DEFAULT_ALLOW_LIST -> input_api.DEFAULT_FILES_TO_CHECK
input_api.DEFAULT_BLACK_LIST -> input_api.DEFAULT_FILES_TO_SKIP

For named parameters:
white_list/whitelist -> files_to_check
black_list/blacklist -> files_to_skip

Bug: 1098562
Change-Id: Icc576b50727256d94ad62b985b2c81991a9af49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317743
Auto-Submit: James Cook <jamescook@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#791975}

* Suppress a lint warning that is expected.
* For methods whose visibility is relaxed not only for the reason of
  testing, remove the @VisibleForTesting annotation.

Bug: 1108022
Change-Id: I3f8004e3b27cfbbc82a8061c19e57e1662a0691a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315926Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791974}

Set expiration date of
Ash.HotseatTransition.Drag.PresentationTime.MaxLateny metric
for one year.

Bug: 2226918
Change-Id: Ib3cd12ef60b0e1f84e58ae5a02e87bc2374a8b9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300998Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Ana Salazar <anasalazar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791973}

This CL defines a CrxDownloaderFactory interface, for which
UpdateClient provides an implementation. This interface is injected
using a function of Configurator. Callers of Update client such as
the component and extensions updater use the Chromium
implementation of the factory: there is no change in the existing
behavior.

Projects such as chrome/updater could in the future provide their
own implementation of the factory to override the CrxDownloader stack.

Bug: 1109283

Change-Id: I36f973b470a756f7e428bdac0407986374488c43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302716
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791972}

This cl extends the expiry date of Navigation.MainFrame.FrameCount
and Navigation.MainFrame.MaxFrameCount uma metrics.

Bug: 1097830
Change-Id: I3dafd1623e213bae3e07a03619716f6bed6714fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317707Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791971}

In preparation for updating WebGL's bindings to use V8 FastCalls,
this CL adds some helper classes to assist in safely implementing
Fast bindings. The WebGLFastCallHelper provides mechanisms for setting
up a scoped temporary object which toggles the in_fast_call_ bit
automatically on construction/destruction. And, it provides mechanisms
to signal deopt or defer WebGL warning/error messages.

Bug: chromium:1101475
Change-Id: I2d9d355fc9fb3d510130fc2cb729769e9e349885
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309143
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791970}

Roll Chrome Mac PGO profile from chrome-mac-master-1595851043-c48b6bdf39deda41f847276998118df921bfd4ef.profdata to chrome-mac-master-1595872800-d57a770d7bc200213efd65ae14b0000c1824f2dd.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com
Change-Id: I00f39b5d34f78d9dd8dcf76cf0b7f873988545c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321090Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791969}

Specifically, record a "launch_on_login" pref whenever lacros
successfully starts. Set the pref false when lacros terminates.

Prefs are flushed to disk periodically, so this means the pref is in
the right state even if ash-chrome crashes mid-session.

Bug: 1109050
Change-Id: If7ca21a570b73b56cbbef838cf59526034092b9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318648Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791968}

Validate the provided view for XrWebGLBinding::getCameraImage(...) is
contained within the provided frame.

Design Doc: https://docs.google.com/document/d/1X4zhSCYqzOKrbC4iGA5SOV983vmI0mqz9tQxRvyrYlk/edit?usp=sharing

Fixed: 1100978
Change-Id: I0177303e67d7ffc7da7a79d5b781d5f2b9b51959
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315639
Commit-Queue: Luis Garcia <luisggarcia@google.com>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791967}

Google material standards usually prefer curly double/single quotes to
neutral quotes. The presubmit detects these punctuations in string
resources and then prints warnings.

Bug: 1100941
Change-Id: Id85ef0a9f299fccc0fabe795e6e1bb385d5379ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319541Reviewed-by: Theresa  <twellington@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/master@{#791966}

Before, the terms of service link would cause the OS settings window
to navigate to the ToS page without a back button.

Fixed: 1096892
Change-Id: Ieb8452ad969013e4242b7552d3fb4bcb0daadf5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314159Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791965}

Add methods for to get and set dictionary, time and list extension
specific ExtensionPrefs.

Design Doc: http://go/extprefrefactor

Bug: 1069560
Change-Id: I4afa211b9eb1a15f87797cb3cea6e20da9fe47ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314992
Commit-Queue: Archana Simha <archanasimha@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791964}

The CookieStore spec recently changed to disallow setting cookies
using this API:

https://github.com/WICG/cookie-store/pull/150

This CL updates the implementation of CookieStore in Blink to
perform this additional check and updates the web platform
tests to reflect the new changes to the spec.

Bug: 1108964
Change-Id: I1bc60332551308498509c0e8bbc6823bd8375ab8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316622Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/master@{#791963}

Bug: 1018157
Change-Id: Ic42b98cb72897d43ea140dbf5ad8470c724b8e79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295706
Commit-Queue: Chris Sharp <csharp@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791962}

crrev.com/c/2220875 added buffer timing infos to latency metrics.

This CL adds the new viz breakdown entries to GetStageName and
histograms.xml in order to record UMAs.

Additionally, this CL adds a NOTREACHED in GetStageName to make sure
if we add another viz breakdown entry we catch if we forget to
add the entry in that function.

Bug: 947077
Test: about://histograms now contains SubmitCompositorFrameToPresentationCompositorFrame.BufferAvailableToBufferReady and the other entries
Change-Id: I0542eb3fda4de50e6396579c89587012c9944a5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316412Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791961}

onTtsEvent() should null out currentUtterance_ like 'interrupted'
and 'end' events do.  Otherwise, the call to startSpeakingNextItemInQueue_
will bail immediately since it thinks an utterance is still
speaking.

Bug: NONE
Test: cast on display assistant after TTS_EVENT_ERROR dispatched to chromevox
Change-Id: Iee5b35d763e526f85ace9d9bfcef85580ca61291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317986Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791960}