1. 25 Aug, 2016 40 commits
    • xiaoyinh's avatar
      Adding the following stylus metrics: · 693c002f
      xiaoyinh authored
      1. Number of “down” events generated by stylus/touch/mouse
      2. Number of “down” events received by clamshell vs touchview
      
      BUG=630070
      
      Review-Url: https://codereview.chromium.org/2270173002
      Cr-Commit-Position: refs/heads/master@{#414304}
      693c002f
    • michaelpg's avatar
      Settings to remap Backspace and Escape keys · 168ecd71
      michaelpg authored
      We can remap modifier keys in Settings, but not Backspace or Escape;
      this adds settings to remap those keys and handles them in EventRewriter.
      
      BUG=608625
      R=kpschoedel@chromium.org,stevenjb@chromium.org,sadrul@chromium.org
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
      
      Review-Url: https://codereview.chromium.org/2250473006
      Cr-Commit-Position: refs/heads/master@{#414303}
      168ecd71
    • yhirano's avatar
      Sync XHR on Worker should not crash when response arrives immediately · 4f2cec77
      yhirano authored
      A WorkerThreadableLoader::MainThreadLoaderHolder instance is created on the
      main thread and its reference is sent to the worker thread. The current
      implementation sends the reference after the loading starts (on the main
      thread), but it's problematic because the loading may exit immediately and
      hence it breaks WorkerThreadableLoader::WaitableEventWithTasks's assumption.
      
      BUG=637980
      
      Review-Url: https://codereview.chromium.org/2250203003
      Cr-Commit-Position: refs/heads/master@{#414302}
      4f2cec77
    • haraken's avatar
      frame()->host() may be null in ScreenOrientationController::pageVisibilityChanged · 1014f297
      haraken authored
      This CL adds a check to isActiveAndVisible() so that
      ScreenOrientationController::pageVisibilityChanged don't access frame()->host()
      which is already null.
      
      BUG=640719
      
      Review-Url: https://codereview.chromium.org/2272043003
      Cr-Commit-Position: refs/heads/master@{#414301}
      1014f297
    • tyoshino's avatar
      Make sure that Apache for HTTP layout tests not to emit Content-Type by default · b44b03b4
      tyoshino authored
      BUG=591902
      R=dpranke
      
      Review-Url: https://codereview.chromium.org/2274743004
      Cr-Commit-Position: refs/heads/master@{#414300}
      b44b03b4
    • Lucas Garron's avatar
      HSTS preload list removals for Chrome 54. · c2ed5d4e
      Lucas Garron authored
      ecosystem.atlassian.net:
      Covered by atlassian.net
      
      redbee.nl:
      > We cannot support HTTPS on the following subdomains:
      > • staging.schoolwijzer.redbee.nl - Customer staging environment, out of
      > our control and just for testing purposes.
      
      cerfrance.fr:
      > We cannot support HTTPS on the following subdomains:
      > • link.85.cerfrance.fr – use by a email marketing service (sarbacane)
      > • link.cn.cerfrance.fr – use by a email marketing service (sarbacane)
      
      spacecompute.com:
      > I have no idea how this happened, since I never submitted the domain, but I
      > would like to remove it because unfortunately it's breaking some services that
      > integrate with google apps -- which it turns out do not play well with HTTPS
      > requests.
      
      ptsoft.de:
      > We cannot support HTTPS on the following subdomains:
      >
      > • dm8000.ptsoft.de - Forwarding to internal server
      > • config.ptsoft.de - Forwarding to internal server
      
      everythingkitchens.com:
      [15 subdomains] hosted on separate server than main domain
      
      hilti.com, etc. (25 hilti.{eTLD} domains):
      internal systems with same domain hilti.com do not all support https yet
      
      souyidai.com:
      > We cannot support HTTPS on the following subdomains:
      > • mail.souyidai.com - cooperation with other company
      
      nitho.me:
      > I am afraid that it due to that blindly following online tutorial.
      
      hovie.at:
      > We cannot support HTTPS on the following subdomains:
      >
      > • andrew.hovie.at - I don't have to time to manage my own server
      > anymore, so I switched to a hosting provider, wildcard certs are
      > expensive, they do not support certs with multiple domains.
      >
      > Also, when I enabled preload, I did not actually know what I am doing,
      > I was just following the recommendation from https://cipherli.st/.
      
      constructdigital.net:
      > We cannot support HTTPS on all sub-subdomains, since we don't have a wildcard
      > SSL for them. Also, this domain is meant for development purpose and was
      > configured as HSTS preload by mistake.
      
      groovinads.com:
      > We cannot support HTTPS on the following subdomains:
      > • my.groovinads.com - Appnexus does not handshake over https, and it's killing us.
      > • groovinads.com - same as above
      > • *.groovinads.com
      
      shamka.ru:
      > We cannot support HTTPS on the following subdomains:
      >
      > • [water] - don’t have ssl cert.
      > • [w] - not open 443 port
      > • and many new subdomains
      
      terravirtua.com:
      > chalk it up to copy-pasting something without fully understanding what i was
      > doing... i had added that after doing the ssl checker, following a
      > recommendation about increasing the 'grade' it returned. i later removed it
      > (the whole HSTS header) only to discover that everything continued to redirect
      > to https... and finally realizing i was preloaded.
      
      domainkauf.de:
      > We support HTTPS in another way and so we have problems with the following
      > subdomains:
      > • mail.domainkauf.de HTTP Redirect to the main mailserver
      > • imap /smtp / pop / pop3 / webmail with same reason
      
      internl.net:
      Uses uniquely generated domains per user with second-level subdomains, e.g. www.*.pa.internl.net; this can't be handled using wildcard certs.
      
      rinobroer.nl:
      No citable reason given.
      
      sexton.uk.com:
      > We cannot support HTTPS on the following subdomains:
      >
      > • mail.sexton.uk.com - costs for multiple SSL or SAN cert
      > • webmail.sexton.uk.com - costs for multiple SSL or SAN cert
      
      extracobanks.com:
      > We cannot support HTTPS on the following subdomains:
      >
      > • Various internal subdomains - Although our external website,
      > www.extracobanks.com, exclusively uses HTTPS, we also use extracobanks.com as
      > our internal domain.  Having extracobanks.com on the HSTS preload list is
      > causing problems for our employees connecting to internal sites, such as our
      > internal CRM that uses a self-signed certificate.  Chrome and Firefox are
      > giving "certificate authority invalid" errors when connecting to these
      > internal subdomains.  We also have some non-HTTPS 3rd party vendor provided
      > internal sites that cannot be changed to HTTPS that we cannot connect to at
      > all.
      >
      > Our www.extracobanks.com site was built and is managed by a 3rd party
      > Marketing firm.  I'm sure they added the HSTS header with the best intentions,
      > but it is causing issues for us internally with our employees.
      
      intramanager.co.uk/intramanager.dk:
      > We cannot support HTTPS on the domain, since we changed our whole SSL setup
      > and therefore do not support HTTPS on the intramanager.co.uk
      > [/intramanager.dk] domain anymore.
      >
      > We have moved all activity to intramanager.com, where we have full HTTPS
      > support.
      
      thekelvinliu.com:
      > I have a Tumblr blog at blog.thekelvinliu.com, which does not support https.
      
      h-neef.de:
      > We cannot support HTTPS on the whole Domain including subdomains, because we
      > moved to a new IP Address and Need it for test purposes!
      
      nathancheek.com:
      > I never intended to be preloaded, nor to include subdomains, but I made the
      > mistake of adding ‘preload’ and 'includeSubDomains’ to the HSTS header,
      > without understanding what they entailed.
      
      mercurystorm.co.za:
      > I have moved from a Virtual Private Server to shared hosting, and can no
      > longer use SSL certificates
      
      klaxn.com:
      > my client is not able to pay for a SSL certificate
      
      postpi.com:
      > self signed certificate
      
      stupus.com:
      > We cannot always support HTTPS on the all of our subdomains.
      > ...
      > I can no longer always support HTTPS on my domain because I change server
      > distributions frequently.
      
      upstox.com:
      > We cannot support HTTPS on the following subdomain:
      >
      > help.upstox.com -> We are using this domain to point help.rksv.in with CNAME
      > record and for rksv.in domain we don't have Wildcard SSL certificate so
      > whenever we open help.upstox.com it goes to HTTPS in chrome.
      
      TBR=palmer@chromium.org
      BUG=527947
      
      Review URL: https://codereview.chromium.org/2113813002 .
      
      Cr-Commit-Position: refs/heads/master@{#414299}
      c2ed5d4e
    • yamaguchi's avatar
      Add comment to clarify what the mock action in the test does. · eb9681e8
      yamaguchi authored
      This is a follow-up of Issue 2230713003.
      
      BUG=629945, 640579
      
      Review-Url: https://codereview.chromium.org/2273123003
      Cr-Commit-Position: refs/heads/master@{#414298}
      eb9681e8
    • penghu's avatar
      Replace 'eglGetCurrentContext()' with 'GetCurrent()'. · b6f04615
      penghu authored
      An external eglcontext may be current on android webview. GetCurrent() is better than eglGetCurrentContext() here.
      
      BUG=
      
      Review-Url: https://codereview.chromium.org/2276873002
      Cr-Commit-Position: refs/heads/master@{#414297}
      b6f04615
    • ksakamoto's avatar
      Add trace event for FirstMeaningfulPaint candidates · 1b6b36c1
      ksakamoto authored
      This adds a trace event that is logged every time the provisional
      FirstMeaningfulPaint timestamp is updated.
      
      Trace-based implementations can find FirstMeaningfulPaint for the page
      load by looking for the last event in the trace.
      
      BUG=638124
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
      
      Review-Url: https://codereview.chromium.org/2276573003
      Cr-Commit-Position: refs/heads/master@{#414296}
      1b6b36c1
    • v8-autoroll's avatar
      Update V8 to version 5.4.515. · b5b34301
      v8-autoroll authored
      Summary of changes available at:
      https://chromium.googlesource.com/v8/v8/+log/d09641f4..b4f9789f
      
      Please follow these instructions for assigning/CC'ing issues:
      https://github.com/v8/v8/wiki/Triaging%20issues
      
      Please close rolling in case of a roll revert:
      https://v8-roll.appspot.com/
      This only works with a Google account.
      
      CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      
      TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org
      
      Review-Url: https://codereview.chromium.org/2274363002
      Cr-Commit-Position: refs/heads/master@{#414295}
      b5b34301
    • recipe-roller's avatar
      Roll recipe dependencies (trivial). · 42faf764
      recipe-roller authored
      This is an automated CL created by the recipe roller. This CL rolls recipe
      changes from upstream projects (e.g. depot_tools) into downstream projects
      (e.g. tools/build).
      
      More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
      (or complain)
      
      build:
        https://crrev.com/355a52109ec78c1bda63274fadaa2f83462b604d Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
        https://crrev.com/38954ea2aea645d40d933ec08fa9300978745851 Make syzygy recipes explicitly set GIT_MODE (agable@chromium.org)
        https://crrev.com/e10345ca9ae54bb82c86679d2e107dabb92a04bc Make v8 recipes explicitly set GIT_MODE (agable@chromium.org)
        https://crrev.com/1841f028ff591483facb7ada955e1e6eb942f343 Make dart recipes explicitly set GIT_MODE (agable@chromium.org)
        https://crrev.com/4fe7d03aee971b7daadc70b69dcf0f43eb1a59a5 Add stip@ to chromium.py OWNERS. (stip@chromium.org)
        https://crrev.com/32a901e0ee458a3b063f995ab461d38096ba80fd Make iOS recipes explicitly set GIT_MODE (agable@chromium.org)
        https://crrev.com/6ae64c302a5ae3bfc0df6d520b4945dfbd05c9ec Make android recipes explicitly set GIT_MODE (agable@chromium.org)
        https://crrev.com/6679485ce287924084b369b20fab59c1f6ef8122 Enable swarming for iOS try bots (smut@google.com)
      depot_tools:
        https://crrev.com/f14eaff8148de420c63c87bd67678bf86837641a Remove --base_url from git cl and upload.py (agable@chromium.org)
      
      TBR=martiniss@chromium.org,phajdan.jr@chromium.org
      BUG=598405,638750,640251
      
      Recipe-Tryjob-Bypass-Reason: Autoroller
      Bugdroid-Send-Email: False
      Review-Url: https://codereview.chromium.org/2274173004
      Cr-Commit-Position: refs/heads/master@{#414294}
      42faf764
    • zhongyi's avatar
      Quic: add the racing cert verification field trial experiment for chrome on Android. · 7abc2fdf
      zhongyi authored
      BUG=
      
      Review-Url: https://codereview.chromium.org/2275163002
      Cr-Commit-Position: refs/heads/master@{#414293}
      7abc2fdf
    • yusufo's avatar
      Delay setting the compositor view background to null on N · 98da165e
      yusufo authored
      We set compositor view background to white while there are no
      frames and onSwapBufferCompleted swap it back to null. On N
      this creates a black flash on some cold starts where there is
      still a frame that is drawn before the frame is actually completed.
      
      BUG=640758
      
      Review-Url: https://codereview.chromium.org/2271393003
      Cr-Commit-Position: refs/heads/master@{#414292}
      98da165e
    • xhwang's avatar
      media: Separate renewal from default External Clear Key test · 0cfb5283
      xhwang authored
      External Clear Key should be an external "Clear Key" key system which
      behaves the same as "Clear Key" but is hosted externally (e.g. in a
      separate process). It could support decrypt-and-decode by incorporating
      codecs, or only support decrypt-only (same as default Clear Key
      implementation in Chromium).
      
      This will help us enable External Clear Key tests on multiple platforms,
      e.g. on Android.
      
      To do this, we need to move non-standard "Clear Key" features out of
      the default External Clear Key test. This CL moves "renewal" test to a
      new key system name: org.chromium.externalclearkey.renewal.
      
      BUG=581893
      TEST=This CL splits a curent test into two tests.
      
      Review-Url: https://codereview.chromium.org/2267283002
      Cr-Commit-Position: refs/heads/master@{#414291}
      0cfb5283
    • jamescook's avatar
      ash: Move more code from Shelf to WmShelf · 8fd4ac5b
      jamescook authored
      This is another step toward eliminating ash::Shelf.
      
      * Move code that needs ShelfView into ShelfWidget to avoid exposing ShelfView
      * Remove dead code (especially shelf_navigator.*)
      * Make icon activation functions static
      
      BUG=615502
      TEST=ash_unittests, browser_tests
      
      Review-Url: https://codereview.chromium.org/2274333002
      Cr-Commit-Position: refs/heads/master@{#414290}
      8fd4ac5b
    • michaelpg's avatar
      MD Settings: fix collapse animation once and for all · 6c4ce51e
      michaelpg authored
      Makes the collapsing card position: absolute (instead of fixed).  Anchoring
      it to the section makes it actually follow the section, so it always moves
      toward the right position even if the containter's scroll/height/size changes.
      Should reduce jarring jumps at the end of transitions.
      
      Also moves the style changes into Web Animations instead of inline. This makes
      the animations fire-and-forget. Transition clean up is largely automatic, there
      are no styles to (forget to) remove (at the wrong time). If a transition is
      buggy, we're still likely to end up in the right place.
      
      This fixes several animation bugs (but likely introduces new ones).
      
      BUG=589681, 621245, 622172
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
      
      Review-Url: https://codereview.chromium.org/2230123002
      Cr-Commit-Position: refs/heads/master@{#414289}
      6c4ce51e
    • yunchao.he's avatar
      [Command Buffer] Coding style: FrameBuffer -> Framebuffer to be comformant · 4656783b
      yunchao.he authored
      BUG=
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/2268993003
      Cr-Commit-Position: refs/heads/master@{#414288}
      4656783b
    • chrome-cron's avatar
      Updating trunk VERSION from 2839.0 to 2840.0 · 5ace2671
      chrome-cron authored
      Cr-Commit-Position: refs/heads/master@{#414287}
      5ace2671
    • tyoshino's avatar
      Remove stale comments for blink::decodeURLEscapeSequences() · da51acae
      tyoshino authored
      There are several comments and FIXMEs about concern about NULL
      unescaping.
      
      The FIXMEs have been there since the commit for upstreaming
      KURLGoogle.cpp which is
      http://crrev.com/1730ee062f4e55666b1bbf3e777443e508c60708.
      
      But the commit
      http://crrev.com/8e70a3c3b73ed85dd62102bf251683feda91307e has already
      removed the special care for NULL character. The internal bug b/1350291
      was just mentioning WebKit bug 20559.
      
      We still have a warning comment about brettw@'s concern in KURL.h, so,
      clean up the others.
      
      As a bonus, this CL adds a test to check that the method decodes UTF-8.
      
      R=brettw
      BUG=none
      
      Review-Url: https://codereview.chromium.org/2270373002
      Cr-Commit-Position: refs/heads/master@{#414286}
      da51acae
    • watk's avatar
      Invalidate VideoRendererImpl's weak ptrs before resetting the decoder · 4889f186
      watk authored
      Previously VideoRendererImpl waited for the VideoFrameStream::Reset() to
      complete before invalidating its frame callback weak pointers, which
      meant that it could receive frames that it didn't want between Flush()
      and OnVideoFrameStreamResetDone(). For simplicity, now the weak pointers
      are invalidated at the same time that Reset() is called, so it's
      guaranteed that no frames will be received after Flush().
      
      Also included in this change is reordering the deletion of the video
      frame queue and resetting of the VideoFrameStream to save VDAs doing
      wasted work.
      
      BUG=640800
      
      Review-Url: https://codereview.chromium.org/2273033003
      Cr-Commit-Position: refs/heads/master@{#414285}
      4889f186
    • rdevlin.cronin's avatar
      [Extensions] Convert some SyncExtensionFunctions · 0c448a7d
      rdevlin.cronin authored
      SyncExtensionFunctions, AsyncExtensionFunctions,
      ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
      deprecated.
      
      Remove SyncExtensionFunctions from:
      - management
      - metrics_private
      - system_private
      - networking_private
      - power
      
      BUG=634140
      
      Review-Url: https://codereview.chromium.org/2261313002
      Cr-Commit-Position: refs/heads/master@{#414284}
      0c448a7d
    • kinaba's avatar
      arc: Stop piggybacking "text input started" and "show virtual keyboard" events. · 17a7a0c8
      kinaba authored
      It is not only useless in the latest version, but is even harmful
      for some advanced apps that take the liberty of splitting these
      two events.
      
      This change itself should not change any observable behavior yet,
      but will be necessary to enable coming Android-side change to
      make this split effective.
      
      BUG=640816
      BUG=b/31001453
      TEST=ArcImeServiceTest
      TEST=Tested manually with some ARC apps (Settings, PlayStore)
      
      Review-Url: https://codereview.chromium.org/2280503002
      Cr-Commit-Position: refs/heads/master@{#414283}
      17a7a0c8
    • catapult-deps-roller's avatar
      Roll src/third_party/catapult/ 5bcf2c70f..06af11370 (7 commits). · ef5c4148
      catapult-deps-roller authored
      https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5bcf2c70f4dd..06af1137071d
      
      $ git log 5bcf2c70f..06af11370 --date=short --no-merges --format='%ad %ae %s'
      2016-08-24 benjhayden Fix composition-span colors.
      2016-08-24 benjhayden Modernize RelatedEventSet to use ES6 classes.
      2016-08-24 ssid TracingMetric: Calculate average MemoryDumpProvider overhead over OnMemoryDump invocations
      2016-08-24 benjhayden Migrate metric_registry_test from ScalarNumeric
      2016-08-24 alexandermont Overhaul unit conversions in trace viewer.
      2016-08-24 ssid MemoryMetric: add total and peak resident set size values
      2016-08-24 oysteine Trace processor: Fixes after perf_insights got nuked
      
      TBR=catapult-sheriff@chromium.org
      
      Review-Url: https://codereview.chromium.org/2275123003
      Cr-Commit-Position: refs/heads/master@{#414282}
      ef5c4148
    • dcastagna's avatar
      exo: Disable RGBX fullscreen overlays. · 18d1778a
      dcastagna authored
      Fullscreen overlays have been enabled on minnie.
      Unfortunately there are some issues in HardwareDisplayPlaneManager::
      AssignOverlayPlanes with RGBX buffers.
      
      This patch disables the overlay optimization for those buffers
      while we work on a fix.
      
      BUG=b/29430506
      
      Review-Url: https://codereview.chromium.org/2278803003
      Cr-Commit-Position: refs/heads/master@{#414281}
      18d1778a
    • estark's avatar
      Bring back SCT_STATUS_INVALID for cached entries · 321ed2a5
      estark authored
      https://codereview.chromium.org/2241213002/ split SCT_STATUS_INVALID
      into two new enum values to record the different reasons that an SCT
      might be invalid. However, we didn't realize that SCT_STATUS_INVALID
      might still be present in disk cache entries, resulting in renderer
      kills when the browser tries to deserialize SSLStatus objects containing
      these cached SCT_STATUS_INVALID values.
      
      This CL brings back SCT_STATUS_INVALID and documents it as deprecated,
      but still existent for the sake of cache entries.
      
      BUG=640296
      
      Review-Url: https://codereview.chromium.org/2277653002
      Cr-Commit-Position: refs/heads/master@{#414280}
      321ed2a5
    • kbr's avatar
      Port context_lost test to new GpuIntegrationTest harness. · 3aa872b6
      kbr authored
      The main trick here is to get hand-written tests to trampoline through
      the _RunGpuTest harness, which is where test expectations are
      implemented.
      
      This is done by adopting a convention that the "real" test, like
      "_GPUProcessCrashesExactlyOnce", is prefixed with an underscore. This
      is implemented in self-contained fashion in
      ContextLostIntegrationTest.GenerateGpuTests. If necessary, this will
      be generalized further into a base class.
      
      The waterfalls will be switched to run the new version of the test in
      a follow-on CL.
      
      BUG=352807
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
      
      Review-Url: https://codereview.chromium.org/2271543002
      Cr-Commit-Position: refs/heads/master@{#414279}
      3aa872b6
    • yosin's avatar
      Convert editing/execCommand/remove-list-item-1.html to use w3c test harness · e211f36d
      yosin authored
      This patch converts "editing/execCommand/remove-list-item-1.html" to use w3c
      test harness to simplify test script for improving readability.
      
      BUG=n/a
      TEST=n/a; no behavior changes
      
      Review-Url: https://codereview.chromium.org/2276563003
      Cr-Commit-Position: refs/heads/master@{#414278}
      e211f36d
    • lgcheng's avatar
      arc: Enable user control for Arc package sync. · 9b98997d
      lgcheng authored
      Current Arc package sync implemetation does not support stop sync and re-enable
      sync without rebooting. So user control of arc package sync is not achievable.
      This patch re-implement sync stop and enable proper user control of arc package
      sync using apps checkbox in advanced sync settings.
      
      BUG= http://b/31034323, http://b/30640291, http://b/30980543
      TEST=Pass sync integration test.
      TEST=Manual test1. Turn on apps sync settings. Enable Arc and install package.
      Nuke Arc then enable arc. Package restored.
      TEST=Manual test2. Turn on apps sync settings. Enable Arc and install package.
      Turn off apps sync settings and then nuke Arc. Then enable arc. Package not
      restored. Then turn on apps sync settings. Package restored.
      
      Review-Url: https://codereview.chromium.org/2277593002
      Cr-Commit-Position: refs/heads/master@{#414277}
      9b98997d
    • twellington's avatar
      [Downloads] Remove externally deleted items from downloads history · e9334c61
      twellington authored
      Rather than greying out externally deleted items, delete
      the files and remove the entry from history.
      
      BUG=616324
      
      Review-Url: https://codereview.chromium.org/2271913002
      Cr-Commit-Position: refs/heads/master@{#414276}
      e9334c61
    • Aaron Gable's avatar
      Make chromium canary recipe explicitly set GIT_MODE · de30c525
      Aaron Gable authored
      This is completely safe because this recipe isn't
      used for anything.
      
      TBR=iannucci@chromium.org
      BUG=640251
      
      Review URL: https://codereview.chromium.org/2276033004 .
      
      Cr-Commit-Position: refs/heads/master@{#414275}
      de30c525
    • servolk's avatar
      Return buffers from StreamParsers in a single unified map · 83f4c6d2
      servolk authored
      Currently various StreamParsers return output buffers via 3 separate
      collections: a queue for audio, a queue for video and a map of queues
      keyed by the track id for text tracks. Now that all stream parsers
      properly assign track id to each buffer we can unify all those 3
      collections into a single BufferQueueMap keyed by track ids.
      
      BUG=341581
      
      Review-Url: https://codereview.chromium.org/2254093002
      Cr-Commit-Position: refs/heads/master@{#414274}
      83f4c6d2
    • calamity's avatar
      [MD History] Prevent horizontal scrolling of history views. · 506120df
      calamity authored
      This CL fixes an issue where the overlay scrollbar would allow Chrome to
      scroll to the right to show the space covered by the vertical scrollbar.
      This has been fixed by reverting to overflow:auto.
      
      BUG=638527
      CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
      
      Review-Url: https://codereview.chromium.org/2273523002
      Cr-Commit-Position: refs/heads/master@{#414273}
      506120df
    • mariakhomenko's avatar
      Implement instant apps infobar. · 90230d6b
      mariakhomenko authored
      Has the expected visual treatment, but doesn't currently do anything functionally.
      Also no one is currently launching the infobar.
      
      BUG=639497
      
      Review-Url: https://codereview.chromium.org/2267463002
      Cr-Commit-Position: refs/heads/master@{#414272}
      90230d6b
    • thestig's avatar
      Add a fuzzer for SfntlyWrapper::SubsetFont(). · 05192643
      thestig authored
      BUG=639545
      
      Review-Url: https://codereview.chromium.org/2268863003
      Cr-Commit-Position: refs/heads/master@{#414271}
      05192643
    • dbeam's avatar
      MD Settings: fix metrics reporting unittests on official testers -- take 2 · 2c9f3ce6
      dbeam authored
      R=dschuyler@chromium.org
      BUG=637068
      
      Review-Url: https://codereview.chromium.org/2265553003
      Cr-Commit-Position: refs/heads/master@{#414270}
      2c9f3ce6
    • groby's avatar
      [MD Settings] Remove jank for webui. · d7997ead
      groby authored
      WebUI URLRequest source data is (on desktop) backed by a memory-mapped
      file. Copying that data in CompleteRead can trigger jankiness due to
      potential file IO caused by the read.
      
      This CL moves the memcpy on the file thread. It is also a re-land of
      https://codereview.chromium.org/2158123003/ with minor changes to fix a
      crash.
      
      R=dbeam@chromium.org, mmenke@chromium.org, dproy@chromium.org
      BUG=455423
      
      Review-Url: https://codereview.chromium.org/2268653002
      Cr-Commit-Position: refs/heads/master@{#414269}
      d7997ead
    • yuweih's avatar
      [Remoting Android] Fix OAuthTokenConsumer's thread safety issue · e8f9faf5
      yuweih authored
      OAuthTokenConsumer.revokeLatestToken() revokes the token on the background
      thread and calls the callback directly on that thread once it is done. This
      would be potentially thread unsafe if the caller doesn't realize the callback
      will be called on a non-main thread. Currently we don't see any bug related
      to this problem since the only caller of revokeLatestToken() passes in null
      as the callback.
      
      This CL makes revokeLatestToken() post a task to the main thread to run the
      callback when the token is revoked.
      
      Review-Url: https://codereview.chromium.org/2277723003
      Cr-Commit-Position: refs/heads/master@{#414268}
      e8f9faf5
    • jrummell's avatar
      EME: Fix nits for encrypted media layout tests · 5a02d174
      jrummell authored
      During recent reviews there have been several nits reported. This
      change fixes a few of them.
      
      BUG=442566
      TEST=updated tests pass
      
      Review-Url: https://codereview.chromium.org/2169713002
      Cr-Commit-Position: refs/heads/master@{#414267}
      5a02d174
    • yosin's avatar
      Get rid of FrameSelection::moveTo() taking two VisiblePosition objects · e8087c7e
      yosin authored
      This patch gets rid of |FrameSelection::moveTo()| taking two |VisiblePosition|
      objects since its call site is only one for improving code health.
      
      BUG=n/a
      TEST=n/a; no behavior changes
      
      Review-Url: https://codereview.chromium.org/2278463002
      Cr-Commit-Position: refs/heads/master@{#414266}
      e8087c7e
    • harkness's avatar
      Added budget_service.mojom · 7e00f5e7
      harkness authored
      This isn't implemented yet, but will be provide the Mojo service that will provide blink an access point to the BackgroundBudgetService.
      
      This also adds a mock and a layout test to check the mojo service.
      
      BUG=617971
      
      Review-Url: https://codereview.chromium.org/2231873002
      Cr-Commit-Position: refs/heads/master@{#414265}
      7e00f5e7