- 26 Mar, 2018 40 commits
-
-
Stephen McGruer authored
This avoids hitting the DCHECK in WorkletAnimation::WorkletAnimation in the case where --disable-threaded-animations is specified. Bug: 825127 Change-Id: I5e2eb0684e472d5a88f40ad07f19f73c0118b627 Reviewed-on: https://chromium-review.googlesource.com/980234Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#545824}
-
Koji Ishii authored
This patch adds the base direction to NGPhysicalLineBoxFragment. The base direction is also known as the paragraph direction, and explained in [UAX#9]. While this is computed and used in layout, it turned out that selection and editing needs this value. [UAX#9]: http://unicode.org/reports/tr9/ Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I2888d36bef7f465f4afacf11e5ca52f6418221a4 Reviewed-on: https://chromium-review.googlesource.com/980393Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#545823}
-
Avi Drissman authored
This does C++11ification. This also does a partial Callback cleanup, only of the instances where it was obvious what they were. Further cleanup is left for later. This also removes ancient cleanup code that has been cleaning up profiles for 4.5 years now. All the profiles have been cleaned up by now. BUG=295882, 714018 Change-Id: I26da23e1a49aa0f776ec1f9ca1310d9254dee3af Reviewed-on: https://chromium-review.googlesource.com/979613Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545822}
-
crystallambert@chromium.org authored
Badges no longer support opacity settings on colors. Updated documentation to reflect this. Bug: 623573 Change-Id: I850e3f91980e2ab74efaf795c00cdcdbb749315d Reviewed-on: https://chromium-review.googlesource.com/979072Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#545821}
-
Eric Karl authored
Skia currently dumps wrapped objects, and Chrome tries to alias these objects with Chrome's own dumps. This isn't always possible, so instead this change uses a new Skia API to ask Skia to skip dumping these. Bug: 795358 Change-Id: Iee3dbbb09037cb84fa8a33f0512cb2a54ef42f32 Reviewed-on: https://chromium-review.googlesource.com/979773Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#545820}
-
Findit authored
This reverts commit 3e261e9b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 545798 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzNlMjYxZTliMDBlZWI4YTA4MTJkNDc2OGIxN2FhYjMyNDkzODhhNzEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Android/83350 Sample Failed Step: compile Original change's description: > Android: Add extra fields related to resources to crash reports. > > This CL adds two fields to Android crash reports. Specifically: > 1. custom_themes: Whether or not the user has apps installed for using > custom themes. This should help debug obscure resources related > crashes. > 2. resources_version: The product version as stored in resources.arsc. > This should help us detect if we tried to load resources from the old > apk during an update. > > Bug: 820591 > Change-Id: I1e2b36ec5640bb1376f83452851eaa5319d0f32f > Reviewed-on: https://chromium-review.googlesource.com/969597 > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545798} Change-Id: I05779ad74a74437faed311583f7249f0e60614b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820591 Reviewed-on: https://chromium-review.googlesource.com/981012 Cr-Commit-Position: refs/heads/master@{#545819}
-
Henrik Grunell authored
WebRtcLoggingHandlerHost can be alive after the RenderProcessHost and the BrowserContext goes away and we must not access it then. It's only used for getting the file path so storing that instead. Bug: 810751 Change-Id: I748b72c6ea4a2cffa756ddea81d95a727c5ce987 Reviewed-on: https://chromium-review.googlesource.com/913348Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#545818}
-
Dale Curtis authored
This adds a base::Feature, kPreloadMetadataSuspend, for suspending preload=metadata players that are either audio-only or have video and have a poster image. Given the uncertainty and issues with canplay, canplaythrough, the current version of this feature signals HAVE_ENOUGH when after a suspended startup successfull completes. This also fixes a minor issue where streams with a positive start time were not suspending at the right time. BUG=694855 TEST=enabling feature still passes all bots. More layout tests, which are disabled by default in this CL since the feature is disabled by default for now. Change-Id: Iccd79eddbd7a3b03933b3090eb99ad19c2fed768 Reviewed-on: https://chromium-review.googlesource.com/978867Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#545817}
-
Jonathan Backer authored
Should strictly be a no-op. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie861d396ae4b825f1b6149044e4947dda46a5f21 Reviewed-on: https://chromium-review.googlesource.com/973543Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#545816}
-
sczs authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I175dc06add2d7c131ecd077062fa60de531968eb Reviewed-on: https://chromium-review.googlesource.com/972192 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#545815}
-
Dan Sinclair authored
This CL adds a custom callback for the PDF plugin to use to display dialogs. Bug: 821266 Change-Id: I6bf97678e773a086b5198a9a961805dcde6acc39 Reviewed-on: https://chromium-review.googlesource.com/961270 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#545814}
-
Daniel Bratell authored
Per answers on chromium-dev@, the android_compile_mips_dbg trybot is no more. Bug: gerrit:8617 Change-Id: I2f23c663d2baf397f30532290300bf2946531ab9 Reviewed-on: https://chromium-review.googlesource.com/980492 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#545813}
-
David Bokan authored
ForceZeroLayoutHeight is a Blink setting that's an Android WebView quirk. When set, Blink will set the height on the initial containing block (i.e. LayoutView) in the main frame to be 0. In the linked bug, we never see the video frame because the iframe it's hosted in is rendering throttled so it never paints. The reason it's throttled is because the IntersectionObserver that determines its visibility on screen uses the LayoutView's size. Because of the ForceZeroLayoutHeight setting, the LayoutView size is empty so the intersection is also always empty so we conclude the iframe is always off screen. The fix here is to carve out an exception in IntersectionObserver when this setting is enabled. In that case, for the root element, we use the FrameView's geometry instead. Bug: 824730 Change-Id: Ief24437135d19120a4e9bba8a2f1777ac448eea7 Reviewed-on: https://chromium-review.googlesource.com/978624Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#545812}
-
Keishi Hattori authored
AtomicPauseScope is used to mark when we have paused the mutator for gc. Bug: 757440 Change-Id: I756337f03c8e1c60408e381d4aff045dc8d6acf4 Reviewed-on: https://chromium-review.googlesource.com/979376 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545811}
-
Patrick Monette authored
This function now returns after the first valid program found in the cache instead of building a vector containing all the programs. Bug: 822867 Change-Id: I9757ac6f81ac4ad4d588461b95af15865e25d863 Reviewed-on: https://chromium-review.googlesource.com/967149 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#545810}
-
Simeon Anfinrud authored
By using a new Scope interface that extends AutoCloseable instead of AutoCloseable itself, types that return Scope are easier to understand in terms of their role with respect to Observables, while still allowing the Scopes to be used in try-with-resources statements. This also removes the StateObserver wrapper that adapted the ScopeFactory interface to an interface with two methods. This reduces the number of intermediate wrappers for every watch() call, which should be slightly more efficient, and gives more control to Observable implementations. For instance, an Observable implementation could now conceivably manage more than one activation at a time, with no changes in observing ScopeFactories needed. There are a couple of ways that this would be useful, but the addition of such an implementation will wait for another patch. Bug: NONE Test: cast_base_junit_tests, cast_shell_junit_tests Merge-With: eureka-internal/156132 Change-Id: Ie348fe4782fa2cdf697c405444717e50d1588cf0 Reviewed-on: https://chromium-review.googlesource.com/969067Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545809}
-
Olga Sharonova authored
Bug: 792441 Change-Id: I0d715e485ce1d7f414d65e4c08291537d3d48614 Reviewed-on: https://chromium-review.googlesource.com/873351 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545808}
-
Michael Spang authored
These are no longer necessary since PlatformEvent is now a typedef to ui::Event*. BUG=none TEST=compile Change-Id: I49749511c7db8d0f2f96add58201ad6d288445f3 Reviewed-on: https://chromium-review.googlesource.com/978468 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#545807}
-
Devlin Cronin authored
A few APIs validate arguments against a signature specified in an event call, rather than as an API method. Allow this validation to happen natively when native bindings are enabled by adding a JS utility to add a custom signature and validate against it. Use this for certificateProvider, printerProvider, and webRequest custom bindings instead of the JS validation. Add unittests for the new JS utility method. Bug: 810487 Change-Id: Ifbc8480ae15acbdaa9ecdffcfb7bfe159e201510 Reviewed-on: https://chromium-review.googlesource.com/914808Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545806}
-
Mugdha Lakhani authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/956183 caused a few tests to be flaky, which was due to the garbage collector getting rid of BackgroundFetchOptions from under us. This change creates a copy of background fetch options early on, converting them from blink::BackgroundFetchOptions to mojom::blink::BackgroundFetchRegistrationPtr. This copy is not going to be deleted by the GC, hence ensuring accurate data later on in the processing of the fetch. Bug: 822276 Change-Id: Iaab780b18182372cf607b57eb15815c852d4595a Reviewed-on: https://chromium-review.googlesource.com/977909 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#545805}
-
Becca Hughes authored
Harden feature policy layout tests and switch them back on. These tests are still disabled with site isolation until HasBeenActivated is replicated. BUG=794631,790549 Change-Id: I8fd2be1f9222c71288d5e39e1639c4d990df995b Reviewed-on: https://chromium-review.googlesource.com/966069Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#545804}
-
Fergal Daly authored
Bug: 805271 Change-Id: I839abbb345aecaf675b762780700f882b3635c2e Reviewed-on: https://chromium-review.googlesource.com/972772 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#545803}
-
Hwanseung Lee authored
block-size[1], inline-size[2], max-block-size[3], max-inline-size[4], min-block-size[5], min-inline-size[6] are added to support in whitelist. and test file are also added. [1]https://drafts.csswg.org/css-logical-1/#propdef-block-size [2]https://drafts.csswg.org/css-logical-1/#propdef-inline-size [3]https://drafts.csswg.org/css-logical-1/#propdef-max-block-size [4]https://drafts.csswg.org/css-logical-1/#propdef-max-inline-size [5]https://drafts.csswg.org/css-logical-1/#propdef-min-block-size [6]https://drafts.csswg.org/css-logical-1/#propdef-min-inline-size Bug: 820299 Change-Id: I97c589deea28bfedc82ec1b1686ceaf9979cb95e Reviewed-on: https://chromium-review.googlesource.com/973561 Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#545802}
-
Luke Zielinski authored
This fixes a regression where the SBER checkbox sometimes had to be clicked twice to be toggled. Bug: 819203 Change-Id: Iad26a6eaa33e4798a086c297fd11540c7c2674e8 Reviewed-on: https://chromium-review.googlesource.com/978629Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545801}
-
Sahel Sharify authored
This is a reland of b23ffdff Original change's description: > Moved feature_list initialization to test SetUp. > > Since I didn't want to disable wheel scroll latching in > InputEventRouterWheelTargetTest I moved MainframeWheelEventsOnMainThread > and SubframeWheelEventsOnMainThread tests to a new subclass that > disables WheelScrollLatching in the SetUp function. > The change is for avoiding data race due to initialization of the > feature_list in the tests. > > Bug: 822764 > Change-Id: I76d9fee1474e8e7a50eca8d311941bcd969dafe3 > Reviewed-on: https://chromium-review.googlesource.com/974366 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545216} Bug: 822764 Change-Id: I385b522c2c56bede81f432060519b4055407e859 TBR: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/978421Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#545800}
-
John Budorick authored
Bug: 799759 Change-Id: I57d860f897db5fbc477e1b67e8979a651768d052 Reviewed-on: https://chromium-review.googlesource.com/979610 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#545799}
-
Eric Stevenson authored
This CL adds two fields to Android crash reports. Specifically: 1. custom_themes: Whether or not the user has apps installed for using custom themes. This should help debug obscure resources related crashes. 2. resources_version: The product version as stored in resources.arsc. This should help us detect if we tried to load resources from the old apk during an update. Bug: 820591 Change-Id: I1e2b36ec5640bb1376f83452851eaa5319d0f32f Reviewed-on: https://chromium-review.googlesource.com/969597 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545798}
-
Rob Wu authored
browserAction and pageAction methods take a tabId as parameter. An extension cannot ensure that the tabId is valid, since the tab might be removed between the invocation and the handling of the API method. To suppress the error, extensions need to be able to access the `chrome.runtime.lastError` object in the callback, which means that all extension action API methods need to accept an optional callback. BUG=451320 Change-Id: I4bd1fe8b17bdb98da7b33a03ec814294d5860da1 Reviewed-on: https://chromium-review.googlesource.com/979451Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Rob Wu <rob@robwu.nl> Cr-Commit-Position: refs/heads/master@{#545797}
-
Manuel Rego Casasnovas authored
Update the baseline for Windows platform. BUG=554893,825209 Change-Id: Iea34acced865105aabb11b1bce804c454bbd01f7 Reviewed-on: https://chromium-review.googlesource.com/979793Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#545796}
-
Emily Hanley authored
This reverts commit 301c89e2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove "Skipped" file and Port.skips_perf_test > > I believe this might be dead code; I'm not sure if > the layout test runner is used to run any Blink > performance tests. > > The last related change was last year: > https://codereview.chromium.org/2734823006 > > Before that, all changes seem to be from about 5 years ago. > > Change-Id: Ib1a23055391112c83b97e000707f0b2f333040e5 > Reviewed-on: https://chromium-review.googlesource.com/966484 > Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545710} TBR=qyearsley@chromium.org,tkent@chromium.org,yoichio@chromium.org Change-Id: I3b905a29342fa0a65b8c2dbb7e643d62cf39679f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/980792Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#545795}
-
Andrew Grieve authored
This way the diff output is the same whether or not the diff was cached. Change-Id: I14428725408d6cf49ae570d269849d6b0b7e1a35 Reviewed-on: https://chromium-review.googlesource.com/979232Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#545794}
-
tzik authored
This applies base_bind_rewriters at //tools/clang/base_bind_rewriters to replace base::Bind() with base::BindOnce() on mechanical cases, and to remove unneeded base::Passed() on base::BindOnce() arguments. Bug: 714018 Change-Id: Ibcdab031e117eb0ecffc2dd75295966cb032ea02 Reviewed-on: https://chromium-review.googlesource.com/979880Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#545793}
-
Ryan Daum authored
Touch events and gesture events which occurred after a ET_SCROLL_FLING_START were still being propagated to the underlying application rather than processed as part of the system gesture event. Fixes detection of gesture begin to include FLING_START. Avoids propagating all touch events while gesture is in progress. Bug: internal b/76161997 Test: CQ, manual test Change-Id: Ie764339d586c16051420720276e7f7202e920acf Reviewed-on: https://chromium-review.googlesource.com/978653Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#545792}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0351f2cb..7ab45c02 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia048a579f79f9fa80ace9897e25a13b17a88e76e Reviewed-on: https://chromium-review.googlesource.com/979974Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545791}
-
Avi Drissman authored
BUG=268984, 170921, 411569 TBR=sky@chromium.org Change-Id: I667c03c27e632336fb5a1c22f198e617ee7451c4 Reviewed-on: https://chromium-review.googlesource.com/979616 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545790}
-
Mihai Sardarescu authored
This CL avoids saving passwords when the user is signing in to Chrome via the Desktop Identity Consistency flow. It basically avoids saving password for URLs with origin "accounts.google.com" and that have the URL parameter "ssp=1". This CL also reverts https://chromium-review.googlesource.com/888623 which was a poor attempt to fix the same bug. To review the code: * Patch 1 is the revert of https://chromium-review.googlesource.com/888623 * Following patches contain the real fix. Bug: 805826 Change-Id: I947b63cea5e2a875260fc9d6066eed696198e35f Reviewed-on: https://chromium-review.googlesource.com/979932Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#545789}
-
Lizhi Fan authored
media::Audio[In|Out]putBufferParameters member name changed to: AudioInputBufferParameters::capture_time_us; AudioOutputBufferParameters::delay_us; AudioOutputBufferParameters::delay_timestamp_us; R=raymes@chromium.org, tommi@chromium.org Bug: 802212 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I95b3205087e04b9508760d6bc4cc9fb88456c5b0 Reviewed-on: https://chromium-review.googlesource.com/977249Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#545788}
-
Robert Phillips authored
This reverts commit f17c70fe. Reason for revert: It looks like this change: slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne (crbug.com/825594) slowed down getImageData and putImageData for the HTML5 Canvas across the board (crbug.com/825585) Bug: 825594 Bug: 825585 Original change's description: > Use new Skia GPU read/write pixel code paths > > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992 > Reviewed-on: https://chromium-review.googlesource.com/973267 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544777} TBR=bsalomon@chromium.org,robertphillips@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565 Reviewed-on: https://chromium-review.googlesource.com/980292Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#545787}
-
Fredrik Söderquist authored
Rather than doing an attribute lookup in GetRestart() and Fill(), just map the attributes in ParseAttribute. Pack with active_state_. Also get rid of the static AtomicStrings. Noticed while looking at the referenced bug. Use new accessor GetActiveState() for active_state_ accesses to avoid stumbling over signedness mismatches. Bug: 823473 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9adf72cdfcc794885b79be1bfc374554f9382d11 Reviewed-on: https://chromium-review.googlesource.com/979807Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#545786}
-
Jun Choi authored
For "FIDO-U2F" attestation statement format, attestation credential data within authenticator data is always present. However, for attestation data received from CTAP authenticators, this may not be the case as the WebAuthN spec defines attested credential data as optional. Change the DCHECK conditions for none attestation statement format to execute only when attested credential data is present. Bug: 825455 Change-Id: Ie63f051846b67c9deaa1b6bb64de76efa49a7aa1 Reviewed-on: https://chromium-review.googlesource.com/979217Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545785}
-