GitLab

This CL fixes permission toggling which had an erroneous assert, and
adds a regression test.

Bug: 906508
Change-Id: Ie026ac246c48b19290da5784199c6a8d75c71e89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502259
Auto-Submit: calamity <calamity@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638002}

Before this patch, encodedBodySize [1] and decodedBodySize [2] fields of
navigation / resource timing entry for Signed Exchanges were not
populated.

After this patch, these fields will have the sizes of Signed Exchange's
inner response body, before and after decoding mi-sha256 encoding.

[1] https://www.w3.org/TR/resource-timing-2/#dom-performanceresourcetiming-encodedbodysize
[2] https://www.w3.org/TR/resource-timing-2/#dom-performanceresourcetiming-decodedbodysize

Bug: 928589
Change-Id: I6b7800497e411822172dea4769ab8fc9d4955b53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496261
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638001}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=abdulsyed@chromiue.org

Change-Id: I7227a29e99627145b19288ab8e0615570a53a9bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505114Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638000}

It turns out PrepareForDrag calls into CaptureController via
ScopedWindowResizer which inspects the gesture state. Transferring the
events earlier avoids us from receiving gesture cancelled events.

	not moving anywhere.

Bug: b/124026845
Test: Drag-to-move via touch of an Android PIP window works instead of
Change-Id: Ib1a4bb5c09bff6d9529805e0a778c10f5dcaf852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498803
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637999}

Refactor QuicFramer connection ID read code

This CL refactors how we read connection IDs to allow future changes
that will use different default lengths based on what is configured for
this connection.

Merge internal change: 236935043

https://chromium-review.googlesource.com/c/1504509/

Make a test involving connection IDs more future-proof

Merge internal change: 236924820

https://chromium-review.googlesource.com/c/1504508/

Remove some fixed packet lengths.

This CL moves us yet another step closer to being connection ID length
agnostic in the lower layers such as the QuicFramer. More specifically,
it replaces instances of PACKET_8BYTE_CONNECTION_ID with
connection_id.length(). This is safe to use without flag protection
because we have code in all connection ID entry points to ensure that
their length is 8.

Merge internal change: 236894613

https://chromium-review.googlesource.com/c/1504506/

R=rch@chromium.org

Change-Id: I488160120ad125ff342e5983cba22946dc437183
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504510
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637998}

This reverts commit 108146f8.

Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=938020#c6

Original change's description:
> Fix flatbuffers_unittests failure-mode
> 
> This is failing on Win7 Tests (dbg)(1):
> https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29?limit=200
> 
> Failures are causing python errors because the "failures" element must be a list.
> The actual cause of the failure is not yet known.
> 
> Bug: 938020
> Change-Id: I53742dbf49f97a8828af5675a0360e431ed376c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503614
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Charlie Harrison <csharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#637839}

TBR=dpranke@chromium.org,csharrison@chromium.org

Change-Id: Iebb35ee8e42272f742497b25713d0927fb00ff14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 938020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504597Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637997}

This makes the blacklist behave identically to the |BlockedSPKIs|
member of the CRLSet.

Formerly, the blacklist had been applied after path building, which
meant that the path builder did not have the opportunity to favor
paths that did not include blacklisted certificates.

If any such cases exist, this change might cause them to be newly
accepted.  It should not cause any certificate chains to be newly
rejected.

TBR=mmenke

Change-Id: Idd6c4d5b5725497f951e749159cd58fd0413b444
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497387
Commit-Queue: Matt Braithwaite <mab@google.com>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637996}

This CL makes the PWA install plus icon animate in with an "Install" label
once installability checks pass for a site.
The frequency of this animation is not yet decided by UX and is subject to
change.

Screencast of animation: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382575&signed_aid=0ZIH354P-QQs-3Fnl4CVEg==&inline=1

This icon is hidden behind the --enable-features=DesktopPWAsOmniboxInstall
flag.

Bug: 907351
Change-Id: Ie74b037533a67f2c00ddd5689df4dbd98ece83cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502313
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637995}

TBR=droger@chromium.org,lwchkg@chromium.org,msarda@chromium.org
NOTRY=true

Bug: 938707
Change-Id: I3b421e177f303135d633987d5429eaada474243a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504656Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637994}

TabFavicon is Tab userdata that provides API for the active
web contents' favicon. This was a part of Tab class but
factored out into its own class.

Bug: 877878, 925242
Change-Id: I49eba08918a2a86985f2b8aea5d4c7e15d666108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482434
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637993}

Update EmbeddedWorkerInstanceHost to use the
blink::mojom::ConsoleMessageLevel enum, rather than an int32. This also
percolates out to the ServiceWorkerVersion, ServiceWorkerContextCore,
and ServiceWorkerContext observer classes, and the
content::ConsoleMessage struct.

Bug: None
Change-Id: I1e392ae7ab5ca2ff679c30057d45817358d3bbf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501498
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637992}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8f4140a12eb..bb71e01e26d0


Created with:
  gclient setdep -r src-internal@bb71e01e26d0

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org

Change-Id: I4c8a00702f7f54f824a1ffb549b6ac81a1aa4a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504933Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#637991}

Currently, Roselle trains on app IDs as-is. However apps clicked from the
launcher chips or search box have the format "[scheme]://[id]/" while apps
clicked from the grid have the format "[id]". This adds a normalisation
step so Roselle always trains on apps with IDs of the form "[id]".

Code adapted from: https://cs.chromium.org/chromium/src/chrome/browser/ui/app_list/app_launch_event_logger.cc?sq=package:chromium&g=0&l=171

Bug: 938706
Change-Id: I6af4366dc70538f909b467bdf12948d3db0d8db3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501774
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637990}

Now that the implementation is mojofied, there is no need for this class
to keep track of running workers.

Bug: 931084
Change-Id: Ie8b21af1561f7939453e8f95793da4152076ec06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504653
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637989}

 - Modify js_externs_generator_test.py to add "@typedef {Object}"
 - Mark optional parameter as optional in bookmarks_manager_private.json
 - Move incorrectly placed annotation in c/b/r/bookmarks/store.js
 - Re-generate bookmark_manager_private.js and add a note at the top of
   that file, about manual edits required.

Bug: 717828,717827
Change-Id: I69639a800d7aabb1bbe5e8885efce487f9414409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499778Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637988}

This can return null per issue 817691. We only recently started getting crashes for
it being null for navigation preloads. It's possible this is due to
r636598 which allowed extensions to intercept nav preload requests.

Bug: 938639
Change-Id: I03149fa3c61234714611c272e4fa783948f2bf5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504594
Auto-Submit: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637987}

Bug: 803584
Change-Id: I189c280a19e9c6a591af6b6ee0e8a37e2abb020d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490497
Auto-Submit: Ian Wells <iwells@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637986}

Part of an effort to remove EmbeddedWorkerRegistry which shouldn't be
needed since mojofication. Shutdown() sent a Stop IPC on each worker
when the registry is destructed, which happens only during browser
shutdown or a fatal error with the service worker system. The Stop IPC
is not needed since ServiceWorkerContext is also destroyed in this
case, which means all hosts are destroyed and the Mojo connection to the
workers are destroyed. The workers in the renderer processes
detect the destroyed connection and terminate.

I thought this might affect the ServiceWorker.WorkerStopped UMA,
but it shouldn't because the registry is refcounted and owned by
EmbeddedWorkerInstances, so it doesn't destruct until those are
already destructed, so no host is alive to record the UMA.

Bug: 931084
Change-Id: Id8c92f59e6602e7d95bf876858f4b771bed19636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504472Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637985}

Bug: 933791
Change-Id: I987b1e0732d208c54bcfd0434408f1f0c4bad6a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497334Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637984}

App lauches are already being logged from the launcher grid
and launcher suggestion chip. Launches from launcher
recommendations are being missed in the UKM logging.
This will fix that.

Bug: 889123
Change-Id: Icbd6a966011b9cc5e50cef692cac7822d5501cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498260Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637983}

This change lets Chrome talk to the production image annotation server.

It also includes a bugfix: the experiment feature is changed from
constexpr to const, as suggested here:
https://cs.chromium.org/chromium/src/base/feature_list.h?l=33&rcl=9d2ac606c7193521bef66585a5209fa562d209c4

Bug: 916420
Change-Id: I5fe8f87d4b8b7b8101931476d19e1aecd0d0c8a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504655
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637982}

WebConsoleMessage::LogWebConsoleMessage() and
WebLocalFrameImpl::AddMessageToConsole() used a fair amount of the same
code, as both were mutating a WebConsoleMessage into a ConsoleMessage,
and then logging it.

Restructure this by adding a ConsoleMessage::FromWebConsoleMessage()
method that can be used by both WebConsoleMessage and WebLocalFrameImpl.

Bug: None
Change-Id: I7a0ff42411f5e950452c86ecde7e58bb4976d7ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501497
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637981}

This CL updates hosted app menu buttons to be a circle instead of a
squircle. This matches the main browser app menu button highlight shape.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382151&signed_aid=8nMn1jvoQMiuwbo9hYOZnw==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382152&signed_aid=dqni06i4dkv3UxZYxCF6FA==&inline=1

Bug: 918093
Change-Id: I9137331b23047570a1a7becd97ee6be6a04d0abe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496399
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Jay Harris <harrisjay@chromium.org>
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637980}

We’ve added Finch flags for Arc App Shortcuts. This CL adds unit tests to ensure the behaviour of the ranker with Finch flags:
1. Doesn’t change the scores when the flag is disabled.
2. Improves the scores when the flag is enabled.

Bug: 931149
Change-Id: I4368bfbae0b1b2862f354469028c028f74cefabf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501892Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637979}

1 - Changed implementation to observe individual DownloadItems rather than
observing an AllDownloadItemNotifier::Observer, because AIDN generates duplicate
updates to the UI.
2 - Changed this class to work with in-progress download manager. This class now
depends on DownloadManagerService to get all downloads.
3 - Changed OfflineContentAggregator to a singleton for android so that it can
 work without a BrowserContext.
4 - TODO : This class is owned by DownloadCoreServiceImpl. Need to fix this
  for service manager mode.

Change-Id: I5741fb0fc9eef05415ab907b23c1fb575ef2203d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1422392
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637978}

This change adds the following additional data dependencies:
1. Directory for the certificate files Web Page Replay (WPR) needs.
2. Two JavaScript files containing scripts WPR needs to inject.

Bug: 847905
Change-Id: If3473e9f554ac58590c78a6548ab28ff4966a585
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504038
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Auto-Submit: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637977}

Added a few more metrics :
1 - Image size ratio between the view and the thumbnail being shown
2 - Number of chips enabled at any time
3 - ThumbnailProvider cache hit/miss and cache size histogram
4 - ThumbnailDiskStorage cache hit/miss and cache size histogram

Change-Id: I1160010808a709ea12c1e877e5e03b18fc04c814
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1429619
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637976}

Remove the async callback used to re-starts commits, replacing it with
a restart time passed when commits are deferred. Check if we need to
restart commits within BeginMainFrame.

This patch also makes it possible to re-start commits within a
lifecycle update, which is important for adding signals that are
discovered during paint or style update.

R=vmpstr@chromium.org
BUG=805798

Change-Id: I393d42adb37716a616ed24d823d657874820946a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497335
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637975}

This involves introducing a bunch of new platform interfaces, such as:
* QuicFakeEpollServer
* QuicRunSystemEventLoopIteration
* QUIC_TEST_DISABLED_IN_CHROME
* QuicGetTestMemoryCachePath

R=rch@chromium.org

Change-Id: Iaafc71908337905a238ae0c7a4675c00f7676863
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504455
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637974}

Instead, resolve it to auto (=logical height)

In the future, this codepath can also be used to implement
flex-basis: content.

Bug: 531656
Change-Id: I57f6cb60ca32919c3efda9e32bc68f524362526a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490212
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637973}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a272d1148d5b..f8f4140a12eb


Created with:
  gclient setdep -r src-internal@f8f4140a12eb

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org

Change-Id: Id6489b13d8344d81a1e0464753f7321aad263671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504833Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#637972}

https://skia.googlesource.com/skia.git/+log/624cec68e43a..537ce575a441


git log 624cec68e43a..537ce575a441 --date=short --no-merges --format='%ad %ae %s'
2019-03-05 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@537ce575a441

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: I97b34f486fef0f18b3d733f150250109b7949350
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504932Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#637971}

Make sure the display buffers are tagged with the correct colorspace and
tag the platform surfaces used with SurfaceControl with this color space.

R=ccameron@chromium.org,piman@chromium.org

Bug: 889328
Change-Id: Iad159f1abe27caa26b3de0701f243cbf970ca581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504699
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637970}

Add a new notification type: SEND_TAB_TO_SELF

DesktopNotificaitonHandler inherits NotificationHandler and implements ReceivingUiHandler.

This CL depends on https://chromium-review.googlesource.com/c/chromium/src/+/1477754

Bug: 937693
Change-Id: I96f8ee3c3de914c6742860b0f9f3650325fc8b07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476103
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637969}

This CL pushes the per-row contents of expandable-app-list to being
specified at the client layer, rather than branching with dom-ifs
internally.

Bug: 906508
Change-Id: Icc3b324a408a0a0dd2d487745eda3793e910f143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481135
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637968}

It only provided a very thin layer of functionality on top of
IntersectionObserver, at the cost of another layer of
WTF::BindRepeating callbacks. Convert all existing usage to use
IntersectionObserver directly.

Change-Id: I77c62b929dbd17e0f28966de3b9ce7f673cb8399
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490405
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637967}

Bug: 938240
Change-Id: Ia75d55ba64415fa8c77f28326afd01ca2861e9d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504267Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637966}

This fixes a couple issues: 1) It allows us to keep the 'Next' button
always enabled so that users can quickly exit the flow, 2) it clears the
background when the user selects a custom background, hits 'Next',
hits the browser's back button, and tries to go back to 'Default'

Bug: 938235
Change-Id: I3ede7c9a99b4e0b293143188f0743c022aa07d42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504127Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637965}

This was not documented well in Chromium code, but will cause a crash or
LOG(FATAL) otherwise.

Bug: internal b/125105834
Test: Started application that caused the crash.
Change-Id: Ica50aaef287159704bc182557c0847aee8318204
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498376
Commit-Queue: Yilong Yao <yilongyao@google.com>
Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637964}

If the destination updates, preserve the user's settings if the
destination supports them. Otherwise, and in the case of initialization
without sticky settings (e.g. kiosk public sessions), use the printer
default.

Bug: 936396
Change-Id: Ie07fd94afe413323c19f13948ebc1715e888e7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474437
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637963}