GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/a097c941d4f8..b64ff931eb98

git log a097c941d4f8..b64ff931eb98 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 skyostil@google.com TrackEvent: Add tip about constexpr event names

Created with:
  gclient setdep -r src/third_party/perfetto@b64ff931eb98

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:132678367
Tbr: perfetto-bugs@google.com
Change-Id: I28eecd9921eac4afdc88be08b7fc6911aabcdad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950035Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721407}

Posthandling events does not work properly in this case as we are
not able to track if the event that has been sent to sink
is handled or not.

That is, SendEventToSink results in copying the entire event which
means that the original event is not going to have its handling
status changed. That means that we are not able to track if the
event is handled or not unless a dispatcher or a target are destroyed
(remember that SendEventToSink returns EventDispatchDetails, but
does not say anything about handling results).

That resulted in the WindowEventFilterLinux always post-processing
events and opening context menus twice (the first one was closed
immediately after it was shown and the second one was shown instead).

TEST: manually tested.
Bug: 1028046
Change-Id: I2bedda57c7ca8a05171428da26b889eac04cf36f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947733Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#721406}

This CL migrates the mojo client in the renderer side of the
contextual_search component to the new BrowserInterfaceBroker,
and adapts the code in the browser process to register the binder
from PopulateChromeFrameBinders(), instead of doing it inside of
ContextualSearchObserver.

Last, this CL also extracts the ContextualSearchObserver class
out of contextual_search_manager.cc, so that the receiver can
be bound now via the BinderMap owned by the BrowserInterfaceBroker.

Bug: 936482,1006361
Change-Id: I95c8046650883c872750dd7408a38e7433ed9df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906667Reviewed-by: Donn Denman <donnd@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#721405}

We shipped this restriction in M77 ([1]). We can safely remove the
underlying feature flags and histogram.

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1646784

Bug: 1030135
Change-Id: I52ce3c152862c0ae74742444faacef741db60abd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947734
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721404}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I32f3daabe58344ff6e6ed22b7876b839a93a1839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950030Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721403}

Bug: 986737
Change-Id: I80eabeb588d807453241df3dacdd1a764c66d7e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942087Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721402}

This CL cleans up old Mojo types for FaceDetectionProvider and
FaceDetection from FaceDetectionImplWinTest using Remote.

Bug: 955171
Change-Id: Ic420d06ccb96986ee5991f5b43e50cc3209bea14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939587Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#721401}

This is the fix to the issue highlighted at
https://chromium-review.googlesource.com/c/chromium/src/+/1938067

Anti-starvation on the UI/IO threads is highly problematic
per unexpected reorder of base::TaskPriority. BrowserTaskExecutors
already disables this. TaskEnvironment needs to do the same.

R=alexclarke@chromium.org

Bug: 1013535
Change-Id: Ief82ff8a80813455e60bb6ed53fdb23228f68f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948093
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721400}

This CL refactors the test so that we don't need to use the macros

Bug: 1028853
Change-Id: Id5372cdc6564921bbb6c850d135257e39838729c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949834Reviewed-by: Tony Yeoman <tby@chromium.org>
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721399}

The spec is unclear on whether or not this is actually a bug with
aria-owns. It was discovered during implementation of Element Reflection
that nodes were unable to be aria-owned by other nodes, if they had
previously been aria-owned. This change allows for nodes to be
reparented, providing the previous relationship has been removed.

BUG=981423

R=dmazzoni, aleventhal, chrishall

Change-Id: Ie6757868c6165df28b5217e5bb41a4bd00eb0478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942593
Commit-Queue: Meredith Lane <meredithl@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721398}

TBR=rogerta@chromium.org

No-Try: true
Bug: 1030602
Change-Id: I67ffa1585a51e32b865b3ba9e28b5c25ff14e060
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950047Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721397}

We replaced the flaky RFH.deleted() check with WaitUntilDeleted().

> Revert "BFCache: Add a browser_test for WebMIDI"
>
> This reverts commit efd7d333.
>
> Reason for revert:
> BackForwardCacheBrowserTest.WebMidiNotCached is consistently failing since this landed on at least one bot:
> https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/8840
> Tracking as part of Bug: 1022876
>
> Original change's description:
> > BFCache: Add a browser_test for WebMIDI
> >
> > Bug: 981740
> > Change-Id: I40605b9b6b343a3e0b4a12fe3b0e5e0b6f992390
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903182
> > Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
> > Reviewed-by: Alexander Timin <altimin@chromium.org>
> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> > Reviewed-by: Fergal Daly <fergal@chromium.org>
> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#713734}

Bug: 981740, 1022876
Change-Id: I531ea5ee417f810df3c8fe699d9b8cebe0be14e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949814Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Auto-Submit: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721396}

These tests depend on the page not going into the cache.

Bug: 1029248
Change-Id: Ie13a0cdd4f01bcb1c3bde3004708dd78ccdfe8d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943708
Commit-Queue: Fergal Daly <fergal@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721395}

There is a case that SharedRemote needs to support a disconnect callback
in order to convert ThreadSafeInterface to SharedRemote. So, this CL
adds set_disconnect_handler to SharedRemote with a test case.

Additionally, this CL makes the constructor and Create() factory
functions private in SharedRemoteBase class. Because SharedRemoteBase
needs to have RemoteWrapper as a member variable to call
set_disconnect_handler().

TEST: RemoteTest.SharedRemoteDisconnectCallback
Bug: 955171
Change-Id: I5131c9947491094fbb0c00bbb733fd3dcbbf1b88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947517
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721394}

https://skia.googlesource.com/skia.git/+log/d61f8670f996..dc7697bc61e9

git log d61f8670f996..dc7697bc61e9 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src bd8110e5..d02b0cb4 (540 commits)

Created with:
  gclient setdep -r src/third_party/skia@dc7697bc61e9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bsalomon@google.com
Change-Id: Idf00878c879dfe165943cb07425aeb14438c6291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949422Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721393}

This CL introduces some debug output about the key and funnel metrics
of autofill to chrome://autofill-internals in order to check whether
reporting is correct for all kinds of corner cases.

Bug: 928595
Change-Id: Ia40b969f0f439532bb88c695989fe4b056951d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947729Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721392}

The lifetime of a GL program compile and link can be seen in
GrGLProgramBuilder::PrecompileProgram. The sequence is
- glCreateProgram creates a program object
- GrGLCompileAndAttachShader creates and compiles the vertex, fragment,
  and geometry shaders
- Link status is queried using glGetProgramiv with GL_LINK_STATUS

Create the histogram Gpu.GL.ProgramBuildTime for this entire time.
While this may not capture all of program building, the fact that it goes
through GL_LINK_STATUS ensures that we at least know the source has
been parsed.

Obsolete histograms that we won't be using. In particular
- Using a test shader to disable Metal won't be acceptable, since that
  will break WebGPU unpredicatably.
- Doing several retry attempts isn't going to move the needle on
  stability, so don't even try.

The purpose of all of this is to give us some data comparing OpenGL and
Metal, in the hopes that we won't continue to be told that we're
holding it wrong.

Bug: 974219
Change-Id: Ibed594aeea286344446244d86f7331597d5619ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948265
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721391}

Since AEC2 has been fully replaced by AEC3, these metrics
are now obsolete and should not be looked at any longer.

Bug: None
Change-Id: I72987600e9e17180c2435054c34ea86aa715b4b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932368Reviewed-by: Armando Miraglia <armax@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721390}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85bb5de39728..162322e97930


Created with:
  gclient setdep -r src-internal@162322e97930

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I210915a97fc17846cc447cf53316e064d1590703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949421Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721389}

Add timestamp tests for blob-backing files and filesystem files.
This CL makes File::LastModifiedTime public because many tests access
it.

This CL has no behavior changes.

Bug: 1027959
Change-Id: I86ff3788f44edf830b1372bc3b17c3a951a77803
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948666
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721388}

Add the checkbox to the new Translate UI's tab view and the source
language view.

Bug: 976352
Change-Id: Ic0e2630b4161dc57f053b625c65cea262476bfc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940496
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721387}

This reverts commit 8b3c757e.

Reason for revert: All dependent reverts relanded, there was nothing broken about this CL specifically.

Original change's description:
> Revert "Delete bind_interface_helpers.h"
> 
> This reverts commit a47f7784.
> 
> Reason for revert: breaks graphics on some Chrome OS devices.
> 
> Original change's description:
> > Delete bind_interface_helpers.h
> >
> > This header provides a bunch of helper functions for Content processes
> > modeled as Service Manager services. Since those are no longer a thing,
> > this no longer needs to be a thing.
> >
> > Bug: 977637
> > Change-Id: Ia1ae177b4a9665b727618b12a35be905d5605ce9
> > Tbr: jam@chromium.org
> > Tbr: erikchen@chromium.org
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929396
> > Commit-Queue: Ken Rockot <rockot@google.com>
> > Reviewed-by: Ken Rockot <rockot@google.com>
> > Cr-Commit-Position: refs/heads/master@{#718367}
> 
> Bug: 1028852
> Bug: 977637
> Tbr: rockot@google.com
> Tbr: jam@chromium.org
> Tbr: erikchen@chromium.org
> Change-Id: Ie621804e4a6c03c26bf64130bab49f6a9380dea6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948401
> Reviewed-by: Shuhei Takahashi <nya@chromium.org>
> Commit-Queue: Shuhei Takahashi <nya@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720918}

TBR=jam@chromium.org,rockot@google.com,erikchen@chromium.org,nya@chromium.org

Change-Id: I738e84cc2af953c2a03da5c3cf791226ccff7c51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028852, 977637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949780Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721386}

ScriptValue was modified to use WorldSafeV8Reference through r701030,
r698399, r694681 but we suspect it may have caused a memory leak.
This change ScriptValue back to use SharedPersistent.
To maintain the same level of security, the world check from
WorldSafeV8Reference has been transplanted into SharedPersistent.

Bug: 1029738
Change-Id: I21ed2929c3e90530a958be0503f153646f85ec7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948671
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721385}

Change-Id: I82111e2602c8d0b6488c1aca2440edafca9cfddc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949832
Commit-Queue: Glen Robertson <glenrob@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Auto-Submit: Glen Robertson <glenrob@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721384}

This reverts commit bfca6c80.

Reason for revert: Reverting the revert which was only done make reverting an earlier CL possible. Earlier CL has been fixed and relanded.

Original change's description:
> Revert "Move Utility processes off Service Manager"
>
> This reverts commit 0a311ff4.
>
> Reason for revert: breaks graphics on some Chrome OS devices.
>
> Original change's description:
> > Move Utility processes off Service Manager
> >
> > This migrates Utility processes to direct ChildProcess API usage instead
> > of bootstrapping IPC through the Service Manager.
> >
> > As this is the last remaining use of Service Manager IPC to bootstrap
> > Content child processes, this also rips out a bunch of infrastructure
> > that existed only to support that.
> >
> > Bug: 977637
> > Change-Id: I08e542f1d9f294bc1c387ea5845e8ba0d5a7d2b8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919719
> > Commit-Queue: Ken Rockot <rockot@google.com>
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#718352}
>
> NOPRESUBMIT=true
>
> Bug: 1028852
> Bug: 977637
> Tbr: rockot@google.com
> Tbr: avi@chromium.org
> Tbr: rsesek@chromium.org
> Change-Id: I9b2e8ca44f5b6accc2d3718cab3cb547d979c230
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948402
> Commit-Queue: Shuhei Takahashi <nya@chromium.org>
> Reviewed-by: Shuhei Takahashi <nya@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720938}

TBR=avi@chromium.org,rockot@google.com,nya@chromium.org,rsesek@chromium.org

NOPRESUBMIT=true

Change-Id: I79ea423c97880366125abfb659dae223d0185023
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028852, 977637
Tbr: rsesek@chromium.org
Tbr: avi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949304
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721383}

This is an attempt to avoid a renderer hang that may be explained by trying to
get an interface via BrowserInterfaceBroker (BIB) and then make synchronous calls
on that interface.

This is an experimental change. It is unfortunate to introduce render_frame_id
parameters here, and my intent is to come back and remove them once I understand
how to do so without the observed hang.

The experiment with this CL is to confirm that the observed hang goes away. If it
does, then it confirms that there is some interaction with BIB that is causing the
issue. If it does not, then we know BIB is off the hook, and we can look elsewhere.

Bug: 1023519
Change-Id: I696b63f057605b3cd5fe7f0c8182b044f2a60578
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949036Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Darin Fisher <darin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721382}

The crash in GetInterpolatedEventForPredictedEvent is due to the initial
value of 'idx' is set to -1, but it's an unsigned type.
This CL makes it initialize to 0.

Bug: 1030386
Change-Id: I44796c1813374f4c192ee3c125c5f957fbe57061
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948048Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721381}

It's flaky on win-asan bots.

TBR=dtapuska@chromium.org

No-Try: true
Bug: 1030589
Change-Id: I317d93e60daf8be5d5813307da487f7b58efedc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949836Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721380}

https://skia.googlesource.com/skia.git/+log/32b010baf507..d61f8670f996

git log 32b010baf507..d61f8670f996 --date=short --first-parent --format='%ad %ae %s'
2019-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b64fbfec4dcd..bbd0694f9ab2 (3 commits)
2019-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 fb40d231c3e2..249cb200173f (15 commits)

Created with:
  gclient setdep -r src/third_party/skia@d61f8670f996

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: bsalomon@google.com
Change-Id: I1527e60130ff3b1070340cb477138ffdc7c8f56b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948542Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#721379}

- Move wrapping logic around chrome.send('removeVisits') into
history_list.js instead of browser_service.js
- Convert this call to use cr.sendWithPromise instead of calling JS
directly from C++ after deletion succeeds/fails
- Delete browser service test, since the logic it is testing is no
longer in the browser service. The test is replaced by adding checks
for the arguments passed to removeVisits() in the history list tests.

Bug: 1022212
Change-Id: I7290d97472b34a0a233ac7921c18c2a298481a3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947956Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721378}

This reverts commit d10a4fc5.

Reason for revert: Reverting the revert which was only done make reverting an earlier CL possible. Earlier CL has been fixed and relanded.

Original change's description:
> Revert "Reland "Move Renderer processes off Service Manager""
> 
> This reverts commit 881a65d7.
> 
> Reason for revert: breaks graphics on some Chrome OS devices.
> 
> Original change's description:
> > Move Renderer processes off Service Manager
> >
> > Migrates Renderer processes to use the simpler ChildProcess IPC
> > interface in place of deprecated Service Manager IPC.
> >
> > Support for preloaded files in service manifest definitions is
> > effectively removed in favor of explicit parameters on
> > BrowserChildProcessHost and ChildProcessLauncher. The only use case (V8
> > snapshot files) has been migrated from manifest data to a simple map
> > definition, and it's used during renderer and utility process
> > launching.
> >
> > After this CL, only utility processes remain to be moved off of
> > Service
> > Manager IPC.
> >
> > NOPRESUBMIT=true
> >
> > Bug: 977637
> > Change-Id: I1d8205cb73ead904aa21b85d6cbee11cb3fc84f5
> > Tbr: boliu@chromium.org
> > Tbr: yucliu@chromium.org
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918375
> > Reviewed-by: Martin Barbella <mbarbella@chromium.org>
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: Ken Rockot <rockot@google.com>
> > Cr-Commit-Position: refs/heads/master@{#717920}
> 
> NOPRESUBMIT=true
> 
> Bug: 1028852
> Bug: 977637
> Tbr: rockot@google.com
> Tbr: boliu@chromium.org
> Tbr: yucliu@chromium.org
> Tbr: mbarbella@chromium.org
> Tbr: rsesek@chromium.org
> Tbr: avi@chromium.org
> Change-Id: I30a52d825cc156b066d7c2ec455c8fb588a408af
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948663
> Commit-Queue: Shuhei Takahashi <nya@chromium.org>
> Reviewed-by: Shuhei Takahashi <nya@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#720939}

TBR=avi@chromium.org,boliu@chromium.org,rockot@google.com,nya@chromium.org,mbarbella@chromium.org,rsesek@chromium.org,yucliu@chromium.org

Change-Id: I69de741d907abd790bdad3019abeeb9a8ca231aa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028852, 977637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949778Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721377}

Just letting the fragmentation machinery do what it would do if it gets
to treat column boxes as regular column content was no conscious choice,
and it turns out that setting the column fragments to the actual column
size is better, or we get some trouble with overflow, both when it comes
to painting column rules, and the fact that we get spurious empty column
fragments after unbreakable content (new unit test
NGColumnLayoutAlgorithmTest.TallReplacedContent).

Remove fast/multicol/rule-in-nested-with-too-tall-line.html and replace
it with a valid test (that still fails both in legacy and NG; in NG
because we fail to paint text on a general basis).

Bug: 829028
Change-Id: I3656c299c7a87bea29e1790477cf524b9522fa97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948923Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721376}

This is a preparation CL for stopping creating ServiceWorkerProviderHost for
service worker clients.

This CL renames ServiceWorkerContainerHost::provider_host() to
service_worker_host(), and ensures it's used only for service worker execution
contexts (not for service worker clients).

Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing

Bug: 931087
Change-Id: I6c625c00f00e96c14623a80ced0afd5ba0e0ca49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947510Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721375}

This is a reland of bdc39552

Original change's description:
> Move GPU and Plugin processes off Service Manager
>
> This introduces a new mode for Browser/ChildProcessHost where the
> primordial pipe is a simple content.mojom.ChildProcess pipe. This will
> become the new default mode of operation for child processes, and
> eventually will be the only mode of operation once NaCl processes are
> gone.
>
> GPU and plugin processes are ported to this mode here since both
> require only minimal changes. This means that "content_gpu" and
> "content_plugin" services no longer exist.
>
> Bug: 977637
> Change-Id: I39c5d2284bd84246663d5f0eb4cbab3b3483d798
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918326
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#717857}

NOPRESUBMIT=true

Bug: 977637
Change-Id: Iaefab7950d7f0437b05417a34ff2b1db73576f0b
Tbr: avi@chromium.org
Tbr: rsesek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948907Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#721374}

Before this the SessionRestore policy wasn't prioritizing the tabs
that haven't been observed by the LocalDB for a long enough period
of time. This could create some issues as not reloading these tabs
will not let the local DB observe them and so this could lead to
some missed events.

Change-Id: I7d74a6c300d42d207bd9b02f5a19aa22894f4037
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943531
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721373}

Use front buffer textures directly for snapshots with swap chain
resources instead of a copy via skia.

R=sunnyps@chromium.org

Bug: 962630
Change-Id: I88f6e5b098b060325cff06cd3a140d85146f60b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949663
Auto-Submit: Khushal <khushalsagar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721372}

Currently, CBCM reporting are supported on many operation systems (like
Linux, Mac, Windows), but not on Chrome OS. In this change list, a
report scheduler will be triggered to report related information
periodically.

Bug:1010213

Change-Id: I18ecce77852b16e21456d666c5c301c05e5f0d61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862447
Commit-Queue: Anqing Zhao <anqing@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721371}

Disabled these tests due to random failures:
PasswordManagerBrowserTest.HTMLLoginAfterHTTPAuthIsBlacklisted
PasswordManagerBrowserTest.NoPromptForSeperateLoginFormWhenSwitchingFromHttpsToHttp
PasswordManagerBrowserTest.Redirects
PasswordManagerBrowserTest.SameOriginIframeAutoFillTest

TBR=dvadym@chromium.org

No-Try: true
Bug: 1030579
Change-Id: I03ee08ec048ad85af50908d6d929db61b02793fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949830Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721370}

Since the z-order of SurfaceViews is pretty arbitrary, in some android
versions after a screen wakeup, the TWV surface is created in wrong order
and hence gets hidden behind the main compositor surface.
Investigated a few options : setZOrderOnTop, setZorderMediaOverlay.
However the main compositor already uses setZOrderMediaOverlay. So we
are left with we can use setZOrderOnTop to fix this issue.
Added ThinWebViewConstraints class  to enable client specify this use case.
Also added support for opacity in the TWV which would be useful for
some clients.

Bug: 1024622
Change-Id: I613c9a34e5b134a8b6d2f794ca2e488bbfe2f454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939892
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721369}

Also, adds additional PRESUBMIT checks to ensure automation keeps in sync with
ax_enums for MarkerType.

Test: existing browser_tests --gtest_filter=ChromeVoxEditing*.*
Change-Id: I58556cc8317cbca62f00aed8d9f3afbcf7feeee2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940868
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721368}