- 10 Sep, 2020 33 commits
-
-
Keren Zhu authored
* Add MdIPHBubbleButton, a transparent MD button with optional white border. * Add snoozable option to IPH bubble. Disable auto-dismiss for snoozable button. UX spec: https://docs.google.com/presentation/d/1l19RBFdJjsLIO2KPVANY-ObfwmUCkpQ1Lj8IeLAqJZM/edit#slide=id.g92aa3ae4f7_1_43 Screenshot: https://screenshot.googleplex.com/5brgyBvGcaoMeEP Bug: 1121399 Change-Id: Ic3ca76b6edcb52bdc9d856aa6ee11476e018218d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394157Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805592}
-
Lukasz Anforowicz authored
This CL introduces DataURLLoaderFactory::Create static method that allows creating an DataURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<DataURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing DataURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static methods. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I173ce25efbdb95442c9978856a93163e9f067495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357618 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805591}
-
Raphael Kubo da Costa authored
Point to https://w3c.github.io/screen-wake-lock rather than https://w3c.github.io/wake-lock. While the latter redirects to the former, anchors are broken in the redirection. Change-Id: I2eca3e236c0105af8017a09af872935dadd43bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395718 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805590}
-
Zentaro Kavanagh authored
- It was accidentally deleted here [1] [1] - https://chromium-review.googlesource.com/c/chromium/src/+/2224346/24/chromeos/components/print_management/resources/print_management.html Bug: None Test: None Change-Id: Ifeed774ca437c29bc38582ce4e5c18ac71619efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402287Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#805589}
-
Seokho Song authored
The input validation has only been considered underflow or overflow. If min and max values are equal and the user input value is different, we should show a message that the values does not match. In this CL, InputType will calculate 'value != min && min == max' to check it must be same. Bug: 1073923 Change-Id: Ia7e1e5e9ece70cd31034f3bda2c833dd36ed1d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389281 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#805588}
-
Shrek Shao authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1788138, these tests were enabled on Android. But flakes are seen on Nexus 6: https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%206%29/33613 Following the similar pattern of skipping them as in: https://chromium-review.googlesource.com/c/chromium/src/+/1808584 https://chromium-review.googlesource.com/c/chromium/src/+/1628391 TBR=kbr@chromium.org Bug: 609629 Change-Id: Icd07a38c4e3a5ff8c12c791bdf0f6b066014e726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401708Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#805587}
-
Tom Anderson authored
This fixes a regression where accelerators like Ctrl+T would not work after changing the keyboard layout after [1]. XKB internally selects and handles NewKeyboardNotify events, which get fired when changing the keyboard layout. This CL fixes the issue by manually selecting and responding to these events. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2317767 R=sky CC=nickdiego Bug: 1125886 Change-Id: Ie8b84e1947da2deb527cd572f7a646b4f833b3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402301 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805586}
-
Tom Anderson authored
After [1], gfx::GetXDisplay() returns a different display for each thread. This introduces a race condition since |g_handler| is shared across all threads. Since X11ErrorHandler will be removed soon anyway (since XProto uses a different error-handling mechanism), this CL simply removes the DCHECK(). [1] https://chromium-review.googlesource.com/c/chromium/src/+/2343314 BUG=1122006 R=sky Change-Id: I1101a3456f4609481a1f204634102dac89bad0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402304 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL introduces AboutURLLoaderFactory::Create static method that allows creating an AboutURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<AboutURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing AboutURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static method. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: Id93cc5b5078019d95dd19988ffdffb8e40d7ac31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358053 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Becca Hughes authored
If Kaleidoscope is available to the user and also we need to shown the first run to the user then we send back a different state to the module telling it to use the first run promo. BUG=1121360 Change-Id: Id48006d0b4c079742b674c73a99895b2e8abcbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401504 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805583}
-
Ryan Hansberry authored
Implement BleMedium::StartScanning() and BleMedium::StopScanning(). This requires adding a ServiceDataMap (mapping from service id to service data) to bluetooth::mojom::DeviceInfo, to represent BLE advertisements. See go/nearby-chrome-bt for more details. Bug: b:154848193 Change-Id: I40489f8128bcda9409b20b43be52e73b2a9a2240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370094 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805582}
-
Kenichi Ishibashi authored
The following service worker related mojom in blink will be used from both //content and //components/services/storage when we move ServiceWorkerStorage to the Storage Service: * navigation_preload_state.mojm * service_worker_database.mojom * service_worker_registration_options.mojom As described in crrev.com/c/1920008, putting these mojom in the mojom_platform target causes some problems when we try to use them from //components/services/storage. This CL gives them their own mojom target the same way crrev.com/c/1920008 did. These mojom files depend on web_feature.mojom and script_type.mojom. web_feature.mojom has it own target. This CL also gives script_type.mojom it own target. Bug: 1016064 Change-Id: I75123c67c6be18060f9eda09f448a0107cfb598d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395197Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805581}
-
Daniel Classon authored
Adds deep links to the A11y page as well as the Manage A11y, Text to Speech, and Switch Access subpages. Adds tests for the A11y page and Text to Speech subpage. Bug: 1084154 Change-Id: I822a128b7230d9fb6de250294b3e00e2e17d01bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391785 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805580}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d42f9890bdc..66e88206d65d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidvc@google.com,adithyas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1126258 Tbr: davidvc@google.com,adithyas@google.com Change-Id: Ia67f4aa822426db89d58c61454a0b3ff57faf497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402053Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805579}
-
Andrew Grieve authored
Improves error messages for existing asserts, and adds one for blink_symbol_level=0 Bug: 1126200 Change-Id: I6624f6858ee568a33b5174ab8ba7c1834c1d5f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401853 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#805578}
-
danakj authored
When moving code from frame_host, we found that there are a large number of presubmit failures in the code already. This fixes the majority of them, except: 1. MessageLoopRunner is deprecated, use RunLoop instead. Which happens a fair number of times. 2. Uses of BindNewEndpointAndPassDedicatedReceiverForTesting() from production code in RenderFrameHostImpl and RenderFrameProxyHost. These are a bug, as the code is not actually called by tests, it is production. R=avi@chromium.org Bug: 1091083, 1038710 Change-Id: Ida76d545307f0003227fd93e5467426c35ea7a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401270Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#805577}
-
Caitlin Fischer authored
This is because Windows has a command line size limit and too many testing configs can result in the limit being hit. See comment 5 on the bug for details on why these studies are candidates for removal. Bug: 1126640 Change-Id: I2cced4fc69b139458e5204eb2bc6f553101b6388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402186Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#805576}
-
Bence Béky authored
Update changes to existing histogram names; remove QUIC_ prefix from entries 101 and above; add 18 new entries starting with 151. Change-Id: I5cfd1b915bd2a5069182912445b0f0c4b8f6d59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399011Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#805575}
-
Alex Ilin authored
A hidden <input type="color"> element displays the color picker in the top left corner. This CL replaces the hidden attribute with the "visibility:hidden" style and zero element size. Screenshot: https://drive.google.com/file/d/1egjk4ZrO_cj0D7Tu5fMOL3INqwAhY6F7/view?usp=sharing Fixed: 1126668, 1047800 Change-Id: Ia7d91759e3a76ea3efa5b45d742e77765e101071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401141 Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805574}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b0da2f1d4f9e..70f34e0b8eaa 2020-09-09 sebmarchand@chromium.org [Telemetry] Allow specifying a custom shutdown timeout If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1124774 Tbr: rmhasan@google.com Change-Id: I58dbf1fa732e6f3a7ad4ca8e41da2317af05bdb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402199Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805573}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/215d2b0fa42d..5eea6aea02d9 2020-09-09 brianosman@google.com SkSL: Fail harder when trying to return a value from a void function 2020-09-09 brianosman@google.com SkSL: Disallow 'void' except as a function return type 2020-09-09 herb@google.com remove initialOrigin - no longer needed 2020-09-09 johnstiles@google.com Add a new statement type 'InlineMarker' to indicate inlined functions. 2020-09-09 brianosman@google.com Fix use-after-free when variable declarations become unreachable 2020-09-09 csmartdalton@google.com Add more flat line cases to trickycubicstrokes 2020-09-09 bsalomon@google.com Temporary hack to force text texture index varying to be float. 2020-09-09 brianosman@google.com SkSL: Catch any dangling Type or Function references before optimization 2020-09-09 johnstiles@google.com Run the optimizer until we stop finding improvements. 2020-09-09 westont@google.com [infra] Target Android10 for GalaxyS9 2020-09-09 jmbetancourt@google.com add oboe version 1.4.3 to third_party dependencies for Android's skottie audio player If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Idce21eb66a6ead3b7297120831d3b4d71332087c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402200Reviewed-by:
-
Richard Li authored
When playing a SDR video after playing a HDR video, GPU process will crash on Intel platform. The root cause is Chrome sets different color space in VP without reset VP, which will cause something wrong happens in VP. This CL provides a fix that VP will reset when input/output color space changes. What's more, color space will be set to VP only when it changes, which reduces frequency of calling VideoProcessorSetStream/*Output*/ColorSpace1() Bug: 1121061 Change-Id: I096e5fb47593e0df034452719029a3750850bc77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371478 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805571}
-
Richard Li authored
media::HDRMetadata is going to be moved to ui/gl/, so its corresponding mojom bind should be move to that path. This is a preparation for passing HDRMetadata to SwapChainPresenter. Bug: 1122910 Change-Id: Id62709d95acc7517578cc37e940f0dca9a3f6d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389103Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Melissa Zhang authored
This CL fixes a bug where sometimes target text height obscures a section of the text. Bug: 1097623 Change-Id: I70c4841de68a831f13bd074c1a9bff569a779500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399164Reviewed-by:
-
Caitlin Fischer authored
This is because Windows has a command line size limit and too many testing configs can result in the limit being hit. See comment 3 on the bug for details on why these studies are candidates for removal. Bug: 1126640 Change-Id: Id33a88a789bb1322519f11b3e861c3cbe93280db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401703Reviewed-by:
-
John Abd-El-Malek authored
Only disable auto reloads for SSL or safe browsing interstitials instead of all errors with custom error pages. r773251 disabled auto reload for any interstitial that has custom HTML, since it wanted to disable them for SSL and SB. The code was componentized in r791935 and shared later with WebLayer. However not every embedder wants to disable auto retries just because they provide a custom error page. Instead make the disabling explicit to check for SSL errors or when the client code blocks a request (SB). Bug: 1126205 Change-Id: I949c94ae2d47c1fe7d30c9b2e58133b615a74fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401944Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#805567}
-
Daniel Classon authored
Adds browser proxies for the A11y Page, Manage A11y Subpage, and Text to Speech subpage. Allows the future creation of test browser proxies to create tests for deep linking in the A11y pages. Bug: 1084154 Change-Id: I83e4b69fac1b07b8e2a2c9813ac57be1642a0e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399570 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cee574832664..9a7b0a2dc5a3 2020-09-09 jonahr@google.com Workaround bogus MscRate reported by some XWayland drivers. 2020-09-09 shrekshao@google.com Suppress AtomicCounterBufferRangeRead failure on Nexus6P If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1042393 Tbr: ianelliott@google.com Change-Id: If7c2e4bf057e63316de695b51e946050533f023c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402204Reviewed-by:
-
Hoch Hochkeppel authored
Adding a class to represent the Windows DataTransferManagerInterop APIs within tests, as well as basic unit tests to validate the test class behaviors. Bug: 1035527 Change-Id: I926078f3b54b350c622adb40fc84fe3614fa89d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397315 Commit-Queue: Hoch Hochkeppel <mhochk@microsoft.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#805564}
-
Chris Lu authored
Each OverlayInteractionHandler needs its own distinct RequestConfig, because the handler's callback installer tie its callbacks to the RequestConfig. Thus, if two InteractionHandlers have the same config, then the banner action response will trigger both handler's callback methods. This creates a behavior where presenting the modal from a banner adds two modal requests into the queue. Bug: 1124587 Change-Id: I83b807017e754ea3935090cdf6e7c3a46b8ef2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397977 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#805563}
-
Patrick To authored
WebGL2 already supports makeXRCompatible() from the implementation in WebGLRenderingContextBase, but has a separate factory create method to handle the context attributes. This change handles the xrCompatible flag in a similar way to WebGL1. Web tests for WebGL2 will be added before enabling xr compatibility by default. Bug: 1087356 Change-Id: Ie80755663485aa2cf98129d4e4f264154ae1ad2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402129Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805562}
-
John Rummell authored
Don't allow calls to proceed once the associated content has been destroyed. Bug: 1121414 Test: example in the bug no longer crashes Change-Id: I3bdeb86f2020f684958b624fcc30438babfb5004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378889Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
-
Samuel Huang authored
Building Trichrome results in multiple .mapping files. This CL changes generate_commit_size_analysis.py to take multiple .mapping file inputs using repeated --mapping-name arguments. Bug: 1040645 Change-Id: If40081b50ac630504a85d3593de9631cb0977b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401949Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#805560}
-
- 09 Sep, 2020 7 commits
-
-
Gang Wu authored
We should use app:chromeDrawableTint to tint TextViewWithCompoundDrawables instead of android:drawableTint. android:drawableTint works on API level 23 and above. But somehow not work for PNG drawables in API 23, and TextViewWithCompoundDrawables provide app:chromeDrawableTint to tint, so we can use it to handle the issue. Bug: 1126035 Change-Id: Iebc9b0d0ccf9ca8510bd03d8285d19b2ba705cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402102Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805559}
-
Kent Tamura authored
webcodecs:unit_tests had a circular dependency with controller:blink_unittests_sources. This CL moves out controller:blink_bindings_test_sources from controller:blink_unittests_sources and adds controller:blink_bindings_test_sources dependency to webcodecs:unit_tests to remove the circular dependency. This CL has no behavior changes. Bug: 800764 Change-Id: Ie578dfe442f2ee111f19abb7496e41a27ff66b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400644 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#805558}
-
Miguel Casas authored
This CL follows crrev.com/c/2393629 by batching up SubmitBuffer calls in the JPEG decode accelerator, used e.g. for MJPEG camera stream decoding. This was verified via chrome:tracing while capturing HD on kohaku and reks (Braswell) in the link [1]. Similarly to what is seen in the previous CL, the combination of SubmitBuffer() calls on ToT is ~10% slower than the batched SubmitBuffers(). A key difference is that since JPEG is way simpler than e.g. VP9, the submitting time is comparable to the ExecuteBuffers_Locked(), so this CL has some minor overall decode-time savings. But still the target here is to reduce contention on the lock and libva for video conferencing cases with multiple remote participants a la Meet. [1] webrtc.github.io/samples/src/content/getusermedia/resolution/ Cq-Depend: chromium:2393629 Bug: b/166646505 Change-Id: I183cc151de24d8fdbdc62e0172be296dacbf26f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393525 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
J Kardatzke <jkardatzke@chromium.org> Cr-Commit-Position: refs/heads/master@{#805557}
-
Miguel Casas authored
This CL follows crrev.com/c/2393629 by batching up SubmitBuffer calls in the VP8 decode accelerator. This is verified via chrome:tracing and codepen.io/full/qzYXba that plays 4 1280x572 VP8 videos at the same time. Tracing is captured for a few seconds, basically the SubmitBuffers() call takes ~0.312ms/call versus the individual SubmitBuffer() calls ~0.072ms -- which gives an aggregate of 0.360ms, or savings of about ~20%. Since decoding itself takes about the same as SubmitBuffers on my BSW device (reks), batching gives ~10% reduction in decode time. Bug: b/166646505 Change-Id: I11c5570bea1c049fe0e9af75239bd60ac906a843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401512 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
-
David Tseng authored
See go/chromevox-touch_gestures Some gestures, e.g. swipe two fingers left, do not have an explicit command. Others, like three finger swipe up/down, have commands which are not also keyboard commands. In Learn Mode, these gestures are not fullyd escribed beyond just the physical gesture description. Add these descriptions now in this change. R=akihiroota@chromium.org Bug: 1124454 Test: browser_tests --gtest_filter=ChromeVoxLearnMode*.Gesture* AX-Relnotes: ChromeVox Learn Mode now describes all new gestures and what they do. Change-Id: I19fd3b39aa15f9df0daa864c4f99f69173d4baa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386377 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805555}
-
Adithya Srinivasan authored
Follow up to https://crrev.com/c/2382064. Bug: 1108793 Change-Id: Iba5aaedcf026907760bc9300846a5d45c0dfe6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398998Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805554}
-
Rakib M. Hasan authored
Follow up to crrev.com/c/2369641. This builder will be in the chromium.android console. It will run WPT on Weblayer for now. More browsers will be tested in this builder. Bug: 1050760 Change-Id: Ia1166f707e4b49dfa654ff199bb9539bb0a8d558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386600Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#805553}
-
