- 18 Jan, 2021 40 commits
-
-
Hiroki Nakagawa authored
By adding a new browser test, this CL clarifies the current behavior that clients in the prerendering state are exposed via Clients#matchAll() on service workers. This behavior can be changed based on future discussions. Change-Id: I6be9d2e3db91a5b411a5debbe4098a83597f4f86 Bug: 1166470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626861Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#844487}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 89-4342.0-1607345364-benchmark-89.0.4351.0-r1 to 89-4380.0-1610362181-benchmark-89.0.4387.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I9cd15c5ed9ee1d80ba1f29918d438a20f7dd1609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635793Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844486}
-
Friedrich Horschig authored
This CL does not affect any behavior. By adding traces, debugging events of jankiness becomes simpler and it allows to figure out which steps that rely on cached data slow down once the caching is reduced. Bug: None Change-Id: I2771e85038fd215067bb2a9aa6a2750e80e842c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633266Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#844485}
-
Anders Hartvoll Ruud authored
This runs tests under wpt_internal, since we don't have a spec yet. Bug: 1145970 Change-Id: Ibf9339d0c3faf89495cee08d51a9c65b694fefb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632750Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#844484}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a9f40de95873..5e5cb23c7e2a 2021-01-18 petermarshall@chromium.org [overrides] Fix files showing up multiple times in folders 2021-01-18 petermarshall@chromium.org [overrides] Only delete confirmed overrides for 'Delete all overrides' If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1143439,chromium:1165300 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I184a02975a183238675de767f6ce6040c937857f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635756Reviewed-by:
-
Mirko Bonadei authored
This reverts commit 59cc46ef. Reason for revert: M89 has branched and it is now possible to land the roll. Original change's description: > Revert "Roll src/third_party/usrsctp/usrsctplib/ 995c0b844..4191ca178 (72 commits)" > > This reverts commit 5903b6b1. > > Reason for revert: This should land after M89 is branched. > > Original change's description: > > Roll src/third_party/usrsctp/usrsctplib/ 995c0b844..4191ca178 (72 commits) > > > > https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/995c0b844144..4191ca1784d8 > > > > $ git log 995c0b844..4191ca178 --date=short --no-merges --format='%ad %ae %s' > > 2021-01-04 vitaly Fixed installation on other than Ubuntu GNU/Linux distributions. (#541) > > 2021-01-01 tuexen Improve handling of aborted associations > > 2020-12-31 yuquanw2 Add SACK into fuzzer_fragment (#516) > > 2020-12-31 61293369+ihsinme Update client_upcall.c (#559) > > 2020-12-30 deadbeef Add optional SCTP_USE_OPENSSL_RAND define to use openssll's RNG. (#558) > > 2020-12-30 deadbeef Lowercase reference to iphlpapi.lib (#560) > > 2020-12-23 tuexen Improve input validation for parameters in ASCONF and ASCONF-ACK chunks > > 2020-12-20 deadbeef Fall back to using urandom on Linux if getrandom isn't available. (#557) > > 2020-12-14 tuexen Harden the handling of outgoing streams in case of an restart or INIT collision. This avouds an out-of-bounce access in case the peer can break the cookie signature. Thanks to Felix Wilhelm from Google for reporting the issue. > > 2020-12-12 tuexen Clean up more resouces of an existing SCTP association in case of a restart. > > 2020-11-19 weinrank Sync master with fuzzing branch (#551) > > 2020-11-18 CoolmanCZ MinGW release build - initialize variables (#548) > > 2020-11-18 deadbeef Call __msan_unpoison after syscall(__NR_getrandom, ...). (#550) > > 2020-11-18 deadbeef Support building with emscripten. (#549) > > 2020-11-18 sironhide0null Fix a typo in user_mbuf.c (#552) > > 2020-11-09 tuexen Fix a potential use-after-free bug introduced in https://github.com/sctplab/usrsctp/commit/b10a5d3b26e94320232dbdf269873497f8f7cff1. > > 2020-11-04 weinrank Fix #545 - remove .lib extension (#546) > > 2020-11-02 weinrank Use CMAKE's BUILD_SHARED_LIBS flag to build shared library (#543) > > 2020-10-22 tuexen Use the SCTP_REUSE_PORT socket option. > > 2020-10-17 tuexen Improve the handling of cookie life times. The staleness reported in an error cause is in us, not ms. Enforce limits on the life time via sysct; and socket options consistently. Update the description of the sysctl variable to use the right unit. Also do some minor cleanups. This also fixes an interger overflow issue if the peer can modify the cookie. This was reported by Felix Weinrank by fuzz testing the userland stack and in https://oss-fuzz.com/testcase-detail/4800394024452096 > > 2020-10-13 tuexen Improve compilation on Windows. > > 2020-10-07 tuexen Whitespace changes > > 2020-10-06 tuexen Reset delayed SACK state when restarting an SCTP association > > 2020-10-06 tuexen Cleanup. > > 2020-10-06 tuexen Accept any cookie if FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION is defined. > > 2020-10-06 tuexen Provide RNG for __native_client__ as suggested by Taylor Brandstetter. Fail compilation on all platforms we don't have a specific RNG for. > > 2020-10-06 tuexen terminate_non_graceful() never returns... > > 2020-10-06 tuexen Initialize variables before using > > 2020-10-06 tuexen Remove dead stores reported by clang > > 2020-10-06 tuexen Cleanup > > 2020-10-06 tuexen Whitespace changes > > 2020-10-04 tuexen Use __func__ instead of __FUNCTION__ > > 2020-10-04 tuexen Cleanup. No functional change intended > > 2020-10-02 tuexen Minor cleanup. > > 2020-10-01 deadbeef Call getrandom via syscall directly on Linux. (#533) > > 2020-10-01 tuexen I guess Bitrig support arc4random(). > > 2020-10-01 tuexen Whitespace change. > > 2020-10-01 tuexen Don't start SCTP/UDP receive threads (and don't open corresponding UDP sockets) when the UDP port specified in scpt_init() is 0. > > 2020-09-30 deadbeef Add missing return type to init_random. (#531) > > 2020-09-30 tuexen Try to fix the Windows build. > > 2020-09-30 tuexen Add Android specific code for the random number generator. > > 2020-09-30 tuexen Add platform specifc includes to the corresponding code. > > 2020-09-30 tuexen Add a cleanup routine for the random number generator. > > 2020-09-29 tuexen Improve the input validation and processing of cookies. > > 2020-09-28 tuexen Whitespace cleanup > > 2020-09-28 tuexen Improve random number generation on __Fuchsia__. > > 2020-09-27 tuexen Improve the handling of fragmented, unordered, and unreliable user data using DATA chunks in the receive path. > > 2020-09-26 tuexen Fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25984 > > 2020-09-24 tuexen Whitespace changes > > 2020-09-22 deadbeef Avoid duplicate definition of _CRT_RAND_S. (#529) > > 2020-09-22 deadbeef Fix gcc/clang type mismatch warnings on Windows (#527) > > 2020-09-22 deadbeef Fix -Wunreachable-code in programs/ (#528) > > 2020-09-19 tuexen Improve consistency. > > 2020-09-19 tuexen Cleanup. > > 2020-09-19 tuexen Improve Windows build. > > 2020-09-19 tuexen Fix syntax error on windows. > > 2020-09-19 tuexen Add include for getrandom() on Linux. > > 2020-09-19 tuexen Fix type of init_random() on Linux and Windows. > > 2020-09-19 tuexen Improve Windows build. > > 2020-09-19 tuexen Improve consistency. > > 2020-09-19 tuexen Improve random number generation on Linux and Windows. > > 2020-09-19 tuexen Cleanup read_random(). No functional change. > > 2020-09-19 tuexen Fix NetBSD related #ifdef. > > 2020-09-19 tuexen Whitespace changes > > 2020-09-18 tuexen Add license. > > 2020-09-18 tuexen Add license statement. > > 2020-09-18 tuexen Fox more typos. > > 2020-09-18 tuexen Fix typo. > > 2020-09-18 tuexen Remove trailing whitspaces. > > 2020-09-18 tuexen Improve consistency, no functional change intended. > > 2020-09-18 tuexen Check for too short packets when using the receive threads. > > 2020-09-18 tuexen Fix mask for ECN bits. > > > > Created with: > > roll-dep src/third_party/usrsctp/usrsctplib > > > > Bug: chromium:1163228 > > Change-Id: I9b0b5f8c98bf3f7c9f51ae6fae24dd0e9b6e3117 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612384 > > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#841036} > > TBR=hta@chromium.org,deadbeef@chromium.org,mbonadei@chromium.org,orphis@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: Ifd8bf7e7fb5a50cdc4fb4b128895bc34425f127a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:1163228 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617778 > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841408} TBR=hta@chromium.org,deadbeef@chromium.org,mbonadei@chromium.org,orphis@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1163228 Change-Id: Ie2a5e1ff72aa815bbd9aa737e3f138ef25514e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633262Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#844482}
-
Eugene But authored
Bug: None Change-Id: I5ddc1f369f999731aa0c8a8784b3dd8d5f3bade0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634231 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#844481}
-
Henrique Ferreiro authored
When a drag-and-drop operations ends, a single operation is selected. OnPerformDrop() should return that operation, instead of a bitmask of multiple operations. This is a precursor CL so that OnPerformDrop can change its return type to ui::mojom::DragOperation which will enforce the allowed operation values via type checking. Test: WMHelperChromeOSTest.MultipleDragDropObservers Bug: 1093536 Change-Id: Ia0a88f8509126c81b6429804c41c58b90404901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597546 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daichi Hirono <hirono@chromium.org> Cr-Commit-Position: refs/heads/master@{#844480}
-
Eugene But authored
Bug: None Change-Id: I05dce85f55787d5b20399eed88feb0abf8c09523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633849 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Glen Robertson authored
Revealed some other classes that were incorrectly missing those headers, so fixed those too. In prep for moving profile to a separate GN target. Bug: 1149277 Change-Id: I2c42ecefbd5183e74b8e96c250d0d69b282388ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632545 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#844478}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibb6ff53b7e1200c5aa578aa8626c595c0595b7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633932Reviewed-by:
-
Matt Falkenhagen authored
Bug: 1132746 Change-Id: Iee24aa91d115e315a56224857ede961452261df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633221 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#844476}
-
Antonio Sartori authored
This CL adds a test for the Content Security Policies 'frame-ancestors' directive when a local file embeds an http url. Unfortunately it is not possible to write such test as Web Platform Tests, since they do not support opening file: urls. Bug: 756204 Change-Id: I7254cc26bebd4a5c0882b55cc340780da1e8b0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631498Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Cr-Commit-Position: refs/heads/master@{#844475}
-
Alice Wang authored
This CL migrates string id to CoreAccountId in ChildAccountInfoFetcher. ChildAccountInfoFetcher.java is moved from components/signin/core to components/signin/public to avoid circular dependency. Bug: 1028580 Change-Id: Iff6ad1bdf8d18d2cc3afc3b4f2ad6dd984dfb4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626434 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#844474}
-
Sanja Perisic authored
Added Chrome Canvas to SystemFeaturesDisableList policy and policy handler for disabled apps. Bug: 1142785 Change-Id: I54c8d0542a4ef7afe4b6903b377fa5cf4245299c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632607Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sanja Perisic <sanjaperisic@chromium.org> Cr-Commit-Position: refs/heads/master@{#844473}
-
Vidhan authored
Bug: 1167099 Change-Id: I1c782ef46244653d0b242e217a3758c11b443b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633046Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I814f88fca5229fd70cebe9e909820f0a5218567c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635425Reviewed-by:
-
Victor-Gabriel Savu authored
The histogram is still being used. Also update email to the correct one. Bug: chromium:1165044 Change-Id: I08d868eecc5ce98a9d4f1a8e8ed94b694486cdbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627420Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#844470}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610938647-590bb4866453137a0c0e295798fa59fea03a855f.profdata to chrome-win32-master-1610948968-73b5b51cc98aa3edcd70782870e3aaa675f980cb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I84ee9a2be0caf0658bbcc17074646e33002f2f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635216Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/beea40504747..bd2954a9c499 2021-01-18 syoussefi@chromium.org Reland "Cleanup translator option checks" 2021-01-18 syoussefi@chromium.org Reland "Vulkan: Generate xfb support code in SPIR-V for extension path" 2021-01-18 syoussefi@chromium.org Reland "Vulkan: Move xfb position decl to translator in extension path" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ic2f6a516fb703b4bdf6f8cb4c91054eb3cfcd848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635211Reviewed-by:
-
Sigurd Schneider authored
When capturing a stack trace, we were providing an invalid scriptId on the corresponding source location. This CL gets the scriptId of the top-most script, just as we get the column/line/url. Bug: chromium:1158782 Change-Id: Iad46758f8b24f60b07cace13239bb9fb678b5b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595528 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844467}
-
Naoki Fukino authored
Adding a flag for the IME support which doesn't need the ConsumedByIme() workaround. When the flag kSupported is specified as a Lacros's init param, Lacros expects that the key events and keysym events are sent in separated APIs without filtered by ConsumedByIme(). exo's new behavior for this new flag is implemented in a follow-up CL. Bug: 1093194 Test: None Change-Id: Id01aa2b064fff6db6fe7420c42e39a99b9c87866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631545 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#844466}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/09729d2ecf49..12971a22d265 2021-01-18 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-18T04:03:42). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I11d59b40548f0b3fd4dc8654f986c999b9e348b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635521Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4cc12ef65f56..a9f40de95873 2021-01-18 alexrudenko@chromium.org Round contrast ratio down If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1166128 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba6c8b1511b2a171e41b59957c805851f4278e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635214Reviewed-by:
-
Hitoshi Yoshida authored
In web tests, TestRunner checks if a test can finish successfully using the main window's main frame, and it is searched from a list of main frames. Internally, JavaScript code which tries to finish tests is invoked from CommitNavigation. But when we use back/forward navigation with BFcache, we update the list of main frames through OnFrameReactivated in OnFinishNavigation, that is called after CommitNavigation. This order makes frames' state inconsistent and tests fail with timeout. This CL moves the call of OnFrameReactivated into ReadyToCommitNavigation, which is called before CommitNavigation, and makes frames' state in the renderer consistent. Bug: 1150297 Cq-Include-Trybots: luci.chromium.try:linux-bfcache-rel Change-Id: Ib87a2d1c604e0013d3d93d5d679583e196d44eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581621 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844463}
-
Dominic Battre authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/2627369/ as AutofillAccessibilityTest.TestAutofillState is still flaky. R=koerber@google.com Bug: 1162484 Change-Id: I564cad803d3950e8b156d28cbddb57e1625b5708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632952 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I28070ab41d0bf184f6c94ba7cf071d7ad74c5ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634823Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844461}
-
Alan Cutter authored
This CL makes the "capture_links": "navigate-existing-client" web app manifest setting open in scope navigations in existing web app windows. If no app window is open at the time a new one is opened (the same as "new-client"). This behavior is hidden behind the WebAppEnableLinkCapturing flag. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=485126&signed_aid=HbGtkKbvjuetuLqwFguItA==&inline=1 Bug: 1163398 Change-Id: I1bc673b2dc019b9ba9113ce71d2bbbdabac865b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635463 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#844460}
-
Wanming Lin authored
setTimeout(..., 0) is clamping up to 1ms for historical reasons: crbug.com/402694, and the issue has been open for years which was blocked by the challenge of updating all test expectations accordingly. Chrome doesn't need the clamp for anything in particular and no 1ms clamp in the spec, moreover, we found Speedometer2 performance can boost ~1% on Windows without it based on Pinpoint perf. Most failure tests failed with this change had been fixed in separated CLs. Bug: 402694 Change-Id: I46196584b887513ca520221be68099116931d4f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578703Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#844459}
-
Miriam Polzer authored
Bug: None Change-Id: I6d6ca83fd518b9d455a16b44b8d068edfac0e613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621814 Auto-Submit: Miriam Polzer <mpolzer@google.com> Reviewed-by:
Arman Uguray <armansito@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#844458}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/26a84431ff72..1bb49a870088 2021-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from aedd133cd85f to 149733cead63 (2 revisions) 2021-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 50c82f42e33f to 68635b431b3c (24 revisions) 2021-01-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from e330bc98 to 1d3066a6 (498 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Test: Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*real_gangster_crime* Change-Id: Ibb3faafe1eba3415e54aea1284d7367f063f0800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635209Reviewed-by:
-
Yunke Zhou authored
Bug: 1159869 Change-Id: I503392bd82e8dd2f7a324da5df3b16ad07e76412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621756 Commit-Queue: Yunke Zhou <yunkez@google.com> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#844456}
-
Jérémie Boulic authored
In //ui/file_manager/image_loader/: - cache.js - cache_unittest.js - image_loader.js - image_loader_unittest.js - image_loader_util.js - image_request_task.js - piex_loader.js - scheduler.js - scheduler_unittest.js Bug: 1133186 Change-Id: Id23e03c916590830be342b2fda99e5701610a88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631398 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#844455}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610926940-efa0e5121c3539a29c4cc2a8e2e370b1761f139f.profdata to chrome-mac-master-1610948968-472c5c5ed4005e92cd456548bcb91e146ae8a09f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iab69ad070de1d8f7545ad81359405483301dab54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635213Reviewed-by:
-
Harvey Yang authored
Supporting multiple sensor clients in FakeSensorService simplifies some unit tests of disconnections. BUG=b:172208566, b:172414302 TEST=unit tests Change-Id: I77ccbc79760e2a3833de6d39fadf4d5e00a4001b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631390Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844453}
-
Angela Gyi authored
This CL adds two stub classes (which are later to be extended) for the content previews feature on Chrome OS devices. Bug: 1167016 Change-Id: I380065471db7a6d123f7110f0d42bac122f782bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631548 Commit-Queue: Angela Gyi <angelagyi@google.com> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#844452}
-
Glen Robertson authored
Seems to be possible on shutdown. For more context see attached bug. Also switched scoped_observ{er->ation} because we always observe a single source (no functional change here). Bug: 1167491 Change-Id: I675f0bc57abe7067960500a7e6607be3f7b8d36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631979Reviewed-by:Dominick Ng <dominickn@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844451}
-
Hiroki Nakagawa authored
A page that has a pop-up window should not activate a prerendered page. This behavior was already implemented by the previous CL (https://crrev.com/c/2560362). This CL adds a browser test for the behavior. Bug: 1138723 Change-Id: I205daba93d6998f03047f19aa5eb149e1dc6eb6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635381 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
crrev.com/c/2631705 removed the read of |text_track_text_color|. This CL restore to read the varialble in WebPreferences StructTraits. Bug: 1097943, 1166690 Change-Id: I1695551bc8eabe39bc8f129471a519af1ae42b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631557Reviewed-by:
-
Glen Robertson authored
As recommended by clang-tidy on crrev.com/c/2626814 Change-Id: Id895aa84ac23f7c1435da869047b38ed84d4e648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631816 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#844448}
-
