- 06 Aug, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/74ec0afe01ec..99f494e42246 git log 74ec0afe01ec..99f494e42246 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 ianelliott@google.com Vulkan: Enable GL_NV_pixel_buffer_object extension Created with: gclient setdep -r src/third_party/angle@99f494e42246 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Bug: None Change-Id: Ie15f8733178cefbfae8bf507785fffe30e78dd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684365}
-
Brian White authored
Updates the expires_after attribute for 250 histograms that show frequent access in the past 90 days. These are the 40% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-02-02. Change-Id: Ib261ee110b3c7b55b3cf2669e30d5bb0a976767d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738711Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#684364}
-
Sujie Zhu authored
Set the |from_dynamic_change_form| and |has_non_focusable_field| in SaveCreditCardOptions when Chrome shows local save prompt to user from a dynamic/accordion form so that sub-histogram can be logged correctly. We add tests to ensure these two fields are correctly populated in SaveCreditCardOptions when a user was prompted local-save/upload from a dynamic/accordion form. The tests for the local save sub-histogram were already introduced in save_card_bubble_controller_impl_unittest.cc Bug: 989771 Change-Id: I286416e2d8a4f90f2e5740658cf414531ba0a574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730853 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#684363}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: Ia6035a0bdcc0c9702d5758715ee27aec7ec7ce3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737671 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#684362}
-
Stephen McGruer authored
FragmentData::UniqueId is not intended to be relied upon as an indicator. Instead, any call to the method should only happen if you know there should be a UniqueId, and failures should be handled by figuring out when a UniqueId should have been created (by paint properties or otherwise). This CL adds a DCHECK to enforce this, and fixes up two locations that were trying to rely on FragmentData::UniqueId to check state. Bug: None Change-Id: I168ad2e91a3418e98d351df8fa3ad879ab2e3427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730859Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#684361}
-
Sam Maier authored
Change-Id: I61cab72b4c197af008012fc73eedaae4cffaaf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733579 Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#684360}
-
Mustaq Ahmed authored
Without a specific frame, we were using the local root of caller's widget, which was showing wrong activation state in certain cases. Bug: 981597 Change-Id: I45a5dd88ea4c487ff4bf3a722e72bb6923fb8319 TBR: dcheng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721186 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#684359}
-
Aaron Leventhal authored
These methods turned out to be unnecessary, as the autofill agent communicates directly with the WebAXObject. Bug: 865101 Change-Id: Id16a03b808f76b0f2fd5030f5ba9f7ffdd119565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731290Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#684358}
-
Morten Stenshorne authored
FloatingObjects has a method LowestFloatLogicalBottom(), which calculates and caches the lowest FloatingObject if this information isn't already calculated and cached. Then there's the method LowestFloatingObject(), which would return that FloatingObject, if it was cached, and nullptr otherwise. So: One method that calculates it if needed, and one that relies on the cache and otherwise returns something bogus. The layout code is quite well peppered with calls to LowestFloatLogicalBottom(), so it requires significant amounts of bad luck to trigger a cache miss, and then another heap of bad luck to actually cause a crash from that. But it was NOT impossible. The fix is to rebuild the cache if needed in LowestFloatingObject(). Letting it return nullptr if the cache was invalid caused us to fail to propagate an overhanging float upon relayout, breaking some sort of link to subsequent blocks, so that when the float later on was removed, we'd fail to remove it from all the block flows that referred to it. The test included in this CL is as minimal as I could get it, but still not super-simple. Here's what went wrong: There is a float somewhat nested inside a container. This container has some siblings, one being an infinitely tall beast with a large negative (also infinite) block-start margin. Another sibling is empty, so that we can collapse through it. Then there's a last, pretty decent, sibling container, except that it contains another float. Because we're dealing with infinite LayoutUnit values, the engine cannot quite agree with itself whether the first float intrudes into the last sibling or not, and this is important when it comes to determining whether the float intrudes into the last container or not. When we lay out initially, we find it to intrude, and add it to the list. We then change the first float ever so slightly, to trigger relayout. This will break the magical chain of FloatingObject references to the first float (because the cache was invalid, and therefore incorrectly report that there's no float there). The last container (the one previously referred to as "decent") has a reference to the float that just got relaid out, because at some point it was thought to intrude. If we had laid out this container again now, we'd clear the FloatingObject list and the float would be gone from the list. But we don't lay it out again, because the relevant part of the engine decides that the float doesn't intrude, contrary to what the part of the engine that caused it to be added in the first place concluded. Then, we'll remove the float (display:none), and we'll fail to remove it from all block flows that referenced it. The last container still has a reference to the hungover (or actually now dead) float. Bug: 989305 Change-Id: I498344fc5b6426cf8225441d2dab195659e31112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738556 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#684357}
-
Ben Kelly authored
This is a reland of cca6943d The CL includes an additional update to MSANExpectations to account for expected interfaces-sw.https.html timeouts in the virtual test suite. These timeouts are expected as described in bug 856601. Original change's description: > CacheStorage: Allow reads to be executed in parallel. > > This CL adds the CacheStorageParallelOps feature with the associated > "max_shared_ops" parameter. Enabling the feature and setting the > parameter to greater than one will allow read-only cache_storage > operations to run in parallel. By default parallel operation is > disabled. > > The overall design is to treat each CacheStorageScheduler as if it > has its own read-write-lock. When an operation is scheduled it must > be flagged as either "shared" or "exclusive". Some number of shared > operations (determined by the feature param) may run in parallel. > Exclusive operations always run by themselves without parallelism. > > This CL also includes the ServiceWorkerCache.PeakParallelSharedOps > histogram which will measure how much parallelism we actually see in > practice. The peak is measured across a small time period defined by > when an idle scheduler begins running its first shared op to until it > stops running all shared ops. > > Bug: 985379 > Change-Id: I4e318b719b51da079ff584acd1fb398d898660d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709008 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#680986} TBR=jwd@chromium.org,dmurph@chromium.org,jam@chromium.org,rayankans@chromium.org Bug: 985379,856601 Change-Id: Ia0480844c141f5646edaea04a33557b4ecad2182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739310 Commit-Queue: Ben Kelly <wanderview@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#684356}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLDetailsElement> and DynamicTo<HTMLDetailsElement> as new downcast helper. 2. Use IsA<HTMLDetailsElement>(element) in place of IsHTMLDetailsElement(element) Bug: 891908 Change-Id: Ib7d9bc62aced8df6158c3e04610e006996e9b28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738456Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#684355}
-
Abhishek Bhardwaj authored
BUG=None TEST=Compile. Change-Id: I35b315c6a72f4b3d2d8d6f23547e138d0c2abb20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738144 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#684354}
-
Lei Zhang authored
The test only checks the sensor pointer with EXPECT_TRUE() and then dereferences the pointer. On failure, this will blow through the EXPECT_TRUE() and crash the test program. Switch to ASSERT_TRUE() to fail without crashing. Change-Id: I18a8b9c2ea7e300b93a11cc6108f195a895bec04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733039Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#684353}
-
Benoît Lizé authored
memfd_create() avoids having to write relocations to disk. It is available on recent-ish Android kernels (>= 3.17). Use it where possible in ModernLinker. Bug: 979638 Change-Id: I6b52373490bec0c29b9028558d3926fff75d7a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730893Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#684352}
-
Yann Dago authored
Bug: 990073, 989734 Change-Id: I35fd81bd4ed1426a0865a2820c818944c263de04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731755 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#684351}
-
Eugene But authored
This CL adds TODO and replaces EARL_GREY_TEST_SKIPPED with EARL_GREY_TEST_DISABLED. Bug: 990947 Change-Id: Idfd04f691d2bff9a38f6332d9e18d25c9a765975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736931 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#684350}
-
Jenna Himawan authored
Bug: 990550 Change-Id: I3224540c71a70ed175308b14927978b88b794a48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735048Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#684349}
-
Antonio Gomes authored
... down to renderer/platform/mediastream. The .cc and test_.cc respective files also got moved from renderer/platform/export/mediastream to renderer/platform/mediastrea/. BUG=704136,919392 R=guidou@chromium.org Change-Id: Ia981d447b28e2b7ad5bcadba3abb13ebc4111f2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739388 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#684348}
-
Geoff Lang authored
If the passthrough command decoder is default, it may get used when it is not supported in compositor_unittests and cc_unittests. BUG=882580 Change-Id: I890315332e07bb61328fc9cb063f4abbdafa0194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739308Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#684347}
-
Anushruth authored
Added chrome_all_tast_tests, cros_browser_sanity_test and base_unittests to chromeos-kevin-google-rel R=bpastene@chromium.org Bug: 988587 Change-Id: I2117296c33c99f72063d6ffac71e007b4c481710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737100Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Anushruth <anushruth@chromium.org> Cr-Commit-Position: refs/heads/master@{#684346}
-
Aaron Leventhal authored
When VoiceOver uses an action to press a checkbox, it requests and reports the new checked state immediately. However, because of Chrome's cross process model, the checkbox/radio/switch checked state is still the previous state, as the round trip has not yet updated the object. This uses a hack to temporarily override these objects with what the state is expected to become. Once the system catches up with itself, it will update the object with the true checked state, which should be the same. Bug: 971429 Change-Id: Ifcc15b281413f02cecf951ac6e4e31890d4c05c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727210 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#684345}
-
Amr Aboelkher authored
Show the cursor highlight accessibility feature only if one of the following conditions have meet : -Its not being controlled by any policy -Its being controlled by a policy and the value of the policy is force on Bug: 552439 Change-Id: I48823a53cb0ebbaf2edc732de56452871ee08eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725915 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#684344}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b9d6775dfb5f..600679a1c326 git log b9d6775dfb5f..600679a1c326 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 khokhlov@google.com Maintain compatibility with both jsoncpp versions 2019-08-05 rsavitski@google.com Merge "traced_probes ftrace: cap the per-cpu pages read per drain period" 2019-08-05 ilkos@google.com Merge "Combine heap profiler stats" 2019-08-05 fmayer@google.com Merge "Move profile.packet to perfetto.third_party package." 2019-08-05 treehugger-gerrit@google.com Merge "UI: Fixed timeline scrubbing" 2019-08-05 treehugger-gerrit@google.com Merge "Improve extension for perfetto trace recording." 2019-08-05 hjd@google.com Merge "Update rollup config to remove warning" 2019-08-05 hjd@google.com Make bad config the right amount of bad 2019-08-05 hjd@google.com Merge "Add bad config to test/config" 2019-08-05 fmayer@google.com Merge "Add //src/base to dep for pprofbuilder." 2019-08-05 fmayer@google.com Merge changes Iff458990,If7f8d5f2,Ia79e6e0b 2019-08-05 ilkos@google.com Add pid to the frame stats metric 2019-08-05 taylori@google.com Merge "perfetto-ui: Only quantize tracks with too much data" 2019-08-05 ilkos@google.com Merge "Enhance heap profiler metrics" 2019-08-02 hjd@google.com Merge "perfetto-ui: Fix ui" 2019-08-02 treehugger-gerrit@google.com Merge "no-stall mode: Track stats about packet loss" 2019-08-02 treehugger-gerrit@google.com Merge "client api: Don't hang if a not-yet-started session is stopped" 2019-08-02 fmayer@google.com Merge "Use ProfiledFrameSymbols for symbolization." 2019-08-02 treehugger-gerrit@google.com Merge "processor: Export LegacyEvent raw events as JSON" 2019-08-02 taylori@google.com Merge "perfetto-ui: Fix tslint errors" 2019-08-02 treehugger-gerrit@google.com Merge "perfetto-ui: Make 'm' timespan select work on all selections" Created with: gclient setdep -r src/third_party/perfetto@600679a1c326 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: chromium:b/133745684 Change-Id: I81653eaafcaf2aad1da8bec5e8d9cbae305ef704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738431Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684343}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fc89641e4a1d..af9ce667581c Created with: gclient setdep -r src-internal@af9ce667581c The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8f34bfa2aa99cceea99aa151f64fb339553a9522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738430Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684342}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e6c294dba63..61b15905b014 git log 2e6c294dba63..61b15905b014 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8776a388..9d357a52 (684182:684300) Created with: gclient setdep -r src/third_party/webrtc@61b15905b014 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I9b75c13119bb8f8d430fce5530686c60fb434733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738429Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684341}
-
arthursonzogni authored
Add 4 tests that regressed recently after: https://chromium-review.googlesource.com/c/chromium/src/+/1654739 Bug: 991194 TBR=ahemery@chromium.org Change-Id: I9f3c93ab99a3c34e7cff0a936078f1343d98bd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738377Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#684340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/88681ddd1d38..3a543aafd4e6 git log 88681ddd1d38..3a543aafd4e6 --date=short --no-merges --format='%ad %ae %s' 2019-08-06 aparchur@google.com Reland "[skottie] Add onTextProperty support into PropertyObserver." Created with: gclient setdep -r src/third_party/skia@3a543aafd4e6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@google.com Bug: None Change-Id: I01e8a19011358ffa29f3d38915c29365cf645de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738428Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#684339}
-
Vadym Doroshenko authored
Context: code for filling passwords in DOM is very convoluted. For username first flow, we need to fill only usernames, which is hard to do in the current setup. Let's refactor! This CL contains: 1.FillFormOnPasswordReceived is removed. It basically delegates filling to FillUserNameAndPassword, which is used now. 2.Checking origin of parent frames moved to a helper method. 3.2 arguments removed from FillUserNameAndPassword, they may be computed from other args anyway. The further CL will contain more simplification to FillUserNameAndPassword. Bug: 875768, 959776 Change-Id: Id1658401a8ec683a1a8db1117e816fe87f7dbaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738554Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#684338}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=vakh@chromium.org Bug: 968047 Change-Id: I82e8243a4dc3bea555c09c8c407f5f855c39c373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729222 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#684337}
-
Wei-Yin Chen (陳威尹) authored
Bug: 964406 Change-Id: I1a6f0969d6361afb00a5f5a4d800c4ad29ff7b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735777 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#684336}
-
Robert Flack authored
As a result of aligning the animation clock to raf, the animations in play-state.html start a bit earlier. This resulted in the test flaking regularly. By waiting for a render and relaxing the time allowed this test no longer flakes. I've added another test to ensure that animations which start with the initial document load are indeed caught by an animationstart event. Bug: 986019 Change-Id: Ib0dff60ddfef4f0395e422ac94bbdc78cc660017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727370Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#684335}
-
Leonard Grey authored
Bug: 956433 Change-Id: I7991566418c52643711d79c7fe9d20852ae203b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729469Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#684334}
-
Noel Gordon authored
This reverts commit 679d952d. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=987448#c31 Original change's description: > Revert "[Sheriff] Disable SingleProcessBrowserTest.Test on Win." > > This reverts commit 2a6e4af1. > > Reason for revert: The test should no longer be flaky on Windows. > > Original change's description: > > [Sheriff] Disable SingleProcessBrowserTest.Test on Win. > > > > Flaky. > > > > TBR=rockot@google.com > > > > Bug: 987448 > > Change-Id: I6db59e7ce6ac618320e10bfe85b1aa700e0fbce1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730902 > > Reviewed-by: vitaliii <vitaliii@chromium.org> > > Commit-Queue: vitaliii <vitaliii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683173} > > TBR=rockot@google.com,vitaliii@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 987448 > Change-Id: Ia37df33292f76bf965d07da3168933586e564061 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736439 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#684053} TBR=rockot@google.com,vitaliii@chromium.org Change-Id: I3b1083a892df5cfa536f3553082b27f31acfdbd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738562Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#684333}
-
Tim Volodine authored
Flaky on recent runs of android waterfall bots. BUG=990555 TBR=hartmanng@chromium.org,adithyas@chromium.org NOTRY=true Change-Id: I2a605b491db96b494f94a20c3451207dc3bd64e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738592Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#684332}
-
Jared Saul authored
Accidentally missed this as part of https://chromium-review.googlesource.com/c/chromium/src/+/1717490 Bug: 868552, 902366 Change-Id: I7e68bc0ada1f48cd465dadbe9a171b09e6f8743d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733410 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#684331}
-
Balazs Engedy authored
This reverts commit 1d544254. Reason for revert: Causes virtual/cache-storage-parallel/external/wpt/service-workers/service-worker/interfaces-sw.https.html to time out on Linux MSAN. Original change's description: > Reland "CacheStorage: Allow reads to be executed in parallel." > > This is a reland of cca6943d > > Original change's description: > > CacheStorage: Allow reads to be executed in parallel. > > > > This CL adds the CacheStorageParallelOps feature with the associated > > "max_shared_ops" parameter. Enabling the feature and setting the > > parameter to greater than one will allow read-only cache_storage > > operations to run in parallel. By default parallel operation is > > disabled. > > > > The overall design is to treat each CacheStorageScheduler as if it > > has its own read-write-lock. When an operation is scheduled it must > > be flagged as either "shared" or "exclusive". Some number of shared > > operations (determined by the feature param) may run in parallel. > > Exclusive operations always run by themselves without parallelism. > > > > This CL also includes the ServiceWorkerCache.PeakParallelSharedOps > > histogram which will measure how much parallelism we actually see in > > practice. The peak is measured across a small time period defined by > > when an idle scheduler begins running its first shared op to until it > > stops running all shared ops. > > > > Bug: 985379 > > Change-Id: I4e318b719b51da079ff584acd1fb398d898660d7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709008 > > Reviewed-by: Jesse Doherty <jwd@chromium.org> > > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > > Commit-Queue: Ben Kelly <wanderview@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#680986} > > TBR=jwd@chromium.org,dmurph@chromium.org,jam@chromium.org,rayankans@chromium.org > > Bug: 985379 > Change-Id: I83d8ce38a647b00e658dc1e2e17828468475cc66 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737031 > Reviewed-by: Ben Kelly <wanderview@chromium.org> > Commit-Queue: Ben Kelly <wanderview@chromium.org> > Cr-Commit-Position: refs/heads/master@{#684049} TBR=dmurph@chromium.org,jwd@chromium.org,jam@chromium.org,rayankans@chromium.org,wanderview@chromium.org Change-Id: I879f85342779a56f445cb6a157aeb5d74fcd3771 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 985379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738591Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#684330}
-
Balazs Engedy authored
This reverts commit 35ad15e3. Reason for revert: virtual/audio-service/external/wpt/mediacapture-streams/idlharness.https.window.html times out on Linux MSAN. Original change's description: > Reland "Add web tests virtual suite for audio service - Take 2" > > This reverts commit 75b38795. > > Reason for revert: Adding expectation to address Linux Leak failure > > Original change's description: > > Revert "Add web tests virtual suite for audio service - Take 2" > > > > This reverts commit 8d648953. > > > > Reason for revert: Causing failures on WebKit Linux Leak > > > > Failure output: > > 06:31:06.621 2998 worker/6 virtual/audio-service/media/autoplay/document-user-activation.html failed: > > 06:31:06.621 2998 worker/6 leak detected: ({"numberOfLiveContextLifecycleStateObservers":[0,2],"numberOfLiveDocuments":[1,2],"numberOfLiveNodes":[4,135],"numberOfLiveResourceFetchers":[1,2],"numberOfLiveResources":[0,2]}) > > > > Original change's description: > > > Add web tests virtual suite for audio service - Take 2 > > > > > > Adds extra expectations with respect to reverted > > > https://chromium-review.googlesource.com/c/chromium/src/+/1715811 > > > > > > Bug: 976696 > > > Change-Id: If36df0fd21b059c2eb212a0d1869c9ff82951c66 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732088 > > > Reviewed-by: Armando Miraglia <armax@chromium.org> > > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#683565} > > > > TBR=guidou@chromium.org,armax@chromium.org > > > > Change-Id: I15488e069bee7e6e1282bcc78dfe2088339b7036 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 976696 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733508 > > Reviewed-by: Chris Sharp <csharp@chromium.org> > > Commit-Queue: Chris Sharp <csharp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#683600} > > TBR=csharp@chromium.org,guidou@chromium.org,armax@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 976696 > Change-Id: I9172e204adef935eb4ae4a60045a54b6c9c157f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735378 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Henrik Grunell <grunell@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683979} TBR=grunell@chromium.org,guidou@chromium.org Change-Id: I0d414e093d158e3142091e376ec7d49926a357c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 976696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738560Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#684329}
-
arthursonzogni authored
Bug: 991178 Change-Id: I89d7ab57849e1a5db8ef0355d525249032316abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738455 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#684328}
-
Tamer Tas authored
We have Blink layout test bots on 3 different platforms using the {blink_downstream} recipe. {chromium_integration} uses src-side definitions for compilation and blink tests. This CL creates the src-side bot definitions for Chromium integration with Blink Layout tests. R=machenbach@chromium.org TBR=jbudorick@chromium.org Bug: chromium:883629 Change-Id: I5b303b1d1dd26cc4a2b3804a8e762b69020069df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736680 Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#684327}
-
Nico Weber authored
Bug: 990921 Change-Id: I12d2775011b4ed8e560117b4c1a3f49b710e66dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739307 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#684326}
-