- 17 Dec, 2020 40 commits
-
-
Daniel Murphy authored
This cleanup migration should be complete now. See this bug [1], which gives more context on the cleanup itself. Removing, which is basically reverting commit d3d65a10 [1], but leaves the pref value for cleanup as per guidelines. This is also being done to replace this functionality with WebAppMover [2] (google only). [1] https://crbug.com/1127128 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2391704 [2] https://docs.google.com/document/d/1GOek_Q4O_jTewHHx0MLnbYXvlTdEKT-KmkPZ5R0VJ3c/edit Bug: 1158066, 1127128 Change-Id: I75de00f67a3f26984c10f1dbdf0389b6f31c71a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587402 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#837873}
-
Leonid Baraz authored
No semantics changes whatsoever. Change-Id: If7d2aee72d62b09cbe864157416988835febfc99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596016Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837872}
-
John Williams authored
Bug: 1159209, b/1154342 Change-Id: I67f862c2f1e9cd2f8cfaeb2d73c5e22ebd360bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559589Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#837871}
-
Gyuyoung Kim authored
This CL migrates AwViewHostMsg_OnContentsSizeChanged to FrameHost interface. This CL uses AssociatedRemote to keep the message order. OnMessageReceived() is removed because AwRenderViewHostExt doesn't handle IPC message anymore. Bug: 1157128 Change-Id: If1e6132ac4c99cb1f1f7ee484a424ba5cc3a75a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592269Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#837870}
-
Asami Doi authored
This CL replaces `data.errors.empty()` with `data.NoBlockingErrors()` because we don't want to consider the WARN_NOT_OFFLINE_CAPABLE state as an error. The state just logs a warning message to DevTools and Application > Manifest > Installability and it should not affect the behavior. Bug: 1157809 Change-Id: I03cf02f134ff4f96441723bf893aac380160cced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592245Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#837869}
-
James Vecore authored
This CL: https://crrev.com/c/2594308 introduced new error states to receive surface registration which was causing the notification manager to fail registration at startup. We can get around this issue by allowing background receivers to register regardless of medium or transfer state. Change-Id: I50f8b00a0a01ea4bd6eb6b259f6c5c522fa38c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596062 Commit-Queue: James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Auto-Submit: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#837868}
-
Joey Arhar authored
Before this patch, <input type=checkbox> and <input type=radio> can be left in an active state if you press the spacebar down to toggle it, and then press tab to move focus away before releasing the spacebar. This patch calls SetActive(false) on the blur event for these input types, which clears the active state in this case. The test uses test_driver.Actions(), which isn't supported by the layout test runner but works just fine in the separate wpt runner in the wpt github repo. I wrote the test and verified that it works well with the separate wpt test runner, then wrote a TestExpectations line against the bug to track the issue with the layout test runner: crbug.com/893480 Fixed: 1157510 Change-Id: I13a0900277dbfccc87ba81ffd684b12430665e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594107Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#837867}
-
Yuta Hijikata authored
This is a mechanical change that renames deprecated macro replacing: - BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}), - gn var is_{ash,lacros} with is_chromeos_{ash,lacros}. There is a section about the renaming on http://go/lacros-macros. Bug: 1052397 Tbr: sky@chromium.org Change-Id: I96abf99580c0c4e9d657ee91ac768f4875ea6080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592580 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#837866}
-
Zhiyuan Cai authored
This change adds test for PriceWelcomeMessageCard component, including https://chromium-review.googlesource.com/c/chromium/src/+/2556657 and https://chromium-review.googlesource.com/c/chromium/src/+/2575579. Bug: 1148020 Change-Id: Ica16dac79569e241d850dc0ee79c613fc212ece8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581694 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837865}
-
Wei Lee authored
Currently the path to send broadcast when capturing only works on SWA. Since we are about to deprecate the platform app version of CCA, it is okay to only support this function on SWA but not platform app. Bug: b/173559007 Test: Manually Change-Id: Id33b6a88c4adafaf5725c5bd874b3d80166b9012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592295 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#837864}
-
Brian Sheedy authored
Removes expectations for the context_lost suite that have been determined to be stale. This only touches expectations that have passed 100% of the time on all builders. Bug: 603329, 965268, 1034008, 1155766 Change-Id: I18cbf44cff542eabf5fc40a4f716af2f04f6a1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591969Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#837863}
-
Curtis McMullan authored
This CL adds the required proto operations to request and return suggestion candidates to the IME shared library. Bug: 1146266 Change-Id: Ie3636e7ef9abf546c2e0ec5c11a8b47cd865f8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583669 Commit-Queue: Curtis McMullan <curtismcmullan@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837862}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6bf9e131d05a..0da7da798b33 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I91e0dff097d0b00f948700e88a9e5b2b5a970393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595238Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837861}
-
Koji Ishii authored
Following up a review comment in r837819 crrev.com/c/2589576 that was made after it was landed. Bug: 1154531 Change-Id: Ib2d6529646be5d4287317fd00bcd193ad10c22c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595750 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#837860}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/632a23afa487..ba158b9daf08 2020-12-16 bungeman@google.com Remove SkScalerContext::getGlyphCount. 2020-12-16 johnstiles@google.com Pass a shared_ptr to Inliner::inlineCall. 2020-12-16 reed@google.com Add filtermode to drawnine 2020-12-16 bsalomon@google.com Make backend allocation tests avoid alphatype conversions 2020-12-16 djsollen@google.com Revert "Rename getTopDevice/getDevice to topDevice/baseDevice" 2020-12-16 egdaniel@google.com GrVkRenderPass supports resolve attachments and discardable msaa. 2020-12-16 kjlubick@google.com [canvaskit] Expose sampling variants of drawImage and drawImageRect 2020-12-16 ethannicholas@google.com Tightened up SPIR-V block output 2020-12-16 bsalomon@google.com Add GrSurfaceFillContext 2020-12-16 johnstiles@google.com Improve inliner variable name mangling. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: Ifba67091b56f8b9fe563e729d2e8b9d81110f6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596381Reviewed-by:
-
Sean Gilhuly authored
deqp/functional/gles3/fbodepthbuffer.html deqp/functional/gles3/fborender/resize_03.html deqp/functional/gles3/fborender/recreate_color_00.html deqp/functional/gles3/fborender/recreate_color_01.html deqp/functional/gles3/fborender/recreate_color_04.html deqp/functional/gles3/fborender/recreate_color_05.html Bug: 1159539 Change-Id: I6fb6dc758fa7e1d4a995cbe58e52d9e0cb7f1da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595451 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#837858}
-
Mason Freed authored
The flake portal seems to indicate that these tests are no longer flaky. I'm going to re-enable them, and see if any revert to flaky. Fixed: 1043488 Change-Id: Icaa2c004a96abad5c217486a35d81117c9fb379d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594321 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#837857}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I000c8b21503db04762a8f08bc02c9339bb42a63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596380Reviewed-by:
-
David Black authored
The placeholder text needs to be updated and a chip added which allows the user to navigate to the Files app. Note that the UX spec has not yet been delivered so font sizes, spacing, etc. are subject to change. Also note that the Files app icon still needs to be plugged in. This CL also fixes some focus rings which were incorrectly colored. Screenshot: http://shortn/_0FB67SM4PA Bug: 1159527 Change-Id: I88e1e7cbc90178f558d2d3490bbd10a358f72c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596218 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837855}
-
Yue Zhang authored
Screenshot with fake data: https://drive.google.com/file/d/1X1Pwho3xM_lyHQ6zO24XcGtuG2lbnAy-/view?usp=sharing&resourcekey=0-1esda1N3RkpWE_rTqZyuDg Bug: 1157892 Change-Id: Ib3a6cb5d1cef705377d39d3e4b1fbd08df994d38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589364 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837854}
-
Xianzhu Wang authored
When mobile viewport is enabled, we have two viewports: the visual (inner) viewport and the layout (outer) viewport. The clip of the visible viewport is not in the paint property tree, so we need to apply the clip separately. The clip was mistakenly removed in crrev.com/824480. Also fix a bug before crrev.com/824480: the current scroll offset of the visual viewport was not considered when applying the visual viewport clip, which caused invisible shifts reported and visible shifts not reported. Bug: 1141739 Change-Id: I425718b1fdfb2689a7f2948c561101d0b476eb7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593180 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#837853}
-
Greg Thompson authored
FilePathWatcherKQueue::Watch uses a FileDescriptorWatcher, which requires that its callers handle spurious runs of callbacks after the watch is cancelled. If this speculative fix resolves the crash, a follow-on CL will revise the FileDescriptorWatcher documentation to make this case explicit. BUG=1156603 R=fdoray@chromium.org Change-Id: I7d5da3fb4e58cf30efab21963908b3ff41e9dc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593379 Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I18c19719e133d5c770c98cd52544e084784a3905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596419Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing GN variable is_chromeos with with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I516266244abf4f05495f690afcf330b7f28c27d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595747Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#837850}
-
Yuta Hijikata authored
This is a mechanical change that renames deprecated macro replacing: - BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}), - gn var is_{ash,lacros} with is_chromeos_{ash,lacros}. http://go/lacros-macros Bug: 1052397 Tbr: reillyg@chromium.org Change-Id: I4dfe8d18cbff8cfb1d7c251e6f0a84f6bf46cb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592079Reviewed-by:Reilly Grant <reillyg@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#837849}
-
Timothy Loh authored
This CL fixes a race that can occur in the DiskMountManager when disks are added. Since we wait for the asynchronous GetDeviceProperties dbus call to complete before updating the disk map, if the disk mount event is received too soon, we notify observers of the mount even though the disk entry is not yet created. As a result, the CrosUsbDetector cannot correctly track these entries and settings may fail to prompt the user when trying to share USB drives. The notification that a new removable storage device is added also does not appear. We fix this by deferring sending the event until GetDeviceProperties returns. I observed this race being triggered consistently on an IronKey D300s drive, which initially presents itself as a CD drive. Bug: 1146325 Change-Id: I2a6b6c352b36c1e06a7ddaa49d5b987e7458c8b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592575Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#837848}
-
yjliu authored
This reverts commit 994bc2bd. Reason for revert: I noticed there were some artifacts appearing in ChromeOS system UI (on the shelf). This was caused by double backdrop blur. Previously, damage expansion for pixel-moving filters was solely done in viz::SurfaceAggregator, which includes expanding damage with |surface_root_rp_damage|, so it didn't need damage expansion done in cc::DamageTracker, before setting |intersects_damage_under|. The change in the CL made the damage intersection check in SurfaceAggregator::Prewalk to depend on |intersects_damage_under|, this requires |intersects_damage_under| to be set correctly in cc. In other words, in cc::DamageTracker, we should expand damage by any pixel-moving filters so the damage under double blur in the SAME surface could be counted for. Original change's description: > Fixed: launcher not using backdrop filter cache when appropriate. > > Launcher has a backdrop blur filter so when there is no activity, i.e. > damage, under it, the backdrop filter cached result should be used. The > bug was caused by damage accumulation taking into account the damage > from above or on the RP with the backdrop filter. > > Change-Id: Ie98f9e4d32ec9f7b955da505276def18590a623d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494060 > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Jun Liu <yjliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821384} TBR=kylechar@chromium.org,yjliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I09f36f2b0e9f19f3450199b5da3126469bc6a2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593359Reviewed-by:
Jun Liu <yjliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837847}
-
Xida Chen authored
This CL converts this base::Closure to base::RepeatingClosure. It needs to be a RepeatingClosure because at MTPDeviceDelegateImplLinux::CreateSingleDirectory, it is used to bind twice. Bug: 1152278 Change-Id: I982c9a7ff93c9e03d27af8825034c5c0c8bbf66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595632Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#837846}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: I500612cf31a29d0529337d65eccb7724a1e20ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595925Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837845}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608119279-c2227cc33d0350f20f44d9be3f390190e6aa297e.profdata to chrome-win64-master-1608141458-dd35fe4430452753fc5df1ee6d76467993c9bca7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic7eece835f6bffb1484219b6f3126d670cfb8911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595700Reviewed-by:
-
Rahul Singh authored
This updates the expiry_milestone for the enable-desktop-pwas-app-icon-shortcuts-menu flag to M93. We'll need this flag for the upcoming macOS implementation for Shortcuts Menu. Bug: 955497 Change-Id: I03eeb5dbe27d4ce4938430a0c45cbcf276859c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595856 Commit-Queue: Rahul Singh <rahsin@microsoft.com> Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
John Palmer authored
BUG=1154591 Change-Id: I921bed5c14bdf8350b4e05d544537f012251d380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576986 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837842}
-
Nidhi Jaju authored
This CL adds an explicit [Exposed=(Window,Worker,Worklet)] declaration to the ReadableStreamDefaultController WebIDL file as it was added in a new version of the Streams spec, based on https://github.com/whatwg/streams/issues/963. Intent To Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/yZuxrW9zhAs/m/6bXDaW2mAwAJ Bug: 1093862 Change-Id: I2bd0c759d856c176037231adbe7e679ccea945c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570755Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#837841}
-
Steven Bennetts authored
This CL provides a shill error message to notifications when Connect fails with an immediate error (which does not set the Service.Error property). It also provides a message for kErrorResultNotOnHomeNetwork. BUG=1137966 Change-Id: I8982c5a0087cc4b15b36f72c3db64b16f1f6f8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575381 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837840}
-
John Lee authored
There may be a race condition for when the JavaScript to query a child in the shadow DOM of a tabstrip-tab-group element runs immediately after the test adds a tab to a group. This CL waits for the tabstrip-tab-group element to appear on the page before running this query. Bug: 1132300 Change-Id: I228f694ffeffa5c9bf303f4952fbbabef8f2334e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594507 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Yuta Hijikata authored
This is a mechanical change that renames deprecated macro replacing: - BUILDFLAG(IS_{ASH,LACROS}) with BUILDFLAG(IS_CHROMEOS_{ASH,LACROS}), - gn var is_{ash,lacros} with is_chromeos_{ash,lacros}. http://go/lacros-macros Bug: 1052397 Tbr: dcheng@chromium.org,zmo@chromium.org Change-Id: I7eff0c9e5e705fe0940e6595eb0f54de3f3bb6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592078Reviewed-by: -
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I328fb7eee3a7b1ee5da3ff153322f2630f30a47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595930Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837837}
-
Josh Nohle authored
Notably, remove the log, "Overwriting private certificates pref with X certificates." Some certificate might be overwritten but with no material changes. For example, consumed salts--used to encrypt the metadata key during advertising--need to be stored in the private certificate. That update overwrites the certificate, but the certificate remains essentially the same. Change-Id: I99b120689d1371f844dac682c2e1c398d65b4c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595191 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#837836}
-
Yi Gu authored
Bug: 1152279 Change-Id: I2e493d1bda58742080d70a3a80d2652adcd93792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594017 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#837835}
-
Gavin Williams authored
In certain languages the done title text needs to wrap, so we reduce the width to align with the buttons underneath. http://screen/5XLCiXVLPV6zxXS Bug: 1059779 Change-Id: I576acceed8eae33a4486afe8b9aee8865bf4ee7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593719Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#837834}
-
