- 25 Sep, 2019 40 commits
-
-
Pavol Marko authored
The underlying issue that has been causing many flakes here (https://crbug.com/1005082) has been fixed, so re-enable the browsertest. Bug: 1005084 Change-Id: I0147578787ca11d8ddbfd49158dfc5eda5bf8a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821482Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#699723}
-
Armando Miraglia authored
This reverts commit fea48b7b. Reason for revert: while not visible, this broke webrtc tests the 20th of August (see https://ci.chromium.org/p/chromium/builders/webrtc/WebRTC%20Chromium%20Mac%20Tester/8622) Original change's description: > Speculatively re-enable TestVideoQualityH264. > > This was reported as flaky. I am unable to reproduce, which could mean > that the issue is fixed, or it could mean that it only flakes on certain > setups (OS, builds, hardware, etc). To aid investigation I am > speculatively re-enabling it; worst case it gets disabled again. > > Bug: 754684 > Change-Id: I866679464fce4facde927652751046e062ca1c81 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761602 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#688531} TBR=hbos@chromium.org,guidou@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 754684, 1007937 Change-Id: I3c6f8954b2a007e3a1ff3ac8db154c896a4cbebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823842 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#699722}
-
Boris Sazonov authored
This CL removes a significant chunk of org.chromium.chrome.browser.invalidation Java package, as Chrome is now using FCM for invalidations. After https://crrev.com/c/1763755, ChromeInvalidationClientService is no longer created and can be safely removed. Bug: 1002894 Change-Id: Ia2c2e4613c2c40b456cef97a83cff93c7f21fc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821784Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699721}
-
Finnur Thorarinsson authored
This reverts commit 3594437b. Reason for revert: One or more of these tests have been consistently failing on the android-asan bot, since build 2270 (https://ci.chromium.org/p/chromium/builders/ci/android-asan/2270): PooledSharedImageVideoProviderTest.RequestImageRequestsMultipleImages PooledSharedImageVideoProviderTest.GenerationIdChangeEmptiesPool PooledSharedImageVideoProviderTest.RequestImageReusesReturnedImages PooledSharedImageVideoProviderTest.SizeChangeEmptiesPool ... with errors such as: [ RUN ] PooledSharedImageVideoProviderTest.RequestImageRequestsMultipleImages ================================================================= ==7769==ERROR: AddressSanitizer: heap-use-after-free on address 0x5ac43bfc at pc 0x94420df5 bp 0xbeb47190 sp 0xbeb4718c READ of size 4 at 0x5ac43bfc thread T0 (st:test_process) Original change's description: > Pool SharedImageVideo for MCVD. > > To reduce thread hops when generating VideoFrames, this CL adds > PooledSharedImageVideoProvider. It builds on the direct provider by > maintaining a pool of SharedImageVideo objects, which it hands out > on its own thread to clients. > > It also adds histograms to track VideoFrame creation time, so that > we can see which device(s) benefit from pooling. > > All of this is turned off by default; it must be switched on by > enabling UsePooledSharedImageVideoProvider. > > Change-Id: I4cfc03938dd4717252f3f527a3bcab0e7ae085a9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699138 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: vikas soni <vikassoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#698985} TBR=mpearson@chromium.org,sandersd@chromium.org,liberato@chromium.org,vikassoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic1d1b26dfa33eeabc49af497d58259b45607ee14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824081Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#699720}
-
Maksim Sisov authored
Wayland compositor provides supported format modifiers. Store them along with buffer formats and provide the WaylandBufferManagerGpu with them during initialization step. Then, GbmPixmapWayland can just use them if they are set. Bug: 1002463 Change-Id: I97f6367ad9315e3e22b0f9f37c8f1aec03df07a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795326Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#699719}
-
Sigurd Schneider authored
This CL enables the coverage model to keep polling the back-end for coverage data while performance tracing is enabled. Bug: chromium:1004203 Change-Id: I187afa45dadae3aac0d5012fa8a293eb26d438fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814825Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#699718}
-
Christian Dullweber authored
Add a FeatureParam to the ImprovedCookieControls experiment to control the value of the default setting. Bug: 967668 Change-Id: If695b80e2e4e0f48c180530c4e9682f7d2b4d882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824465Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#699717}
-
ckitagawa authored
Add data structures for tracking glyph usage. There are two variants sparse and dense and which one is used should depend on the font being subset, this can be done heuristically before starting tracking to minimize memory overhead. Part of landing: https://chromium-review.googlesource.com/c/chromium/src/+/1786583 Bug: 1006242 Change-Id: I251fae2270386ea0279268db4ffef8e98942e278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816440Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#699716}
-
Ioana Pandele authored
Bug: 986298 Change-Id: Iccb2f8722e09362f9c32ad496688876fe1141bf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821723Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#699715}
-
Paul Irish authored
Change-Id: I31caa742e32727fcdd3c992fca0f815fefbf9740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818609 Auto-Submit: Paul Irish <paulirish@chromium.org> Reviewed-by:
Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/336bd791..87177fcb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I42f93221a33e872d33df22a0628c53fde53cf41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824977Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699713}
-
Boris Sazonov authored
Activity instance was used before to check sign-in UI visibility and showing dialogs. These dialog have since been removed, so the Activity parameter can be removed to simplify the code. Bug: 1007332 Change-Id: I2e338a555dbd57b06a29697581b16f5ef4b7313d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823078 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Eric Stevenson authored
Previously, the "repackage_native" target was providing the GEN_JNI class. When there were multiple deps containing this class, zip.py would just choose the first one. This works right now because it grabs //base_java's GEN_JNI and the only dep of cronet using proxy natives is //base_java. To allow more deps to use proxy natives, this CL adds a couple sub-targets that are responsible for including the correct version of GEN_JNI. Bug: 929661, 1005836 Change-Id: Ifbcba3c012e7191be8ca410f4e8789ec791eac6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811974 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#699711}
-
Karolina Soltys authored
Bug: 968047 Change-Id: I0e48308bfdb555d34d0dcbff57ff82b30e29d8a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742163 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#699710}
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. Bug: 941669 Change-Id: I4a423a71375fd4d8cfc8283dd2703855781ece6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818519 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#699709}
-
Jan Scheffler authored
Until now, selected but not focused items with a network error in the network pane where not distingushable from items without a network error. This patch fixes the problem by keeping the font red. Bug: chromium:843014 Change-Id: I66b3d1b6466120beb13ad4380c44a8e94971c0f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821783Reviewed-by:
-
Mark Cogan authored
The tab grid contains a scroll view holding three view controllers (the incognito tabs, the regular tabs, and the recent tabs). By default, all of the contents of a scroll view can be read and navigated via VoiceOver. For the tab grid, only the view controller which is currently visible (the "current page view controller") should be exposed to VoiceOver. The logic to manage this is (prior to this CL) mostly in TabGridViewController's -setCurrentPage:animated: method. If one of the view controllers that's not visible in the scroll view has its contents focused with VoiceOver, the scroll view will show the focused content without triggering any of the other scrolling behavior. In the tab grid, this means that the page control will go out of sync with the page being displayed (which may lead to consistency DCHECKs or other problems). There were at least two bugs in this code. First, the first time the tab grid is entered, if the user navigates to the right (in LTR) in VoiceOver, they will focus the first line of text in the Recent Tabs view controller. As far as I can tell, this bug hasn't been reported. Second (crbug.com/980844), if a user is in the tab grid when they close the last incognito tab, they will switch to the regular tabs page, but the in- cognito tabs page will have its text focused and visible. Both bugs arise from the accessibilityElementsHidden property of the non- current view controller not being set to NO at the correct time. For the first bug, this is a matter of setting all non-current view con- trollers to be invisible as part of -viewDidLoad. For the second bug, the general pattern was to set the value of _currentPage and then set self.currentPageViewController.view.accessibilityElementsHidden to NO. However, when the scroll view is scrolled with animation, _currentPage is only set when the animation ends, and -setCurrentPage:animated was marking the current view as non-hidden immediately, not when the animation completed. This means that (in the case of this bug) the incognito view controller was re-marked as not-hidden, and the regular tabs view controller remained hidden. The fix in this CL is to replace direct writes to _currentPage with a property setter that always marks the prior page view controller as hidden-to-VoiceOver and always marks the new current page as unhidden. Since this setter used to induce scrolling (which itself needed to update the current page), scrolling has been pulled into an explicit -scrollToPage:animated: method. The currentPage property no longer scrolls implicitly, and is now usually set as a part of scrolling. Bug: 980844 Change-Id: I7ccb904442a55d791df95ab4c0c8c2795a6c74e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813332 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699707}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b27dd1ff740..53bdbb292b71 git log 0b27dd1ff740..53bdbb292b71 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 lalitm@google.com trace_processor: refactor tracks to reflect final design Created with: gclient setdep -r src/third_party/perfetto@53bdbb292b71 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627 Change-Id: I1ff52381de3c2f38efbcd5ad7ac29d26aea8e5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699706}
-
Jan Krcal authored
This CL adds back a test that was removed by crrev.com/699666. Bug: 881289 Change-Id: Iec9e4865a331ee5964c9855d5c648d9ca07fa0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824461 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3a762d54f649..527a689307a4 git log 3a762d54f649..527a689307a4 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 alanbaker@google.com Remove validate_datarules.cpp (#2911) 2019-09-24 stevenperron@google.com Handle extract with no indexes (#2910) 2019-09-24 ehsannas@gmail.com Add Bazel build configuration. (#2891) 2019-09-24 stevenperron@google.com Handle id overflow in convert local access chains (#2908) 2019-09-24 dsinclair@google.com Add OpCopyMemory test to SVA. (#2885) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@527a689307a4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: I5dd3b40bb0559e40839e3f9de499fa28bce0872f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824652Reviewed-by:
-
Marc Treib authored
Sync.LocalDataFailedToLoad and Sync.LocalModelOutOfSync aren't needed anymore. Even though they were set up as per-data-type histograms, they were both only recorded for one data type (passwords and bookmarks, respectively). They were also only recorded for the old pre-USS implementation of the data types, which is not used anymore and will be removed soon. Bug: 935926 Change-Id: Ice9778906082acb1cccf46cecc04f2064a7a424e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824883Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#699703}
-
Julie Jeongeun Kim authored
This CL converts ChannelPtr, ChannelRequest, ChannelAssociatedPtr, and ChannelAssociatedRequest to new Mojo types using PendingRemote or Remote, PendingReceiver, Receiver, PendingAssociatedRemote or AssociatedRemote, PendingAssociatedReceiver and AssociatedReceiver. It also updates OnConnection from secure_channel.mojom. Bug: 955171 Change-Id: I6065f8208a2a79316f812e9f48af6b3b88240e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819288Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699702}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8548fb8c. With Chromium commits locally applied on WPT: d4ca0e6e "Add missing worklet referrer tests" a0586590 "Don't fold SaveAlphaLayer into DrawTextBlob" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I470dd44d2b2d2c1924eaa6259c56d3167ccdbdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823984Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699701}
-
Marc Treib authored
This has been deprecated since 2010; no need to keep the proto fields around any longer Bug: 950904, 860643 Change-Id: Iba066a497901f016c8f4f2e39b7855a21efe2287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823839Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#699700}
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. Bug: 941669 Change-Id: I6aece261941a1a10fbc329bc4ac1012a9a06ebd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818518 Commit-Queue: Raul Tambre <raul@tambre.ee> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/84004c441c75..70bc753cc6c6 git log 84004c441c75..70bc753cc6c6 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 asapersson@webrtc.org Add comments to MultiCodecReceiveTest. Created with: gclient setdep -r src/third_party/webrtc@70bc753cc6c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: Ib10671e52fc7b6c7ab344f241b7f236d82313a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824898Reviewed-by:
-
Richard Knoll authored
Extracts SharingUiController::App into a separate file to make includes easier. Also cleans up overrides in SharingDialogView. Bug: None Change-Id: I99cec881b51a4218e4681f05a8ad494ed8b3d11a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823837 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#699697}
-
Julie Jeongeun Kim authored
This CL converts SubscriberPtr and SubscriberRequest to new Mojo types using PendingRemote or Remote, RemoteSet, PendingReceiver, and ReceiverSet. It also updates RegisterSubscriber, Connect, and Clone from app_service.mojom. Bug: 955171 Change-Id: I3de5fe264d54ba707966f5cecde4c9d0778c6911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821498Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#699696}
-
Mohamed Amir Yosef authored
After recent refactoring, the method isn't used anymore. Change-Id: I5d95b050035202fadfbfc69505dc6e9c1ecd3073 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821722Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#699695}
-
Martin Šrámek authored
...by actually waiting for the cache entries to be written, rather than relying on a short timeout. Bug: 911171,978891 Change-Id: I59294b8009ab23d08ec09561184df3e04252dd85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821720 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#699694}
-
Imranur Rahman authored
method. stream_metadata and stream_data were intended for some sort of "streaming response" mode. But it was never used. So, we are removing the unnecessary fields and corresponding proto messages. Bug: 1007190 Signed-off-by:
Imranur Rahman <i.rahman@samsung.com> Change-Id: Ic3cfca34f1d4cf20472b9d40b8a0ab314ca84983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821500Reviewed-by:
-
Anqing Zhao authored
Add a new policy 'DeviceLoginScreenSystemInfoEnforced' to control the behavior. This setting will be checked in 'VersionInfoUpdater'. Bug: 859298 Change-Id: I06ad06c485feaf7cc23c1067a4047fa1e21070cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806460 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#699692}
-
Petr Smirnov authored
Add VersionUpdater member GetEolStatus to check if device is in end-of-life state. Bug: 1005151 Change-Id: I23655afa42dfff744bc93b90fcd59a140d7d695d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807229Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Petr Smirnov <petrsmirnov@google.com> Cr-Commit-Position: refs/heads/master@{#699691}
-
Roman Aleksandrov authored
Detect license existence and save it inside EnrollmentConfig for further use in wizard controller and OOBE screens. Test: unittested by these "*AutoEnrollmentClientImplTest*" tests. Bug: 871207 Change-Id: I52c644c80ec3175c3d1efb9ee13e696b9f500b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782175 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
This reverts commit 1d2c953e. Reason for revert: This is somewhat speculative, but ever since this change was introduced, bot "Builder Linux Tests (dbg)(1)" has been failing on every run. The CL for the failing test talks about Perfetto and tracing, so this CL seems like a likely culprit. [12707:12707:0924/154115.904192:FATAL:privacy_filtering_check.cc(48)] Unexpected field in TracePacket proto. IDs from root to child : 8 #0 0x7f66c614a14f base::debug::CollectStackTrace() #1 0x7f66c5e7cecd base::debug::StackTrace::StackTrace() #2 0x7f66c5e7ce88 base::debug::StackTrace::StackTrace() #3 0x7f66c5ece649 logging::LogMessage::~LogMessage() #4 0x5651bc1aac57 tracing::(anonymous namespace)::VerifyProtoRecursive() #5 0x5651bc1aa9da tracing::(anonymous namespace)::VerifyProto() #6 0x5651bc1aa7d2 tracing::PrivacyFilteringCheck::CheckProtoForUnexpectedFields() #7 0x5651bbb57f38 content::ProtoBackgroundTracingTest_ProtoTraceReceived_Test::RunTestOnMainThread() #8 0x5651bd505564 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() Original change's description: > Add metadata at beginning of trace for discard buffer mode > > Trace metadata is almost always discarded in discard buffer mode of > perfetto tracing. For this case, add metadata at beginning of the trace. > Handles cases when generators are added while tracing. > > Change-Id: I911794fba1e7b460ca1a7a3a54599a8c05678d75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1812248 > Commit-Queue: ssid <ssid@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699493} TBR=oysteine@chromium.org,ssid@chromium.org,eseckler@chromium.org Change-Id: I98fdb75be1a0582ab1a196c66dd74213aeced90b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823861Reviewed-by:
-
Mohamed Amir Yosef authored
This was to support the fill-on-select experiment. The current UI is very hard and will mostly not going launch. This CL is replacing the behavior of opening of prompts on page load with existing Fill on account select behavior (which is already working on PSL matching and http forms). Using the existing behavior has multiple benefits: 1.decrease maintenance cost 2.ensure that this feature works 3.collects UMA on using this feature TBR=mkwst@chromium.org,vasilii@chromium.org Change-Id: I7a0b19dd18a56ae86712b34429023c96ceab9404 Bug: 949519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821524 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Fredrik Söderquist authored
Move common (or to-be-common) code into a new TransformHelper class. This class contains logic for computing the reference box as well as the transform based on computed style. Also move the other transform-related helper SVGTransformChangeDetector to this new location. Some to-be-common code is moved from LayoutSVGShape to the super-class, for reuse by LayoutSVGImage. In LayoutSVGShape, set the |transform_uses_reference_box_| flag on style change rather than during layout. Bug: 1007146 Change-Id: Ie61537126a488a5c6c91cf416351ec2e28c692c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821919 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#699687}
-
Jit Yao Yap authored
Change-Id: Ibda3d1206b5fb5923914c0d6d2a8152681a87e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816538Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/942786e2..336bd791 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8b57ce3b3ae815ebfea9aacca94dee089058ba37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823983Reviewed-by:
-
Alex Clarke authored
We wish to prioritize loading and compositing tasks till FCP, but that changes the order in which the task posted by AudioWorkletObjectProxy::DidEvaluateModuleScript runs in relation to other loading tasks (it's called by WorkletModuleTreeClient::NotifyModuleTreeLoadFinished). Changing this task to be TaskType::kInternalLoad preserves the original order with the new scheduler policy. Bug: 971191 Change-Id: I1d80a9c7dd7e9c97b7303b087506caa9e51981d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819255 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#699684}
-
