- 23 Jul, 2019 40 commits
-
-
Jack Steinberg authored
Bug: 972945 Change-Id: I1fb8f40b491fa86aa1e11fe7764446da110dcc32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713387 Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#680143}
-
rbpotter authored
This allows running: python polymer_test.py from tools\polymer to pass on Windows, and prevents ..\js\paths\like\this.m.js, which cause a parsing error. Bug: 965770 Change-Id: I23701cffeab4ef5bf7d61bb06307b6fe8a9e17e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715147Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#680142}
-
Brian Sheedy authored
This reverts commit ac8fe0e9. Reason for revert: crbug.com/986879 Original change's description: > android: Reintroduce and rework ModernLinker. > > This is partially a revert of two commits: > - 53a10113: "Delete unused file: > base/android/linker/android_dlext.h" > - fdb31883: "Use the LegacyLinker instead of the > ModernLinker" > > ModernLinker has been reworked, especially the native side. Notable changes: > - The library is only loaded once, not twice in the browser process > - Relocations are always shared between the browser process and the other ones. > > This is enabled only on N+ for Chrome.apk, neither for Monochrome nor for TriChrome. > > on Q, further commit will trim it as well. > > Binary-Size: Increase due to bringing back ModernLinker. Required to save memory > Bug: 979638 > Change-Id: Ia76773b58a71854a36ea49ab82daef1af717b606 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683245 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679535} TBR=pasko@chromium.org,yfriedman@chromium.org,agrieve@chromium.org,lizeb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 979638 Change-Id: I431aa2011c4a0c4b23b725099e414a52443778f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715745Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#680141}
-
Henrique Ferreiro authored
After the IdentityManager code restructing into public and internal APIs was fixed in https://crbug.com/952788, this CL fixes the build dependencies in //chrome/browser. Bug: 970268 Change-Id: Ic3a2a2bcf41685bf409ce5bc044e15e2dd148e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712871Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#680140}
-
Andrew Luo authored
Bug: 924194 Change-Id: Id53cdc9890977de6e8d58940b53eeea79833c426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684972 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#680139}
-
Avi Drissman authored
Reuse the PWA intent picker for the UI. BUG=981337 Change-Id: Ib4956fb0218d9d6055c315a4fcb579094ea0daec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703487 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#680138}
-
Clark DuVall authored
ProfileSyncService may not be created if a command line flag turns off sync. In this case, ProfileSyncServiceFactory::GetForProfile returns null and crashes when IsSyncFeatureEnabled is called. Bug: 978617 Change-Id: Idb381a82008065427d67d87583f56eca9d1e9606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715094 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#680137}
-
Hesen Zhang authored
- Simple implementation with only one icon, need to complete logic with multiple icons. - Still working on unit test. - Didn't implement Load Icon in this CL: logic is more complex than I thought and will have a single class like IconLoader to deal with. TBR=dtrainor@chromium.org Bug: 963290 Change-Id: Iec98897afbcfca3ea5ea3f24cb76d870f413b5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707032 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#680136}
-
rbpotter authored
Port tests for the shared JS resources migrated to modules in https://crrev.com/c/1682889. Note: Tests only run if optimize_webui is false, since these resources only exist in this case. Bug: 965770 Change-Id: Ia45584f59617165b3d230d551351ea51f3385add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703424 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#680135}
-
Clark DuVall authored
This started flaking after WebRequest was moved to UI in http://crrev.com/c/1682434. Previously, we got lucky that the beacon requests from unloaded frames came in before the FrameData was removed from the frame data map, since WebRequest could grab the FrameData on IO before the beacon request started. This CL stores recently deleted frames, and posts a task for the removal of the deleted frame's FrameData so we have access to it when the beacon request comes in. Bug: 522129, 980774 Change-Id: I1fa0d16d52c52cf61d1095588882170b48ab3e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713864 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680134}
-
ssid authored
Startup tracing started by flags can be aborted or sometimes never owned if the service doesn’t request. In this case tracing must be stopped in all processes. So, set a timeout for 10 seconds and cancel tracing if no clients claim the trace data. Change-Id: I330491382c8c6973d9763db92a814ab8a9b7920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666694Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#680133}
-
Jeremy Chinsen authored
Currently draw_utils::GetSurroundingRect() takes a pp::Rect object and uses only the y-component and height, which means it uses only half of the structs attributes. This refactor makes it so GetSurroundingRect() just takes |page_y| and |page_height| as individual int values, reducing the amount of unnecessary data sent. Change-Id: Ie201b4e2d5d6f3c246173782af43cb44890014ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715789Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#680132}
-
Nicolás Peña Moreno authored
This CL adds 'largest-contentful-paint' to PerformanceObserver's supportedEntryTypes, and adds a test. It also fixes a typo in the LayoutShift supportedEntryTypes test title. Bug: 965505 Change-Id: I6954f8abbdf27640413d790e05ff72aa945a248b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713295 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/84bcd0c3ae08..15baa953a54e git log 84bcd0c3ae08..15baa953a54e --date=short --no-merges --format='%ad %ae %s' 2019-07-23 mtklein@google.com only need to hoist one register per tbl imm 2019-07-23 robertphillips@google.com Address TODO in testing code (i.e., cleanup create_backend_texture) Created with: gclient setdep -r src/third_party/skia@15baa953a54e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I56ba9da4bf4b2219dcff5233e354497a62fa233f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680130}
-
Shakti Sahu authored
This CL creates a ThinWebView class that can display a WebContents on an android surface. It also provides method to the user to attach a ContentView that can be used to provide user interactability. Bug: 980323 Change-Id: If99b98b695a512daa693c343c07ba4717af6ca52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684331 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#680129}
-
James Forshaw authored
This CL removed the old wrapper for RegDeleteKeyEx which was used for compatibility with Windows XP. As the code base is only supported on Windows 7 and above this function can be statically linked. Bug: 986625 Change-Id: I46814d7758948c371de42f66a6e9e96e4a6bfb87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714289Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#680128}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/109b30b3..4d5a1973 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If655c7b2a98c33b80b969e6d2b3e4eec10b0d952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715406Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680127}
-
Ted Meyer authored
Also moved the trace event to GetResolutionsForDecoders so that when it is refactored, performance can be measurably improved. Change-Id: Ia0d8808aac8962fde5a45753933672b49900d429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705034 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#680126}
-
Alex Cooper authored
The xrWebGLLayer tests didn't have their expectations wrapped in t.step so their failures were reported as timeouts, rather than the actual error. xrWebGLLayer_viewports expected the device init viewport to match the output viewport, which is not a specced behavior, and contradicts the webxr-test-api spec which calls this out as unsupported, so that part has also been reverted. Bug: 986672 Change-Id: I23713956f6b0bd3d432f0e6e6fdc9d015d509099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715237 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#680125}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0a30c29ba846..3d61312959f3 git log 0a30c29ba846..3d61312959f3 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 tsepez@chromium.org Remove xfa/fwl dependence on xfa/fxfa/parser 2019-07-23 tsepez@chromium.org Remove fpdfdsk/pwl dependence on core/fpdfapi/page 2019-07-23 tsepez@chromium.org Remove circular includes from fpdfapi/font to fpdfapi/page. 2019-07-22 tsepez@chromium.org Remove knowledge of CPDF_ImageObject from fpdfapi/font layer. 2019-07-22 tsepez@chromium.org Use CPDF_Type3Char::FormIface rather than CPDF_Form in cpdf_type3font.cpp Created with: gclient setdep -r src/third_party/pdfium@3d61312959f3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ia43bc2f2fb1c770179b920eecf70482c60b84c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715788Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#680124}
-
Kyle Milka authored
Remove some unused CLASSES and move the remaining one to the file it's actually used in. Set the text label via replacements instead of in javascript. Bug: None Change-Id: I72896252332507854930ad2aa6a682f2ff81495d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715108Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680123}
-
Yann Dago authored
Bug: 982371 Change-Id: I3442efe051902541697c7f2499e63ab06e0d1361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713365Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#680122}
-
Robert Ogden authored
Bug: 985099 Change-Id: Id125845b72a84101451e1d100432e6e470457c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715723 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#680121}
-
Owen Min authored
The report size estimate depends on an assumption that full Profile report is much larger than the basic one. This is not true for the test which causes one of the test flaky. Adding more things into Profile to make the test more close to the real world. Bug: 956237 Change-Id: Idd66ed699362628d0ebd7b2322efd6e960c00d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713254Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#680120}
-
Yi Gu authored
target_location has a value only if the target exists. When it doesn't we early exit the DispatchMouseEvent(). In addition, we should skip setting the mouse_down_post_transformed_coordinate_. Bug: 985692 Change-Id: I4cd4dad3b1caefaf2bd7e81660e257a4bdb5fdfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715227 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680119}
-
Kristyn Hamasaki authored
Ctrl+Shift+R locks bubbles from closing and allows bubbles and their elements to be inspected. Change-Id: Iba876a5dcc78324be4750823f6f53a307559bdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703459 Commit-Queue: Kristyn Hamasaki <khamasaki@google.com> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#680118}
-
Nicolás Peña Moreno authored
This CL replaces responseEnd with loadTime in ElementTiming. Before, responseEnd would be used and would be problematic for memory cached images and for inline images (data scheme). We change it to loadTime, the time at which LayoutObject::ImageNotifyFinished is called. This is the same time as when LargestContentfulPaint computes loadTime. As they are both under runtime flags and the hooks are not unified, for simplicity we compute the timestamp again. This will not be too expensive for ElementTiming, as the timestamp is gated on the existence of the elementtiming attribute. To store the loadTime, we change images_notified_ to be a HashMap which now stores the timestamp corresponding to loadTime and whether the image has painted (after being loaded). Bug: 982046, 879270 Change-Id: I69da42c9250cc36c567df5da285ef1a9a357b554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710840 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#680117}
-
Asanka Herath authored
This change uses the plumbing introduced in prior CLs to perform detailed logging of GSSAPI library invocations. R=eroman@chromium.org Bug: 884313 Change-Id: Id010fda54f32691a092edd97385470502d18d15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698942 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#680116}
-
Meilin Wang authored
Delete kAssistantKeyRemapping feature flag and chrome flag since this feature has been launched. Bug: none. Test: local compile and manually test. Change-Id: Ieb8781dbb60c4ec7049c666ce05f0ce100695ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715095Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#680115}
-
Jonah Ryan-Davis authored
Recent ANGLE patches have gotten two tests to pass on all platforms: conformance/glsl/misc/shaders-with-invariance.html conformance2/rendering/blitframebuffer-size-overflow.html Bug: 830046 Bug: 980675 Change-Id: I94dbd1d5567a0524aa0e0ecc23268e390cd99816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710200Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#680114}
-
Josh Nohle authored
Adds fake implementations of CryptAuthGroupPrivateKeySharer and CryptAuthGroupPrivateKeySharerImpl::Factory for use in unit tests. Bug: 951969 Change-Id: I27a281f7f9985021c6820400e0788f7df7ed16e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713292 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#680113}
-
Takuto Ikuta authored
Main purpose of this roll is to confirm that GN built on Xenial by os upgrade in https://gn.googlesource.com/gn.git/+/431bbf510dec8e10f607f7fff3f80a1ae84a737f works on Trusty builder. https://gn.googlesource.com/gn.git/+log/972ed755..152c5144 152c5144 Update and add metadata documentation 579b5b39 Move 'rust_example' to the toplevel 'examples' folder 61be3f2e Fix desc to handle single-value outputs correctly bf27729d [rust] Update RustTargetGenerator to not duplicate work 4c0c60eb Move examples to toplevel, document better. c4a88ac9 Allow crate type to be set on all Rust targets 23d22bca [docs] : fix typo 'then' => 'they' and re-generate 'reference.md' 3b5fa962 [docs] : add Markdown format for '--time' 9edc6c08 [docs] : clean up cross_compiles.md d3304fbb [docs] : fix typo sone => some fe0c6bbb Write depfile for non-C-like tools f898ccf7 Fix linking deps propagation 445ac323 [docs] GN can tell empty lists from non empty lists 3ddcc49a Fix build with GCC on FreeBSD Bug: 981741 Change-Id: I062d6b21d3955cd0a2773321b4f68056972f8950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714681Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680112}
-
Cammie Smith Barnes authored
We add DCHECKs to CreateNetworkFactory(...) for PlzDedicatedWorker to ensure that the render frame host exists, in order to help de-flake the following webkit_layout_test: virtual/omt-worker-fetch/external/wpt/fetch/api/request/destination/ fetch-destination-worker.https.html We also change the erroring out and early return in DidStartScriptLoad(...) before the call to CreateNetworkFactory(...) to the condition when |ancestor_render_frame_host| is null, rather than merely when |worker_process_host| is null. Bug: 910713 Change-Id: I471e6393392423fce736a0ef16442222629ca613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699379 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#680111}
-
Xiyuan Xia authored
LoginDisplayHostWebUI does not need to wait for wallpaper initial animation since it has no visual change (It goes from white boot splash screen to white oobe wallpaper with brightness+gray filter). Make LoginDisplayHostWebUI always create a hidden webui and show it when webui signals ready or has network errors. Bug: 985515 Change-Id: I210ac98890e908ac4381371cba686b6283297824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710000Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#680110}
-
Takuto Ikuta authored
This is for faster compile step time by dropping debug symbols. Higher symbol level seems to cause slow link time. e.g. https://chromium-build-stats.appspot.com/ninja_log/2019/07/23/win-chromium-compile-dbg-ng-37-nyxn/ninja_log.win-chromium-compile-dbg-ng-37-nyxn.chrome-bot.20190723-064013.9724.gz/trace_sort_by_end.html from https://ci.chromium.org/p/chromium/builders/try/win_chromium_compile_dbg_ng/347566 Bug: 794423 Change-Id: I393d5aae685fba158e7c4be7d7f25ab79b46dd7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714371Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#680109}
-
Tina Wang authored
Fix nits to make code clearer. Bug: 980277 Change-Id: I08c6f04fba7e78482f01fbd5ed5f6a0b1eb09a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706556Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#680108}
-
Nick Diego Yamane authored
XEventDispatcher implementation *can* optionally be associated to a PlatformEventDispatcher, however in most cases it is not the case and 3 methods must be overridden with a empty/stub implementation. This CL changes XEventDispatcher, adding default empty implementation for PlatformEvent-related functions, making it easier and more intuitive implementing it. Bug: 789065 Change-Id: Icdb501133817038a536b108f8a0d8556ff3389f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710242 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#680107}
-
behdad authored
The name used for SubmitCompositorFrameToPresentCompositorFrame was not compatible with the code and has been changed to SubmitCompositorFrameToPresentationCompositorFrame Original CL added this histogram: https://chromium-review.googlesource.com/c/chromium/src/+/1672201 Bug: chromium:963778 Change-Id: Iaaace499606d7f896b0b9b5e38e13948655985a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715545Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#680106}
-
Kyle Milka authored
These are in doodle.js and unused in local_ntp.js Bug: None Change-Id: I967f1f27a1ab7bc136c561d320282613d5b72f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715717Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#680105}
-
Gayane Petrosyan authored
Sample screenshots: https://screenshot.googleplex.com/H1mkRMhHjAT.png https://screenshot.googleplex.com/eQpbkh9vQaO.png https://screenshot.googleplex.com/3sfoZP8NaSa.png Change-Id: I78cea0e8a387dcd3bc7aa1fe0396672e79fe7463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714219Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#680104}
-