- 13 Jul, 2020 40 commits
-
-
Yunke Zhou authored
User is not able to click on the text to toggle the checkbox Bug: 1103513 Change-Id: I8d71fb4eaaad1130938d2b316202003937f5b2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289427Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#787683}
-
Christian Dullweber authored
Add preference for a cookies view in page info. Screenshot: https://crbug.com/1077766#c16 Bug: 1077766 Change-Id: I197782a86b9cb5bd608e4ce036bed99ac463706f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274623Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#787682}
-
Stephen Nusko authored
Bug: 1104211 Change-Id: Ib91c163e6e1b7c158f675bc2adbf2d66a950d038 No-Try: True TBR: johnchen@chromium.org CC: mythria@chromium.org,tmrts@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292281Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#787681}
-
sandromaggi authored
This CL allows to clear a field instead of filling it. It will behave the same way as filling a field in regards to the |forced| flag, i.e. if the field is already empty (and we don't force it) we don't do anything. The field is, in the end, checked for emptiness. Non empty fields with the |clear_value| flag will fail the action. The |clear_value| flag should only really be used for <input> fields. It can work with <select> as well (setting the value attribute) but this is not guaranteed to actually empty the field (if the default has a different value). The flag does not work in combination with |fallback_click_element| at all. Bug: b/160850266 Change-Id: Ib170ee0f3e6931ad5f09a1664548c492e260e52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289779Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#787680}
-
Nidhi Jaju authored
Bug: 1095896 Change-Id: I6b799e6b02c7073b130b4046cc83941c0a00c154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294759Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#787679}
-
Hidehiko Abe authored
Now we have at most one lacros-chrome tree at a time. Defer the log file renewal to the lacros-chrome. Bug: None Test: Launch lacros-chrome locally, and log file is renewed. Change-Id: I3fad92681fd7600997b0924f49924c237caa6d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280804 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#787678}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/94667fbf66ee..40c3c1cace0a 2020-07-12 vasniktel@gmail.com spirv-fuzz: TransformationAddSynonyms (#3447) 2020-07-11 vasniktel@gmail.com spirv-fuzz: Remove unused functions (#3510) 2020-07-11 vasniktel@gmail.com spirv-fuzz: Minor refactoring (#3507) 2020-07-10 greg@lunarg.com Preserve OpenCL.DebugInfo.100 through elim-local-single-store (#3498) 2020-07-10 jaebaek@google.com Preserve debug info in vector DCE pass (#3497) 2020-07-10 stefano.milizia00@gmail.com Implement transformation to record synonymous constants. (#3494) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I571db35cc9668eb6e3f0f7f0d9e358bfb6bc3666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787677}
-
Ilia Samsonov authored
Bug: 1068400 Change-Id: Ib39f6657e9df0d683521a59a6476bea4903b2f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288327Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787676}
-
Jakob Ivarsson authored
Intent to experiment: https://groups.google.com/a/chromium.org/g/blink-dev/c/Mt9GmmF-Vwc/m/G4EhuBsdBQAJ Bug: 1086942 Change-Id: I5453997dd00746e42aac1b9941f1eabf4905b07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266172 Commit-Queue: Jakob Ivarsson <jakobi@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787675}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594611817-3939336dc9344e90c2a5b4af88e6cee72fe360b0.profdata to chrome-win32-master-1594619844-d5053288f580f604630f8165bdd4c71186bbf354.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I407f9a89adbc5c0411c970d46eca730b82023513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294698Reviewed-by:
-
Swapnil authored
ExtensionInstallEventLogManagerWrapper is a class which observes the pref that indicates whether to log events for extension installs. Add unit tests for this class. Bug: 1103237 Change-Id: Ia1b21d3bd40944d53b62c5177ccfda53b7859892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289422Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#787673}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594598363-93f916054c84cb07f9e79c6e6fd62a54f73f0a49.profdata to chrome-win64-master-1594619844-5466e7844d9f3c0d4a095c9938c9765c2c3181c8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I3f72fcbd3a758c29049982122deefe8744f16f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294719Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "undo-iframe-location-change.html" to use |async_test()| to test content document of <iframe> before/after navigation. Before this patch, "undo-iframe-location-change.html" doesn't finish w3c test harness correctly because main document is reloaded during testing. Bug: 1104693 Change-Id: Iccc6d3189d721d1a5b92f882c5c171f8b4b87bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291926 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787671}
-
Yuki Shiino authored
Implements/ports tkent[1]'s binary size optimization of [CEReafctions, Reflect] attribute set callback in the new binding generator. The APK size reduces by about 52 KB. [1] https://crrev.com/c/1732676 Bug: 839389 Change-Id: If485747158ffb4307d5f20e21a1aba807af45ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291820 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#787670}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88e5b1f40c89..570934c3dab2 2020-07-13 dberris@chromium.org debt: Reduce special case list in isolate mappping If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:950165 Tbr: nuskos@google.com Change-Id: Id4bb16b291d68bd09b15bbfbbb4fc4de7d987b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294721Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f675314f19f..ef4cb58b72bb 2020-07-13 alexrudenko@chromium.org Update CDP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I99cb3219c88e52107e80125023b12d92cce0885a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294723Reviewed-by:
-
Hidehiko Abe authored
Lacros-chrome starts to provide a way to open a new window. This will replace "IPC based on process launching". The API in lacros-chrome called by ash-chrome should be rare, but this is one of the exceptional cases. Bug: 1094106 Test: Ran locally. Manually opened the multiple windows via launcher. Change-Id: Iba6ccfb7acdc97837d44a176eb4d163524811590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280803 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/206886948ad5..4e13c90944e9 2020-07-13 cepheus@frii.com Fix #2329: don't use invalid initializers. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I9a3a35948e7ccb429c4f9cdc571dfe388d7cb0a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294690Reviewed-by:
-
Kent Tamura authored
We missed to call SetOrthogonalFallbackInlineSizeIfNeeded() for LayoutNGRubyText. Bug: 1102186 Change-Id: Ia060b794f13dc51e03c7f715b8d307220b7f5f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291923 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#787665}
-
dpapad authored
WebUI Gzip/compression related documentation is quite obsolete and does not reflect the following (not so recent anymore) changes: - compress="gzip" is the default behavior for HTML, JS, CSS and SVG files. - The UseGzip() C++ method no longer exists (as it is not necessary). Bug: 1068407 Change-Id: I36be8895abd5b115c07a40d094e52d00efb9d764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290997Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#787664}
-
Omer Katz authored
This CL deals with 2 issues in ListHashSetNode: Tracing ======= ListHashSetNode::Trace traces the node's value and the next_/prev_ nodes. The next_/prev_ nodes are written to atomically but do not have a write barrier. That means that if we rely on these references to retain the nodes, we can have races in incremental marking. In practice, nodes in the set are retained by the backing HashMap. Tracing a ListHashSet traces the entire HashMap. Tracing an iterator to the ListHashSet triggers tracing of the entire ListHashSet. This CL removes the tracing of next_/prev_ from ListHashSetNode::Trace to indicate that nodes are not retained by other nodes, but only by the HashMap (which has write barriers and is safe from races). Finalization ============ Garbage collected nodes are reclaimed by the sweeper when no longer reachable. During reclamation, the node destructor is called. Calling the destructor manually from Destroy means that the destructor of garbage collected nodes is called twice. This didn't result in errors because ListHashSetNode maintains a boolean flag denoting whether it was already destructed or not. This is a bit weird because we are accessing a field of a destructed object (although not yet reclaimed). We can resolve this by simply not eagerly destroying garbage collected objects. As a bonus, the branch checking whether an object is garbage collected can be optimized away at compile time, while the existing branch (which checks a field) could not. Additionally, ListHashSetNode inherits from ConditionalDestructor so that it gets a destructor if the Type used in the set is garbage collected and not trivially destructible. Since HeapListHashSet only supports Member types (which are trivially destructible), the condition will always be false and inheriting from ConditionalDestructor is redundant. Bug: 986235 Change-Id: Ib7ca79f79b831e097e65d05970d0ba12f5a0c493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292301Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#787663}
-
Marc Treib authored
It has been essentially unused for a while. Apart from deleting the code, this CL contains the following changes: - In ChromeGcmListenerService: stop passing incoming GCM messages to the cacheinvalidation code. - In ProcessInitializationHandler: stop initializing cacheinvalidation's Logger class. - Create a dummy GcmRegistrationTaskService: This service (part of the cacheinvalidation library) is listed in the AndroidManifest.xml as exported, so it's part of Chrome's public API and can't just be removed. Adding an empty dummy implementation lets us keep the manifest entry without the actual implementation from the library. Bug: 1099672 Change-Id: I7e17415cd33cd76b864bd9e6f310f6c52bdf5503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274884 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#787662}
-
Side Yilmaz authored
This CL replaces |ImageFetcherFactory#createImageFetcher| functions in FeedImageLoader by using newer function with profile parameter. Since feed is only available in regular mode, this CL creates image fetcher by passing |Profile#getLastUsedRegularProfile|. Bug: 1041781, 1083923, 1075562 Change-Id: I62f8f939c12768458522a24d897e769633a9d0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278054Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#787661}
-
Owen Rodley authored
Forgot to do this before enabling tree closing... Bug: 1094768 Change-Id: I18cc98051471cdeadbda8540196ee9ef725b40e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294739 Commit-Queue: Owen Rodley <orodley@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#787660}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If1a41d9b9b1361b09eed0e4b059d47d65ff6efda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294689Reviewed-by:
-
Mugdha Lakhani authored
This change gets rid of the EditText we were using in InstrumentationTestActivity for weblayer instrumentation tests and replaces it with a UrlBarView returned by UrlBarViewController. All relevant methods have been updated, and a small UrlBarControllerTest added to verify expected behavior. This was previously reviewed and submitted here: https://chromium-review.googlesource.com/c/chromium/src/+/2270442 Geolocation tests were failing on Android L after this change: https://luci-logdog.appspot.com/logs/chromium/android/swarming/logcats/4d4937bf36d05911/+/logcat_logcat_org.chromium.weblayer.test.GeolocationTest.testGeolocation_denyFromPrompt_20200708T215038-UTC_05fcae3f0ae58958 but making them load a static HTML page fixes that. Bug: None Test: ./out/<build_dir>/bin/run_weblayer_instrumentation_test_apk Change-Id: Ia455e56c1424af714659b1b32b8af6a7a6dafa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289976Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#787658}
-
Yuki Shiino authored
Ports https://crrev.com/c/2261270 and https://crrev.com/c/2258781 to the new binding generator. Bug: 839389 Change-Id: If45e62bccbc8244353a9ba9362b70eb11d24ce46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291814 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Jia authored
This cl moves LSS to chromeos/components and changed some APIs. For background and CL review, please see go/componentize-cros-search-service Bug: 1102232 Change-Id: I31e209e4e27f56a3d8fc8d687052a784829d56c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289270Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#787656}
-
Koji Ishii authored
Following <crrev.com/c/2291181>, this patch cleans up |NGFragmentItems|: * Add |NormalText| and |FirstLineText|. The latter retruns |nullptr| when there is no `::first-line` style. * Change |Text(bool)| to return |NormalText| if |FirstLineText| is not available, instead of returning |nullptr|. This pattern matches |LayoutObject::Style| functions and safer not to return |nullptr|. Bug: 982194 Change-Id: I1d1238e506c0f38223108c5dfbb5ca29d52bb3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291917 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This is a reland of 2c6f0159 The original CL was reverted because this CL had introduced 4% flakiness for OOBE tests on ChromeOS. There were two kinds of regression issues with the origin CL. One was that WebUI APIs didn't work after a crash and reload since the old Mojo connections were kept for WebUI, and another thing was that BrowserInterfaceBroker was not ready but it was used in WebUIExtensionData ctor. This CL fixes the above regressions. - Resets WebUI Mojo connections when the render frame is exited, and adds a test case. - Connects WebUI Mojo connections without BrowserInterfaceBroker dependence right after AllBindings is called. Original change's description: > Convert FrameMsg_SetWebUIProperty and FrameHostMsg_WebUISend to mojo interfaces > > This CL converts FrameMsg_SetWebUIProperty to WebUI mojo interface > and FrameHostMsg_WebUISend to WebUIHost mojo interface, and > introduces those mojo interfaces newly. > > Bug: 1041074 > Change-Id: Ifd47bca7b919647bd7163758826537f7d201dc85 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097795 > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Cr-Commit-Position: refs/heads/master@{#768092} Bug: 1041074 Change-Id: Id6f6e0903f9816bd4cc65d8da00e2739c9fbc4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215650 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#787654}
-
Wolfgang Beyer authored
DevTools CL: https://crrev.com/c/2288703 Test was deactivated in https://crrev.com/c/2290935. Change-Id: Id0e61894e2786bae2b1fe237c2e01bcdcd0c6aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292050Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#787653}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f64be13cbf84..041796e60364 2020-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 79b4d6eb to b39fabb9 (542 revisions) 2020-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 479689912ee2 to b9285f69ba2c (11 revisions) 2020-07-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 6cd27bab06f4 to ad65826a2ab1 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: Ia082a3c29663f1498caf21ceb12971783b05867b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294684Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6723c14bd63c..fb5b460e9d7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yosin@google.com Change-Id: I0f526c4fabe2c4fdc306813995e00158d3728d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294683Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787651}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6711a818ee92..7f675314f19f 2020-07-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4f12d9c57a88126980d9ec81e71036a68078318d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294686Reviewed-by:
-
Side Yilmaz authored
This CL replaces |ImageFetcherFactory#createImageFetcher| functions in LogoDelegateImpl by using newer function with profile parameter. Today, image fetcher is created with regular profile always, even in incognito mode. By this CL, LogoDelegateImpl will create image fetcher with the profile coming via constructor. Bug: 1041781, 1083923, 1075562 Change-Id: I1d6df827b29e8f284a2ee5e7c2859b29399d2433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279201Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#787649}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594598363-c555f7e8a80b40cf8a42d21663f74bad4c776a90.profdata to chrome-mac-master-1594619844-912178519bb1004852ab23f2e1c1769d435241f8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand@google.com Change-Id: If79cf875f175b98f534c159dae69dbade42801cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294688Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I54299eb9a7faa485069f43733b413c946bafd2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291521 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594600621-783048b6dd03c460bf0ffdecd7c0b42fb3608f4c.profdata to chrome-win32-master-1594611817-3939336dc9344e90c2a5b4af88e6cee72fe360b0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I52e3ab8d6fbcd7c1bf0d4d75c5c8c30af82c7ed2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294679Reviewed-by:
-
Owen Rodley authored
This will be submitted shortly after sending a PSA to infra-announc@ Bug: 1094768 Change-Id: I277dade09e7a0299a50b7b776dbd0279cd1f7a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294503Reviewed-by:
-
Quang Minh Tuan Nguyen authored
this is done in crbug.com/1007680 Bug: 1007680 Change-Id: I461787bcd77b1ac0ac6b1845e371cd1985648da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291818 Auto-Submit: Quang Minh Tuan Nguyen <nqmtuan@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787644}
-
