- 24 Feb, 2020 40 commits
-
-
Patrick Monette authored
Bug: 1041093 Change-Id: Idc9c23461a794c736f230d79391f7f37e738f8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065313 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#744062}
-
Varun Khaneja authored
Bug: 963165 Change-Id: I782470e37747c460da3ba167a966af6d21023306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069478 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#744061}
-
bttk authored
The previous patch missed a file. See: https://chromium-review.googlesource.com/c/chromium/src/+/2019479 Bug: 1046181 Change-Id: I3b8f76acd34adb61430b134eedd82e460e49827c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067931Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#744060}
-
Piotr Bialecki authored
This adds logic into the ArImmersiveOverlay to keep track of multiple pointers present in MotionEvent & propagates this information to ArCoreGl. ArCoreGl will still send only the touch event information about the primary pointer to the renderer. Part 1/2(?). Changes: - ArImmersiveOverlay now keeps track of the state of all the pointers. - Switch ArImmersiveOverlay to use MotionEvent.getActionMasked() - some ACTION_* values contain pointer information that need to be discarded for the purposes of comparing with ACTION_* constants. - Propagate the information about primary pointer and pointer id from ArImmersiveOverlay to ArCoreGl through OnScreenTouch. - ArCoreGl now maintains an unordered map from input source ID to event data, and from pointer id to input source ID assigned to it. Pointer IDs are recycled by Android when it passes MotionEvents to the application - ArCoreGl ensures that the input source IDs are assigned appropriately. Bug: 1048329 Change-Id: I8834adfc5b601eb883993114636b551fe0bf8fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067538 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#744059}
-
Jiawei Li authored
In certain cases, second DidStartNavigation event will occur prior to prior navigation's DidFinishLoad, leading to that CastWebContentsImpl would drop second main frame loading event. DidStartNavigation -> DidStartNavigation -> DidFinishLoad -> DidFinishLoad. (LOADING->ignore same LOADING -> LOADED -> IGNORE SAME LOADED event). Ignored event won't be broadcasted to CastWebContents::Observer. BindingsManagerCast might not work as intended under this specific circumstance. To resolve that, another page loading notification should be added on ReadyToCommitNavigation. Bug: Internal b/149898650 Test: Verified with manually build. Change-Id: Ie119b21495fde6db7b4dd24515ceac3a080c5166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067870Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#744058}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/02497d40161f..659cc1c90705 git log 02497d40161f..659cc1c90705 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 herb@google.com Make the strike cache hash table own the strike 2020-02-24 robertphillips@google.com Remove SkDDLTmpRedirect.h 2020-02-24 dmazzoni@chromium.org Allow passing multiple node IDs per PDF structure node. 2020-02-24 bsalomon@google.com Fix GrTextureEffect with kRepeat/kRepeat/kBilerp. 2020-02-24 jvanverth@google.com Reland "Create D3D device and queue" 2020-02-24 jcgregorio@google.com [assets] Add CockroackDB as an asset for testing. Created with: gclient setdep -r src/third_party/skia@659cc1c90705 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:607777 Tbr: jlavrova@google.com Change-Id: I0970029a43a5ebe58681d57d2be2b09c28099cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069334Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744057}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/33466973bc4c..1249ada986fc git log 33466973bc4c..1249ada986fc --date=short --first-parent --format='%ad %ae %s' 2020-02-24 cwallez@chromium.org Vulkan: Load promoted extensions or core entrypoint as needed Created with: gclient setdep -r src/third_party/dawn@1249ada986fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I313dc996811446d08e11e6ef88e5d22e7eaa5573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070323Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e0897515da03..b3a40936b9f0 git log e0897515da03..b3a40936b9f0 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 brcui@microsoft.com Add high contrast support to the What's New tool (Help module) Created with: gclient setdep -r src/third_party/devtools-frontend/src@b3a40936b9f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib54a9140c354e8eb4ce8731be88e544f16f8126c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069049Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/207c622c1ef0..fd7c149eef90 Created with: gclient setdep -r src-internal@fd7c149eef90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040143,chromium:1041701,chromium:1050094,chromium:1054683 Tbr: jbudorick@google.com Change-Id: I31bc04afc7c5ce844001cbdb3f85234a73deadbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069047Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744054}
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: Ia34aad31bf40f5ba5dfbfa52c41982666b3335d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066791 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#744053}
-
Sebastien Marchand authored
This removes several entries from fieldtrial_testing_config.json for features that are in the FEATURE_ENABLED_BY_DEFAULT state. Methodology: - Make a script that list all the features listed in fieldtrial_testing_config.json - Run git grep for all these features in the chrome codebase, save the first line of the output in a file (this could be improved for features that wrap over multiple lines). - Find the line containing FEATURE_ENABLED_BY_DEFAULT, check if the entry is trivial (no param changes etc) and if the feature isn't behind a #ifdef block, remove it if it sounds safe. A follow up CL will remove all entries that don't have a corresponding feature in the codebase. Bug: 1053702 Change-Id: Ifb526b74d988bdf18f8997f536463956a4d9578e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062697Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#744052}
-
Victor Costan authored
This CL fixes all currently-enabled clang-tidy warnings in //content/browser/appcache. The main benefit here is to prevent distractions while pursuing further refactoring in AppCache. This CL introduces no functional changes. Change-Id: I81176a48ac8a3362d75cdde6672e462590cb397f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069849 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#744051}
-
Kramer Ge authored
This reverts commit a799e280. Reason for revert: <Android crashes blocking M-82 crbug.com/1055463> Original change's description: > Release GrContext during OnBackgroundCleanup on low end device > > To reduce Gpu memory on low end device, GrContext and associated > resources should be released. Abandoning GrContext directly results > in resources associated to theVkDevice becoming lost. It's preferable > to destroy entire vulkan context during background cleanup and > re-initialize when chrome is foregrounded. > > Bug: 1048692 > Change-Id: I6bb0740edee72413f0ac083d847d06e4427133ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047828 > Commit-Queue: Kramer Ge <fangzhoug@chromium.org> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742815} TBR=penghuang@chromium.org,fangzhoug@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048692 Change-Id: Ice1010228ccade56edbb4b3a7b54ba40cbd8dd22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070663Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#744050}
-
Dale Curtis authored
Now that all processes which can launch from the zygote are doing so, we should ensure future launchers are safe by default and that exceptions are intentional. Additionally adds file://sandbox/OWNERS for relevant files. Fixed: 22703 Test: All existing tests pass. Change-Id: I188f4314fbf5cf4659bf555b14b572f657a8720c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067541 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#744049}
-
Jan Wilken Dörrie authored
This change implements StartBulkLeakCheck() and StopBulkLeakCheck() in the BulkLeakCheckServiceAdapter and makes it listen to the OnEdited() event issued by the SavedPasswordsPresenter. Bug: 1047726 Change-Id: I043edbdcaf901eff784ffe1d7740fedfee462d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070198 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#744048}
-
Michael Sun authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/c22aa6b47ff6..a0ee3aa5b911 $ git log c22aa6b47..a0ee3aa5b --date=short --no-merges --format='%ad %ae %s' 2020-02-23 michaelfsun system_api: Add CRAS media player D-Bus constants 2020-02-11 zuan cryptohome: Port allow user to selectively remove keysets to UserDataAuth. 2020-02-10 zuan cryptohome: Port allow users to create data restore key to UserDataAuth. 2019-12-24 cylai system_api: protobuf message for new dbus service |pca_agent|. 2020-02-18 pmoy power: add three more fields to proto Created with: roll-dep src/third_party/cros_system_api Change-Id: I6f9ef976ce4c697182bc350cdd36738c7fd69948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067192 Auto-Submit: Michael Sun <michaelfsun@google.com> Commit-Queue: Michael Sun <michaelfsun@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#744047}
-
Peter Kasting authored
TestContentSettingImagePressed() wasn't actually verifying that the image in question was visible before "pressing" it. Fixing this caused several different tests to start failing because they weren't actually triggering the permission requests they thought they were (but didn't previously detect it). Fix these tests and improve the InvokeUi cases to all show a requesting URL (of "example.com"). Bug: none Change-Id: Ic64e233163d82d71e88cbb09e3da9a26ed2aede5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067745Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#744046}
-
Anastasia Helfinstein authored
Refactors three Switch Access classes for clarity, consistency, and readability. Bug: None Change-Id: Ib81a279cef24348f997f870f208413245a8c2357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064790Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#744045}
-
Elly Fong-Jones authored
This change makes DialogDelegate::Close non-virtual. It also splits DialogTest.AcceptAndCancel into several smaller tests, to avoid it needing to return false from Accept/Cancel/Close; this also makes the tests easier to follow. A followup CL will delete DialogDelegate::Close completely, replacing it with a new method DialogDelegate::CloseDialog(), for unit tests that want to simulate closing a dialog but have not created a Widget for it. Bug: 1011446 Change-Id: I2cb64c3c757e7685d32c1d3b99406999a2cf626d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068299 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#744044}
-
Anastasia Helfinstein authored
The desktop needs to be fundamentally different from other root nodes in Switch Access because it is the only root that does not have a back button. Bug: 1054482 Change-Id: I47d1f8f5383d271debf1ef5749c106015102679a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065732 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#744043}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bde4517dec7..1cb4a3a99d23 git log 3bde4517dec7..1cb4a3a99d23 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 rsavitski@google.com Merge "traced_perf: enable SMB scraping + cts improvements" 2020-02-24 rsavitski@google.com Merge "traced_perf: record "expired" (skipped) samples in the trace" 2020-02-24 hjd@google.com Merge "ui: Fix formatting of dev_server errors" Created with: gclient setdep -r src/third_party/perfetto@1cb4a3a99d23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1d81a67265b9b4cb5e399d84ecf4f8216b19bf5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070437Reviewed-by:
-
Charlie Hu authored
In previous CL, a bug on type name where 'bool' should have be 'Bool' causes bool value calling PolicyValue constructor for double, with extra param. This CL fixes the bug and add tests on parse_default_value function. Change-Id: Ica555f337336fe83ad061f3455769b5a0b3ffe67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069856 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#744041}
-
chrome://downloadsDaniel Rubery authored
chrome://downloads was previously displaying the in progress UX for downloads that were in the middle of scanning. This could be confusing given that we may remain in this state for several minutes. Instead, we should indicate to the user that the file is being scanned. This CL also removes the ".dangerous #description" selectors that could cause warning text to change color. These currently aren't doing anything (the text is black). Screenshot: https://screenshot.googleplex.com/sTApKg55f4n.png Bug: 1048891 Change-Id: I3fb736818814dd0343871c08ca230435899bf5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063043Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#744040}
-
Anastasia Helfinstein authored
Previously, Switch Access would get stuck in the virtual keyboard when it was hidden, and would not jump to it when it was activated by any method other than the Switch Access menu. This change listens to events corresponding to the keyboard being shown and hidden, and reacts appropriately. Bug: 996899 Change-Id: Ic6c58c8f66afdbf7422b74a8dc86b0d64c700607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062584 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#744039}
-
Bettina authored
Bug: 1054636 Change-Id: I46529471783a15c504b7b12c2f5998f84b8d3e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067799 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#744038}
-
Olga Gerchikov authored
https://chromium-review.googlesource.com/c/chromium/src/+/1945923 change erroneously initializes hold_time_ to null when scroll timeline is inactive. This makes assert to fail in Animation::CommitPendingPlay at: DCHECK(start_time_ || hold_time_); Bug: 1042924 Change-Id: I98060d065da93bb633d6cbc1506c591194a11692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037348 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#744037}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/959d077f605e..c7f63a01d344 git log 959d077f605e..c7f63a01d344 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 jmadill@chromium.org Fix debug callback in perf tests. Created with: gclient setdep -r src/third_party/angle@c7f63a01d344 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: geofflang@google.com Change-Id: Ib4766d1bd355d1ad722635b87bbe1753838aedef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070435Reviewed-by:
-
Juanmi Huertas authored
This Cl removes the softwareUsage fallback for CanvasResourceProvider, it adds a new set of constructors for the different type of Resource, and replaces the calls for all instances of SoftwareUsage. This is the first part of a big refactor removing all of the fallback use cases and that will enable an overall simplification of the codebase and it will make more explicit this part of the code base. Bug: 1035589, 1021287 Change-Id: Iaeec2ee05d2a95f35eec753acc39e948260b3142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013483 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#744035}
-
Ankit Kumar authored
This CL enables the focused annotation to scroll into view in a PDF. The method Form_OnFocusChange() is added which gets called when PDFium calls FFI_OnFocusChange(). Here we check if the focused annotation is out of the viewport and scroll to bring the top left corner of the annotation into the center of the viewport. This CL also adds FormFillerTest.Form_OnFocusChange which expects appropriate function calls to scroll when needed. Bug: 989027 Change-Id: Ice8da8d7080404b4e34b830fd29bccb1a0b11546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032483 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#744034}
-
Ben Wagner authored
Skia is planning to change how the CTFont is created for glyph metrics and drawing. As a result there will be some changes to layout tests. Hold out the Skia side changes until the tests can be updated. Change-Id: I807591eba700c7af3e20c5e234af06d16155a742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068829Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#744033}
-
Kyle Milka authored
Add users actions to various points in the sharing hub. Bug: 1009124 Change-Id: I92379ef1153d54d64257d4b32f369ec402119534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055689Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#744032}
-
Toni Barzic authored
When dragged app item view is dropped into a folder at the end of the drag, hide its title, and keep it hidden. Generally, the title will be hidden at the end of the drag while the item is animating to the new target bounds, but the item view is removed from the views model before the bounds animations run, so AnimateToIdealBounds() will not update the dragged view title. BUG=1053935 Change-Id: Ief279b9f11f7c6bf7d562e4e4d9a690e89acf229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068279 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#744031}
-
Matt Wolenetz authored
BUG=878133 Change-Id: I3b65e4013536aa7a7e28b1425d6ffa6852f26c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066390 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#744030}
-
Nick Harper authored
https://quiche.googlesource.com/quiche.git/+log/7c89615d6dd7..5f23a2d78434 $ git log 7c89615d6..5f23a2d78 --date=short --no-merges --format='%ad %ae %s' 2020-02-20 nharper Move QuicCryptoServerStream::Helper to QuicCryptoServerStreamBase 2020-02-20 bnc Dump header name and value length (not value itself) if value too long. 2020-02-20 danzh gfe-relnote: n/a(test only) fix a GCC complier error in QUIC test utils. Not protected. 2020-02-19 dschinazi Introduce QUIC_VERSION_IETF_DRAFT_25 2020-02-19 fayang gfe-relnote: In QUIC, when arming PTO timer, ignore application data until handshake completes rather than handshake confirmed. Not affecting prod, not protected. 2020-02-19 fayang gfe-relnote: Add an IsAckFrameEmpty const method to received_packet_manager and make sure GetUpdatedAckFrame is only called to retrieve nonempty ACK frame. Refactoring only, not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I08858b30e044a162bdcb167b8819bc973151cd8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068649Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#744029}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d41bcabd124f..c93fa1ff0194 git log d41bcabd124f..c93fa1ff0194 --date=short --first-parent --format='%ad %ae %s' 2020-02-24 thakis@chromium.org Fix a Wrange-loop-analysis warnings in pdfium. 2020-02-22 thestig@chromium.org Disable RenderManyRectanglesWithExternalMemory test for Skia. 2020-02-21 thestig@chromium.org Roll third_party/freetype/src/ 8930cc961..49f3394d7 (3 commits) 2020-02-21 thestig@chromium.org Add placeholder comments to DEPS to mitigate CQ interference. Created with: gclient setdep -r src/third_party/pdfium@c93fa1ff0194 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1039697 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I3723464918b59eec3463ae50f8ff71cc972c9756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070436Reviewed-by:
-
Victor Costan authored
AppCache's net::DiskCache wrapper header currently declares a static const kUnknownResponseDataSize in the content namespace, resulting in a copy in each translation unit that includes the header. While the copies are most likely eliminated by the linker due to lack of use, this declaration still pollutes the namespace. This CL moves the constant into the HttpResponseInfoIOBuffer class, so it is only emitted once. This CL doesn't introduce any functional change. Bug: 1055133 Change-Id: Ib9c8a339e6a543a908ee4c952bb0bc1174fa7dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069842 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Daniel McArdle authored
Bug: 1052228 Change-Id: I2c14024f760148cc8ddaec96cbeea3cdee7edf96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065319Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#744026}
-
Adam Langley authored
Kim is no longer active in this area but has done a review recently and we want to make it easy for her to return :) Other emeriti are not, in practice, reviewing in this area. Remove them so that tools don't auto-suggest them for CLs that they'll only have to bounce to someone else. Change-Id: I5d46659e1621e526912b3b48323b2027c8878593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070563Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#744025}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cb8594a9..f6d87d0f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ica9cd42176f680ef802c5421446e482d9a6b7045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070536Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#744024}
-
Etienne Bergeron authored
This reverts commit 27ed0337. Reason for revert: Top crasher on Windows. Original change's description: > Report crash-dump for GetFontFallbacks that succeed on Windows > > On Windows, ShapeRuns(...) is shaping the text by trying: > PrimaryFont > GetFontFallback(...) : using DWrite > GetFontFallbacks(...) : using registry keys (Font Linking) > > The GetFontFallbacks function is deprecated and should be > remove. There is still a long tail of cases that succeed > only with the use of that mechanism. This CL is making > these cases to be reported as a crash to be analyzed > before removing the code. The goal is to avoid breaking > the text rendering even for a small population. > > R=robliao@chromium.org > > Bug: 995789 > Change-Id: I381753ed3985779cd34dae58a34f523c2f215c9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049126 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Etienne Bergeron <etienneb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741606} TBR=robliao@chromium.org,etienneb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 995789 Change-Id: Ibd4e3a1dd4fadb9178511a0cab38200c8fd4ade4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068830Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#744023}
-
