- 14 Nov, 2018 40 commits
-
-
Chih-Yu Huang authored
The autotest video_ChromeHWDecodeUsed verifies Chrome used the HW decoding when playing a video stream by checking the histogram value, which is reported from GpuVideoDecoder. In order to keep the test pass during switching from GpuVideoDecoder to MojoVideoDecoder, we have to report the same histogram value temporarily from MojoVideoDecoder. With this CL, we can enable MojoVideoDecoder at ChromeOS platform. BUG=chromium:902968 TEST=Pass video_ChromeHWDecodeUsed autotest on Eve TEST=Play video at Youtube on Eve and confirm the successfull option of Media.GpuVideoDecoderInitializeStatus are increased. Change-Id: I26fc53704843e9b153bbee304e8f60ab3a7b0417 Reviewed-on: https://chromium-review.googlesource.com/c/1328634 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#607890}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2a01274b3caf78d0d714aab391783b554bc4a16e Reviewed-on: https://chromium-review.googlesource.com/c/1335090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607889}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/def2885f901d..357df2f5f824 Created with: gclient setdep -r src-internal@357df2f5f824 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8ce36da709dc52d9193694e75671578cffb1ea1e Reviewed-on: https://chromium-review.googlesource.com/c/1335087Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607888}
-
Vlad Tsyrklevich authored
Currently, base::bits::Count{Leading,Trailing}ZeroBits fail to link when used with 64-bit inputs on 32-bit MSVC builds because MSVC only implements the _BitScan{Forward,Reverse}64 intrinsics for 64-bit builds. Fix this by implementing equivalent support using 32-bit intrinsics. Change-Id: I9b9095abd03587c29dd642df65cf9783bd9b202d Reviewed-on: https://chromium-review.googlesource.com/c/1321253Reviewed-by:Albert J. Wong <ajwong@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#607887}
-
Aidan Wolter authored
Creates a mapping between the audio group ids and the application session id. When the CAOS is created, it uses the group id in the audio params to look up the session id and uses that to retrieve the proper MultiroomInfo. Bug: b/111669896 Test: Cast to a MZ group, cast_media_unittests, cast_base_unittests, cast_shell_unittests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6979bbb2bfc118e4d135bfd354ce1ad956503182 Reviewed-on: https://chromium-review.googlesource.com/c/1221067 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607886}
-
Lin Sun authored
Remove following suppressions for Intel on Linux: conformance/renderbuffers/depth-renderbuffer-initialization.html conformance/renderbuffers/stencil-renderbuffer-initialization.html BUG=794339 Change-Id: Ibf3cd5a96a22b7318730fb981dbbe7ce063f4f2e Reviewed-on: https://chromium-review.googlesource.com/c/1309429Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#607885}
-
John Budorick authored
Tbr: crouleau@chromium.org,nednguyen@google.com,perezju@chromium.org Bug: 903849 Change-Id: I2821fc28f5c63a036d563a6350db4659c4fb5440 Reviewed-on: https://chromium-review.googlesource.com/c/1334831Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607884}
-
Weidong Guo authored
Background: When dragging home launcher down to show a window, the window will be shown on drag start and will slide down on drag update. However, this does not work for window with modal dialog because the dialog's visibility change cancels the touches for all other windows. Changes: Avoid cancel touches on windows that are not in the same transient window tree of the modal dialog. Bug: 900321 Change-Id: I2047224de2f6fac9e892376477b7bf9c938cc2c0 Reviewed-on: https://chromium-review.googlesource.com/c/1316434 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#607883}
-
Carlos IL authored
This reverts commit 91d24688. Reason for revert: This CL made ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange flaky (crbug.com/904108) reverting while investigating why. Original change's description: > Variations service now checks explicitely if previous attempt was HTTP. > > Variations service now sets a flag if the last request was an HTTP > retry, and uses it to decide whether to retry again, instead of > relying on the scheme of the final URL. Also, retries are now disabled > if the fallback url is HTTPS. > > Bug: 902727 > Change-Id: Ibd6df4a22bc6302b231aff0ae32f8e1c8a1f277c > Reviewed-on: https://chromium-review.googlesource.com/c/1325035 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607022} TBR=asvitkine@chromium.org,carlosil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 902727 Change-Id: I67036ea20097f889e71de5179a2e4510a201388d Reviewed-on: https://chromium-review.googlesource.com/c/1334421Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#607882}
-
Manas Verma authored
Relanding browser tests for local migration flow. Commented out flaky tests that were causing issues earlier. Bug: 897998 Change-Id: I7dd0fdb5f71587bddc236732c6d3725dc6411818 Reviewed-on: https://chromium-review.googlesource.com/c/1332704Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#607881}
-
Jia authored
If experiment param is valid, a global curve will be constructed from it. Otherwise a default value will be used. Bug: 881215 Change-Id: I0986a145bc943d190fbc9609630e9d21ef5d57e7 Reviewed-on: https://chromium-review.googlesource.com/c/1333097 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607880}
-
Becky Zhou authored
Bug: 903858 Change-Id: Ie4e05d6d19fb03c08e9dc1f1e2b0d6108f33eaaf Reviewed-on: https://chromium-review.googlesource.com/c/1333782 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#607879}
-
Jordy Greenblatt authored
This adds a chromeos switch to allow tether host scans to occur in spite of ethernet connections. This is a followup to CL 1332693. ----- TESTING: I confirmed manually that turning off the switch prevented a host scan when ethernet is plugged in while turning it on allowed the 'tether host found' notification. Bug: 904609 Change-Id: If0938796841228415c72fb6ccc9b0a52c3d64786 Reviewed-on: https://chromium-review.googlesource.com/c/1334206 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#607878}
-
Sandra Sun authored
Currently, once we decide to animate a scroll to an offset, we update the scroll a little bit each frame until it reaches the specified offset. However, during the animation, the scroller's maximum scroll offset might become smaller than the specified offset. For example, on an android device, a user wants to find a string in a page. After tapping the 'search' icon on the virtual keyboard, the smooth scroll is initialized but the window's size becomes larger as the virtual keyboard disappears. In such cases, if we still decide to animate to the originally specified offset, the page won't be rendered correctly. We should always clamp the scroll offset during the animation. Bug: 902905 Change-Id: I3a3117be0aff40bc012206d741f5142d12de2a7b Reviewed-on: https://chromium-review.googlesource.com/c/1329542 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607877}
-
Bo Liu authored
Problem is when CanDraw is false but needs_prepare_tiles is true Scheduler will keep requesting begin frames but do nothing in a begin frame since invalidate is blocked on CanDraw. We already have an efficient shortcut that does not involve actually producing a frame if invalidate is only requested for needs_prepare_tiles. So the simple fix is simply allow invalidates for this case. Bug: 900557 Change-Id: Ib3c3e213e2e2461d7aa1b8dd8d2e91ab64042feb Reviewed-on: https://chromium-review.googlesource.com/c/1334550 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#607876}
-
Kenneth Russell authored
Assertions fail when running multithreaded WebAssembly code which uses WebGL. Bug: 905000 Change-Id: Ic45df5f43aa859a5f9225586f4836919ef31b54a Reviewed-on: https://chromium-review.googlesource.com/c/1334844Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#607875}
-
Victor Miura authored
These stories are superceded by newer stories such as infinite_scroll_root_n_layers_99 and css_opacity_plus_n_layers_99. Now that we have had overlapping data from the new stories for some time, the old stories can be removed. BUG=878951 Change-Id: Idb146ed7d9f5420bac1d5217e86c6547a772efe5 Reviewed-on: https://chromium-review.googlesource.com/c/1334929 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607874}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f768692bdef0..f28410e9eb26 git log f768692bdef0..f28410e9eb26 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 tsepez@chromium.org Use {{include}} directive in more tests. 2018-11-14 tsepez@chromium.org Introduce {{include}} directive for PDF file fixup. 2018-11-14 tsepez@chromium.org Add CPDF_IndirectObjectHolder::New<T>() 2018-11-13 thestig@chromium.org Add more tests for transfer function creation and usage. 2018-11-12 tsepez@chromium.org Test pushbutton specific field properties. 2018-11-10 thestig@chromium.org Roll tools/clang/ 3041f30dd..31f2d265b (4 commits) 2018-11-10 thestig@chromium.org Roll build/ a09219387..81ffd0040 (178 commits) 2018-11-10 thestig@chromium.org Roll buildtools/ 2dff9c9c7..fdce2ad26 (2 commits) 2018-11-10 thestig@chromium.org Roll DEPS for catapult to 5d509166 2018-11-10 thestig@chromium.org Roll third_party/googletest/src/ d52663267..2e68926a9 (68 commits) 2018-11-10 thestig@chromium.org Roll third_party/instrumented_libraries/ 323cf3219..a959e4f0c (4 commits) 2018-11-10 thestig@chromium.org Roll third_party/zlib/ dcf1d0f8c..dde5ce526 (6 commits) 2018-11-10 thestig@chromium.org Roll third_party/depot_tools/ 71e3be7a5..ddbeac1c0 (78 commits; 12 trivial rolls) 2018-11-10 thestig@chromium.org Roll third_party/icu/ c56c67199..45f655f2f (11 commits) 2018-11-10 thestig@chromium.org Roll third_party/skia/ fa7df23d8..36b85be49 (158 commits; 11 trivial rolls) 2018-11-10 thestig@chromium.org Roll third_party/freetype/src/ f56830ed4..fb0d66d04 (20 commits) Created with: gclient setdep -r src/third_party/pdfium@f28410e9eb26 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I532bd42f0153e67d50628395705ccd33a1350831 Reviewed-on: https://chromium-review.googlesource.com/c/1334572Reviewed-by:
-
Michael Lippautz authored
Mixin construction relies on the fact that no garbage collection can be triggered. When moving to the new MakeGarbageCollected bottleneck the hook for mixin construction was dropped. This restores previous behavior. In a followup GarabgeCollectedMixin::operator new() should be inlined in the construct trait, creating the invariant that all operator new() methods are deleted for Oilpan. Bug: 904546, 757708 Change-Id: I47e672f1cb3035d8a4bea72d90bfceb2a31c5d89 Reviewed-on: https://chromium-review.googlesource.com/c/1333761Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#607872}
-
David Black authored
Per request, modifying Assistant strings for Related Info. These strings occur in Chrome Settings and Assistant OOBE. See bug for screenshots. Bug: b:119503388 Change-Id: I9219c59dceac4207061e978efe68633f89d7034b Reviewed-on: https://chromium-review.googlesource.com/c/1334279Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#607871}
-
Lei Zhang authored
Move some out of place flag descriptions to the right sections. Change-Id: I61569c122d8b5c93adcad002661a13fc33dcd14a Reviewed-on: https://chromium-review.googlesource.com/c/1330893 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#607870}
-
Yuichiro Hanada authored
The original CL is crrev.com/c/1331294 and it was reverted due to MSan failure. The failure should be fixed by adding initialization for |is_removing_imm_entry_|. Android IMEs can be disabled in Android side by using 'ime' command. This CL ensures that disabled IMEs are also disabled in Chrome OS's InputMethodManager. Bug: b/119274469 Change-Id: I4f9067cabf96fcb28d594a72856df1e34d469114 Reviewed-on: https://chromium-review.googlesource.com/c/1334672Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#607869}
-
Sadrul Habib Chowdhury authored
It looks like there is a CompletionEvent that is never getting signaled from the compositor thread, and the main-thread stays blocked on it. This causes a fair number of hangs in the renderers (~30% of all hangs or crashes in cc/ code in stable channel on Windows). Try using a ScopedCompletionEvent to make sure all CompletionEvents are always signaled, and see if that helps. BUG=622080 Change-Id: Ic25089f0e4f671182b18c1b44e278196eeb040c2 Reviewed-on: https://chromium-review.googlesource.com/c/1332726Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6d64a5e5e40b..6ce627d2b73d git log 6d64a5e5e40b..6ce627d2b73d --date=short --no-merges --format='%ad %ae %s' 2018-11-13 benjhayden@chromium.org Add place-holder for v2spa. Created with: gclient setdep -r src/third_party/catapult@6ce627d2b73d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib7d97fbe1d8d8c99104429375797b359ca00350d Reviewed-on: https://chromium-review.googlesource.com/c/1334587Reviewed-by:
-
Mei Liang authored
This CL updates the histogram metadata. Bug: 890502 Change-Id: I20fa1f69a3b7fc720fc314d2be98bff6fd175415 Reviewed-on: https://chromium-review.googlesource.com/c/1333781Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607866}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9d32daac..dd90e943 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa8537cab02e312ed8ee99a20c6bc64ed446c2b3 Reviewed-on: https://chromium-review.googlesource.com/c/1334562Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607865}
-
Quan Nguyen authored
The email label now uses the same layout rule as the user name label, which fixes the same bug, but for long emails rather than long user names. Bug: 902362 Change-Id: Icfde3129078ffd6a5977b388210bf2773e0ee405 Reviewed-on: https://chromium-review.googlesource.com/c/1334827 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#607864}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9d958b54af30..6c242459120d git log 9d958b54af30..6c242459120d --date=short --no-merges --format='%ad %ae %s' 2018-11-13 brianosman@google.com Remove SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS from Skia's Chromium GN 2018-11-13 scroggo@google.com Remove unused SkPath::unique() 2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6ed398b46847..b3c4d88a647a (1 commits) 2018-11-13 scroggo@google.com Build custom empty SkFontMgr for Android Framework 2018-11-13 jvanverth@google.com Avoid overflow in bufferOffset calculations Created with: gclient setdep -r src/third_party/skia@6c242459120d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel BUG=chromium:b/118742766 TBR=rmistry@chromium.org Change-Id: Ife94330d4007392c300980f4c387e0fd8267bcb7 Reviewed-on: https://chromium-review.googlesource.com/c/1334249Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f9143725470b..d1a55e393e65 git log f9143725470b..d1a55e393e65 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 jmadill@chromium.org Expand dEQP-GLES3 suppressions. Created with: gclient setdep -r src/third_party/angle@d1a55e393e65 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:822310 TBR=cwallez@chromium.org Change-Id: I707d1a122db30dcf53255adc0ee1a749552ffe02 Reviewed-on: https://chromium-review.googlesource.com/c/1334570Reviewed-by:
-
yiyix authored
Skipped Frame tracker used to record every frame produced at all times. With that approach, it's hard to study the correlation between the user actions and the skipped frame rate. In this patch, we only track the skipped frame rate during scrolling events. More user actions will be added in the future cls. Design doc on skipped frame tracker: https://docs.google.com/document/d/1SqqdQsdh9CA5SRHCvkI_FDcc-vBW-saEj1kh4-qTBwg Videos on how it used to work: https://drive.google.com/open?id=1S5fnq8VrqvUIYFZjvIi4GNA3ekIdggG0 Bug: 894149 Change-Id: I02441cb5c9f551cc80b51ea1dcbafa3c492cb5ce Reviewed-on: https://chromium-review.googlesource.com/c/1334103Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
Previously, FetchClientSettingsObjectImpl - Is used as WorkerFetchContext's FetchClientSettingsObject, - Implements GetHttpsState(), and - Is used for checking mixed contents on workers. Issue 880027 will introduce outsideSettings WorkerFetchContext which will have FetchClientSettingsObjectSnapshot as its FetchClientSettingsObject [1]. Therefore, this CL switches - WorkerFetchContext's FetchClientSettingsObject and - MixedContentChecker::IsMixedContent() to use FetchClientSettingsObject (not ...Impl), and implements GetHttpsState() in FetchClientSettingsObject and FetchClientSettingsObjectSnapshot. This CL shouldn't change the behavior at this time, because WorkerFetchContext's FetchClientSettingsObject is still a FetchClientSettingsObjectImpl object, and thus mixed content checks is done using already-implemented FetchClientSettingsObjectImpl::GetHttpsState(). The code path added in this CL will be used in [2]. [1] https://chromium-review.googlesource.com/1328043 [2] https://chromium-review.googlesource.com/1328164 Bug: 880027 Change-Id: I399694bd239c21fe9b5a650fcb689fb2c98572f5 Reviewed-on: https://chromium-review.googlesource.com/c/1328162Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#607860}
-
Rakina Zata Amni authored
In WebContents destructor, |find_request_manager_| is not reset but FrameTreeNode destructor is trigerred, eventually causing calls to FindRequestManager::SendFindRequest that will try to send a find request to another frame in the same WebContents, which results in a crash. There are also other cases where the WebContents is navigated away, the window is closed, etc. where we also try sending to another frame within that WebContents, even though we won't need it. This CL fixes the crash, and the root cause will be explored and fixed in another CL. Bug: 884679 Change-Id: I229f38a663d50b6a5e8e167ac0d483f9826a7f0b Reviewed-on: https://chromium-review.googlesource.com/c/1242728 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607859}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9e9db70e8858..def2885f901d Created with: gclient setdep -r src-internal@def2885f901d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I09159c00b4e8c4709792f921e2c0d0feebf1c541 Reviewed-on: https://chromium-review.googlesource.com/c/1334571Reviewed-by:
-
Jinsuk Kim authored
Android CFI tests exposed a missing null check in one of the tests. Relanding https://crrev.com/c/1304038 after fixing it. TBR=tedchoc@chromium.org Bug: 877878 This reverts commit 7d0fbfd8. Change-Id: I75c560af86cd0f92b4b5eded5896c884fb7181ce Reviewed-on: https://chromium-review.googlesource.com/c/1334667Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#607857}
-
Nikunj Bhagat authored
Bug: 904953 Change-Id: I763d48881143645102fdaf5d85cb2ab812e8b8c0 Reviewed-on: https://chromium-review.googlesource.com/c/1334327Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#607856}
-
Eric Roman authored
Bug: 904889 Change-Id: I52e5b4cc2bff0cff0b1c7d6ec55d26b01924c288 Reviewed-on: https://chromium-review.googlesource.com/c/1333906 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#607855}
-
Sammie Quon authored
They were deleted when fingerprint_progress_arc.js was moved from settings to cr_elements. Test: browser_tests CrElementsFingerprintProgressArcTest.* Bug: 894285 Change-Id: I66419456bb00b30b348dcfad1c663237b41e2412 Reviewed-on: https://chromium-review.googlesource.com/c/1332767 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#607854}
-
Hector Carmona authored
Bug: 901210, 900377 Change-Id: I928f6cdb1a8251131afbe2e95afe1cbca39703ea Reviewed-on: https://chromium-review.googlesource.com/c/1332696 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607853}
-
Theresa authored
Create a new package for top toolbar classes and move relevant classes. BUG=904998 Change-Id: Ia9233913f04ec77f31c592f5a033ea18a5fccbf0 Reviewed-on: https://chromium-review.googlesource.com/c/1334416 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607852}
-
Akihiro Ota authored
Clean up aria-setsize-posinset.html Layout Test to use testharness and be more human-readable. Larger goal is to more thoroughly test the aria-posinset and aria-setSize attributes, especially in ambiguous cases. Change-Id: I950d45ceda2bbeb3fb10423812a13380b0da3ef4 Reviewed-on: https://chromium-review.googlesource.com/c/1332412Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#607851}
-
