- 15 Nov, 2018 40 commits
-
-
Nicolas Pena authored
At TPAC, we agreed that 'script' is confusing because it implies that longtasks only measure script work. Thus, we decided to change the name to 'unknown'. Also see https://github.com/w3c/longtasks/issues/47. Change-Id: I5a0666d0fa078bfeac8ab6e8397b9b51aca3e833 Reviewed-on: https://chromium-review.googlesource.com/c/1336367Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#608479}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f3acb8c133fa..666818eacf79 git log f3acb8c133fa..666818eacf79 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 jmadill@chromium.org Use angle::Result in front-end (Part 8) Created with: gclient setdep -r src/third_party/angle@666818eacf79 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I5e67d545fd9e3d7a4a0f41fe0f01772a6eb5e6c9 Reviewed-on: https://chromium-review.googlesource.com/c/1337483Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608478}
-
bsheedy authored
Updates the string used to set the paired viewer to Daydream View during VR tests. It was getting set to this version anytime an NFC scan occurred, causing image diff tests to fail depending on which subset of tests were run due to slightly different render sizes being reported by VrCore. TBR=billorr@chromium.org Bug: 904012 Change-Id: I4ce031ffc0a5fba3abbe59a5d33dff1e5a416885 Reviewed-on: https://chromium-review.googlesource.com/c/1338224Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#608477}
-
Elly Fong-Jones authored
Bug: None Change-Id: I5efda82d931dee0c6da98e17d68240a10f5eb885 Reviewed-on: https://chromium-review.googlesource.com/c/1337791Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#608476}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/abaffd85abb7..005fdd4ec834 git log abaffd85abb7..005fdd4ec834 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3fc6893c8b24..8f20452b0219 (1 commits) 2018-11-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f3acb8c133fa..666818eacf79 (1 commits) 2018-11-15 csmartdalton@google.com sksl: Add support for 2x2 matrix inversions in Metal 2018-11-15 egdaniel@google.com Add flag to force purge resources from cache as soon as possible. 2018-11-15 mtklein@google.com remove mention of 16-bit shader procs 2018-11-15 brianosman@google.com Use GrVertexWriter in GrLatticeOp Created with: gclient setdep -r src/third_party/skia@005fdd4ec834 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ife7a2224be73c96d0a7583e4a3096764115aa51c Reviewed-on: https://chromium-review.googlesource.com/c/1338146Reviewed-by:
-
Regan Hsu authored
We are launching the new multi-device services and removing the old functionality. As part of the internal cleanup, we are removing references to kMultiDeviceApi from MessageTransferOperation - as the functionality it entails will become the default action - and removing code that relies on old methods. Many of the tests that rely on fake classes that mimic old functionality fail. As a result, this CL disables those tests. Bug: 905151 Change-Id: I9ad4572431afe9e659e1a82edf878b09d3734367 Reviewed-on: https://chromium-review.googlesource.com/c/1328163 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#608474}
-
Joe Downing authored
This CL replaces the confusing, generic, platform provided permission dialog on Mojave with one which provides more context and instructions on what the user needs to do to enable Chrome Remote Desktop on Mojave. Bug: 902041 Change-Id: Ibda9459dfba3579c596cf5e2703b8c3d0ea28059 Reviewed-on: https://chromium-review.googlesource.com/c/1334838Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#608473}
-
Tom Tan authored
Disable IAT hooks on Windows ARM64 for the same reason as Windows X64. IAT virtual address is 4 bytes in length and insufficient to hook to arbitrary 64-bit address. Bug: 893460 Change-Id: I05b607737e07e12a318f261366a59c8ed1a52782 Reviewed-on: https://chromium-review.googlesource.com/c/1337294Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#608472}
-
Yuki Awano authored
Bug: b/119523533 Test: steps described in the bug Change-Id: I87d594d3655cd0de86a9a783eb9e5fc9ba2665c4 Reviewed-on: https://chromium-review.googlesource.com/c/1337221Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#608471}
-
Vladimir Levin authored
This patch adds ability to delay style until display lock is committed. However, once committed it will go through all the phases and display contents synchronously. It adds the ability for the DisplayLockContext to keep track of the current state, making it easier to reason about what should happen next. As well, it adds a lifecycle update state to keep track of which lifecycle stage should occur next. This is a stepping stone towards a correct solution. R=chrishtr@chromium.org Bug: 882663 Change-Id: I660e81d9cd30604883f8f4971920a1bb19dafe67 Reviewed-on: https://chromium-review.googlesource.com/c/1334656Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608470}
-
mark a. foltz authored
This updates the task posted to check the Windows firewall settings to CONTINUE_ON_SHUTDOWN, to fix a shutdown hang. Bug: 902821 Change-Id: I4f261db1d08a075f39422f7c553394e2a95624ea Reviewed-on: https://chromium-review.googlesource.com/c/1336915Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608469}
-
Javier Ernesto Flores Robles authored
Bug: 845472 Change-Id: I1691063eecb6fa423bc36c21a910adcf21f00da8 Reviewed-on: https://chromium-review.googlesource.com/c/1338108Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#608468}
-
Tatiana Buldina authored
Disable WindowTest.testSetsTheSizeOfTheCurrentWindowFromIframe Remove tests from _REVISION_READY_TO_RUN_FILTER Bug: chromedriver:2661 Change-Id: Ibe170f821790be7cdadac10432f7f967b2692e1c Reviewed-on: https://chromium-review.googlesource.com/c/1335107Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#608467}
-
Kevin Ellis authored
This patch fixes the problem where subtle changes to numerical values in matrix interpolation cause mismatches in the expected results. To address the issue: * Styles are checked to see if they are of the form matrix(...) or matrix3d(...). * If the style is a matrix, then arguments are rounded and the style is reconstructed. Bug: 797472 Change-Id: I44d6e0ed13e24dc2ecfeeacbcd4809d6dcdb6465 Reviewed-on: https://chromium-review.googlesource.com/c/1337640Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#608466}
-
Charlie Harrison authored
This test currently waits 30s before completing. This CL speeds it up by injecting a TestMockTimeTaskRunner and using it to fast forward time. Bug: 896787 Change-Id: I35cb9ea8f269bfa1a9d2cb35858e3fd697a41ac4 Reviewed-on: https://chromium-review.googlesource.com/c/1334289 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#608465}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a06bf8506fdf..f0db2e2ef5d2 git log a06bf8506fdf..f0db2e2ef5d2 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 eladalon@webrtc.org nit: Missing space in build_overrides/build.gni 2018-11-15 alessiob@webrtc.org AGC2 flags: remove deprecated fields. Created with: gclient setdep -r src/third_party/webrtc@f0db2e2ef5d2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id1eb83a2d950366ba06c5e49a0914be33c61f038 Reviewed-on: https://chromium-review.googlesource.com/c/1338119Reviewed-by:
-
Jonathan Backer authored
Bug: 905511 Change-Id: I1d37cb900749085384c6abcb2e0b9d8224f0a190 Reviewed-on: https://chromium-review.googlesource.com/c/1338160Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#608463}
-
Javier Ernesto Flores Robles authored
Hide card and address icons when no data is available. Show them again if data becomes available. Bug: 845472, 905650 Change-Id: If0420746b2df8fd3ebbbbd8dff6524eb326cef7c Reviewed-on: https://chromium-review.googlesource.com/c/1335570 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
This is the string that UX and the Translation team agreed upon. Bug: 878388 Change-Id: Ibd42ebb2068cac63283389ff50f161baa29d85b9 Reviewed-on: https://chromium-review.googlesource.com/c/1338179Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#608461}
-
Lei Zhang authored
- Prefix global with "g_". - Return std::string() consistently. - Remove an #else block that is not necessary. Change-Id: I15017665a37c2010db7bed02a37ebfb4c18a083f Reviewed-on: https://chromium-review.googlesource.com/c/1336514Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#608460}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/32a6bd7b54fd..30746749adb0 Created with: gclient setdep -r src-internal@30746749adb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I054d86018ec340e1376725ac4f893086b826f34f Reviewed-on: https://chromium-review.googlesource.com/c/1338121Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608459}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/144f1014..68fee3ed Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I21e04c24617338747d44ec6e60450b93191c9220 Reviewed-on: https://chromium-review.googlesource.com/c/1338172Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608458}
-
Jun Cai authored
The browsertest changes in the following CL is moved to this CL since it is not related to the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1323658/7/chrome/browser/chrome_browser_main_browsertest.cc This CL fixes the ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange browser test which failed on the release Builder linux64 machine. For more details, please refer to the following issue link. In the release Builder linux64 machine, the intermediate connection state is CONNECTION_ETHERNET, so in the test it needs to make sure the NetworkConnectionTracker's underlying network connection state is CONNECTION_NONE before it starts to run the actual test code. Bug: 902784 Change-Id: I16866f1fb0e8834dfa621930efa83aba26aa52d0 Reviewed-on: https://chromium-review.googlesource.com/c/1336433 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608457}
-
David Benjamin authored
TLS 1.0 and 1.1 are deprecated. See: https://security.googleblog.com/2018/10/modernizing-transport-security.html https://groups.google.com/a/chromium.org/d/msg/blink-dev/EHSnAn2rucg/oiu0DoQ0CAAJ As part of that deprecation, show a console warning in DevTools and also add a Blink-level UseCounter. (We typically measure things at the connection or request level for network features, but since we're plumbing this in anyway, go ahead and add one.) I mirrored the plumbing and UseCounters for Symantec certificates. Bug: 896013 Change-Id: I9b45e6264a2119b7b68a5a9f282dfd63a372210a Reviewed-on: https://chromium-review.googlesource.com/c/1324878 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608456}
-
Jonathan Metzman authored
Improve efficient_fuzzer.md by making the following changes: 1. Get rid of static corpus instructions (just use regular corpus) 2. Add details about authenticating to use ClusterFuzz buckets. 3. Eliminate extra newlines 4. Be consistent about the example fuzzer name 5. Mention dict should be ascii encoded Improve clusterfuzz.md by linking directly to coverage page and by linking to most recent stats. Change-Id: I9990ab8ab4811445214735e65a6e8d2bd2319179 Reviewed-on: https://chromium-review.googlesource.com/c/1323272 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#608455}
-
Koji Ishii authored
When WTF::StringImpl is displayed in the VisualStudio debugger, and when the string is expanded, each character should be displayed, but each character is typed as StringImpl and that code points cannot be seen. This patch fixes it for both 8bit and 16bit cases. r603419 (CL:1288930) removed (wchar_t*) because local test did not show the differences, but it was because the natvis in the DLL was prioritized over the local natvis. When both files were fixed, the symptom was fixed properly. Change-Id: I68ff0f83456a4e99db803f7140b6e0d6a7630bba Reviewed-on: https://chromium-review.googlesource.com/c/1337671Reviewed-by:
-
Adrienne Walker authored
The linter gets mad at this when anybody changes this file because the line is too long, but there's no way to format this properly and not wrap, so just make the test name shorter. Bug: 805798 Change-Id: I41e052843d721c8c50becdb5425a376503b8889a Reviewed-on: https://chromium-review.googlesource.com/c/1336558Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#608453}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1ff7a8e7e55f..3189731cbd9e git log 1ff7a8e7e55f..3189731cbd9e --date=short --no-merges --format='%ad %ae %s' 2018-11-15 hjd@google.com Merge "Add tools/gen_all" Created with: gclient setdep -r src/third_party/perfetto@3189731cbd9e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9955787f24243b43b112f0de195a2e1b451fdff9 Reviewed-on: https://chromium-review.googlesource.com/c/1338143Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d098799efb32..eaddc34b5d48 git log d098799efb32..eaddc34b5d48 --date=short --no-merges --format='%ad %ae %s' 2018-11-15 cbruni@chromium.org [telemetry] Simplify rethrowing in InspectorBackendList Created with: gclient setdep -r src/third_party/catapult@eaddc34b5d48 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I51a4900e23fc25b8d35f601ee70b6cc60b52278c Reviewed-on: https://chromium-review.googlesource.com/c/1338144Reviewed-by:
-
Jonathan Metzman authored
This should slightly improve performance and provide other benefits. Bug: 883948, 905708 Change-Id: I7b00ca2b398115c9a5eb5dca47dda70be2df6cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1338174Reviewed-by:
-
Christian Biesinger authored
In Jan 2015 the spec changed in https://drafts.csswg.org/css-flexbox/#change-201409-align-content-wrapping Change our code accordingly. This effectively reverts commit crrev.com/290823003 and relands crrev.com/2191683003 align-content-wrap-004 is a test for bug 641789, which was a regression from the previous attempt at landing this patch. Bug: 599828 Change-Id: I8de127c19203854922eb23a626cee4de9a772f22 Reviewed-on: https://chromium-review.googlesource.com/c/1323906 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#608449}
-
Peter E Conn authored
Web App Manifest icons can have the MASKABLE purpose specifying they were designed with all of their important content sufficiently far from the edges to allow the User Agent to apply a mask [1]. This CL just adds code to read in that purpose, which will be used in upcoming CLs. [1] https://w3c.github.io/manifest/#purpose-member Bug: 904354 Change-Id: Ib62eb7af9226d14199d0d74615cb5bbf2666abda Reviewed-on: https://chromium-review.googlesource.com/c/1329792 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#608448}
-
Xianda Sun authored
Because the hit test query fuzzer generates hit test flags and async hit test reasons independently, it sometimes triggers a DCHECK that verifies correct reasons have been set when there is an asynchronous hit testing being performed. This CL fixes it by generating non-kNotAsycnHitTest reasons only when the fuzz flags contain kHitTestAsk. Bug: 905463 Change-Id: Ibf73d7138951af93b7fe2029242d6e062ff1a11d Reviewed-on: https://chromium-review.googlesource.com/c/1338139Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#608447}
-
Matthew Cary authored
This small change removes the KitKat restriction for manual listing of tests. Bug: 905230 Change-Id: Ib66544873017fd0c5261af0ad1d57358ea97a167 Reviewed-on: https://chromium-review.googlesource.com/c/1337493Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#608446}
-
danakj authored
When RenderFrameProxy::CreateFrameProxy() is called, it will 1) Make a RenderFrameProxy 2) Make a WebRemoteFrame 3) Swap out the RenderWidget on the RenderView 4) Give the WebRemoteFrame to the RenderFrameProxy This is called from RenderViewImpl::Initialize, or from an IPC from the browser via Mojo to RenderThreadImpl::CreateFrameProxy. In the latter case, it doesn't appear to remove the local main frame from the RenderViewImpl/RenderWidget. This is done by the browser destroying/detaching the main frame separately. But since detaching sets the LocalFrame to nullptr but does not SwapOut the RenderWidget, this call is required in RenderFrameProxy to do the SwapOut. At that time we should also stop the compositor. R=piman@chromium.org Change-Id: I24da561e14eea0e23e7e16d0af38f95279a27ed2 Bug: 896836 Reviewed-on: https://chromium-review.googlesource.com/c/1335661Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#608445}
-
Jacob Dufault authored
TBR=alemate@chromium.org Bug: 905109 Change-Id: I7be1cccec0a18ee7d6a664d736aa0ab55512911b Reviewed-on: https://chromium-review.googlesource.com/c/1338219Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#608444}
-
Sorin Jianu authored
Also, do not allow negative sizes. Bug: 881076 Change-Id: I254d52258f5902d5d8740e74be35012cdf2b43e4 Reviewed-on: https://chromium-review.googlesource.com/c/1336524Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608443}
-
Min Chen authored
Set the gesture event as handled if it can not be used to drag the window during window drag. Browser window is special since it has its own logic to handle the drag. Bug: 900959, 877976 Change-Id: I6a9416505da7fc92306ad5c364f4be04213dd992 Reviewed-on: https://chromium-review.googlesource.com/c/1332289 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#608442}
-
Sky Malice authored
RefreshThrottlerTest tests broke on the day daylight savings time ended. To fix this, set a TestClock's time to a specific date so the real date will never affect tests going forward. Removed all unittest usage of Time::Now in Feed code. Bug: 901698 Change-Id: I76b0b092aa12b7c4fef65a353caa317a381f32c1 Reviewed-on: https://chromium-review.googlesource.com/c/1324414 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#608441}
-
Vasilii Sukhanov authored
- When the dropdown is shown we record if password generation is available. - The type of the chosen suggestion is recorded. Bug: 883319 Change-Id: I69ac20b4022707cbcb57164b8718feecf85ab83a Reviewed-on: https://chromium-review.googlesource.com/c/1335605 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
