GitLab

According to design, on iPad the spacing between buttons (not text
fields) and an adajcent edge should be greater.

Fixed: 1053988
Change-Id: Id061603e32e184864cba61ee11c6e6a946b41e49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066541Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#743121}

The flag itself was already removed in r735677, this removes the
metadata from the json file.

Bug: 1046131
Change-Id: Id54ebfcd472e06f1bbfb870fa60e62bb97555ff1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064815Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743120}

The HostZoomLevelContext class was refcounted, but only ever owned by
a StoragePartitionImpl so remove the refcounting. It also had a custom
deleter doing basically the same work as DeleteOnUIThread so use that
instead. De-virtualize the destructor, too.

Change-Id: I75bf780953e6420e00d488af1560262ca4ed7188
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028934
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743119}

* Wire PeopleHandler::TurnOffSync to the IdentityManager.
* Clean up PeopleHandler unit tests. Re-enable some tests on Chrome OS,
  delete unused helper methods, make signin step more explicit.
* Add initial implementation of RevokeSyncConsent to IdentityManager.
  For now this is only supported on Chrome OS because Chrome OS is the
  only platform that needs to exercise it.

Bug: 1050677
Test: Enable SplitSettingsSync, enable sync in browser first-run flow,
      go to Settings, turn sync off, chrome://sync-internals shows
      browser sync feature enabled is false
Test: added unit_tests and components_unittests

Change-Id: I5b2afa49ffa71aac155f93b9abb504c14c4f6b80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982186Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743118}

Child user will see the notification with the details of time
limit change in the following cases:
* App did not have the limit and new limit was set.
* App had time limit set and it was removed.
* The value of time limit changed.
There are no notifications displayed for web apps, as they
share the limit with Chrome and notification will be shown
for Chrome.

Bug: 1052011
Test: AppTimeControllerTest
Change-Id: I662773969b4668c73bc3d6a9d572f8a11d147ae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065411Reviewed-by: Yilkal Abe <yilkal@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743117}

https://chromium.googlesource.com/angle/angle.git/+log/b0e9cd6645e1..2156c444568a

git log b0e9cd6645e1..2156c444568a --date=short --first-parent --format='%ad %ae %s'
2020-02-20 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f155ccfd202d..6112b121e104 (8 commits)

Created with:
  gclient setdep -r src/third_party/angle@2156c444568a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I7ed398a158660559225f7443f328b468b6adbb82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065906Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743116}

On some websites multiple redirects occur straight after login
but on iOS they are not treated as redirects, but rather as form
submissions, so the infobar should not expire not only on redirects,
but on form submission navigation as well.

Bug: 720090, 720154
Change-Id: I766ee66749d0f4942206cc44a6d5d1e50a2a672b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066617Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Maria Kazinova <kazinova@google.com>
Cr-Commit-Position: refs/heads/master@{#743115}

NetworkIsolationKey and site-for-cookies are related, in such a way as
that we shouldn't be sending same-site-cookies for requests when the
NIK doesn't indicate the top-frame origin (and frame origin, if
present) are for that site. We want to add DCHECKs that this is always
the case.  This CL fixes a couple NetworkContext unit tests where
the two values don't agree.

Bug: 1052148
Change-Id: Ibd7118310ac01b19f60001a1296f3e76af091c70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055426Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743114}

Change-Id: Iaadce70c24f55fe5bb68ffdd6963c7812f25e271
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065273Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743113}

Fixed: 1054402
Change-Id: I4e07f98bf365f0adbbf51680d913af91b0e81859
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066448
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743112}

https://webrtc.googlesource.com/src.git/+log/1282babe6621..2e161c4dd654

git log 1282babe6621..2e161c4dd654 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 mbonadei@webrtc.org Revert "Remove ResourceAdaptationModule::OnMaybeEncodeFrame"
2020-02-20 phoglund@webrtc.org Fix required property for iOS tests.
2020-02-20 jakobi@webrtc.org Update target rates if stable target has changed.
2020-02-20 sprang@webrtc.org Lazy conversion to i420 buffer in SimulcastEncoderAdapter
2020-02-20 danilchap@webrtc.org Delete legacy DataSize and DataRate factories
2020-02-20 danilchap@webrtc.org Parse DependencyDescriptor rtp header extension
2020-02-20 phoglund@webrtc.org Whitespace change to kick bots.
2020-02-20 elrello@microsoft.com Rollback transport created by data channel
2020-02-19 philipp.hancke@googlemail.com loosen ice-ufrag/ice-pwd ice-char restrictions
2020-02-19 titovartem@webrtc.org Add YUV to IVF video converter util
2020-02-19 mbonadei@webrtc.org Remove wildcard ownership for build files.
2020-02-19 danilchap@webrtc.org Refactor parsing generic descriptor extension into own function
2020-02-19 mbonadei@webrtc.org Remove inactive OWNERS.
2020-02-19 titovartem@google.com Remove unused compile-dep from sdk/android:base_java target
2020-02-19 phoglund@webrtc.org Fix dead link.
2020-02-19 mbonadei@webrtc.org Make error message more actionable.
2020-02-18 deadbeef@webrtc.org Make CNAME optional.
2020-02-18 deadbeef@webrtc.org Add constants for allowed network_priority values
2020-02-18 jamiewalch@chromium.org Add missing interface methods.

Created with:
  gclient setdep -r src/third_party/webrtc@2e161c4dd654

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032987,chromium:1044521,chromium:1052352,chromium:1053756,chromium:1053891
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ibf46e5e39407babffe40e4cf83b35a9e7134aaf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065905Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743111}

The screen reader's focus rings have outsets around the bounding box
from the semantics tree info.  However, when the bounding box is for
a full screen item (like the background image, for example) the
focus ring becomes invisible because it renders outside the screen
area.  This CL clips the points to the screen's dimensions.

Bug: 1052121
Test: Local build display assistant with screen reader enabled
Change-Id: Icf4ad68f59c23e503bc3baf9ec7763e175095853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055668Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743110}

While here, also remove some references to GYP.

Bug: 1031169
Change-Id: Ibb00ea755454be02b366f344d9bae8b693dbd581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066060
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743109}

The current algorithm first finds a |prefix|, then checks if the
immediate following text is the |search_text|. If it is it'll advance
|search_start| to the end of the |search_text| so it can confirm it's
followed by the |suffix| text. However, this means that if the |suffix|
text doesn't match, the next iteration of the algorithm will start
searching for the |prefix| at the end of the |search_text|. This is a
problem if the |search_text| == |prefix| because we've now skipped the
|search_text| part of the range for prefix matching.

E.g. With prefix=foo search_text=foo suffix=bar we'll fail to match:

foo foo foo bar

Because the first iteration of the loop will use the first "foo" as
the prefix, and the next iteration will use the third "foo" as the
prefix; we skip the second.

Bug: 1054243
Change-Id: I62b8a32f89c987e5bed8ea439ae1b7d53d12436d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065979Reviewed-by: Nick Burris <nburris@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743108}

This reverts commit 7a9ca38d.

Reason for revert: It appears all the browserlist observers are
busted after closing the last incognito tab.

Original change's description:
> [iOS] Create WebStateList observation registrar.
> 
> This CL creates AllWebStateListObservationRegistrar, which can be used
> in any case when an object needs to observe all web state lists for a
> given BrowserState.
> 
> This is a generalized version of the snapshot cache tab model observer,
> which this replaces.
> 
> For cases where only regular or OTR browsers' WebStateLists should be
> observed, AllWebStateListObservationRegistrar has an optional param that
> can be set at creation time.
> 
> To avoid circular dependencies, one target in web_state_list/ had to
> be split from the main target (hence the scattershot BUILD.gn updates).
> 
> Change-Id: Ic3977b709d5b089ebf31afd0fa868067833f2249
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997306
> Commit-Queue: Mark Cogan <marq@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#742172}

TBR=rohitrao@chromium.org,marq@chromium.org,justincohen@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: If97541ae3196c04da57c8a49896e8c55d5646949
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063918Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743107}

Enable whitelist policy wrapper to graciously handle
empty or incorrect values.

Bug: 1051201
Change-Id: I1e94af89e60106b7eedbd0e65c2b1138055ba5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065983Reviewed-by: Aga Wronska <agawronska@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743106}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71d0f777fcf6..e1cd8b3dcc1d


Created with:
  gclient setdep -r src-internal@e1cd8b3dcc1d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1040143
Tbr: jbudorick@google.com
Change-Id: I331dde0bcc0b63c9888e06acb1346421beb0c2da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065904Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743105}

Update the expected test output, which is caused by changes in the
DevTools CL linked below. Reenable the respective test.

https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2056480

Bug: chromium:1035309
Change-Id: I5910d4f83741b9fb1c2c5235ce888e5d304ec8b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059976Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743104}

We were only catching Exception which meant that other Throwables (often
OutOfMemoryError) were still crashing in the JNI bindings instead of
generating "nice" Java stacks.

Bug: 718929
Change-Id: I6c941002d632696c736aed9ad3304223d813c94b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060671
Auto-Submit: Richard Coles <torne@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743103}

Under chrome/browser/resources/pdf directory, move existing enums into
constants.js. constants.js will be used to hold all future enums which
are added into this directory.

Change-Id: Ic3ed8e0d0cfa13e157c45ea640ec52dd5a67b90e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056568Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Hui Yingst <nigi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743102}

This reverts commit be7ed6c8.
The fail/timeouts in cfi tests are caused by an implicit DocumentPolicyFeature enum to int cast in feature_policy_helper.cc.tmpl. The problem is fixed by including document_policy_feature.mojom-blink.h in feature_policy_helper.cc.

Original change's description:
> Revert "Add DocumentPolicyFeature enum"
>
> This reverts commit 9594a5d4.
>
> Reason for revert: suspect causing faillures on LinuxCFI bot.
>
> Sample build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16433
>
> Manually bisected and this CL seems to cause the tests' timeout.
>
> Original change's description:
> > Add DocumentPolicyFeature enum
> >
> > This CL separates DocumentPolicyFeature enum from FeaturePolicyFeature
> > enum, which makes DocumentPolicy and FeaturePolicy independent to each
> > other. Previous test on document policy and feature policy coexist
> > is removed. Follow-up CL will replace all usage of migrated features,
> > i.e. font display and unoptimized-lossless-images so that current wpt
> > tests on document policy still pass.
> >
> > Bug: 993790
> > Change-Id: I730b95efd013c25d97c2d24dd777e12b7b38bbb7
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028666
> > Cr-Commit-Position: refs/heads/master@{#741609}
>
> TBR=dgozman@chromium.org,dcheng@chromium.org,iclelland@chromium.org,chenleihu@google.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 993790
> Change-Id: Ifaacbc1461dfd4048329ed11763ecfff197b22e4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060188
> Cr-Commit-Position: refs/heads/master@{#741884}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 993790
Change-Id: I1a282d6546819936617ecebbab96ecc73cf498fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061394Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#743101}

Bug: 1040143
Change-Id: Ife79cfe1f0c5963bf4c6c7bee0c810e936b0a9a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062208
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743100}

Move the LayoutInstability test case and CLS-specific stuff into a
separate file, add comments to document MetricIntegrationTest APIs,
and create UKM/UMA tester objects automatically.

Bug: 1045064
Change-Id: I905975afc97fa7ebd3b3d5382b7c77429628c07a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064780Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743099}

Before this CL it was a vector, but after recent cleanups, it only ever
had a single entry.

Bug: 1029481
Change-Id: I0e7964d4233f08e102b1c0a0413aaff7dd6514ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065004
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#743098}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/69ac3898ce66..f0a082ec3466

git log 69ac3898ce66..f0a082ec3466 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-02-20 tvanderlippe@chromium.org Update TypeScript to 3.8.1RC

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@f0a082ec3466

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Idd5d708cae7996fc4148905651571b54081b22ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065902Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743097}

This CL modernizes the HistoryClearBrowsingDataCoordinator
 - to use |browser| in the initializer instead of |browserState|
 - to remove the public property for dispatcher
 - to use self.browser to get browserstate and dispatcher values.

Bug: 1029346, 1048407
Change-Id: I9422cc3dac91b0b27f16378f4c65dbe9c2d42563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064392Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Cr-Commit-Position: refs/heads/master@{#743096}

https://android.googlesource.com/platform/external/perfetto.git/+log/e4a608b99a32..c2ca38da431c

git log e4a608b99a32..c2ca38da431c --date=short --first-parent --format='%ad %ae %s'
2020-02-20 fmayer@google.com Merge "Do not insert session into active_configs_ if setup fails."

Created with:
  gclient setdep -r src/third_party/perfetto@c2ca38da431c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ifb7848755231e396023ce02b0b3979658f0c9523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065903Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743095}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b86395aa..6afd7913

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1d9998d03bda2bbd8d35247a19117177a66099aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066578Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743094}

The aria-description property is now in the master branch of the
draft ARIA spec.

Bug: 1006767
Change-Id: Ic23904c8d8de32aa0f7ff3c4c03ec8a9a26c6b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999301Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743093}

https://skia.googlesource.com/skia.git/+log/2c2db2762809..9d4e31d6cda5

git log 2c2db2762809..9d4e31d6cda5 --date=short --first-parent --format='%ad %ae %s'
2020-02-20 reed@google.com rm Sk3D.h -- long live SkMat4

Created with:
  gclient setdep -r src/third_party/skia@9d4e31d6cda5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: lovisolo@google.com
Change-Id: I82ca68ac628ca6612a837fb1de49a5aeb94db439
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065901Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743092}

Using wpt-import in Chromium 82fd87a4.
With Chromium commits locally applied on WPT:
d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching"
9431619c "Clipboard Tests: Update DOCTYPE to lowercase."
76ee218c "Split html/.../query-encoding/ tests"
40478e29 "Revert "Roll CTS and fix extract_expectation_names.py""


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ie60855462c2ea146a80da659fe4245abfbc1c82d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066577Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#743091}

Test that the script URL reported by the debugger is the same as the
Response URL passed to the streaming compilation API.

R=bmeurer@chromium.org

Bug: v8:10172
Change-Id: Ifaf8bcdd91df4104527e61b8c7e7b40bfe9eb63b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064388
Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743090}

...instead of manually watching for relevant changes.
This is a small cleanup/simplification; no behavior changes expected.

Bug: 1024332
Change-Id: Ie5671ebc278c890ca0f7ce082b1ec0df3c98b107
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065001Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743089}

When troubleshooting why no media files appear in the PhotoPicker
it is important to know what query was issued so that the file system
can be inspected (to see if any files should have matched).

This is only logged once (when a PhotoPicker dialog is opened).

Bug: 656015
Change-Id: I833665827f598bb1c40cbfeec2cc44f6c8c4b7d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066537
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743088}

Bug: 1044365
Change-Id: I9fd23b258c86f68e01be02f17c49d0adcbe7a1e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064940
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743087}

This reverts commit 68d4bec3.

Reason for revert: Build failures:
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/35129
https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux/67071

Original change's description:
> Introduce Mojo interface for accessibility, adding a SetMode() method
> 
> Based on crrev.com/c/1847304, by Colin Blundell <blundell@chromium.org>
> 
> This CL starts the process of converting accessibility IPC to Mojo. We
> start off by converting the message FrameMsg_SetAccessibilityMode
> which, while not strictly a message from accessibility_messages.h,
> it's very important in that it's responsible of getting accessibility
> enabled in the renderer side, when the ui::AXMode::kWebContent is
> specified.
> 
> Also, it's important to migrate this message first and doing it using
> an associated channel for the new mojom::RenderAccessibility interface
> since we need to make sure that this new RenderAccessibility::SetMode()
> method gets processed in the expected order relative to other messages
> already being sent using Mojo between the browser and renderer process,
> such as those for mojom::NavigationClient, for instance. Not doing it
> in this way would lead to race conditions during the migration period,
> since the ordering of some messages from accessibility_messages.h being
> migrated to Mojo could not be processed in the expected order compared
> to this new RenderAccessibility::SetMode() method, which is required to
> happen first to get the RenderAccessibilityImpl object created in the
> renderer.
> 
> Specifically, this CL does the following:
> - Adds render_accessibility.mojom with the RenderAccessibility
>   interface.
> - Adds a new class RenderAccessibilityManager implementing the new
>   mojom::RenderAccessibility interface, which will also manage the
>   lifecycle of the object that will be handling accessibility in the
>   renderer (i.e. the RenderAccessibilityImpl object).
> - Sets up the plumbing for RenderFrameHostImpl to be able to connect to
>   the mojom::RenderAccessibility implementation via RenderFrameImpl,
>   using an associated channel to connect to the receiver side,
>   implemented by RenderAccessibilityManager.
> - Changes how RenderAccessibilityImpl gets created, so that its
>   existence is now manager by RenderAccessibilityManager, which is
>   permanently connected to the browser process for the entire lifetime
>   of the RenderFrameImpl object.
> - Uses this infrastructure to replace the sending and handling of
>   FrameMsg_SetAccessibilityMode.
> - Updates RenderFrameImpl::SetAccessibilityModeForTest() to rely on
>   RenderAccessibilityManager::SetMode() from now on.
> - Updates tests as needed.
> 
> Future work will incrementally convert the rest of the accessibility
> messages, including introduction of the Mojo interface for methods
> that go from the renderer to the browser.
> 
> Bug: 1010831
> Change-Id: I919177bcf7cfa0af6ae4b921341f239674606d52
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991446
> Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Ken Rockot <rockot@google.com>
> Cr-Commit-Position: refs/heads/master@{#743081}

TBR=dmazzoni@chromium.org,dcheng@chromium.org,aboxhall@chromium.org,rockot@google.com,haraken@chromium.org,dtapuska@chromium.org,chrishall@chromium.org,arthursonzogni@chromium.org,mario@igalia.com,meredithl@chromium.org

Change-Id: I97660f4d0c88a8eed6d9014e9d4ea4b4006842ef
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1010831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065671Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743086}

This adds a feature flag for Safe Browsing, and disables WKWebView's version
of Safe Browsing when this flag is enabled.

Bug: 1028755, 1050174
Change-Id: I213a3fb1aeaeaa4b497e7ba56be2c61046a5b688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065550Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743085}

Remove cross origin sensor metrics, due to RAPPOR framework
being turned down.

Cross origin metrics measure the Device Motion/Orientation
API usage across frames. These metrics will be added using
the new UKM framework as a follow-up if necessary.

BUG=1025720

Change-Id: Ie9506fcdc9d0b04088e49af91f7a5a7b093a881b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062332Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743084}

R=sdoerner@google.com

Bug: 1043748
Change-Id: Ib0ad2f166fd644922a8202c3cbb0e798d5853e19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064308Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Deepankar Tyagi <dpnkar@google.com>
Cr-Commit-Position: refs/heads/master@{#743083}

Adds a getAndroidAccount, getId, getEmail, getGaiaId static helpers to
CoreAccountInfo. These helpers all do the same task - they return
Account/CoreAccountId/Email/GaiaId from the argument if it's not null,
and return null otherwise. IdentityManager.getPrimaryAccountId will be
replaced by this in subsequent CLs.

Bug: 1051000
Change-Id: Id0cc2bb5049f5464cbfc06a4866c7a9bf2074724
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061813
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743082}