- 18 Jun, 2020 40 commits
-
-
Arnaud Mandy authored
Test to verify screen id. adding 3 displays to display vector. getScreens() should return 3 screens with ids 0,1,2. removing middle display from display vector. getScreens() should return 2 screens with ids 0,1. removing last display from display vector. getScreens() should return 1 screen with id 0. Bug: 1075656 Change-Id: Ib671b760353766d21330b95833b983c9b5e4737f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238112Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#779689}
-
Hesen Zhang authored
Bug: 1087476 Change-Id: If941947a498da55e0e5d0809cdef276d16f5ae50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248863Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779688}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If4336e492c4d9dee0163b6d1b8473681dc5d9212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251359Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779687}
-
Joel Hockey authored
The related bug shows that infobar is using the wrong color for non-tabbed PWAs. Infobar takes its color from the active tab color, and non-tabbed PWAs are currently setting active tab color to the theme color (rather than alt color) in order to get the desired NTP page during page load. The fix here is to roll back some of crrev.com/c/2094484 and set active tab color back to the alt color, and then to separate NTP and active tab colors so that NTP can be kept with the desired theme color. All other clients of BrowserThemePack are unchanged since ntp_color is taking active tab color in GetAutogeneratedThemeColors. Only AppBrowserController is changing for non-tabbed PWAs to set alt color for active_tab (fixes bug relating to info bar), but can now keep the theme color for NTP so as not to regress crbug.com/1059696. For reference the previous changes for AppBrowserController: crrev.com/c/2045278 crrev.com/c/2064164 crrev.com/c/2094484 Screenshots: crbug.com/1096027#c1 Bug: 1096027 Change-Id: I7db5a2836fef381116b4082b1fde219ba8bdec95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248391Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#779686}
-
Kazuki Takise authored
We are still actively monitoring these metrics. Bug: 1052913 Bug: 1052914 Test: builds Change-Id: I19fbeb7c77c6a43b0fba00f0624a26fe6e4f55af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247425Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#779685}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 85-4147.33-1591609027-benchmark-85.0.4170.0-r1 to 85-4161.0-1592216902-benchmark-85.0.4175.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ibaaea16b4630d5bacac330d4168ac525d65a8ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251353Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a3a9da74308f..67237c14a6db 2020-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 5af39e89 to 2adbb514 (484 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: Ic3ccd36e489a9e8a9b69ffeb71460cb04b854ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251342Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d56d2c282f22..622ed3fe6f3f 2020-06-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Icae1f13873710c5ec8cec04d78edc741884aac75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251343Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 85-4147.33-1591609549-benchmark-85.0.4170.0-r1 to 85-4163.0-1592215894-benchmark-85.0.4175.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3ccfc6bc70c4a8b83af4154299ce7d79884923d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251352Reviewed-by:
-
Alexis Savery authored
Add UMA histograms "Platform.StatefulTrim.TimeBetweenTrim" and "Platform.StatefulTrim.TrimmedAmount" to track the amount of time between trims and the amount of data that is trimmed by chromeos-trim. Implementation CL: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2236859 Bug: chromium:1063105 Test: ran validate_format.py Change-Id: I9fd71492804000c1ec73cd5944a5894a4ef63c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237047 Commit-Queue: Alexis Savery <asavery@chromium.org> Reviewed-by:
-
Peter Kasting authored
This eliminates the need for implementations to override the getters. Bug: none Change-Id: I3df33cd593c3c600739b5b0546270d89342394aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250822 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#779679}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 85-4161.0-1591613309-benchmark-85.0.4170.0-r1 to 85-4163.0-1592214946-benchmark-85.0.4175.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic74c65068c943da594a0fe5077cd715a5bf4f273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251351Reviewed-by:
-
Jeevan Shikaram authored
Add jshikaram@chromium.org to the owners file for b/chromeos/apps for work on apk_web_app_service*. Change-Id: I98b7e3302bbbf786ace2a6b533d38ffde842df1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248394Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#779677}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592434762-d0256013ebfb9b66f1c9d30375481125009d55f6.profdata to chrome-win64-master-1592444957-71678dbb85583180f0a866ae4da634fc0e847777.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9bd0a0dbcfa20193cd0193e392fe62ea87c79e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251338Reviewed-by:
-
My Nguyen authored
As per enterprise review, make emoji suggest addition defaulted to false. Default value does not support DICTIONARY type so created new pref value instead. Bug: 1077629 Change-Id: I0e153d72973188a89521ee8700c87ae3cd202747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239434 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#779675}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome TBR=chrome-os-gardeners@google.com Change-Id: I3e4e7b5c94f34b1a5ad15edd38a71567b27fa660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251318Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779674}
-
Kyle Horimoto authored
Was forgotten in the original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2233898 Bug: b/154866535 Change-Id: I49b7d808ef62c1ebd9537043f1a0e61fc7c7fb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250472 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#779673}
-
Victor Costan authored
The test has a few sync wrappers for QuotaClient's async methods. The wrappers store the async method results as test fixture members. This scope is unnecessarily large, which is an unnecessary mental burden on folks who need to understand the test. This CL stores each async method result as a local variable in the method's sync wrapper and removes the member variables. DeleteOriginData() is also changed to pass through the async result. This will produce more informative messages if the tests fail. Change-Id: Ia5afba6a532593a610f52beba13efe376dbf46d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250709 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#779672}
-
Leonid Baraz authored
Bug: b:153364303 Change-Id: I7355fcf9ffc717983b1c8ea3808cbec86a95f55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242472 Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#779671}
-
Tarun Bansal authored
Refactor detection of offline connections for the purpose of offline indicator to a separate class. This class also handles the logic of waiting for 2 seconds after the connection is offline before notifying the offline indicator class. If the connection is online, then the indicator class is notified immediately. In the next CL, this class would also handle the logic of holding on to the notification when Chrome is brought to the foreground (see crbug.com/1093574) Change-Id: I3368fce894b1fa2dfda3efce3fef5c3764c7217b Bug: 1084740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240899 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#779670}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a286a8469b97..22e7befe144d 2020-06-18 chonggu@google.com [Fuchsia] Add Tracing Support for Fuchsia in Telemetry If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1088033 Tbr: eseckler@google.com Change-Id: I73a05fde41e8cb0b92a787a51f4b857eeb200ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250817Reviewed-by:
-
Luciano Pacheco authored
Bug: 1064504 Change-Id: I25aa5a0d12c1a13f1b7c4e3a816e8ce34c1d2e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248387 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#779668}
-
Luciano Pacheco authored
Bug: 1064504 Change-Id: Ic985380972ba755b68226072ff3da1c29a71abab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249429 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#779667}
-
alanlxl authored
Update the tf native code of neural palm detection. Model description: 1. Trained with kohaku + meowth data, the auc on basking data is 0.9478. 2. Feature vector is the same as the old one, feature size = 193. Bug: 1095874 Test: deployed and tested on a kohaku device Change-Id: Id62f14f82dfc9d0895aba88765b44407cd35db6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249279Reviewed-by:
Rob Schonberger <robsc@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#779666}
-
Yi Xu authored
Test case fast/canvas/canvas-composite-text-alpha.html is flaky on Mac, linux and windows platform. The expected outcome of the test is Pass or Timeout. Bug: 1093836 Change-Id: I0f9c8e4ce891cb12ca0be72fd0e506ff3c3b4c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249438 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#779665}
-
Meilin Wang authored
This CL is splitted from the original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2199870 with all files changed on ambient/. side. Bug: b/156531168 Test: unittests. Change-Id: I4f84277c74c95419ac96e6cfaaa48081c407b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248878 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#779664}
-
Kent Tamura authored
This CL adds base::Feature for LayoutNGRuby runtime flag. We can disable the feature by Finch when we find a critical bug of the feature. Bug: 1069817 Change-Id: I93385fd2e6a67acad7af3e45310e254b6692f504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250140 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#779663}
-
Kent Tamura authored
ComputeAnnotationOverflow() produced annotation overflow values even without any ruby annotation text because text fragment height can be taller than line-height. Such annotation overflow values extended line spacing. This CL fixes this issue. Bug: 1069817 Change-Id: I044cf909567b549cec38d1b97de36e6dde836dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251139 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#779662}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592434762-368c9b0f65c1d2b4a5321bdc0e3bbf6ce9a20651.profdata to chrome-win32-master-1592441973-8f9a4741d5f9fee5ba7748f102e2fb2e80661b9c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iefa9fb5c1c3e62c032fc8fb78372a084dab5a2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250813Reviewed-by:
-
Victor Costan authored
QuotaClient's methods will only be called with a StorageType in the list of types provided to QuotaManager::RegisterClient(). The QuotaClient implementation managing service worker registrations only provides kTemporary, like all modern storage APIs. Therefore, its QuotaClient implementation does not need to handle other StorageType values. Bug: 1016065 Change-Id: I15d6cd4dc503790d6ac3a7b1d7bd5c5db0b6da01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249635Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Bug: 1064504 Change-Id: I08f2f92948113514e9288b440e2e4b7e954370bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245993 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5ed965e4370d..7898d65dedca 2020-06-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8dc0bde668a0df0f5b14e484ecaad21f5b3742fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250816Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c84220a61be7..b623d84fd3d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kinuko@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kinuko@google.com Change-Id: Iadad6cff154d44135a9b56118edea3177266bb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779657}
-
Robert Ogden authored
Leaves the UA and UA-Mobile hints though. Bug: 1096109 Change-Id: Ic15fb72c35deedabc9a9689cbe7df1795721f0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250355Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#779656}
-
Haiyang Pan authored
API 23: emulator version: 29.0.11 -> 30.0.12 system image: 31 -> 32 API 28: emulator version: 29.0.11 -> 30.0.12 system image: 9 -> 10 API 28 with playstore: emulator version: 30.0.0 -> 30.0.12 Change-Id: I1baa0354767f3fed5b52a4bcb31dc2df09500760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251167 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#779655}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I67e1610c7e4499995f2659b2e8ddb230d4f816f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250470Reviewed-by:
-
Haiyang Pan authored
The following are disabled in both chrome_public_test_apk and network_service_out_of_process_chrome_public_test_apk: * org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testThumbnailFetchingResult_defaultAspectRatio * org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testRecycling_aspectRatioPoint75 * org.chromium.chrome.features.start_surface.StartSurfaceLayoutTest#testActivityCanBeGarbageCollectedAfterFinished Bug: 1092987, 1096295 Change-Id: Ia218e3b87b0df6f694a0e96d06a9ac79357eee43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250710 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
-
Xing Liu authored
When download is scheduled to start in the future, don't auto resume it from auto resumption handler. The DownloadSchedule::only_on_wifi() is ignored here, we use DownloadItem::AllowMetered() to check network condition for "later" downloads. Bug: 1078454 Change-Id: Ib7cbd605ee86863899173400d820fa5a05f226c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248926Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#779652}
-
chrome://media-appTrent Apted authored
The launch handler follows the approach of `setCurrentDirectory`, but it is much simpler. There's no need to obtain the File in order to get the MIME type, since we assume all selected files are "related". (The Files app does not offer the media app as a viable launch task if all selected files do not match the file handler type declaration). Update and consolidate the test helpers used to trigger launch. Expose the "real" launchConsumer and use it for existing tests as well for extra test coverage. Bug: b/159107125 Change-Id: I2c0239b58ba9ae0dfe472b600af086a941c828ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247922Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#779651}
-
Yue Zhang authored
http://crrev.com/c/2247142 sets top margins for some sections in start surface. However, setting top margin for some sections with app:layout_scrollFlags="scroll" makes the scroll behaves weird for variation with omnibox_scroll_mode = quick. Without digging into the root cause, this CL fixes issue by dynamically setting the margins in code and skip setting top margins for OMNIBOX_ONLY variations. Bug: 1091988 Change-Id: I88e8b9b0524c148879262e0250adf9b3c57777c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250934 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779650}
-
