- 03 Jan, 2020 40 commits
-
-
Clark DuVall authored
This should help figuring out where the duplicate IDs are coming from. Bug: 996940 Change-Id: I3e3611e83ed563cf883729f307bbe2b66ac6b74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977186Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#728258}
-
shrekshao authored
Fix the issue where requesting GL_WEBGL_multi_draw_instanced_base_vertex_base_instance returns null when GL_WEBGL_multi_draw is first requested on passthrough. TBR=kbr@chromium.org Bug: 891861 Change-Id: Ib9c15787c8eef79c71d71386a3e1ac4add1f92d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986124Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#728257}
-
Tarun Bansal authored
Make it possible to configure loading predictor table size using field trials. The next step is to experiment with different sizes. Change-Id: I607f83e0ca557466d434143fa1894900a135cf7d Bug: 1038703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984253Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728256}
-
John Palmer authored
Change-Id: I8efa1dce401bd3088972a58881c7ff1eeed68fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986466 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#728255}
-
Yusuf Sengul authored
Bug: 1036084 Change-Id: If87438015293fcdcfa22eb1d1ccc2c2563884bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981118Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#728254}
-
Kevin Ellis authored
The animation was often finishing before the screenshot resulting in a failure. Extended the duration of the animation and starting the animation from the midpoint should address the flakiness without needlessly extending the run time of the test. Bug: 1029543 Change-Id: I32e7794ff77a3b26e7d7f260f80d4b00bbc9d6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986212Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#728253}
-
Andrew Xu authored
Scrollable shelf updates its layout when a shelf icon is added to shelf view as a child. When an external display is connected, shelf view of the external display should add shelf icons during shelf view initialization. However, ShelfView::Init is called before shelf view becomes the grand child of ScrollableShelfView. As a result, scrollable shelf cannot perceive the change in view hierarchy. This CL makes the initialization of shelf view be the last step of ScrollableShelfView::Init. It also fixes the side effect brought by reordering of child views' initialization. Bug: 1035596 Change-Id: Ice08606d34b5af725157602c0038d995df2d36ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984725 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728252}
-
Alex Turner authored
Adds PageLoad.Clients.Ads.FrameCounts.AdFrames.Total to the set of metrics recorded in the ad_tagging.cluster_telemetry benchmark. This will allow for a more direct measurement of frame coverage changes when filter lists are updated. Bug: 1036451 Change-Id: I31606e97f45867e6e68f9819f24a3ed1da74eae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986426Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#728251}
-
Brian Osman authored
This is a refactored (and now public) API to solve the same problem. SkRuntimeColorFilterFactory was just a shim over SkRuntimeEffect, and will be deprecated/deleted soon. Change-Id: I043c82ab38a2ddebfa29680f394c4263973ac42d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982791Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#728250}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0f14db22decb..d57274888541 git log 0f14db22decb..d57274888541 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 philipel@webrtc.org Run delay tasks on time when using GlobalSimulatedTimeController. 2020-01-03 nisse@webrtc.org Delete unused member BasicPortAllocator::allow_tcp_listen_ 2020-01-03 saza@webrtc.org Merge the preambles of the ProcessStream implementations Created with: gclient setdep -r src/third_party/webrtc@d57274888541 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I818c0c825514074bc0eff0c200f30ef190b7065c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728249}
-
Kelvin Jiang authored
This CL adds the following functionality: - GetMatchedRules API call, to get all rules an extension has matched - Ability for extension to specify a tab ID to filter rules in GetMatchedRules Bug: 983761 Change-Id: I3672d84cc23be0e21a1387ede52923c3fe6354ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913611Reviewed-by:
-
Patrick Noland authored
Bug: 1036556 Change-Id: I1f11e34de7915c8b40b141bd5243fbee95688458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986188Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#728247}
-
gogerald authored
Bug: 1035573 Change-Id: I12f217b6cb01481f3f414f81bcb6c41f14738c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974832Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#728246}
-
Robert Ogden authored
Still wanted to track regressions. Bug: 1037206 Change-Id: I257fe9880e3fe2d6aaadd074ad1c7c67079f7127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984817 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#728245}
-
Ian Kilpatrick authored
Previously we resolved lengths within ConstructAndAppendFlexItems using the block-size from the initial fragment layout. This resulted in under/over sized flex-items. This changes the calls to use NGLayoutResult::IntrinsicBlockSize instead. This also changes a few of the calls to use just border_padding, instead of border_scrollbar_padding. Bug: 845235 Change-Id: Ib332d1c68b2e99c13715a4ee9bda79868695df31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986857 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728244}
-
Alison Maher authored
This change reduces the number of times the WebThemeEngine and NativeTheme are called into in order to get the state of ForcedColors by caching its value in Document. Tests: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/style_engine_test.cc?l=1572 https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/css/style_engine_test.cc?l=1602 Bug: 970285 Change-Id: Ie03f911b65448a851b64ce001fff73a487b68f2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962625 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#728243}
-
Dominic Battre authored
TBR=isherman@chromium.org Bug: 956560 Change-Id: Ie5cf8a193452c0281b8770eaab4f3d0eb107bb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986076Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#728242}
-
Takashi Toyoshima authored
Add "ios" platform, and launching params for all platforms. Bug: 905971 Change-Id: Ic3a914063c286b321b64725435b2925b9b407763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981956Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#728241}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/114e7ffbe641..7426a76a4d80 Created with: gclient setdep -r src-internal@7426a76a4d80 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iec99463f7d98c82b344244e5bdf2b2d35aa530b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986861Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728240}
-
Pavel Yatsuk authored
BUG=1028382 R=twellington@chromium.org Change-Id: Iced791e07368a25ed4885978579a69fe71866524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982717Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#728239}
-
Balazs Engedy authored
These tests are slow on virtually all platforms and cause massive amounts of hidden CQ flakes. Bug: 1020379 Change-Id: I0fd54bbcd64ae22dbc4b2e407dbaf84287db2d69 TBR: petewil@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986826Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#728238}
-
Glen Robertson authored
Bug: 1037362 Change-Id: If79e815dea20975496dc90655a6d25311a7ee33b Fixed: 1037362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986465 Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium aad41255. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I336b6ddd2931273e385988a3dbe2dbc3fc5d3346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984505Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728236}
-
Jan Scheffler authored
This cl updates the testreults for crrev.com/c/1967136. Bug: chromium:1029826 Change-Id: Icb60e1bf3e45a6f07e83702255e11903c0afe39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967244 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#728235}
-
Michael Giuffrida authored
Bug: 1036865 Change-Id: I4a88c4df5f15292d34af5beed5274ad6311d3560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983262 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b0e11f6c807f..ad5473a1bad8 git log b0e11f6c807f..ad5473a1bad8 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 eseckler@google.com Merge changes I14fd3d97,I050183c3 Created with: gclient setdep -r src/third_party/perfetto@ad5473a1bad8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I088904bd86592133e266c276c288c2ca2ee378d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986855Reviewed-by:
-
Alison Maher authored
This change is a follow-up to the intrinsicSizes implementation based on feedback in the following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1949536 The main changes are as follows: 1. Pass in the correct information to CalculateChildPercentageBlockSizeForMinMax(). 2. Subtract out border_scrollbar_padding_ instead of border_padding_ from the intrinsic sizes if in legacy layout. Bug: 726125 Change-Id: I430a029ef76f7326a3224593c4c9bac18c0e94d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980895 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#728232}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4cbf1de4ac07..ccd45a5efe06 git log 4cbf1de4ac07..ccd45a5efe06 --date=short --first-parent --format='%ad %ae %s' 2020-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms ab3cf9c7bd22..605b00d7728f (1 commits) 2020-01-03 brianosman@google.com Tweak the CanvasKit interface to SkRuntimeEffect 2020-01-03 mtklein@google.com one more flourish 2020-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cbbfa2f28a0e..1fdf6ca5141d (1 commits) 2020-01-03 mtklein@google.com ultimate retry for image shader cleanup 2020-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 81693dc9..a12a9d87 (186 commits) Created with: gclient setdep -r src/third_party/skia@ccd45a5efe06 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I53c5370ac0cad09185c34432b0b4d7b0a278bacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986851Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5e198b494fa086f68300bf6d0ad8418dc733eb68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986849Reviewed-by:
-
Antonio Gomes authored
... instead of a dummy empty function on anonymous namespace. BUG=787254 R=haraken@chromium.org Change-Id: I39beabcbe99175a895522c7cca1e16d4c4aa0424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986132Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#728229}
-
Tomasz Wiszkowski authored
This change allows all suggestions to benefit from Spannable container that introduces .equals for Spannables. Bug: 982818 Change-Id: Ia31d7baf2fb4a97556090867b1f29e9f8fb1547b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968115Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#728228}
-
Antonio Gomes authored
... to use of the corresponding WTF counter part bind functionality. BUG=787254 R=haraken@chromium.org Change-Id: Icdd46e7cbe5da49110fe9fe9cbba911a6a56f396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984504Reviewed-by:
-
Evan Stade authored
Bug: none Change-Id: I0f8e0c81f64f0c340b95374296d85800c4197c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986236Reviewed-by:
-
Regan Hsu authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1967803, while learn more links were being swapped out with settings-localized-link elements, "nearbyPrintersListDescription" was incorrectly used for the link-url attribute when "printingCUPSPrintLearnMoreUrl" should have been instead. This CL corrects that mistake. Fixed: 1038646 Change-Id: If35351143c81c17e2bcaec0268281a41d9fcf576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985137Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#728225}
-
Antonio Gomes authored
... now that it is out of the Blink API layer. This is a follow up of crrev.com/c/1976214 BUG=919392, 704136 R=haraken@chromium.org Change-Id: I43a004e6c6eb170f95eca3704f4cb52efb142fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984503 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Eric Seckler authored
Previously, we already didn't emit the category or event name for end events that were split off from complete events. In preparation to the switch to the client libary, stop emitting them for explicit end events, too. Trace processor will match the begin/end pairs and emit the matched begin event's category and name when converting to JSON. Also stop emitting names of nestable async events (categories are still required as they are included in event ID matching [1]). [1] https://cs.chromium.org/chromium/src/third_party/perfetto/src/trace_processor/importers/proto/track_event_parser.cc?bpv=0&bpt=1&l=394 Bug: 928738 Change-Id: I80810ac555355270297f09804343107bed2bbbdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983174Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#728223}
-
Nicolás Peña Moreno authored
Currently, idlharness fails because attribution is not frozen in the toJSON output. This CL fixes that by calling FreezeV8Object on the object. In addition to this, we remove the loop and produce interface objects instead of JSON objects per the algorithm in https://heycam.github.io/webidl/#es-default-tojson. Change-Id: Idc4e2adb1c8bfedc296817d1ca259b2ab90fdb21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986015 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#728222}
-
Evan Stade authored
This change makes it easier to construct IconDescription by adding default values to three out of four constructor params. No functional change is intended, although on SK_ColorBLACK is changed to gfx::kPlaceholderColor. This should not matter because all the icons it applies to have hard-coded colors for every individual path (verified manually). Bug: none Change-Id: Ieed356656b2e1f346cbecd76a4d230a445873e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985124 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728221}
-
David Bokan authored
It looks like this crashes because of a null outer viewport scroll node. That should never happen here because we have an inner viewport scroll node. There's a few ways this could be going wrong: - A ScrollNode is marked as the inner scroll node even though it wasn't registered as one in viewport_property_ids_ - The ScrollNode doesn't exist in the property tree even though it was registered. - We're getting this bad combination from Blink. I've turned a few DCHECKs into release CHECKs to narrow down which of these it might be. Bug: 1037759 Change-Id: I972582da6e18725557859063da0889d465063c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981268 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#728220}
-
Abhijeet Kandalkar authored
The goal of this CL is to use new downcast helper and remove DEFINE_COMPOSITOR_KEYFRAME_VALUE_TYPE_CASTS from t_p/b/r/c/animation to adopt new downcast helpers. This CL removes DEFINE_COMPOSITOR_KEYFRAME_VALUE_TYPE_CASTS for below classes. - CompositorKeyframeColor, - CompositorKeyframeDouble, - CompositorKeyframeFilterOperations, - CompositorKeyframeTransform Bug: 891908 Change-Id: I2b34d477f21cb0aa016f78f7d7292c55809abaf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983680Reviewed-by:
-
