GitLab

In cases where there are only one match, active match ordinal might not
update properly due to prevention of update of UI. In other cases when
Find-in-page is forcefully redone due to DidFinishLoad call, previously
found active match is not reactivated correctly. This CL fixes both
of them.

Bug: 890622
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Icdb287af7a4cd27bdfb70dba1f53e12bd46d4723
Reviewed-on: https://chromium-review.googlesource.com/c/1256393Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596543}

BUG=None
TEST=unit_tests

Change-Id: Id67c423d842b7fabf9fb29e17cca2336cbd542cb
Reviewed-on: https://chromium-review.googlesource.com/c/1260025Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596542}

Android notifications are stored in Android logs. User data are removed
from media notifications in incognito mode to avoid leaking this data.
The change is behind a disabled by default switch and is previously
reviewed in: crrev.com/c/586868

Bug: 629887
Change-Id: Icbe2ba7b7b670e59f78dd53e282bc326631c9a9c
Reviewed-on: https://chromium-review.googlesource.com/c/1196367
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596541}

Currently PrefetchURLLoader in the browser process handles prefetch requests to
reduce the memory consumption by skipping sending back the body to the renderer
process, and to handle signed exchanges.

But when NetworkService or ServiceWorkerServicification feature is enabled,
prefetch requests from Service Worker controlled pages don't go to the
PrefetchURLLoader. So SignedExchange's prefetching processes, such as
certificate fetching and sub resource preloading will not be triggered.

To fix this problem, this CL moves the prefetch_loader_factory from
RenderFrameImpl to ChildURLLoaderFactoryBundle.
BuildServiceWorkerNetworkProviderForNavigation() clones the
ChildURLLoaderFactoryBundle with the prefetch_loader_factory, and passes it
to the ServiceWorkerNetworkProvider as a fallback_loader_factory which will be
used when respondWith() of the fetch event is not called in the service worker.

Note: This CL moves the routing logic of prefetch request from
RenderFrameImpl::FrameURLLoaderFactory to ChildURLLoaderFactoryBundle.
Calling fetch(event.request) in service workers for prefetch requests doesn't go
to the PrefetchURLLoader. So the signed exchange handling is not triggerd. This
change is supposed to be tentative and should go away, as we're likely moving
the special prefetch handling code into the network service. So we can remove
this change when that happens.

Bug: 890748
Change-Id: I6b5362b180a133d9274a20045ef82eaad9034ee4
Reviewed-on: https://chromium-review.googlesource.com/c/1256468
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596540}

Image: https://drive.google.com/open?id=1fxpVgLqHb4-5oUCU1pMVJbGjUhrheQSf
On 10.3.1: https://drive.google.com/open?id=1xaO4Ja8WZbvjRvT1lQXccBkTfBFiECqE

Bug: 891279
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I13ac8525ebc6108f0e2e064c424d7e8762435694
Reviewed-on: https://chromium-review.googlesource.com/c/1257792
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596539}

Bug: 715640
Change-Id: I130337f41b02b9402e4d27dd6e909212768989bf
Reviewed-on: https://chromium-review.googlesource.com/c/1260745Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596538}

Using wpt-import in Chromium d3447bbe.
With Chromium commits locally applied on WPT:
92605c16 "[Unified Plan] Remote MediaStreamTracks should be muted by default."
65d72632 "Make DTMF tone change more deterministic"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25791

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I899f588ba549321cda054ebf8929c9dcf29b2e7f
Reviewed-on: https://chromium-review.googlesource.com/c/1260922
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596537}

This patch renames |at_start_of_block_| to |should_collapse_white_space_| to
make variable name to represent what is indicate, for ease of code reading.

This is follow-up of the patch[1] which changed role of the variable.

[1] http://crrev.com/c/1250825 Make Element#innerText to not collapse white
space around inline-block

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Idfb50d1fe1b88643e8ccd8d38346587740251b0b
Reviewed-on: https://chromium-review.googlesource.com/c/1260387
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596536}

This reverts commit 4ad50af3.

Reason for revert: Breaks is_chrome_branded builds -- startup_tab_provider_unittest.cc is still referencing members of StandardOnboardingTabsParams that were removed.

Original change's description:
> NUX Onboarding: clean up build process.
> 
> This CL cleans up the remnants of the NUX Experiments bulid configs. Including:
> - removing os_win and google_chrome_branded build flag.
> - removing prefs that tracks if the one-off NUX experiments were seen.
> - fixing closure compile errors now that it needs to build on non-official bots.
> 
> Bug: 874153
> Change-Id: I03c1ed09c54f5ba91944bcb31837e80a0ee1fc74
> Reviewed-on: https://chromium-review.googlesource.com/c/1252906
> Commit-Queue: Scott Chen <scottchen@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596432}

TBR=sky@chromium.org,scottchen@chromium.org

Change-Id: I643cfa84bb9da07b4e1ebf8a9481d0ac32aeea90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 874153
Reviewed-on: https://chromium-review.googlesource.com/c/1260128Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596535}

Flaky crashes on all platforms.

TBR=dalecurtis@chromium.org

Bug: 891880
Change-Id: Ia4ae47a2c427d16a4983cd9188901353e1562ae6
Reviewed-on: https://chromium-review.googlesource.com/c/1260607Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596534}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I4243cfba3ba6e7b756ff434ba76eedfeee73ce6e
Reviewed-on: https://chromium-review.googlesource.com/c/1260265Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596533}

Use Adapter's power state for GetState().

Bug: 870192
Change-Id: I4c431fad09e540e8f20b21feb638ae6ba701f637
Reviewed-on: https://chromium-review.googlesource.com/c/1250581
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596532}

https://webrtc.googlesource.com/src.git/+log/cd18bf9522d4..e2a9282198da


git log cd18bf9522d4..e2a9282198da --date=short --no-merges --format='%ad %ae %s'
2018-10-04 buildbot@webrtc.org Roll chromium_revision d6b77ab5..fdb60d4f (596382:596485)
2018-10-04 thaloun@google.com Prepare for per-media DSCP values.  Push dscp for stun packets to the port layer where they are created.
2018-10-03 buildbot@webrtc.org Roll chromium_revision f33d9eb9..d6b77ab5 (596278:596382)
2018-10-03 qingsi@google.com Add API level check for the use of ConnectivityManager.getActiveNetwork.


Created with:
  gclient setdep -r src/third_party/webrtc@e2a9282198da

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I44ce5da6f6466e37d292eb61fdb24f36a0b1f1c9
Reviewed-on: https://chromium-review.googlesource.com/c/1260765Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596531}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b79459a0027..de6d4d2b0fca


Created with:
  gclient setdep -r src-internal@de6d4d2b0fca

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib83cde7f11e95c6813fa4a25a803c219dff7c9f9
Reviewed-on: https://chromium-review.googlesource.com/c/1260766Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596530}

This reverts commit cdafdcb9.

Reason for revert: Time outs on Mac https://bugs.chromium.org/p/chromium/issues/detail?id=892016

Original change's description:
> Do not apply hover during scroll
> 
> In order to improve the performance and eliminate the issues that the
> fake mouse move events cause to the testing and web developers, we
> should not send fake mouse move events during scroll. This is
> implemented behind a flag.
> 
> We will update the hover effect after scroll finishes in a following
> patch.
> 
> Bug: 877132
> Change-Id: Iee838f50e0a52b5048081d79f91442ddf0467e8f
> Reviewed-on: https://chromium-review.googlesource.com/c/1211907
> Commit-Queue: Lan Wei <lanwei@chromium.org>
> Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#596049}

TBR=dgozman@chromium.org,bokan@chromium.org,lanwei@chromium.org,dtapuska@chromium.org,nzolghadr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 877132
Change-Id: Ia388825045560d1d4cd4275e4ec5572819f2b6a1
Reviewed-on: https://chromium-review.googlesource.com/c/1260603Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596529}

This should fix a NO_RESOURCE error due to a change of bot from 8 core
to 32 core.

TBR=nodir

Bug: 891884
Change-Id: I7e496871a1b531e50e95cb55b82193519f8977bf
Reviewed-on: https://chromium-review.googlesource.com/c/1260327Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596528}

Let's also assert focus movements to the other focusables. Previously,
the only thing this test tested was that DOWN would _not_ move focus...

Once we've fixed Issue 801162, this test's expectations will change:
We want spatnav to first _focus_ the scroller (before scrolling it).

Bug: 803086, 801162
Change-Id: I5c8a964c2900fb3a550a55ba9a975c7a33ef42dd
Reviewed-on: https://chromium-review.googlesource.com/c/1257832
Commit-Queue: Hugo Holgersson <hugoh@vewd.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#596527}

Changing bounds in minimized state can lead to
bounds change on android side when restored, which
in turn causes delay.

Bug: 889438
Test: covered by unit test
Change-Id: I9f9c2feef9cf468a670bcdb5a729c5877fdca2b6
Reviewed-on: https://chromium-review.googlesource.com/c/1258970
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596526}

Rename it to WebAppDataRetriever.

Modernize: Use BindOnce.

Bug: 875698
Change-Id: I4bf74a2966642f606f0ed602bc5bc7d72466e1da
Reviewed-on: https://chromium-review.googlesource.com/c/1256404Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596525}

Following bot results are included.
10272 10275 10281 10286 10290

3 lines were removed and 3 lines were deflaked by consecutive
results since 10224.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I28db5da988c1af7bd9694c3ab82b76bc25d4994f
Reviewed-on: https://chromium-review.googlesource.com/c/1259702
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596524}

Users were feeling like they were "trapped in incognito". This solution
returns the user to the regular tabs tab switcher when the last
incognito tab is closed. This behavior is similar to pre-bijou.

Bug: 891396
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifa9ba23bcc4d0f6029dbff73e60acd42993e1272
Reviewed-on: https://chromium-review.googlesource.com/c/1259481Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596523}

Incognito temporary whitelist and the last item in it are removed.
All items in the list were audited and removed before and the list is
no more in use.

Bug: 861722
Change-Id: I2922c3010efe3685beff59271294669affa93af5
Reviewed-on: https://chromium-review.googlesource.com/c/1256684Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596522}

This patch means skip password_manager_utils
by creating one instance of that cleaner
and using a mock CredentialsCleaner::Observer.

Bug: 889983
Change-Id: I246133064540887c06104c85c97fad1ba7b7aed9
Reviewed-on: https://chromium-review.googlesource.com/c/1257495Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#596521}

There are two parts to this change:

1. Create a new BluetoothAdapterClient instance. For this we add
   "alternate_bluetooth_adapter_client()" to the bundle of DBus clients.
   This new instance uses a separate DBus Connection through
   BluezDBusThreadManager. This ensures actions on one client won't
   affect the other client.

2. Implement BluetoothSystem::GetState using the new client.

Bug: 870192, 882771
Change-Id: I9faa92e8234b14dd374a04b4c9e9acbcfd7e6201
Reviewed-on: https://chromium-review.googlesource.com/c/1215427
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596520}

Previously the position of toast was not updated when the display
size is changed and it might keep visible on wrong place.

This CL adds the code to update the location if the display metrics
is changed.

Bug: 882371
Change-Id: Ia416f9fa8dbbcd081b578c37da6826846da243f0
Reviewed-on: https://chromium-review.googlesource.com/c/1258746
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596519}

We have vertical-japanese-kokoro-insert.html to test Japanese
content in vertical flow, but not for horizontal flow.

In order to test the performance of CJK text and vertical
flow separately, this patch adds the horizontal flow version
of the test.

Bug: 636993
Change-Id: Iac256490d6c52e89f6396da61a581752184b3575
Reviewed-on: https://chromium-review.googlesource.com/c/1253165Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596518}

In issue 883117 an externally injected stylesheet changed scroll style
of QuickView text documents: scroll bars went missing.

Investigating more, I find the background color of QuickView <webview>
content is also not set, so it is currently possible for an externally
injected stlyesheet to override the background color of text documents
in QuickView by accident.

Prevent such accidents - set the <webview> content background color to
white and add a test to verify the background color.

Bug: 891150
Change-Id: Ic7881ae45b2f36ba94ed245bae3d5944cda0eb2e
Reviewed-on: https://chromium-review.googlesource.com/c/1260784Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596517}

https://chromium.googlesource.com/catapult.git/+log/0543f082e2f4..e3b37a4725a0


git log 0543f082e2f4..e3b37a4725a0 --date=short --no-merges --format='%ad %ae %s'
2018-10-04 dtu@chromium.org [common] Update commits script to show minutes and a longer history.


Created with:
  gclient setdep -r src/third_party/catapult@e3b37a4725a0

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Idcfce525e5caf38f351cacbb4f2d65fc9b3664a7
Reviewed-on: https://chromium-review.googlesource.com/c/1260764Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596516}

Tab is managing numerous classes used for the active WebContents
it is showing. This CL defines a TabWebContentsUserData that they
can inherit from. New interface initWebContents/cleanupWebContents
are to be defined by child classes.

It is first applied to TabGestureStateListener. The other classes
will follow.

Bug: 884597
Change-Id: I7d31b5a2d4c64aef49697fb0bbe8e3db4e3b2443
Reviewed-on: https://chromium-review.googlesource.com/c/1229734
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596515}

This change should make chromium.fyi/linux-code-coverage-generation
build one target with code coverage instrumentation and isolate it using
the chromium recipe.

This depends on change http://crrev.com/c/1258608

Tested locally:

~/chromium/src/tools$ ./mb/mb.py lookup -m chromium.fyi -b \
linux-code-coverage-generation

Writing """\
is_clang = true
is_component_build = false
is_debug = false
strip_absolute_paths_from_debug_symbols = true
symbol_level = 0
use_clang_coverage = true
use_goma = true
""" to _path_/args.gn.

R=mmoroz,stgao,liaoyuke

Bug: chromium: 891532
Change-Id: I5afdd45d149fad0f62b8a6b8f021c99d0217134c
Reviewed-on: https://chromium-review.googlesource.com/c/1255590Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596514}

Products like ZoomText use get_characterExtents with the special IA2_TEXT_OFFSET_CARET to get the
bounds of the character with the caret. Sometimes this results in getting the bounds for the
null character at the end of an editable textfield's text. In this case, get_characterExtents()
should return what the caret bounds would be if placed there.

In order to make this work, we can use the bounds of the anonymous inner editor element within
a textfield, and collapse it to the width of the caret. Normally this is exposed, but in the
case of an empty textfield, we were ignoring it.

This CL also adds a lot more tests for different kinds of empty fields. The plan is to move
the character extents implementation into the ui/accessibility code so that the automation
API support can leverage it.

Bug: 869985

Change-Id: I907a9df834f88aa9bf536e4dbbc9432e33d31202
Reviewed-on: https://chromium-review.googlesource.com/c/1255203
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596513}

The TODO was introduced in 2015:
https://codereview.chromium.org/981893002

Change-Id: I6efe5e05cee5c6553050d35f2437a165d065c282
Reviewed-on: https://chromium-review.googlesource.com/c/1260522Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596512}

https://skia.googlesource.com/skia.git/+log/8841085abeb9..4dd17156c6e4


git log 8841085abeb9..4dd17156c6e4 --date=short --no-merges --format='%ad %ae %s'
2018-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e5051aa35032..3b5e426b815f (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@4dd17156c6e4

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=mtklein@chromium.org

Change-Id: I3d7c22f28414aee22d2535fa11f9c3185193fa9c
Reviewed-on: https://chromium-review.googlesource.com/c/1260159Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596511}

The same check is done in other functions in this .cc file.
Do the same thing for UnwrapPlatformHandle().

BUG=891990
TEST=mojo_unittests

Change-Id: I05fe4bfd5edd8ec3fc67aeb9f11879c74fd71dd4
Reviewed-on: https://chromium-review.googlesource.com/c/1260782Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596510}

This is based on Dirk's comment in https://chromium-review.googlesource.com/c/chromium/src/+/1259475#message-01cdaf3daae02840bb55b523a0eb71c9201adade

TBR=dpranke@chromium.org, jbudorick@chromium.org

Bug: 891747
Change-Id: Iec031e348d26d77de3f897641f4a151d0b4f544d
Reviewed-on: https://chromium-review.googlesource.com/c/1260519Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#596509}

Problem:
Let a focused(and scrollable) element's (visible) bounding box
is (x, y, w, h). If we hit down arrow key, then its result of
SearchOrigin() will be (x, y, w, 0), i.e. top edge of the element.
This introduces additional candidates are considered if we use the
result. Previously, we are considering an element that its bounding
rect is (x', y', w', h'), where y' >= y+h (except intersecting
candidate). But, if we use the result, an element (x'', y'', w'', h'')
where y <= y'' < y+h can be candidate.

Here is an example:
(x, y, w, h)
---------  (x'', y'', w'', h'')
|       |  -----
|   A   |  | C |
|       |  -----
---------

  (x', y', w', h)
  -----
  | B |
  -----

In above example, assume that we hit down arrow key. And element 'A'
is focused and scrollable element. If we use A's bounding box as
search origin, then only element 'B' is candidate for getting focus,
because y+h < y', y+h > y''. But if we use top edge of element
'A'(x, y, w, 0), element 'C' also can be candidate because y+0 < y''.
In point of intuitive, element 'C' is not in down side direction of
element 'A', so it should not be candidate in this scenario.

Solution:
Use bounding box for focused(and scrollable) element as well.
This CL also change SearchOrigin() from recursion to iteration.

Bug: 891149
Change-Id: Ib9e3ba07859e6bfc415cd19f93b42cc33fda7c74
Reviewed-on: https://chromium-review.googlesource.com/c/1253523
Commit-Queue: JunHo Seo <junho0924.seo@lge.com>
Reviewed-by: Hugo Holgersson <hugoh@vewd.com>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#596508}

For synthesized scroll/drag/pinch gestures, dispatch the events
at a high frequency (120Hz) so that there's at least one event in
each frame. Dispatching events at a lower frequency (60Hz) means
the timer can go out of sync with begin-frame, and so there can
be frames where there was to event dispatch. Our telemetry code
reports this as jank, which is incorrect. Dispatching at a higher
frequency for the scroll/drag/pinch gestures resolves this issue.

BUG=783034

Change-Id: I1102f76ed743231cbb10fdb872e8c66f895fa223
Reviewed-on: https://chromium-review.googlesource.com/c/1255152Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596507}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a664d328ecfc..6b79459a0027


Created with:
  gclient setdep -r src-internal@6b79459a0027

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I0c200a5a9c289c60a3ca77a19cba1f1fbdc9ee56
Reviewed-on: https://chromium-review.googlesource.com/c/1260158Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596506}

TBR=aluo@chromium.org

Bug: 814405
Change-Id: I0daf53d6e5784d5f476d804e4c13dcc2c35ba5c5
Reviewed-on: https://chromium-review.googlesource.com/c/1260385Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596505}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I58af57e2d849ca7f2c25e8a19adddac074f90d6e
Reviewed-on: https://chromium-review.googlesource.com/c/1260763Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#596504}