Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 04 Dec, 2018 31 commits
  3. 03 Dec, 2018 9 commits
    • chromium-autoroll's avatar
      Roll src/third_party/webrtc ec0f45be1144..ec086d842ce7 (1 commits) · 1e31da31
      chromium-autoroll authored 
      https://webrtc.googlesource.com/src.git/+log/ec0f45be1144..ec086d842ce7


git log ec0f45be1144..ec086d842ce7 --date=short --no-merges --format='%ad %ae %s'
2018-12-03 srte@webrtc.org Fixes race in SendSideCongestionControllerTest.OldFeedback.


Created with:
  gclient setdep -r src/third_party/webrtc@ec086d842ce7

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2b9c9d8a3e9eb8b45e4b661eba92c960a2b9a680
Reviewed-on: https://chromium-review.googlesource.com/c/1359372Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#613336}
      1e31da31
    • Ken Rockot's avatar
      More migration of ServiceContext to ServiceBinding · 700c68d8
      Ken Rockot authored 
      Migrates most remaining usage of ServiceContext over to ServiceBinding
and eliminates all remaining usage of EmbeddedServiceInfo outside of
content.

Bug: 891780
Change-Id: Id7a83918e58a1cecdcadd6c20ee624c1dcbd3729
Reviewed-on: https://chromium-review.googlesource.com/c/1357534Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#613335}
      700c68d8
    • Nigel Tao's avatar
      First draft of an App Service extension publisher · 3582e2d0
      Nigel Tao authored 
      Lots of TODOs, but there's enough implemented so that running "chrome
--enable-features=AppService" will populate the launcher with extension
apps' names and icons, and clicking on the icon will launch the app.

BUG=826982

Change-Id: Id424abac859dde69ffdac3c28a473fce61fbe8df
Reviewed-on: https://chromium-review.googlesource.com/c/1351975
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Reviewed-by: default avatarYusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613334}
      3582e2d0
    • Joshua Peraza's avatar
      Reland "Enable Crashpad for Android" · b8d90223
      Joshua Peraza authored 
      This is a reland of 66b2e0f1

Original change's description:
> Enable Crashpad for Android
>
> Overview:
> This CL disables Breakpad for Chrome, Content Shell, WebView, and
> Chromecast on Android and replaces it with Crashpad. When a crash
> signal is received, the browser forks+execs a Crashpad handler process
> either for itself or on behalf of a crashing child to create a crash
> dump.
>
> components/crash/
>   - Remove CrashDumpManager. Minidump creation is handled entirely by
>     Crashpad.
>   - Remove OnChildStart from ChildExitObserver as it is no longer
>     necessary.
>   - ChildExitObserver observers CrashHandlerHost to be notified when
>     child processes receive crash signals.
>   - De-duplicate calls to ChildExitObserver::Client::OnChildExit when
>     NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent.
>
> components/minidump_uploader/
>   - Uploaders expect crash reports to already be MIME encoded since
>     Breakpad was doing that in a signal handler call-back.
>     CrashFileManager now automatically calls into native code to do
>     the encoding and write to a directory of crash reports whenever it
>     checks for reports without logcats.
>
> chrome/app/*.{cc,h}
> chrome/browser/*.cc
> content/shell/app/*.{cc,h}
> content/shell/browser/*.cc
>   - Initialize Crashpad instead of Breakpad, with minor cleanup and
>     adjustment for changes to CrashDumpObserver.
>
> chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc
>   - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED,
>     CLOSED} and signals sent to ChildExitObserver instead of a crash
>     dump.
>
> android_webview/
>   - AwBrowserTerminator now observes child process crashes via
>     ChildExitObserver rather than its own pipe.
>   - Crashpad always produces minidumps, and not microdumps.
>   - Disabling Crashpad is not yet supported.
>
> chromecast/
>   - There are now two directories that crash report uploaders should
>     be aware of: "Crashpad" contains a database of raw minidumps
>     produced by Crashpad, and "Crash Reports" contains MIME encoded
>     minidumps. MIME encoding is performed by a CrashReportMimeWriter
>     in CastCrashUploader.java:checkForCrashDumps().
>
> Bug: crashpad:30
> Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
> Change-Id: I0efa451585f60287853c47f860f09ced581c8958
> Reviewed-on: https://chromium-review.googlesource.com/c/989401
> Commit-Queue: Joshua Peraza <jperaza@chromium.org>
> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612987}

TBR=tobiasjs@chromium.org,jam@chromium.org,wnwen@chromium.org,halliwell@chromium.org,sanfin@chromium.org,yfriedman@chromium.org,peter@chromium.org,isherman@chromium.org

Bug: crashpad:30
Change-Id: Ia1654bc4fbe59005513f30364753309ae232052d
Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg
Reviewed-on: https://chromium-review.googlesource.com/c/1357941
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Reviewed-by: default avatarMark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613333}
      b8d90223
    • Dan Beam's avatar
      Dark Mode / WebUI: make TestWebUI auto-register message handlers · e59ccd94
      Dan Beam authored 
      This makes test code easier to write and understand and is also what the
"prod" WebUI class already does.

This is loosely related to Dark Mode support, as I discovered this
difference in behavior while working on unit tests for this work.

WIP Dark Mode CL: https://crrev.com/c/1354685

R=jam@chromium.org
BUG=883049

Change-Id: I6862e2cd0244bdb02bd6dd92870bc2ec70d2099a
Reviewed-on: https://chromium-review.googlesource.com/c/1359132Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613332}
      e59ccd94
    • Dominic Mazzoni's avatar
      Remove flag from espeak · 45b6eae1
      Dominic Mazzoni authored 
      Bug: 862710
Change-Id: I84432cae10fb11134023dd68da86995855fa809f
Reviewed-on: https://chromium-review.googlesource.com/c/1351088Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613331}
      45b6eae1
    • Eugene But's avatar
      Do not use LoadCommittedDetails.item in VoiceSearchNavigationTabHelper. · da0c6d87
      Eugene But authored 
      NavigationItemCommitted is deprecated in favour of DidFinishNavigation.
This change will simplify transition from NavigationItemCommitted to
DidFinishNavigation, because DidFinishNavigation does not pass
NavigationItem as argument.

Bug: 720786
Change-Id: I758d7220c2d600bc663d8c55eeb49b5c54e619ff
Reviewed-on: https://chromium-review.googlesource.com/c/1356770
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613330}
      da0c6d87
    • Doug Arnett's avatar
      [Previews] Removes unused EffectiveConnectionTypeThresholdForClientLoFi · 0868dc05
      Doug Arnett authored 
      The EffectiveConnectionTypeThresholdForClientLoFi() is no longer used
except for tests (replaced by GetECTThresholdForPreview(PreviewsType::LOFI)),

Change-Id: I925c21ecd5589d6a74f232359dd24f2e84b16ed3
Reviewed-on: https://chromium-review.googlesource.com/c/1359460Reviewed-by: default avatarRyan Sturm <ryansturm@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613329}
      0868dc05
    • dpapad's avatar
      WebUI: Convert remaining usages of var to let/const, part 1. · ed18408a
      dpapad authored 
      Conversions performed with a tool (lebab). In a few occasions had to
manually convert, where the tool could not determine if the conversion
was safe.

This is in preparation of turning on no-var, and prefer-const ESLint
checks for all of chrome/browser/resources/

Bug: 792774
Change-Id: I0d5fa98d5efb935e84c1990db635f96df5957e4d
Reviewed-on: https://chromium-review.googlesource.com/c/1357726Reviewed-by: default avatarDan Beam <dbeam@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613328}
      ed18408a