- 24 Jul, 2018 40 commits
-
-
mark a. foltz authored
This completes the work to make the Presentation API mojo service part of the Blink public API. Bug: 817903 Change-Id: I9e9cdc4567bb906640eb0ba68375e023f77305dd Reviewed-on: https://chromium-review.googlesource.com/1145782Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577654}
-
Alex Moshchuk authored
The goal of this CL is to do a DumpWithoutCrashing if we ever send a proxy creation IPC to the same renderer process more than once. This shouldn't ever happen, since even if the proxy becomes non-live after a process crash and is later recreated, the IPC should go into a newly respawned renderer process. Bug: 794625 Change-Id: I6df34d2582645c8c398b9f6b6ce9c87ba772591d Reviewed-on: https://chromium-review.googlesource.com/1147483Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#577653}
-
Derek Cheng authored
This reverts commit 6ec9b32f. Reason for revert: <INSERT REASONING HERE> svg/as-border-image/svg-as-border-image.html / svg/as-border-image/svg-as-border-image-2.html have been failing since https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.13%20%28retina%29/65 Original change's description: > [LayoutNG] Remove spaces before <br> to avoid crbug.com/40634 > > This patch removes spaces before <br> because the images do > not match due to crbug.com/40634, which LayoutNG does not > have the problem. > > TBR=eae@chromium.org > > Bug: 591099 > Change-Id: I8f0770f8911ce2d5c6f9e37ff90752011b84cb49 > Reviewed-on: https://chromium-review.googlesource.com/1142050 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576333} TBR=eae@chromium.org,kojii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 591099 Change-Id: Iaeae508ed67354b06beec60704fdb0da5021bd34 Reviewed-on: https://chromium-review.googlesource.com/1148807Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577652}
-
Jeremy Newton-Smith authored
assets/cast_config was being accessed. Bug: Internal 111712809 Test: Verified that file descriptors were no longer being leaked when Change-Id: Ide58d71f9f284255cb1d73f3dadae111875be453 Reviewed-on: https://chromium-review.googlesource.com/1148686Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Jeremy Newton-Smith <jeremyns@chromium.org> Cr-Commit-Position: refs/heads/master@{#577651}
-
Rajesh Mahindra authored
To add the functionality of a reverse proxy to the QUIC server, 2 classes were added: 1. QuicHttpProxyBackend: Implements the interface: QuicSimpleServerBackend to fetch the response from a backend server. Creates a proxy thread and manages an instance of net::URLRequestContext within that thread to make HTTP calls to a backend server. 2. QuicHttpProxyBackendStream: Created on a per-stream basis, manages an instance of the class net::URLRequest to make a single HTTP call to the backend server using the context created by QuicHttpProxyBackend. Run As a Proxy To run the quic_server as a reverse proxy, run with --mode=proxy. The param --quic_proxy_backend_url specifies the backend server from which the response is fetched. For instance, ./out/Default/quic_server \ --certificate_file=net/tools/quic/certs/out/leaf_cert.pem \ --key_file=net/tools/quic/certs/out/leaf_cert.pkcs8 \ --mode=proxy \ --quic_proxy_backend_url=http://localhost R=rch@chromium.org, zhongyi@chromium.org Change-Id: I79b7d66eb6bba9628d99181def004c0a5ea2e214 Reviewed-on: https://chromium-review.googlesource.com/1128323 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577650}
-
Rohit Rao authored
When the previous view controller's title is too long, iOS may choose to label the navigation bar's back button with either the word "Back" or to omit the label entirely. Have EG tests search for the back button using all three potential labels. BUG=863476 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7cae966be78e63b4a26f0e2d2a1f708b43a46d0 Reviewed-on: https://chromium-review.googlesource.com/1148466 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577649}
-
Toni Barzic authored
External loader that loads extension CRXs from the offline demo resources image mounted by the image loader service. It expects that offline demo resources, in addition to actual CRX files to install, a JSON that maps bundled app IDs to the CRX location and app version (in the same format as for other external extensions, e.g. default Chrome OS apps). Bug: 863162 Change-Id: I88aa544be10d74c1ead10a685bb7fd238f18cdd0 Reviewed-on: https://chromium-review.googlesource.com/1134579Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#577648}
-
Chris Blume authored
A few small typos were recently introduced in some comments. This change fixes those typos. No compiled code changed. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1e3d1e7224fcab1c18d98ed19fd1d50fa6f640cc Reviewed-on: https://chromium-review.googlesource.com/1147073Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#577647}
-
Sergey Ulanov authored
Previously ComponentControllerImpl::BindToRequest() was called twice, so the Context process was crashing. Bug: 850743 Change-Id: I7fe63558afcf586beb1380ce0d108458e1532f9b Reviewed-on: https://chromium-review.googlesource.com/1147551 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#577646}
-
Charlie Andrews authored
Based on a try job launched in the linked bug, this story appears to be passing now. TBR=nednguyen@chromium.org Bug: 657433 Change-Id: Id2351f2dd2f763d695a1256c72f6e5aff53677b0 Reviewed-on: https://chromium-review.googlesource.com/1143446 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#577645}
-
Robert Sesek authored
The script is no longer used by the signing pipeline and will be removed in https://chrome-internal-review.googlesource.com/c/654803. Bug: 660598 Change-Id: Ia80e4dfbf186c2142b8aff021e3842f87c44a2ad Reviewed-on: https://chromium-review.googlesource.com/1147472Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#577644}
-
David Black authored
We should not show Assistant UI when the Assistant has been disabled in Chrome OS settings. This reverts a change made in: https://chromium-review.googlesource.com/c/chromium/src/+/1141346 Bug: b:111704810 Change-Id: Ic8ede48f0637efbc7520df7e1223964554055aef Reviewed-on: https://chromium-review.googlesource.com/1146151 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#577643}
-
Robbie McElrath authored
This will allow NetBenchmarking to be used with the network service enabled. This also adds a NetworkContext::CloseAllConnections method. Bug: 824974 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I566124d13e6607d579583202f030425ec2f3c598 Reviewed-on: https://chromium-review.googlesource.com/1135715Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#577642}
-
Eric Karl authored
LockTexture currently crashes if a texture is not found. This can happen when initialization of a discardable texture fails, and should be handled gracefully rather than crashing. R=khushalsagar Bug: 866808 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia920e7ee649a30f550e968d4e8350f40e77f84b1 Reviewed-on: https://chromium-review.googlesource.com/1148684 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#577641}
-
Zhongyi Shi authored
Bug: 790547 Change-Id: I7aa158e639094bc4234b7c41243685084b2ea24f Reviewed-on: https://chromium-review.googlesource.com/1147679 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#577640}
-
Derek Cheng authored
It is flaky as part of network_service_browser_tests on Linux Tests (dbg)(1). TBR=dvadym Bug: 347159 Change-Id: I72e204f87334d94723c26b998d4b649e187c78f0 Reviewed-on: https://chromium-review.googlesource.com/1148774Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577639}
-
tzik authored
ChainedBlobWriterImpl is a ref-counted object, and its first reference used to be taken by base::BindOnce implicitly in its constructor. The reference is posted to another thread, and released after the task has run. However, if the task finished before the constructor finished, the object is destroyed immediately, and `new ChainedBlobWriterImpl` may return a stale pointer. This CL adds a static constructor to ChainedBlobWriterImpl to keep a reference while the task is posted. Bug: 866456 Change-Id: If8fee2e8944ce550e766b5269d47878f357db6c5 Reviewed-on: https://chromium-review.googlesource.com/1148098Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577638}
-
John Abd-El-Malek authored
The problem was different timing of loading messages. Normally, DocumentLoaderImpl::DidRead is called very early which calls into DocumentLoaderImpl::SaveBuffer. The latter sees that the request was in |pending_requests_| and then calls OnPendingRequestComplete which loads the information about the document (e.g. number of pages, linearized PDF info). With the network service, OutOfProcessInstance::DidChangeView was being called before the DidRead calls which was causing |pending_requests_| to be reset. The fix is to only reset pending_requests_ in PDFiumEngine::CalculateVisiblePages if we have already loaded the PDF document structure. This was the intended effect of that code; the extra check wasn't needed before the network service because we were always reaching that function after the document info was loaded. Bug: 705114 Change-Id: I4e668ebfdda0c17ede3c6daa951dea0a1b38eb05 Reviewed-on: https://chromium-review.googlesource.com/1147932Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#577637}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/734b2a859784..6a4e60bb8f49 git log 734b2a859784..6a4e60bb8f49 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 robertphillips@google.com Revert "Reduce arbitrary opList splitting when sorting (take 2)" 2018-07-24 egdaniel@google.com Add Metal test bots. 2018-07-24 ethannicholas@google.com Revert "Revert "removed SkSLLayoutLexer"" 2018-07-24 robertphillips@google.com Reduce arbitrary opList splitting when sorting (take 2) Created with: gclient setdep -r src/third_party/skia@6a4e60bb8f49 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I892ad89cf41a6ee9525774ce615b479a766eb701 Reviewed-on: https://chromium-review.googlesource.com/1147959Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577636}
-
Xiangjun Zhang authored
This CL adds implementation to create a network context through Network Service for the Mirroring Service. Bug: 734672 Change-Id: I26422b4f4f5c69bd8398dc3ae3d5ee501c996eea Reviewed-on: https://chromium-review.googlesource.com/1139218Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577635}
-
Lu Chen authored
After a webpage is loaded, get metrics of anchor elements in the viewport and send them to the browser process. These metrics, together with metrics extracted in the browser process, are used to compute and record anchor element navigation overall score. This navigation score will be used to decide what action (e.g.,preload, prerender) to take, (or choose to do nothing). Bug: 850624 Change-Id: Ieb85bc0b048f5ec6cb174c41e9b3d72639b393c9 Reviewed-on: https://chromium-review.googlesource.com/1119201 Commit-Queue: Lu Chen <chelu@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Kaplow (OOO until 0730) <rkaplow@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577634}
-
Mitsuru Oshima authored
IME uses this propery to tell if it's arc windows. With this fix, text input on type type window (e.g. FB ChatHead) works again. BUG=b/111713229 TEST=manual. See bug for repro step. Change-Id: Ifa058f3a4c4c91daf7059311044c4440780f47ad Reviewed-on: https://chromium-review.googlesource.com/1148237Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#577633}
-
Ricardo Quesada authored
Fix small typo in a comment. 'pixesl' is replaced by 'pixels' BUG=None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie916fc278f794eb07b81e71c519972bbcb9d8d16 Reviewed-on: https://chromium-review.googlesource.com/1148599Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Cr-Commit-Position: refs/heads/master@{#577632}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/696e3951..5107ef4f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifc51ffbc7fd1202a57b98970ce5dc77fa5ab1885 Reviewed-on: https://chromium-review.googlesource.com/1148641Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577631}
-
Daniel Cheng authored
- GetMemoryAs<T> should be used when the mapping contains one T. - GetMemoryAsSpan<T> should be used when the mapping contains more than one T. The element count can be explicitly specified or autodeduced from the size of the shared memory mapping. Bug: 795291, 866975 Change-Id: Icea4e276a26a1c47688c0a5206b97cd42ff92043 Reviewed-on: https://chromium-review.googlesource.com/1144312Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577630}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6ec6d27f2d1b..ca7d881540e3 git log 6ec6d27f2d1b..ca7d881540e3 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 ehmaldonado@chromium.org Reland "Reland "gclient_scm: Use cherry-picking instead of rebasing."" Created with: gclient setdep -r src/third_party/depot_tools@ca7d881540e3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812 TBR=agable@chromium.org Change-Id: I64f7a6ad1c38b3453ef7493fd3789454d58b333b Reviewed-on: https://chromium-review.googlesource.com/1147912Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577629}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: I2d2f80b5d0b84b1315016903b74f06d10ab6d4e8 Reviewed-on: https://chromium-review.googlesource.com/1146189Reviewed-by:
Egor Pasko (futex_wait(&secret))) <pasko@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#577628}
-
Derek Cheng authored
TBR=foolip@chromium.org Bug: 866965 Change-Id: If4b3f8c350b4677490f2ad72d47d12437d82c77d Reviewed-on: https://chromium-review.googlesource.com/1148659Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577627}
-
Jun Mukai authored
BUG=857103 TEST=ash_unittests, unit_tests Change-Id: I46f1b09a2d2ad4a90fe42c75a9d0f587c03ab1cf Reviewed-on: https://chromium-review.googlesource.com/1137232 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#577626}
-
Esmael El-Moslimany authored
Bug: 865899 Change-Id: Ic759da99d5dd11f2e08b201b731bab8006da7b38 Reviewed-on: https://chromium-review.googlesource.com/1145625 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577625}
-
tzik authored
This CL adds a static constructor to ScreenObserverDelegate to avoid a racy ref count operation. As ScreenObserverDelegate is a ref counted class, base::Bind implicitly increments the reference count, and releases it on the callback instance destruction. If PostTask in the SOD ctor fails, or the posted task ran soon before the ctor has completed, the ScreenObserverDelegate instance may be destroyed immediately, and `new ScreenObserverDelegate` may returns a stale pointer. Bug: 866456 Change-Id: I7c64915529786b2f0738731c323aaf2f293dbc20 Reviewed-on: https://chromium-review.googlesource.com/1147896Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#577624}
-
kristipark authored
Add functionality to add, delete, undo delete, and reset custom links. These can only be called from the Most Visited or the edit custom links iframes. Delete and undo delete will use the existing "deleteMostVisitedItem" and "undoMostVisitedDeletion". Bug: 856394 Change-Id: I737aa72b92225e2e20174351bd431578311a3396 Reviewed-on: https://chromium-review.googlesource.com/1144526 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#577623}
-
Samuel Huang authored
This is the last of the series of CLs to add LLD-LTO string literal support to Supersize by parsing BC .o files when LLD-LTO is enabled. Details: - Add ResolveStringPieces() (alongside ResolveStringPiecesIndirect()) to process strings extracted from BC files. - Check each .o files processed to decide if it's a BC file. - nm is still used to process all .o files (including BC files) to extract symbols. - Any BC .o files found are processed by the new code that calls llvm-bcanalyzer. This provides flexibility since some .o files may still be ELF. Bug: 723798 Change-Id: I5b7d1db9f91a2cd6749fe4c57595ac46eee664a8 Reviewed-on: https://chromium-review.googlesource.com/1130006Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#577622}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bff8e3ea. With Chromium commits locally applied on WPT: 4bd63c29 "webrtc wpt: close RTCPeerConnection in generateAnswer helper" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21664 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: I7360a6b3716d213b4f87c06283e282814b55960a Reviewed-on: https://chromium-review.googlesource.com/1148583 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#577621}
-
Ryan Hamilton authored
Merge internal change 205691599. BUG=865809 Change-Id: I0369074ac0c1e754cc350c37a47681101e35cf12 Reviewed-on: https://chromium-review.googlesource.com/1148640Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577620}
-
Andrew Luo authored
Bug: 857590 Change-Id: I2e7387d87e0459e331648ddee8e106a0716af8de Reviewed-on: https://chromium-review.googlesource.com/1144522Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#577619}
-
Patrick Monette authored
In some rare circumstances, that function trigger the reconfiguration of a product, which can open the Windows Installer dialog. It is unknown yet why this happens because we have no repro, but the fix was verified with an external user. Instead look for the path of the component directly in the registry. Bug: 860537 Change-Id: Ib1d32a9f8b64f234c20c11d04bb2d825d51f00eb Reviewed-on: https://chromium-review.googlesource.com/1145821Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#577618}
-
Scott Violet authored
BUG=842365 TEST=none Change-Id: I4006ea0b9fd59d183620b90aafa182a239e9bfb7 Reviewed-on: https://chromium-review.googlesource.com/1146994Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#577617}
-
Mostyn Bramley-Moore authored
Otherwise gitiles renders these as (broken) relative links. Change-Id: I66fffdf2e9934bfa7ced35f2850d528a2bbfa947 Reviewed-on: https://chromium-review.googlesource.com/1148046Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#577616}
-
Jan Krcal authored
This CL makes all sync owners own autofill sync bridges. The current owner from the sync team (jkrcal@) is left there to indicate who is the primary POC for this code. Bug: 853688 Change-Id: I0a5d26ccbbd75b86033b853e37fc29a1998050ea Reviewed-on: https://chromium-review.googlesource.com/1148578Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#577615}
-