GitLab

This patch was split off from the larger CL authored here:
https://codereview.chromium.org/1901303004/

BUG=605259

Review URL: https://codereview.chromium.org/1919193003

Cr-Commit-Position: refs/heads/master@{#389903}

After setting emma_coverage as true, and then run JUnit testcases, code
coverage information will be stored in coverage.ec. In order to read
coverage.ec file, you will need to find the corresponding <name>.em file
in out-gn/Debug and then merge the .em and .ec file into a txt or html.

BUG=604900

Review URL: https://codereview.chromium.org/1913593002

Cr-Commit-Position: refs/heads/master@{#389902}

BUG=598073

Review URL: https://codereview.chromium.org/1914063003

Cr-Commit-Position: refs/heads/master@{#389901}

These became unused due to recent changes to the Bookmarks integration.

BUG=589526

Review URL: https://codereview.chromium.org/1921563005

Cr-Commit-Position: refs/heads/master@{#389900}

This CL addresses odd size frame problems found by fuzz tests.

BUG=606185
TEST=Minimized fuzz test case now passes. Also added unit tests.

Review URL: https://codereview.chromium.org/1918073003

Cr-Commit-Position: refs/heads/master@{#389899}

Using update-w3c-deps in Blink 3f9ef169.

In anticipation of trying to activate some more tests
rebasing against the latest web platform tests is
needed.

BUG=606875,606900,606934

Review URL: https://codereview.chromium.org/1923043002

Cr-Commit-Position: refs/heads/master@{#389898}

BUG=

Review URL: https://codereview.chromium.org/1903533002

Cr-Commit-Position: refs/heads/master@{#389897}

The Windows settings page was opened instead of the intent picker.

BUG=606928

Review URL: https://codereview.chromium.org/1920033004

Cr-Commit-Position: refs/heads/master@{#389896}

This brings it up to speed with our present naming, where classes that
inherit from TracingAgent end with TracingAgent themselves.

Review URL: https://codereview.chromium.org/1908373003

Cr-Commit-Position: refs/heads/master@{#389895}

TBR=yfriedman@chromium.org
BUG=606939,606942

Review URL: https://codereview.chromium.org/1924483003

Cr-Commit-Position: refs/heads/master@{#389894}

for the very first navigation within the MetricsWebContentsObserver.

This is used for the FromGWS abort metrics.

This patch was split from the previous CL here:
https://codereview.chromium.org/1901303004/

BUG=605259

Review URL: https://codereview.chromium.org/1924543002

Cr-Commit-Position: refs/heads/master@{#389893}

Changed to use std::unique_ptr in tests since scoped_ptr is being
removed.

Original patch: https://codereview.chromium.org/1877273002/
Revert: https://codereview.chromium.org/1916973003/

TBR=mfoltz@chromium.org

Review URL: https://codereview.chromium.org/1918403002

Cr-Commit-Position: refs/heads/master@{#389892}

It is critical that the pref service outlives the update_client.

BUG=604563

Review URL: https://codereview.chromium.org/1902443004

Cr-Commit-Position: refs/heads/master@{#389891}

BUG=594234

Review URL: https://codereview.chromium.org/1916973004

Cr-Commit-Position: refs/heads/master@{#389890}

Deleting the TaskManagerIoThreadHelper should cancel any pending
OnMultipleBytesReadIO calls. If it doesn't, we can sometimes fail the
DCHECK(!bytes_read_buffer_.empty()); check.

BUG=None
TEST=TaskManagerOOPIFBrowserTest.LeavePageWithCrossSiteIframes/0

Review URL: https://codereview.chromium.org/1918423002

Cr-Commit-Position: refs/heads/master@{#389889}

This ended up pulling in a bunch of v8 code that doesn't work with the
ninja-xcode bindings.

BUG=

Review URL: https://codereview.chromium.org/1922863003

Cr-Commit-Position: refs/heads/master@{#389888}

This API is necessary to remove loading progress code from Tab, which is
currently stores the loading progress and provides it to Toolbar.
Corresponding method does not exist in WebContents, because on Desktop
the progress is not shown in UI and on Android progress is stored in
WebContentsDelegateAndroid.

BUG=None

Review URL: https://codereview.chromium.org/1905393002

Cr-Commit-Position: refs/heads/master@{#389887}

This allows use of the gtest test generator and easy swarming.

https://codereview.chromium.org/1915003004/ is the build-side change.
https://chromereviews.googleplex.com/411237013/ is the build_internal-side change.

BUG=525873

Review URL: https://codereview.chromium.org/1918733002

Cr-Commit-Position: refs/heads/master@{#389886}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ea682869..0c48cc8c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1923633002

Cr-Commit-Position: refs/heads/master@{#389885}

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/1920153003

Cr-Commit-Position: refs/heads/master@{#389884}

Use correct paint offset and clip, and apply zoom factor.

Some changes are based on https://bugs.webkit.org/show_bug.cgi?id=143527.

BUG=475128
TEST=fast/images/imagemap-focus-ring-in-positioned-container.html
TEST=fast/images/imagemap-focus-ring-with-paint-root-offset.html
TEST=fast/images/imagemap-focus-ring-with-scale-transform.html
TBR=dmazzoni@chromium.org (passive change under Source/modules/accessibility due to function renaming)

Review URL: https://codereview.chromium.org/1912863002

Cr-Commit-Position: refs/heads/master@{#389883}

BUG=431177
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/1919373002

Cr-Commit-Position: refs/heads/master@{#389882}

BUG=part of 585134
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

This is a part of the design for 585134 which includes a larger set of traces.
As part of that design we also noticed overlapping traces that existed earlier
for navigation start to commit. As discussed with carlosk@, this change also
reverts the earlier traces which only covered PlzNavigate and adds the new
traces that cover the following scenarios:
- plzNavigate and traditional flows
- committed and aborted/failed/canceled loads

This patch adds the async begin and end traces in the constructor and
destructor of NavigationHandleImpl respectively. That would cover all of
the scenarios as detailed in the design doc
(https://docs.google.com/a/chromium.org/document/d/1yM2khCxLC5AV3X4y7cyuCNCFHCmq9CpqQzDwK6MROaw/edit?usp=sharing).
The start time of Navigation is passed in the
constructor and that would be used as the trace start timestamp. For
failed/aborted provisional loads, the argument net error code will give the error
code.

In this patch I am adding them in the existing "navigation" category only and
later they might be extended for new categories like "loading".

Review URL: https://codereview.chromium.org/1825533002

Cr-Commit-Position: refs/heads/master@{#389881}

It's not used.

BUG=None

Review URL: https://codereview.chromium.org/1922783004

Cr-Commit-Position: refs/heads/master@{#389880}

Currently llvmpipe driver from Mesa is black listed.
It is fast and stable enough to allow using the gpu
process. But only enable WebGL, other features still won't
use the gpu process. For example the 2D Compositing Skia is
faster than gpu compositing on software GL driver.

BUG=571899

R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

TEST= GALLIUM_DRIVER=llvmpipe LIBGL_ALWAYS_SOFTWARE=1 chrome
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Review URL: https://codereview.chromium.org/1548893004

Cr-Commit-Position: refs/heads/master@{#389879}

On Mac with an external JIS PC keyboard, pressing "Convert",
"NonConvert" and "KanaMode" keys will always produce |NSFlagsChanged|
NSEvent with |keycode| == 255. Which will then cause blink to fire two
"keydown" events.

These three keys do not exist in Apple's Japanese keyboard, and there
is no way for us to distinguish them or get any useful information (and it requires hack to mock "keydown"/"keyup").

Safari generates two "keydown"s (with no useful information).
Firefox does not generate keyevents for these keys, this CL matches Firefox's bahavior.

BUG=601964

Review URL: https://codereview.chromium.org/1923023002

Cr-Commit-Position: refs/heads/master@{#389878}

Revert of Reland: [qcms] Fix build_output_lut to return correct data for parametric curves (patchset #14 id:260001 of https://codereview.chromium.org/1862053002/ )

Reason for revert:
This broke the Windows compile (again).
https://build.chromium.org/p/chromium/builders/Win/builds/42772

Original issue's description:
> [qcms] Fix build_output_lut to return correct data for parametric curves
>
> build_output_lut() does not invert a parametric gamma curve when
> computing the output curve data. The effect has not been visible
> since Chrome only uses the output gamma values from the precache
> table (which is inverted).
>
> Make build_output_lut() return inverted data for parametric gamma
> curves. Add a test to write the inverted data, and the output of
> LCMS function DefaultEvalParametricFn, to a file for comparison.
>
> For now the size of input and output gamma table for parametric
> curves is hard-coded to 256; assert this in the test code. See
> compute_curve_gamma_table_type_parametric for details. Future
> implementations might return an arbitrary-sized table.
>
> BUG=600338
>
> Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801
> Cr-Commit-Position: refs/heads/master@{#389754}
>
> Committed: https://crrev.com/3a4a913c1de915ef228a35b4f85603662719c49f
> Cr-Commit-Position: refs/heads/master@{#389866}

TBR=noel@chromium.org,radu.velea@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=600338

Review URL: https://codereview.chromium.org/1920253003

Cr-Commit-Position: refs/heads/master@{#389877}

https://chromium.googlesource.com/skia.git/+log/82ecc5773faa..8ffab6fc0eff

$ git log 82ecc5773..8ffab6fc0 --date=short --no-merges --format='%ad %ae %s'
2016-04-26 borenet Whitespace change to trigger bots after recipe fix

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/1918243003

Cr-Commit-Position: refs/heads/master@{#389876}

To handle lucid sleep (where we need to silently resume the system), turn
off the displays on suspend. This also removes the delay for restoring the
display state added in "On resume perform a delayed call to
SetDisplayPower()" According to the bug for that change, it didn't seem to
help with the issue anyways.

BUG=535021
TEST=suspend/resume of various cros platforms with/without external monitor
connected

Review URL: https://codereview.chromium.org/1861593002

Cr-Commit-Position: refs/heads/master@{#389875}

BUG=601972

Review URL: https://codereview.chromium.org/1915683002

Cr-Commit-Position: refs/heads/master@{#389874}

In hit testing, we should use the render surface screen space
transform (which doesn't have sublayer scale) instead of the
screen_space_transform stored on the transform node (which
has the sublayer scale baked in) as the clips stored in clip
tree already account for the scale.

BUG=604731
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1917043002

Cr-Commit-Position: refs/heads/master@{#389873}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/89ac5c3cccf7..7744caa3a0f0

$ git log 89ac5c3cc..7744caa3a --date=short --no-merges --format='%ad %ae %s'

BUG=605972,606052,606706

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1923583002

Cr-Commit-Position: refs/heads/master@{#389872}

BUG=506331

Review URL: https://codereview.chromium.org/1910323002

Cr-Commit-Position: refs/heads/master@{#389871}

BUG=603636

Review URL: https://codereview.chromium.org/1895533004

Cr-Commit-Position: refs/heads/master@{#389870}

BUG=chromium:606726

Review URL: https://codereview.chromium.org/1918363002

Cr-Commit-Position: refs/heads/master@{#389869}

We have substantial crashes since adding bad_message errors for invalid
blob messages. It looks like there is a pre-existing condition where
blob references are race casing across processes.

While we investigate the issue, we want to remove this crash so it's not
making the situation worse (crashing instead of having a broken blob).

I'm keeping the uuid.empty() condition as a bad message, because that's
definitely an error that shouldn't be happening.

BUG=606065

Review URL: https://codereview.chromium.org/1913343002

Cr-Commit-Position: refs/heads/master@{#389868}

The capture callback must always be run, or eventually the capture
decision logic will think there are too many captures in-flight.  This
closes some "holes" in content::AuraWindowCaptureMachine where methods
exit early without running the callback.  This is a potential fix for
crbug 600031.

BUG=600031

Review URL: https://codereview.chromium.org/1913283004

Cr-Commit-Position: refs/heads/master@{#389867}

build_output_lut() does not invert a parametric gamma curve when
computing the output curve data. The effect has not been visible
since Chrome only uses the output gamma values from the precache
table (which is inverted).

Make build_output_lut() return inverted data for parametric gamma
curves. Add a test to write the inverted data, and the output of
LCMS function DefaultEvalParametricFn, to a file for comparison.

For now the size of input and output gamma table for parametric
curves is hard-coded to 256; assert this in the test code. See
compute_curve_gamma_table_type_parametric for details. Future
implementations might return an arbitrary-sized table.

BUG=600338

Committed: https://crrev.com/a89370950f514a3df77ed84240d4b8e3abbee801
Cr-Commit-Position: refs/heads/master@{#389754}

Review URL: https://codereview.chromium.org/1862053002

Cr-Commit-Position: refs/heads/master@{#389866}

This CL adds a flush mode and a flush() method to Cronet's
BidirectionalStream API and buffers writes until flush() is
called. By default, Cronet flushes after every write().

net::BidirectionalStreamQuicImpl uses ScopedPacketBundler
to bundle small writes into one data packet along with
request headers.

net::BidirectionalStreamSpdyImpl will do an extra memcpy
to combine small write buffers into a big one.
BidirectionalStreamSpdyImpl doesn't combine header frame
with data frame currently.

BUG=599902

Review URL: https://codereview.chromium.org/1856073002

Cr-Commit-Position: refs/heads/master@{#389865}

It turns out that we don't have to trace as much as expected, plus automation
cannot often be applied anyway. So let's just get rid of it and write traceWrapper
methods by hand.

LOG=no
BUG=468240

Review URL: https://codereview.chromium.org/1917883002

Cr-Commit-Position: refs/heads/master@{#389864}