- 24 May, 2018 40 commits
-
-
Sylvain Defresne authored
Pass the current tab as the opener when opening a new tab. This allow selection the previous current tab when the tab is closed via "pull-to-close" action or via the new "close" action in the UI refresh. The current tab is passed when tab is opened via ([*] denotes that this behaviour is added by this CL): - open tab in background - "New Tab" menu action [*] - captive portal detection [*] - search by image [*] Bug: 661988 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iecf41a8c0b3cfe465b3ff95a1061c97739b4ed79 Reviewed-on: https://chromium-review.googlesource.com/1068680Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561427}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/27f5a0df4a28..8517631bf410 $ git log 27f5a0df4..8517631bf --date=short --no-merges --format='%ad %ae %s' 2018-05-24 angle-skia-autoroll Roll third_party/externals/angle2/ 586750168..b001528ff (4 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: Ic59d9bc073c68ce102eeb6f51d74731be60cadc4 Reviewed-on: https://chromium-review.googlesource.com/1071235 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561426}
-
Thomas Tangl authored
The layout and the strings of the sync confirmation dialog and the consent bump are updated to match the mocks under: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZWnUS9sdsb0Q/files/MCHtA7U1iMGr6xZArjQ0C0km5svyrm3ZWaI Main changes: - Add new illustration on top of the dialog. - Add account picture. - Add settings button. - Update/add strings. Screenshot of sync confirmation dialog: https://drive.google.com/file/d/1hLL7JijPMqId63Emst_-Neap5YzksjDU/view?usp=sharing Screenshots of consent bump: https://drive.google.com/file/d/1YIUwtY421r5kCeowUIWXmurHKoO4-J0r/view?usp=sharing https://drive.google.com/file/d/1DbNOb9TJsrnkvZLsRHNiP2xZH-BCGYwi/view?usp=sharing Bug: 823967, 819909, 801342 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic3da556e78b9d22ac1eececed599da8743fd2f17 Reviewed-on: https://chromium-review.googlesource.com/1021812Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#561425}
-
Michael Lippautz authored
Split write barrier into fast and slow parts: - The fast part only checks whether any Oilpan heap is currently marking. This check is only approximate as it does not consider the current ThreadState. In general, we expect this check to be enough to allow bailing out of the barrier. - The slow version checks whether the current ThreadState is marking and whether the values actually require a write barrier. This way we emit only a short instruction sequence for the fast cases and avoid poluting the regular instruction sequences. Verified locally on the microbenchmark blink_perf.parser query-selector-deep which showed a 42% regression. Scores (higher is better): - ToT: 8932 - Without barrier: 15188 - With this CL: 13352 Bug: chromium:844576, chromium:757440 Change-Id: Ie8ebbf95fef0ff59ad8f1a111dd5daecfabc4109 Reviewed-on: https://chromium-review.googlesource.com/1071272 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561424}
-
Matt Falkenhagen authored
Similar to frames, the shared worker needs a factory bundle in order to load non-NetworkService URLs like chrome-extension://. This fixes the remaining test failure but we're still missing test coverage. I think the factory bundle needs to be propagated to ServiceWorkerSubresourceLoaderFactory for use with network fallback. Bug: 839982 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2c489a17fb30364e477d691bc346f7656b07906d Reviewed-on: https://chromium-review.googlesource.com/1069956 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#561423}
-
Kush Sinha authored
|ChromeOSOAuth2TokenServiceDelegate| loads tokens at startup and calls |FireRefreshTokensLoaded| before some token service observers may have had a chance to register themselves. This causes them to miss the |OnRefreshTokensLoaded| callback. For now, the solution is to respect the temporal coupling between |OAuth2TokenServiceDelegate::LoadCredentials| and |OAuth2TokenService::AddObserver|, i.e. |LoadCredentials| is called only when all observers have been added. Ideally, it should be an observer's responsibility to check whether it has been initialized 'too late' and may have missed the |OnRefreshTokensLoaded| notification. Bug: 820046 Change-Id: I3ac67798d165afe230fa29e03ec7af75a9a093a9 Reviewed-on: https://chromium-review.googlesource.com/1069353 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#561422}
-
Lei Zhang authored
r560826 added chrome/apps/printing_strings.grdp, and the duplicate file name made part of the translation pipeline unhappy. Rename the file in components/, to be consistent with the solution for bookmark_strings.grdp. BUG=846106 Change-Id: Iacfb38c3ea4f9e234e25ddb2163081539af9c1d2 Reviewed-on: https://chromium-review.googlesource.com/1070872Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#561421}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b001528ffa00..2a12b3d585a8 $ git log b001528ff..2a12b3d58 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 jiajia.qin ES31: Add struct uniform block support in compute shader for D3D Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I96c49978656f736a511efc4ccb0057cc0fd7196c Reviewed-on: https://chromium-review.googlesource.com/1071236Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561420}
-
Marc Treib authored
Before, OnRefreshTokenRevoked triggered a notification to observers, and OnCredentialsRejectedByClient caused us to invalidate the credentials in the SyncEngine. In both cases, it actually seems better to do both of these things, so this CL merges the two. Bug: 842697 Change-Id: I81fd4578731c282284fa40cbbb0be0e1cd102656 Reviewed-on: https://chromium-review.googlesource.com/1068880 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561419}
-
Keishi Hattori authored
Clear all persistents on thread termination, because when we have a bug and it leaves a Persistent behind, it will not be a stale pointer and just causes null dereference. Since we disabled PersistentHeapCollections on non-main threads we can assume all PersistentNode::Self() can be cast to Persistent<DummyGCBase> Bug: 831117 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib55b280f8e7c5d966ce43d3f60f2af873cd50739 Reviewed-on: https://chromium-review.googlesource.com/1025547 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561418}
-
Greg Thompson authored
I can't repro the failures anywhere outside of the real environment. BUG=818832 R=martiniss@chromium.org Change-Id: I9ccaa3bf5f7e357f879c4d804310d34b0e1abaaa Reviewed-on: https://chromium-review.googlesource.com/1070192Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#561417}
-
Niels Möller authored
Bug: 842613 Change-Id: I71bc2e6b2188e454d45f23c91ab27aa546cb8068 Reviewed-on: https://chromium-review.googlesource.com/1056992Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#561416}
-
Yuta Kitamura authored
TBR=fhorschig@chromium.org,rdevlin.cronin@chromium.org Bug: 846172 Change-Id: Ie06f83131d4f60b9c3465a8d1b77bcfce45ff19f No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1070955Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#561415}
-
Javier Ernesto Flores Robles authored
Fixes vertical offset when the pop over is shown below Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd98e7ca6b3a4e117e1b3315893c178e0ded543f Reviewed-on: https://chromium-review.googlesource.com/1068733 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#561414}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/71e81d76d2fc..74cfbb05fcd9 $ git log 71e81d76d..74cfbb05f --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:none The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5631b600211b84a85a7d7bbcd709be916d543089 Reviewed-on: https://chromium-review.googlesource.com/1071234 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561413}
-
Paul Irish authored
Bug: 772558, 846211 Change-Id: I4f74ea0d4a84908d2e7c4ccfe7035ee421bdf023 Reviewed-on: https://chromium-review.googlesource.com/1070532 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561412}
-
Alexandr Ilin authored
AudioSyncReader::shared_memory_region() is never called more than once. If we return a region from this function by value, we don't have to duplicate the region. This is a follow-up to https://crrev.com/c/1068928 Bug: 844508 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I22ac7f9bae926ed418c025ac0a8487b98659817a Reviewed-on: https://chromium-review.googlesource.com/1069352Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561411}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/602f06cfb107..18f7fbca4612 $ git log 602f06cfb..18f7fbca4 --date=short --no-merges --format='%ad %ae %s' 2018-05-24 thestig Mark some pointers as non-const in CPDF_NameTree. 2018-05-24 thestig Improve constness for more CPDF_Objects pointers. 2018-05-23 thestig Remove GetBits32(). 2018-05-23 thestig Avoid repeated calculations in CFX_BitStream::GetBits(). 2018-05-23 thestig Add unit test for CFX_BitStream. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia95af36aa7ddcdf1ae8e677e1cdc454719f0a97b Reviewed-on: https://chromium-review.googlesource.com/1071167Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561410}
-
Javier Ernesto Flores Robles authored
This is an early prototype to show a manual fill option to the user. - Using showcase so designers and PMs can play with it. - Currently the iPad and iPhone specific code is separated in two demos to allow quick experimentation. - iPhone Screenshots - https://drive.google.com/file/d/1PbwOiCadB0xRdT9-no-wy8mhfwBv9NCL - https://drive.google.com/file/d/1uTqpQVmpHFIZC7mr3LM7RF24xAdxYbjh - iPad Screenshoots - https://drive.google.com/file/d/1Y5yUSO-0Dv6bsx3_F6LV41Us95TKKIlL - https://drive.google.com/file/d/19Va4ku9-vvE9doZ6naSUr4iicovfmcOg Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0475b630641152fe57d4c246608f75e94d2619fd Reviewed-on: https://chromium-review.googlesource.com/956486 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#561409}
-
Oystein Eftevaag authored
The feature is behind a flag and I'm fairly sure this is an issue with the test itself, so I'm disabling it for TSan while investigating. Tbr: primiano@chromium.org Bug: 846204 Change-Id: Ie0e05a35ceef124722e3cef545a2bc945a5b7849 Reviewed-on: https://chromium-review.googlesource.com/1071075Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#561408}
-
tzik authored
Implementations of WebMIDIAccessor in //content holds an raw pointer to MIDIAccessorClient, however, the pointer may be invalid between GC marking and its sweeping. This CL removes the pointer by clearing WebMIDIAccessor itself on the context destruction. Bug: 846182 Change-Id: I857769a34b6c64e48b0540a117b29c94194ed611 Reviewed-on: https://chromium-review.googlesource.com/1071157Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#561407}
-
Jose Dapena Paz authored
Move anonymous namespace union ThreadRef to non anonymous namespace to avoid this warning in GCC: /../../../chromium-68.0.3432.3/base/debug/activity_tracker.cc:605:31: warning: 'base::debug::ThreadActivityTracker::Header' has a field 'base::debug::ThreadActivityTracker::Header::thread_ref' whose type uses the anonymous namespace [-Wsubobject-linkage] struct ThreadActivityTracker::Header { It is discouraged to use in a public type a type declared in an anonymous namespace. It should not be a problem in our case as it is only used internally in activity_tracker.cc, but GCC will still complain in jumbo build as the .cc is used as an include. Change-Id: I121af0053b5ee51661be99ae4470512909416859 Reviewed-on: https://chromium-review.googlesource.com/1066001 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#561406}
-
Ryo Hashimoto authored
BUG=None TEST=None Change-Id: Idb4c7792493141c7b95ea8f240b197991c67b3e9 Reviewed-on: https://chromium-review.googlesource.com/1070954Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#561405}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/13235d8966e4..27f5a0df4a28 $ git log 13235d896..27f5a0df4 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 khushalsagar Reland fonts: Cleanup cache miss logging for font remoting. 2018-05-23 khushalsagar Reland fonts: Add support for distance field text to font remoting. 2018-05-23 csmartdalton ccpr: Handle winding and even-odd in the same shader Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=allanmac@chromium.org Change-Id: I84f83ee900d04da9d48d1423f56d6f4ed1f90992 Reviewed-on: https://chromium-review.googlesource.com/1071121Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561404}
-
Stuart Langley authored
Change-Id: I881f3cd54a59b5aedfb3cfb9e2e49925768509bd Reviewed-on: https://chromium-review.googlesource.com/1071152Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#561403}
-
Yuta Kitamura authored
TBR=fhorschig@chromium.org,fdoray@chromium.org Bug: 846121 Change-Id: I8056ceedd453daf33f210cae953deb10a148cc26 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1071329Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#561402}
-
Han Leon authored
This CL lets ServiceWorkerProviderHost get the resource context from ServiceWorkerContextWrapper directly, rather than getting from ServiceWorkerDispatcherHost, then we no longer need to keep a resource context in each ServiceWorkerDispatcherHost. BUG=845341 Change-Id: Ia6dd603055607b3e2d53f5bbc7d5095c9514f954 Reviewed-on: https://chromium-review.googlesource.com/1068268Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#561401}
-
Adam Rice authored
Blink had a bug that sync XHR would timeout after 10 seconds. Add a regression test to make sure the issue does not reoccur. BUG=844268 Change-Id: I161e133582b719102a02349828cd4d9a08773785 Reviewed-on: https://chromium-review.googlesource.com/1070089 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#561400}
-
David Trainor authored
This CL makes the following modifications to the download notification text: - Moves time remaining (if known) to the subText/contentInfo. - Changes the contentText to display percent downloaded, bytes downloaded, or files downloaded. The current primary usage will be of bytes downloaded, which will have the format "XX KB / YY MB" or "XX KB / ?" if the total is unknown. BUG=845324 Change-Id: Iaf331b6d31c21863ee0a653399d3226e1816dbbd Reviewed-on: https://chromium-review.googlesource.com/1068127 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561399}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ib56847fac69d87b3a296023749357470af80566e Reviewed-on: https://chromium-review.googlesource.com/1071348Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#561398}
-
Oystein Eftevaag authored
This is a reland of 49d49cc1 Relanding with additional upstream CLs (last one fixing the libfuzzer targets): $ git log a6f6a3133..a98de15f3 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 oysteine Fixed unresolved dependencies on fuzzer targets for the Chrome build 2018-05-23 lalitm perfetto: add ability to override upload limit flag on debuggable builds 2018-05-23 lalitm perfetto: move sqlite to the non-ui build deps 2018-05-22 lalitm perfetto: add sqlite to ui part of buildtools 2018-05-22 hjd Fix clean build of UI Original change's description: > Roll src/third_party/perfetto/ a6f6a3133..d1fe1ee42 (39 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/a6f6a3133cf7..d1fe1ee42456 > > $ git log a6f6a3133..d1fe1ee42 --date=short --no-merges --format='%ad %ae %s' > 2018-05-21 oysteine Re-enabled TraceWriter flushing on destruction > 2018-05-21 hjd Fix mac build > 2018-05-21 fmayer Tune values for ftrace_largebuffer. > 2018-05-21 fmayer Change LOCKDOWN_UNSET to LOCKDOWN_UNCHANGED. > 2018-05-18 brucedawson Disable features that fail in Chromium builds > 2018-05-18 fmayer Add test config with larger buffer size. > 2018-05-18 brucedawson Changes to get Perfetto tracing in Chrome for Windows > 2018-05-18 fmayer Change wording in trace_to_text output. > 2018-05-18 fmayer Correctly handle EINTR. > 2018-05-17 fmayer Output duration of ftrace as well as total trace duration. > 2018-05-17 primiano Add tdresser@ to ui/OWNERS > 2018-05-17 dproy Rerun ninja when UI source files change > 2018-05-17 brucedawson Fix Perfetto export definitions for Windows > 2018-05-17 primiano Fix fuzzers and reduce noise from ftrace_parser unittest > 2018-05-16 primiano Add skeleton for UI (Node + TypeScript + WASM + build integration) > 2018-05-08 primiano Clean up some TODOs and use PageAllocator in CpuReader > 2018-05-15 lalitm perfetto: update docs to keep in sync with other copies > 2018-05-15 fmayer Add -b flag to tools/tmux to run in background. > 2018-05-15 primiano Roll GN, clang and libc++ to match chromium revisions > 2018-05-14 primiano Fix mac build, make pipe_stats linux-only > 2018-05-14 brucedawson Enable protozero tests on Windows > 2018-05-14 brucedawson Use relative path to import perfetto.gni > 2018-05-10 brucedawson Get page allocator working on Windows > 2018-05-10 fmayer Add sanity check for page size. > 2018-05-10 primiano Introduce WASM toolchain > 2018-05-10 lalitm protos: fix typos for lint to be happy > 2018-05-09 fmayer Use dynamically read header_page information. > 2018-05-09 fmayer Add metatracing to trace perfetto itself. > 2018-05-09 fmayer Add PRESUBMIT to protect whitelist. > 2018-05-09 fmayer Add compile_commands.json to gitignore. > 2018-04-30 hjd trace_to_text: Print FtraceStats > 2018-05-09 fmayer Allow to parse events/header_page. > 2018-05-08 brucedawson Enable more unit tests on Windows > 2018-05-08 fmayer Add script to visualize pipestats. > 2018-05-08 fmayer Add tool to analyze rate of events. > 2018-05-08 primiano Limit concurrent traces to 5 to prevent stalls in traced_probes > 2018-05-08 fmayer Temporary workaround for 32-bit crashes. > 2018-05-04 fmayer Fix off by one. > 2018-05-03 fmayer Increase ftrace buffer. Decrease i/o scan batches. > > Created with: > roll-dep src/third_party/perfetto > > Change-Id: I0e085bac9d14b1c55b1be527cd80e4f206240308 > Reviewed-on: https://chromium-review.googlesource.com/1068622 > Commit-Queue: Primiano Tucci <primiano@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560522} TBR=primiano@chromium.org Change-Id: I35dad57beeddecb99f4ec48395397714feefd77d Reviewed-on: https://chromium-review.googlesource.com/1070538 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#561397}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ebdd0db493b2..1f156687a201 $ git log ebdd0db49..1f156687a --date=short --no-merges --format='%ad %ae %s' 2018-05-23 agrieve gerrit/api.py: Add get_revision() helper. Created with: roll-dep src/third_party/depot_tools BUG=chromium:702625 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I36402206ada18e96a8e50729e37fddb326127a03 Reviewed-on: https://chromium-review.googlesource.com/1071168Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561396}
-
Michael Lippautz authored
Move wrapper tracing visitation to regular blink::Visitor and inherit from that in blink::ScriptWrappableVisitor. This is prework for removing TraceWrappers and solely rely on Trace methods, even for wrapper tracing. The bigger idea is to bring Trace in sync with TraceWrappers and drop TraceWrappers completely. The visitors should distinguish which part of the graph the would like to trace. Bug: chromium:841830 Change-Id: Iae4d000318f8fd2f81eb9c66ed0a625699bada34 Reviewed-on: https://chromium-review.googlesource.com/1068890Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#561395}
-
Joel Hockey authored
FilesApp will only show crostini integration when features::kExperimentalCrostiniUI is enabled. There is no need for a dedicated crostini-files flag. Bug: 834103 Change-Id: I019f56abe6348b6723c0de9b86425d05b0fe22f4 Reviewed-on: https://chromium-review.googlesource.com/1068584 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#561394}
-
Christopher Cameron authored
BrowserCompositorMac has historically rolled its own surface sync via the Suspend/Unsuspend functions, and compositor_suspended_lock_ in RecyclableCompositorMac. This no longer works in MacViews browser, because we no longer use RecyclableCompositorMac. Leave the Suspend/Unsuspend code in place for the non-MacViews case. Split up UpdateSurfaceAndUnsuspend - Make it just update the surface size - Call it whenever the compositor is recycled or the surface resizes - Move the AddRootLayer to TransitionToState Add a GetDeadlinePolicy method - When using surface sync, return a deadline of 8 frames (empirically works well for retina displays) - Otherwise return an immediate deadline. Bug: 840173 Change-Id: I6a1de5698e73d754ee03d9db8f4a97480c71dfb3 Reviewed-on: https://chromium-review.googlesource.com/1069834Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#561393}
-
Yutaka Hirano authored
It was needed because "it's hard to handle IPC errors synchronously", but we don't have that problem now with mojo IPC. It is not only redundant but also harmful because it breaks a WebSocketClient contract: OnFinishOpeningHandshake must precede OnAddChannelResponse. Bug: 721400 Change-Id: Idd475140d4aef1d49f001855ff80fcf8d5f99cda Reviewed-on: https://chromium-review.googlesource.com/1068784Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#561392}
-
Christopher Cameron authored
This (appropriately) DCHECKs when attempted. Skip event routing (send directly to the root RWHV) when no frame sink is present. Bug: 844095 Change-Id: I867c9f6cb7135473fc52fb44dcff7ed5e1759658 Reviewed-on: https://chromium-review.googlesource.com/1071120Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#561391}
-
Christopher Cameron authored
Setting the background color on delegated layers can cause artifacts (only non-tiled areas get the background color). This also appears not to have been necessary. Bug: 845968, 840173 Change-Id: If8eca7d3eb793952a9a606a2d27683b02d2c4b3f Reviewed-on: https://chromium-review.googlesource.com/1071117Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#561390}
-
Christopher Cameron authored
The method RenderWidgetHostViewMac::GetOffsetFromRootSurface is to be used to indicate where the view is in its root ui::Compositor. It used to be that the two were always aligned, but now they can be offset. Bug: 846018, 840173 Change-Id: Id3f761d56c75ebd33b75c40c05d46a84b485d162 Reviewed-on: https://chromium-review.googlesource.com/1070883Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#561389}
-
Joe Downing authored
This CL sets up a subsequent CL which refactors a shared chunk of code out of the browsertest file. These files are being checked in as-is (i.e. trigger a number of formatting warnings) however they aren't included in any build files so they shouldn't cause any build issues and will be fixed in the follow-up CL. TBR=sky@chromium.org Change-Id: I428463c0a6c9e942899a44c76bebb2e0e0b34856 Reviewed-on: https://chromium-review.googlesource.com/1071070Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#561388}
-