- 14 Jan, 2021 40 commits
-
-
Marc Treib authored
This CL adds the account-indication footers also for single-account and for sync users. Bug: 1121258 Change-Id: Idc78aad4ccb3ae8173adb97e3011789f174d21d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627161 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#843567}
-
Mihai Sardarescu authored
The methods OnPrimaryAccount{Set|Cleared} were replaced by OnPrimaryAccountChanged(). This CL removes them. Bug: 1158855 Change-Id: I7652904a299a9edbffb5d1ff078c54f0f1cbeb66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627390 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843566}
-
Leonard Grey authored
Looks like I missed these in r835679 Bug: 1152274 Change-Id: I9ab585c62c753b2945b88a77ad1c3938f6693dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626513Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#843565}
-
Michael Lippautz authored
The Oilpan library version does not require detaching manually from an Isolate as the heap is tied directly to V8's JS heap for its lifetime. Bug: 1056170 Change-Id: I61e7c9d017a523aaf4ad09430fc1e8363e2b2fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629307 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#843564}
-
Peter Kasting authored
Bug: 1159562 Change-Id: I236611f9223a6a9172a6b29a16ca947b43a4561d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628085 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#843563}
-
Antonio Sartori authored
This is a small refactoring of the code in blink::CSPDirectiveList which is parsing new Content Security Policies. This change separates the raw parsing of the policies from the side effects (applying the policies and storing state). This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: Iace800247ef6165a47adef2601d336a09e930897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601368 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#843562}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101140600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/DYU_0-Aok5UvqgV35z_dEgBIqBP98Ypx98hUZ8a8NcoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/170172576,b/175344485,b/177365224,b/177375485,b/18961540 Tbr: media-app@grotations.appspotmail.com Change-Id: Idcf3c25bf23ced4a58cf644dcbb879717c4cff8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629395Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843561}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I87da04ea6e4088e695809d9973d1fa37a024c6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629388Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843560}
-
Elaine Chien authored
Since UNKNOWN is the least stable channel these features wouldn't work when run with official builds. Changing allowed channel to STABLE. Bug: 1165704 Change-Id: I5822c9c719cda9336bc50e39eeadb8e0b3438c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626915 Commit-Queue: Caroline Rising <corising@chromium.org> Auto-Submit: Elaine Chien <elainechien@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#843559}
-
Rushan Suleymanov authored
This metrics shows fullness of the full title field in specifics. Since most of bookmarks were reuploaded, this metric is not needed anymore. Bug: 1153774 Change-Id: Iacc69717212f6ec41cd327c6a0ade0f677768d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600831Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#843558}
-
David Roger authored
Local profile: https://drive.google.com/file/d/1GH_DmqD-A0bVU-ebZND96-vGN5ao7_fZ/view?usp=sharing&resourcekey=0-WGPrVjdN2hJcXBJ7YVwE2w Signedin profile: https://drive.google.com/file/d/1cK0pYOunr_j6sS84bgJDlC6-6fi_WyRJ/view?usp=sharing&resourcekey=0-o_2bkNB9RiJtxxTVAWDOSQ Fixed: 1166653 Change-Id: I46365046e2a940951088f77367a4cb47ded0d1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628295 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843557}
-
Adithya Srinivasan authored
Bug: 1166659 Change-Id: Ifcfae51d6b5bf6d43435e55774aad3e503165b6f Tbr: tellier@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628134Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843556}
-
David Maunder authored
Speedup: 48997ms -> 21318ms (56% speedup) Bug: 1166399 Change-Id: I296c5c40d9136a816c8b881c904f19b5baa1e5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627629Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#843555}
-
David Maunder authored
Speedup: 4500ms -> 1810ms (61% improvement) Bug: 1166382 Change-Id: I75839a35b02373bf31235c05aef3cc2bd2b6c74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628314Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#843554}
-
Benjamin Beaudry authored
Elements with the listitem role should always expose their accessible names with UIA. This was causing an issue with Narrator on Windows when navigating by list item - Narrator would only announce "element x of N" when it should actually announce "[listitem name], element x of N". This is per spec: https://docs.microsoft.com/en-us/dotnet/framework/ui-automation/ui-automation-support-for-the-listitem-control-type Bug: N/A Change-Id: I4f2d1a999d00cc8f5b23989d3ade90c907764152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610264Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843553}
-
John Delaney authored
What: Use schemeful domain when matching the url a a conversion occurs on with conversion destinations from impressions. Why: This is the proposed mechanism in the API explainer, and allows for advertisers to track conversions across different subdomains for a single impression. How: We add a new column `conversion_destination` to the impressions table which holds the etld+1 of the conversion destination. This column is used when attributing impressions for a conversion and deactivating impressions instead of `conversion_origin`. `conversion_origin` is still used for data remover integrations. All existing impressions are updated with an associated conversion domain, so there will be no data loss across the migration, but slight behavior changes are expected. When a conversion is received, we now associate it with the etld+1 of the top-level frame where it was received instead of the origin. This adds a new migration mechanism for ConversionStorage, including a MetaTable to store the current database version and a test suite. Much of the migration logic and testing follows WebDatabase: https://source.chromium.org/chromium/chromium/src/+/master:components/webdata/common/web_database_migration_unittest.cc;l=1 This does not yet update information in the conversion-internals page, which will be left for a follow-up CL. Bug: 1131624 Change-Id: I41e5d61930beab5278fe3fc3f3e40e0369e553d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194182 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#843552}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610603782-7b9d002ed8792e03b1869b7e10210ec4783af8d1.profdata to chrome-win32-master-1610614773-04b9d3e4229c2110629eb37dfecb509103b5731f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id503e587e5aaa378a9a59e0870b264af13fa2aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628864Reviewed-by:
-
Arthur Hemery authored
Enable kBlockInsecurePrivateNetworkRequests by default on WPTs. Also fixes a handful of tests expectations following this change. Bug: 1154729 Change-Id: I3fd5810f6b511bf7b1100c66499e576d6f3c0055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611721Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Sigurdur Asgeirsson authored
This allows the WorkerWatcher to cope with the case where there are multiple Frame<->Worker relationships in existence at the same time for a single Frame, Worker pair. Multiple relationships are represented as a single edge in the graph, which is added/removed on 0<->1 count transitions. Bug: 1143281 Change-Id: I032f62e7440ce4e4daf7495085f7c75877cb5188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624868 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#843549}
-
Yuwei Huang authored
When AudioCapturerMac starts the audio queue, macOS would not show the prompt asking for microphone permission for the host unless NSMicrophoneUsageDescription is set on Info.Plist. Without it AudioCapturerMac capatures nothing but silence. This CL sets the missing key. Bug: 1161363 Change-Id: I5e0a57a42b8276439a68cf0647199094ff7c8eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628890 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#843548}
-
Bo Liu authored
This makes out/Default/bin/webview_instrumentation_apk run <url> work. Change-Id: I9bb1adfc23997c0ab4ebe84b44a80025953138af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627880Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843547}
-
Morten Stenshorne authored
Bug: 1166602 Change-Id: Ic98fb9e170c264f943b65a80919234865a8dec40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629272Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#843546}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/81eee879ea6e..6d32fb19b043 2021-01-14 szuend@chromium.org [ts] Update TypeScript to 4.2.0-beta 2021-01-14 jacktfranklin@chromium.org Style component doc breadcrumbs with class 2021-01-14 jacktfranklin@chromium.org Fix IssueSurveyLink component example If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1166169 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id95d32ad435edf6fd6552153ae06e25f393f8c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628866Reviewed-by:
-
David Bokan authored
As mentioned in the removed TODO, the meaning of the "handled" vs "not-handled" is with respect to the compositor. If the compositor consumes an event, it is "handled". If it is forwarded to the main thread, it is "not-handled" (...by the compositor). DID_HANDLE_NON_BLOCKING is used for events that are sent to the main thread but marked as non-blocking (because e.g. the touch handler is marked as passive) so they're ACKed to the browser before being queued on the MainThreadEventQueue. Bug: NONE Change-Id: I31fe64afa15490dfd7b9284f8a961d8e6db17f70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200623Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843544}
-
Yuta Hijikata authored
Removes limitation on thread numbers applied to lacros- chrome that is only necessary for linux not chrome os. Bug: 1052397 Change-Id: I196a7ab7656cce1d79e853e1929c83ae269ae541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592219 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1166650 Change-Id: I946c92b6be7db6814a40c731f09e2f74d374cb4d Tbr: mmenke@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629487 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Domenic Denicola authored
942aca88 switched us from parsing the Origin-Isolation header to parsing the Origin-Agent-Cluster header. However, it left the file/function/field names unchanged. This followup aligns them with the new name. Bug: 1158853 Change-Id: I1d4c931c9480ba9bd1d952112f7013555abe65d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617466 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#843541}
-
Peter E Conn authored
Add another required method and make the class public. Change-Id: Iede75f4e2dba149632d929b1b4aad544f2bc3621 Bug: 1164866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629269Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#843540}
-
Asanka Herath authored
kMaxIdentifiabilityStudyMaxSurfaces places a hard-coded maximum for the number of surfaces that can be reported by a client regardless of server configuration. After running the study on pre-release channels we've determined that the existing hardcoded limit can be increased without affecting our privacy guarantees. The existing limit of 10 was based on the initial assumption that the number of surfaces would be in the order of ~60. The actual number is ~1000. Hence the increase. R=pauljensen@chromium.org Bug: 973801 Change-Id: Iff5f7a10db6180836d63519c59074ea2a61e6710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629527Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#843539}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/704a1aa4c802..94ca9a9578a7 2021-01-14 primiano@google.com GN: wrap libperfetto_android_internal in perfetto_build_with_android 2021-01-13 lalitm@google.com Merge changes Ic59f417e,Iad7221eb 2021-01-13 fmayer@google.com Merge "Fix `trace_to_text profile` crash for empty trace." 2021-01-13 lalitm@google.com stats: fix compile on Android using Bazel 2021-01-13 fmayer@google.com Merge "Fix outdated comment." 2021-01-13 lalitm@google.com Merge "tp: don't propogate constraints on tables with left/outer span join" 2021-01-13 hjd@google.com Merge "ui: Limit bug filing links to 8kb" 2021-01-13 fmayer@google.com Merge "Dynamically decrease sampling rate when buffer fills." 2021-01-13 treehugger-gerrit@google.com Merge "tp: strip on all Android targets" 2021-01-13 treehugger-gerrit@google.com Merge "tp: remove unnecessary stripping script" 2021-01-13 treehugger-gerrit@google.com Merge "traced: add statsd instrumentation" 2021-01-13 fmayer@google.com Merge "Make names of malloc hooks / preload more descriptive." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2a155487dab1c0ec1b4964cbccf1db13bc3bcf58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628054Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b421774ae9c3..72c58a865b57 2021-01-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3549479dc4cc to 5255c465bbba (6 revisions) 2021-01-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 50bcbaad4cbf to 5869a809d551 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I89cdad4aa6ea5cff39990b6bda46e46641d1399e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629390Reviewed-by:
-
David Roger authored
Strings updated to match the mocks. This CL also adds the Chromium version for the subtitle (which was previously only Chrome branded). Screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/47e8c87c841f9b9673f93babdaf98212e6b3056e Subtitle V2: https://storage.cloud.google.com/chromium-translation-screenshots/3a59c757a6c0f10694c64384cef092967697b863 Fixed: 1166621 Change-Id: I009011e045336940c452cd7dd5fd5249fc8705be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627857 Commit-Queue: David Roger <droger@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#843536}
-
Anders Hartvoll Ruud authored
We need to propagate container size information down to style resolution of elements that depend on a container queries. The StyleRecalcContext class will (eventually) transport that information. This CL is the first in a chain of CLs which does the necessary refactoring to propagate a StyleRecalcContext all the way from StyleEngine::UpdateStyleAndLayoutTreeForContainer to descendants ElementRuleCollector instances. Longer term I expect StyleRecalcContext to also setup/manage the SelectorFilter (or otherwise merge with that functionality), but this problem is out of scope at the moment. Bug: 1145970 Change-Id: Ia30b796e0e95c83e5f04d971a593644ec18bc8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626433 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843535}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: I546ad3eb3c63e14b0e0290f0e1e6151ac5c52565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627998 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#843534}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9fba07e606db..069cce000b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: Id59dc86471034b1ca98692fee8bbbd0f5d4a0ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629391Reviewed-by:
-
Sunny Sachanandani authored
This is needed for importing the UV plane of a P010/P016 texture into GL/ANGLE. Bug: 1116101 Change-Id: I32a008ddc0350858372d764de14998c930d48683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626100 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#843532}
-
Caroline Rising authored
Add two metrics, one tracking the bookmark bar state the first time a user adds to the reading list because we then open the reading list and another that tracks the bookmark bar state on all additions to the reading list. For the latter, make the ReadLaterButton a ReadingListModelObserver, this will also be needed for future read later work to add a red dot indicator and button highlight. Bug: 1163938 Change-Id: I572ca447707a840f41880a86b1d0779b02eedc5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627692 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#843531}
-
Jérôme Lebel authored
Removing //ios/chrome/browser/ui/authentication/signin:signin_protected from //ios/chrome/browser/ui/settings/google_services. This dependency is not used anymore. Change-Id: I543b9c129441bfa8b39d3cf16c6fd4aaeab2247e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626389Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#843530}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610603782-a901bed343e038af516adf3da71b37fc556670e5.profdata to chrome-linux-master-1610625483-0ee558e7111df5b3a3b368fd27939cbeb6a581b3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0ac68b1c49f32fe2c994bbe0107bcca181a88df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628865Reviewed-by:
-
Rune Lillesveen authored
Bug: 630597 Change-Id: Ie35038b6e1546f29dc015e3ba2c5bdad73157255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628293Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#843528}
-
