GitLab

1. Remove surface_synchronization. It's on everywhere at this point so
   it's not neessary to list it.
2. Make metal and surface control platform specific. They aren't
   relevant outside of MacOS and Android respectively.
3. Make features that are experimental or ongoing finch controlled roll
   out not show up in problems detected list when disabled.
4. Remove |needs_gpu_access| attribute since it's not used.

Bug: none
Change-Id: I9e9909d33d849e2025a550e0bd0d42eb90c00d74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648650
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667255}

Bug: pdfium:1320
Change-Id: I766c1207b42822b58ba1c142d5ae34017880fd9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648777Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Andrew Weintraub <asweintraub@google.com>
Cr-Commit-Position: refs/heads/master@{#667254}

This CL is the first CL to remove the per-UnifiedConsent code from
the sync confirmation dialog. The pre-UnifiedConsent sync confirmation
HTML and JS are still for the case when sync is disabled by policy.

Follow-up CLs will attempt to do the clean-up for these cases.

Bug: 971183

Change-Id: I9b24b5b23fad9a0658ebea0ab0c80f3157e530ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645358Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Auto-Submit: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667253}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13f3e6190c83..cf4f55b6edc4


Created with:
  gclient setdep -r src-internal@cf4f55b6edc4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com

Change-Id: Ic9913a274dc25f4d09ec517ae1d6f8c7a4cff522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650061Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667252}

The new BVC command to show the send tab to self UI will be handled
by this new coordinator.

Bug: 970284
Change-Id: Ib57e91d8beee9f99ffa9de2b1ab57e07a25e6dd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645209
Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667251}

Change-Id: I7ca3f8d00a48b0f61872363a36b565d68258dfad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646077Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667250}

We already had a fix for inline, misssed fixing
it for block.

Bug: 967977
Change-Id: Iad883eca7761f0db203fc6e01d48466d7b09dfd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648299Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667249}

This makes the generated build files deterministic with respect to build path.

Bug: 871574
Change-Id: Icf30415f6505710d45743d3921b0ae73b83c6a13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649301Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667248}

Bug: 883163
Change-Id: I49b5c18601bb53f3f199aff9363d84a0ae1f7dc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644597Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667247}

This is a reland of a2d78e6e

Original change's description:
> Reland "Reland "Added handling of large requests to Autofill API.""
> 
> This is a reland of 4149e2e9
> 
> Original change's description:
> > Reland "Added handling of large requests to Autofill API."
> > 
> > This is a reland of c6677df1
> > 
> > Original change's description:
> > > Added handling of large requests to Autofill API.
> > > 
> > > Increased the limit of Query GET requests, added a POST Query fallback, and
> > > added UMA metrics to keep track of URL length and associated events.
> > > 
> > > This change might be needed when metadata is enabled.
> > > 
> > > Bug: 948862
> > > Change-Id: If0934a685758ab8999ceea6ce22a27499e4f772f
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549615
> > > Commit-Queue: Vincent Boisselle <vincb@google.com>
> > > Reviewed-by: Roger McFarlane <rogerm@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#656080}
> > 
> > Bug: 948862
> > Change-Id: I29eee8f16ae6c3775eb31e8e95d4a289c31f1485
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594618
> > Reviewed-by: Roger McFarlane <rogerm@chromium.org>
> > Commit-Queue: Vincent Boisselle <vincb@google.com>
> > Cr-Commit-Position: refs/heads/master@{#656452}
> 
> Bug: 948862
> Change-Id: I8fdc33c0e496862232dfed6e13349e55fbd36e07
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594190
> Reviewed-by: Roger McFarlane <rogerm@chromium.org>
> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
> Commit-Queue: Vincent Boisselle <vincb@google.com>
> Cr-Commit-Position: refs/heads/master@{#662780}

Bug: 948862
Change-Id: Ie27a8325eaba03a2158e3a441436fcebcab1a56d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642815Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/master@{#667246}

while on chrome:// URLs

This allows us to use this mechanism in CSS:

  @media (prefers-color-scheme: dark) {
  }

to vary styles for Chrome web UI in dark mode while also disabling via
feature on certain platforms.

This unblocks us from migrating to the @media query (from the existing
[dark] attribute syntax) and later removing a bit of JS/C++ custom code
in favor of simply using the web platform.

R=futhark@chromium.org
BUG=965811

Change-Id: I79f4582ce21661d7ba2f6a33f3f054f5ff62d0db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626024
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667245}

Change-Id: I29fce7fafe5ab0923eed465fb58fcf5def079689
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1355195Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Connor Clark <cjamcl@google.com>
Cr-Commit-Position: refs/heads/master@{#667244}

SCREEN_OOBE_WELCOME was (mostly) removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1520310/8/ui/login/display_manager.js
except for one occurrence. This occurrence prevents the ctrl+alt+E key
combination to work on network and eula screen and also produces error
log output. This CL removes the remaining occurrence. This change is
safe since its old behavior was already replaced by
attributes.postponeEnrollmentAllowed, which is true for the welcome
screen.

Bug: 965391
Change-Id: Ie8d80c25b8c240f1f5d36ab7c28d15143e48474d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640407
Auto-Submit: Alexander Hendrich <hendrich@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667243}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=bialpio@chromium.org

Change-Id: I39077687bd9eadfa2b1ce2c05b00b3687d2b8aa0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648268
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667242}

Add CloudTokenData to WalletMaskedCreditCard.
This is a part of b/133228158.

Change-Id: I18a8d58d0ef42921fa47158c0fc519de8e88c60b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647377
Commit-Queue: Anne Lim <annelim@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667241}

Reland "Changed the way the Query URL is matched in the JSON file and re-added unittests (only for Linux)"

This is a reland of 4e636d5e

Original change's description:
> Changed the way the Query URL is matched in the JSON file and re-added unittests
> (only for Linux)
> 
> Bug: 954379
> Change-Id: I0fa6d80dd56cc239ed2eaa554c89b0700950acf6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574899
> Commit-Queue: Vincent Boisselle <vincb@google.com>
> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#656495}

Bug: 954379
Change-Id: Ie4f82545a4828f757461f81c1296497105d60547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641987
Commit-Queue: Vincent Boisselle <vincb@google.com>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667240}

Currently, changes by setRootId() in Tab are not reflected in TabState
and will be lost when tabs are restored. This CL fixes this issue.

Bug: 971327
Change-Id: Ia7daf36d4feb23f79b9c364d1232090671a7b9d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647134
Commit-Queue: Yue Zhang <yuezhanggg@google.com>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667239}

CString is being removed. Also, this was sort of relying on
an implementation detail of CString, and this fixes that.

Bug: 950077
Change-Id: I4fab8de0ef8f3202c0144dcea8eeedf89e90ce77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648712Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Gyuyoung Kim <gyuyoung@igalia.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667238}

The suggestion to powerwash only shows up when there's a firmware
update, which is relatively rare. Default to hide this line item.

BUG=925279

Change-Id: I690010a7b68bd6cc108e6c2ad420d2b69d7f3dee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646649
Auto-Submit: May Lippert <maybelle@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667237}

IWYU after commit b8fdf46c ("Consolidate code to set device::Gamepad id
field"), which also fixes the libstdc++ build:

../../device/gamepad/public/cpp/gamepad.cc:28:3: error: use of undeclared identifier 'memset'; did you mean 'wmemset'?
  memset(id, 0, sizeof(id));

Bug: 957519
Change-Id: I5b5a8d9d7bc0de6e5b32ddd29ce0c5c17c883ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649496
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667236}

This CL is fixing a cause of flaky tests when re-ordering tests execution.

SystemFont is keeping two static callbacks that modify metrics of the
system fonts. Typically, these callbacks are set up before the SystemFont
class is instantiated. A DCHECK was ensuring this.

We are able to repro flaky test by changing tests order or
by specifying test filters (see below).

A DCHECK fails because it is possible in unittests to set the
callbacks after the SystemFont is instantiated. The problem is
that callbacks are static variables that keep states
between two tests.

I believe other fancy bugs may be hidden by this bug since system fonts
may be scaled based on the callback left by a previous test.

This CL is adding the required logic to reset the system fonts.


R=robliao@chromium.org,asvitkine@chromium.org
CC=​benck@google.com
Bug: 944227

C:\src\chromium\src>out\build\gfx_unittests --gtest_filter=FontListTest.Fonts_DeriveWithHeightUpperBound:RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs:SystemFontsWinTest.AdjustFontSize
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 1 parallel jobs.
Note: Google Test filter = FontListTest.Fonts_DeriveWithHeightUpperBound:RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs:SystemFontsWinTest.AdjustFontSize
[==========] Running 3 tests from 3 test suites.
[----------] Global test environment set-up.
[----------] 1 test from FontListTest
[ RUN      ] FontListTest.Fonts_DeriveWithHeightUpperBound
[       OK ] FontListTest.Fonts_DeriveWithHeightUpperBound (13 ms)
[----------] 1 test from FontListTest (14 ms total)

[----------] 1 test from RenderTextTest
[ RUN      ] RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs
[       OK ] RenderTextTest.HarfBuzz_FallbackFontsSupportGlyphs (32 ms)
[----------] 1 test from RenderTextTest (34 ms total)

[----------] 1 test from SystemFontsWinTest
[ RUN      ] SystemFontsWinTest.AdjustFontSize
[26180:21012:0605/182005.067:1151493921:FATAL:system_fonts_win.cc(100)] Check failed: !SystemFonts::IsInitialized().

        base::debug::CollectStackTrace [0x00007FFB78F6D7E0+48] (C:\src\chromium\src\base\debug\stack_trace_win.cc:284)
        base::debug::StackTrace::StackTrace [0x00007FFB78F6C950+80] (C:\src\chromium\src\base\debug\stack_trace.cc:206)
        base::debug::StackTrace::StackTrace [0x00007FFB78F6C8D8+40] (C:\src\chromium\src\base\debug\stack_trace.cc:203)
        logging::LogMessage::~LogMessage [0x00007FFB78FBC78F+143] (C:\src\chromium\src\base\logging.cc:613)
        gfx::win::`anonymous namespace'::SystemFonts::SetGetMinimumFontSizeCallback [0x00007FFB834E3E41+161] (C:\src\chromium\src\ui\gfx\system_fonts_win.cc:101)
        gfx::win::SetGetMinimumFontSizeCallback [0x00007FFB834E3D93+19] (C:\src\chromium\src\ui\gfx\system_fonts_win.cc:222)
        gfx::win::SystemFontsWinTest_AdjustFontSize_Test::TestBody [0x00007FF7F312886E+46] (C:\src\chromium\src\ui\gfx\system_fonts_win_unittest.cc:30)
        testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00007FF7F31A50DF+79] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2507)
        testing::Test::Run [0x00007FF7F31A5049+185] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2529)
        testing::TestInfo::Run [0x00007FF7F31A5D11+225] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2701)
        testing::TestSuite::Run [0x00007FF7F31A69D6+278] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2827)
        testing::internal::UnitTestImpl::RunAllTests [0x00007FF7F31B0EE9+1113] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:5284)
        testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00007FF7F31B0A75+85] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:2505)
        testing::UnitTest::Run [0x00007FF7F31B08BC+300] (C:\src\chromium\src\third_party\googletest\src\googletest\src\gtest.cc:4873)
        RUN_ALL_TESTS [0x00007FF7F32463F1+17] (C:\src\chromium\src\third_party\googletest\src\googletest\include\gtest\gtest.h:2453)
        base::TestSuite::Run [0x00007FF7F32459D4+164] (C:\src\chromium\src\base\test\test_suite.cc:316)
        base::internal::FunctorTraits<int (base::TestSuite::*)(),void>::Invoke<int (base::TestSuite::*)(),(anonymous namespace)::GfxTestSuite *> [0x00007FF7F2E1516D+29] (C:\src\chromium\src\base\bind_internal.h:499)
        base::internal::InvokeHelper<0,int>::MakeItSo<int (base::TestSuite::*)(),(anonymous namespace)::GfxTestSuite *> [0x00007FF7F2E150E4+52] (C:\src\chromium\src\base\bind_internal.h:599)
        base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(),base::internal::UnretainedWrapper<(anonymous namespace)::GfxTestSuite> >,int ()>::RunImpl<int (base::TestSuite::*)(),std::__1::tuple<base::internal::UnretainedWrapper<(anonymous  [0x00007FF7F2E15068+88] (C:\src\chromium\src\base\bind_internal.h:672)
        base::internal::Invoker<base::internal::BindState<int (base::TestSuite::*)(),base::internal::UnretainedWrapper<(anonymous namespace)::GfxTestSuite> >,int ()>::RunOnce [0x00007FF7F2E14F3E+78] (C:\src\chromium\src\base\bind_internal.h:641)
        base::OnceCallback<int ()>::Run [0x00007FF7F324E611+97] (C:\src\chromium\src\base\callback.h:98)
        base::`anonymous namespace'::LaunchUnitTestsInternal [0x00007FF7F324BCE2+418] (C:\src\chromium\src\base\test\launcher\unit_test_launcher.cc:158)
        base::LaunchUnitTests [0x00007FF7F324BAFD+253] (C:\src\chromium\src\base\test\launcher\unit_test_launcher.cc:492)
        main [0x00007FF7F2E14AAA+138] (C:\src\chromium\src\ui\gfx\test\run_all_unittests.cc:81)
        invoke_main [0x00007FF7F33739E4+52] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:79)
        __scrt_common_main_seh [0x00007FF7F3373B1E+302] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
        __scrt_common_main [0x00007FF7F3373B9E+14] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:331)
        mainCRTStartup [0x00007FF7F3373BB9+9] (d:\agent\_work\2\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp:17)
        BaseThreadInitThunk [0x00007FFBB44837E4+20]

Backtrace: 
Change-Id: I23109356db89c48c89c51b1db78cbb0c04367e8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647192
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667235}

Use ScopedTaskEnvironment instead of MessageLoop in /ui/events/devices/mojo/device_struct_traits_unittest.cc

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=meacer@chromium.org

Change-Id: I56dcf5a81b19ec45040fba583bd38112eef247c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649511
Auto-Submit: Carlos Caballero <carlscab@google.com>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667234}

Feature launched in M70, and has been default enabled since, this CL
removes the flag from Chrome's code, and the switch from
chrome://flags

Bug: 936008
Change-Id: I57772ccc041b137255e39b220777e739d72c9789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644788
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667233}

This commit clarifies previously established ownership semantics of
Profiles within ProfileManager through the use of unique pointers.
Changes were made to the parameters of
ProfileManager::RegisterTestingProfile() and
ProfileManager::RegisterProfile() to take a std::unique_ptr instead of a
raw pointer. A further change was made to the return type of
ProfileManager::CreateProfileAsyncHelper() from a raw pointer to a
unique pointer. All callers to the aforementioned functions (including
unit tests) that made calls to the two functions are updated to pass in
unique pointers.

Bug: 968187
Change-Id: I05cab32d75fa8aad30359e8cc5b4a85efaaf9d12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639183Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667232}

https://swiftshader.googlesource.com/SwiftShader.git/+log/c2c829bc9a63..f60a2d59c9f2


git log c2c829bc9a63..f60a2d59c9f2 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 sugoi@google.com Removed some dependencies on old threading class
2019-06-07 sugoi@google.com Replace sw::Resource with sw::WaitGroup
2019-06-07 swiftshader.regress@gmail.com Regres: Update test lists @ c2c829bc


Created with:
  gclient setdep -r src/third_party/swiftshader@f60a2d59c9f2

The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=swiftshader-team+autoroll@google.com

Change-Id: I5aba07eefad5deffab83d6f592200ec5f27ef93a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648884Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667231}

When a dialog's child element is focused and then becomes hidden
the browser unfortunately moves the focus to <body> which in turn
prevents any keydown/keypress listeners on <dialog> from firing.

Also preventing an iron-select event from bubbling, since it
ends up triggering unrelated code (although this is not required
for the fix, it is safer).

Bug: None
Change-Id: Ifaad8070d6cab5b4db7167d461c35dfc5168d2d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648729Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667230}

Remove dependency on FormFetcher and IsPasswordOverridden.
Removing IsPasswordOverridden makes the Android UI similar to iOS. The combobox
is always shown if there multiple passwords save and we decide to update.

Bug: 845826
Change-Id: I7d5f90961017f7c6629d1a3c15e79d834bc69bba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648174
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667229}

Compilation fails because we are declaring ParseValueForFuzzer as friend method,
but we are declaring it is in anonymous namespace. Moving to global namespace
still fails (in this case in Clang).

So final solution is making it a public static method of FeaturePolicyParser.

Bug: 819294
Change-Id: Iea307cb6faef675b748d6eb5da2175dcbb17fdc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645223
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667228}

The previously void methods AddDevice(), DeleteDevice(), and
SetRegistry() now return a boolean, indicating whether or not the
registry changed as a result of the call. Also, the pref will now only
be updated when the registry changes. And, DeleteDevice() no longer
DCHECKs that a device with the input |instance_id| is in the registry,
instead returning false if such a device doesn't exist.

The RemoteDeviceProvider needs to know when a DeviceSync updates the
local device cache. The aforementioned changes to
CryptAuthDeviceRegistry will help make that determination for v2
DeviceSyncs.

Bug: 951969
Change-Id: I6ad98cadc659d02895da3b16eed90b0ba50773bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638386
Commit-Queue: Josh Nohle <nohle@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667227}

This CL implements the fingerprint/biometric enrollment and a test
utilizing a PIN-enabled virtual authenticator. Note that the current
enrollment handler requires a PIN to be set on the device before
enrolling. Once hooked into a UI, the PIN will be required to enroll a
new fingerprint.

Change-Id: Iffe71b00c0ba4e10f697b54d038d268d65a6f310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636723Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Matthew Webb <noviv@google.com>
Cr-Commit-Position: refs/heads/master@{#667226}

This CL  adds template args for CRWWKScriptMessageRouter._handlers to
make it more readable.

Bug: 956511
Change-Id: Iba9dfc5fb0068bb1e2966de5c40b667b1e53145e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649494Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667225}

Before this CL the UI looked like this:

  When you connect your devices you agree that your Chromebook can:
    * Install apps on your Chromebook
    * ...

This sounds a bit awkward, since "your Chromebook" is repeated twice.
This CL changes the first bullet point to "Automatically install apps"
instead.

Bug: 950691
Change-Id: Ibbe2a203f7a2a921541c09eabe393c7b0ad1f615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650121
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667224}

https://skia.googlesource.com/skia.git/+log/fe18de506097..ac53c42b09f3


git log fe18de506097..ac53c42b09f3 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@ac53c42b09f3

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Change-Id: Ia9cd9d8d92054d8da165e6c6ae35b3ec49d146d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649384Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667223}

In the input data structure passed to PaintWorkletProxyClient::Paint
I added a structure to take the CSSStyleValueVector structure
parsed_input_arguments_ from CSSPaintValue.  The CSSStyleValues
needed to be converted into a vector of CrossThreadStyleValue
which is converted back to a CSSStyleValueVector.

Bug: 946519
Change-Id: I0fd02b88e5f105afc5c3269088bd82c6f72b0eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645894
Commit-Queue: Adam Raine <asraine@google.com>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667222}

Uses of base::Callback<...> is deprecated in favor of either
base::OnceCallback<...> or base::RepeatingCallback<...> (the
former is preferred if possible).

This is part 8 of a multi-CL refactoring and does:

-   use PostTaskAndReplyWithResult in
    HistoryService::QueryMostVisitedURLs thus removing a naked
    "new" and the use of base::Unretained and base::Owned
    to pass the value to both callbacks

-   change QueryMostVisitedURLsCallback callback to be
    invoked with MostVisitedURLList passed by value
    instead as a const pointer thus allowing to remove an
    helper function

-   change QueryMostVisitedURLsCallback to a
    base::OnceCallback<...>

-   change HistoryBackend::QueryMostVisitedURLs to return
    the result by value instead of via an out parameter

Bug: 812523, 714018
Change-Id: Ia020a8d780945c84b5ce674c239aff4da915925a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634872Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667221}

Bug: 963448
Change-Id: Ied98c28e35bca8bdd03f8ee2c328eb566590d8aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648741Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667220}

https://chromium.googlesource.com/angle/angle.git/+log/b407e1a0b5bf..ed65dc4302f8


git log b407e1a0b5bf..ed65dc4302f8 --date=short --no-merges --format='%ad %ae %s'
2019-06-07 syoussefi@chromium.org Vulkan: implement glSampleCoverage


Created with:
  gclient setdep -r src/third_party/angle@ed65dc4302f8

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Change-Id: I2975f133b4d60557024a4eda1eb40052326c252b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649665Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#667219}

By comparing OpenGL ES 3.0, 3.1, and 3.2 spec side by side, we could safely assert that floating-point is core in and only in GL ES 3.2.
Thus we should advertise EXT_float_blend enable float 32 blending on GL ES 3.2 backend regardless of whether it is listed.

* ES 3.0, section 4.1.7: Blending applies only if the color buffer has a fixed-point format. If the color buffer has an integer format, proceed to the next operation.
* ES 3.1, section 15.1.5: Blending applies only if the color buffer has a fixed-point ~~or floating-point~~ (it’s striked through in the original source), format. If the color buffer has an integer format, proceed to the next operation.
* ES 3.2, section 15.1.5: Blending applies only if the color buffer has a fixed-point or floating-point format. If the color buffer has an integer format, proceed to the next operation


Bug: 964208, 970532
Change-Id: I7b7ec375f6b0ac34276d6cfec92c4956d7c1f6cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649055
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667218}

Deduplicating this string lifetime logic should make it much less error prone.

Bug: 971819
Change-Id: I55361dc44aebb665ddace76a6602a71e0a7fc6b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648713Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Gyuyoung Kim <gyuyoung@igalia.com>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667217}

First step towards migrating the profiler to Perfetto.

R=ssid@chromium.org

Bug: 967008
Change-Id: If714e13b2796728766b4f010593a223dd1f24c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629177Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: ssid <ssid@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667216}