- 07 Jan, 2021 40 commits
-
-
Lucas Berthou authored
Change expiration date of histograms: Media.VAJDA.ResponseToClient Change-Id: I8d0194bb5988012e4d7027509c2a3e83a03ed2f5 Fixed: 1050661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613824 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Lucas Berthou <berlu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841238}
-
Daniel Libby authored
crrev.com/c/2567866 changed the coordinate system of of HitTestResult's LocalPoint so that it is container, not content. LayoutText::PositionForPoint needs to take this into account as well. This didn't show up as an issue until crrev.com/c/2584855 landed since NGPhysicalBoxFragment::PositionForPoint already takes this into account. Given that LayoutNGFullPositionForPointEnabled may not be enabled for M89, we'll need a fix for current behavior on ToT. Bug: 1162596 Change-Id: I401ab0dc7dea075e346ecac5f7aa81b705b1cecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607679 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#841237}
-
David Benjamin authored
I don't have a machine to run the benchmarks on, but for comparison, on a Pixel 2, the assembly improves AES-128-GCM performance from 35 MB/s to 1072.5 MB/s. (AES is obnoxious. It's really hard to implement in constant-time in software, but if you use dedicated AES instructions, you get dedicated silicon for it.) Apple's ARM64 calling conventions are the same between macOS and iOS, so we should be able to use the same files. For reviewer: To test, confirm on an ARM Mac that boringssl_crypto_tests and boringssl_ssl_tests pass. You can also run crypto_unittests and net_unittests if you feel like it. To confirm the perf improvement, patch in https://chromium-review.googlesource.com/c/chromium/src/+/2595253 (if it hasn't landed yet), build boringssl_tool and compare speeds for various operations. Benchmarks to try, largely in decreasing expected benefit. # This will switch from a fairly slow software implementation # to dedicated CPU instructions and should see a dramatic # improvement. boringssl_tool speed -filter AES-128-GCM # These will pick up dedicated CPU instructions. boringssl_tool speed -filter SHA-1 boringssl_tool speed -filter SHA-256 # This will pick up some SIMD optimizations. boringssl_tool speed -filter ChaCha20-Poly1305 boringssl_tool speed -filter SHA-512 # This will pick up some optimized assembly for Montgomery reduction. boringssl_tool speed -filter RSA See CL for benchmarks from thakis. Some highlights: Before: Did 8591 AES-128-GCM (16384 bytes) seal operations in 1040540us (8256.3 ops/sec): 135.3 MB/s Did 58000 SHA-1 (16384 bytes) operations in 1001711us (57900.9 ops/sec): 948.6 MB/s Did 21000 SHA-256 (16384 bytes) operations in 1008911us (20814.5 ops/sec): 341.0 MB/s Did 35000 SHA-512 (16384 bytes) operations in 1024153us (34174.6 ops/sec): 559.9 MB/s Did 29000 ChaCha20-Poly1305 (16384 bytes) seal operations in 1015541us (28556.2 ops/sec): 467.9 MB/s Did 902 RSA 2048 signing operations in 1010769us (892.4 ops/sec) Did 41000 RSA 2048 verify (same key) operations in 1017036us (40313.2 ops/sec) Did 31000 RSA 2048 verify (fresh key) operations in 1000641us (30980.1 ops/sec) After: Did 194000 AES-128-GCM (16384 bytes) seal operations in 1002938us (193431.7 ops/sec): 3169.2 MB/s Did 147000 SHA-1 (16384 bytes) operations in 1004933us (146278.4 ops/sec): 2396.6 MB/s Did 149000 SHA-256 (16384 bytes) operations in 1001852us (148724.6 ops/sec): 2436.7 MB/s Did 38000 SHA-512 (16384 bytes) operations in 1017680us (37339.8 ops/sec): 611.8 MB/s Did 62000 ChaCha20-Poly1305 (16384 bytes) seal operations in 1003024us (61813.1 ops/sec): 1012.7 MB/s Did 1632 RSA 2048 signing operations in 1012696us (1611.5 ops/sec) Did 79000 RSA 2048 verify (same key) operations in 1011790us (78079.4 ops/sec) Did 50000 RSA 2048 verify (fresh key) operations in 1018441us (49094.6 ops/sec) Bug: none Change-Id: Id4eea23c0babd1a3d361497a7f4110cc342d0af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595350 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#841236}
-
Eugene But authored
These histograms are useful for monitoring user-visible renderer crashes on iOS. Might be useful on other platforms as well. Bug: 1089568, 1089567 Change-Id: I40d38b162fccc356d3373f2e16d491e6bf29725f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615719 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#841235}
-
Tommy Li authored
This reverts commit ecae40df. Reason for revert: Seems to break some user's Default Search Engines who have (or have had) extensions that have changed the Default Search Engine in the past. See thread on Omnibox Team. Original change's description: > [search_engines] Reset keywords of replaceable "example.com_" engines > > This CL collapses entries that with previously uniquified keywords, i.e. > "example.com_" and resets their keywords from their URL, which should > be regenerated as "example.com". > > All safe_for_autoreplace() engines are either prepopulated or generated > as the user browses, so they should all have keywords of the form > "example.com" (they should all look like hostnames). > > If they end in an underscore, it's because we tried to uniquify it in > the past, and it's leftover in the database. > > Engines that the user manually edited would no longer be marked as > safe_for_autoreplace(), so we are only talking about prepopulated or > autogenerated engines. > > By resetting the keyword from the URL, we will set it up to be > eligible for automatic de-duplication with other "example.com" > replaceable engines. > > The full design is in: > go/chrome-search-engines-2020-improvements > > Bug: 1022775 > Change-Id: I2763b6d7371aa266c1d8d720725876bf3107b6a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598005 > Commit-Queue: Tommy Li <tommycli@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840267} TBR=pkasting@chromium.org,tommycli@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1022775, 1164024, 1163453 Change-Id: Idfd2b976de8a34fb47b5fbf91a83e2d7532abc23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615925Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#841234}
-
Ken Rockot authored
Straightforward migration of HID web tests from old to new Mojo JS bindings using ES6 modules. Bug: 1004256 Change-Id: I50111b23a3c9187dacfcf40887e5db72457b2719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611338 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#841233}
-
Etienne Bergeron authored
This CL is delaying the WM_TIMECHANGE notifications to ensure it's running while the computer is fully resumed from power suspend. It is also batching multiple concurrent notifications if they subsequent notifications occurred before the completion of the initial one. note: The thread controller already handle delayed tasks and power management by not posting delayed task while computer is in power suspended state. Jank stackframe: tzset_nolock tzset icu_68::TimeZone::detectHostTimeZone() device::TimeZoneMonitor::DetectHostTimeZoneFromIcu() device::TimeZoneMonitorWin::OnWndProc(HWND__ *,unsigned int,unsigned __int64,__int64) gfx::SingletonHwnd::ProcessWindowMessage(HWND__ *,unsigned int,unsigned __int64,__int64,__int64 &,unsigned long) gfx::WindowImpl::OnWndProc(unsigned int,unsigned __int64,__int64) gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned __int64,__int64) base::win::WrappedWindowProc<&gfx::WindowImpl::WndProc(HWND__ *,unsigned int,unsigned __int64,__int64)>(HWND__ *,unsigned int,unsigned __int64,__int64) UserCallWinProcCheckWow DispatchMessageWorker base::MessagePumpForUI::ProcessMessageHelper(tagMSG const &) base::MessagePumpForUI::ProcessNextWindowsMessage() base::MessagePumpForUI::DoRunLoop() base::MessagePumpWin::Run(base::MessagePump::Delegate *) base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool,base::TimeDelta) base::RunLoop::Run() R=gab@chromium.org,fdoray@chromium.org Bug: 1074036 Change-Id: I5b5d5fd945205a3d2eaacbbde274e9f8caf5136e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582549 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#841232}
-
Gordon Seto authored
Add skeleton code for the confirmation code page in eSIM setup flow. Bug: 1093185 Change-Id: I5929a3bda2ea5bf8999fdc7f6182d8d1a79174d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612376 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#841231}
-
Zach Trudo authored
Bug: b:176508994 Change-Id: Ic6137310e012b53ebd209f6c8b7d58b579ed7021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610983 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#841230}
-
Xianzhu Wang authored
Previously if a setting needed to invalidate multiple things, we needed to define a new type of invalidation and add code in page.cc to handle the invalidation. Change-Id: I8d5d89795a43e0aed58c59d20404f8d2ab4cf0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613714 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841229}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d0a38010a14c..a7158eb524dd 2021-01-07 syoussefi@chromium.org Vulkan: Fix image leak in staged updates in ImageHelper 2021-01-07 syoussefi@chromium.org Build compiler_tests only if GLSL or ESSL build is enabled 2021-01-07 penghuang@chromium.org Remove the checking before accessing to function pointers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1146516,chromium:1161513,chromium:1163354 Tbr: ianelliott@google.com Change-Id: I5b275a7e53c2d20f92a7952cd0a04947e178eb16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615740Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841228}
-
Andre Le authored
- Add a flag for the scalable status area feature. - Add enum and helper function in SystemTrayModel to capture system tray size. - Add date to system tray when the screen is large. Bug: 1161557 Change-Id: Id85a6bee9a30684c65b2253862ba30ab78583525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600912Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Andre Le <leandre@chromium.org> Cr-Commit-Position: refs/heads/master@{#841227}
-
Jeroen Dhollander authored
The main goal is to ensure we can create |AudioInputHost| independently of |PlatformApiImpl|. This CL also makes |AudioInputHost| virtual so it can be faked during the unittests of |AssistantManagerServiceImpl|. Bug: b/171748795 Test: chromeos_unittests --gtest_filter="Assistant*:Audio*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ic41ff343b28dae801b0c5f4c8c6417267270d8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610047 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841226}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/725a542f7776..ffb3b84133b0 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from ad77ed7a8d52 to f3ccb633dfd7 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com Change-Id: Ib3fa09252315df34bd8533d293788d1a89dab4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615952Reviewed-by:
-
Elly Fong-Jones authored
This change lays out the overall architecture of a ScreenTime integration for Chrome on macOS. Specifically, this change adds: * screentime::TabHelper, which manages the state of ScreenTime for a single WebContents * screentime::WebpageController, an interface used to wrap the real STWebpageController object (which relies on systemwide state and is only available on 11.0+) * screentime::WebpageControllerImpl, an implementation of the above interface backed by STWebpageController * screentime::FakeWebpageController, an implementation of the above interface backed by lies This change does not add: * Any test coverage * Most of the useful integration we would need to do This change also has not yet been tried on a real 11.0 machine! Change-Id: I233d63239cc61d934a9d76b0f5fab60d5da059c1 Bug: 1154287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585655 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#841224}
-
Alexei Svitkine authored
The previous code was using pair<string, string> for the key when doing look ups, which resulted in extra string copies. Instead, it's possible to look up with string references, even if the underlying map holds actual strings in the key. This CL switches the code to doing that. (StringPiece would also be possible, but in practice it doesn't actually buy anything given the params are coming from a FieldTrial object where they are std::strings.) I noticed this inefficiency while investigating some mysterious crashes in this code (referenced bug). Bug: 1131877, 1163921 Change-Id: I842edba20029d75e38e235836a9436fe4ad111c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615323Reviewed-by:
-
Kramer Ge authored
shell_toplevel allows a surface to set window-like properties such as maximize, fullscreen, and minimize, set application-specific metadata like title and id, and well as trigger user interactive operations such as interactive resize and move. Refactor shell_toplevel responsibilities out of shell_surface_wrapper. shell_toplevel_wrapper's relationship with shell_surface_wrapper should be similar to shell_popup_wrapper and shell_surface_wrapper. Change-Id: Iecfdf73dba05d67589b26c85c19368c24b39c3d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600385 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#841222}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Idb25eb17aa2ad08dad777a28f0a0b99cac2159e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616282Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841221}
-
Victor Costan authored
Currently, the SQLDatabaseTestExclusiveMode suite is not instantiated, so the tests are not run. This CL instantiates the suite. This problem was discovered by attempting to roll googletest past CL 315255779, which causes test binaries to fail when they include test suites / parametrized tests that are not instantiated, and when they include empty test suites. Bug: 1163396 Change-Id: Ieb47f8d612c48af04f3d9d05e1873fc437c2f6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615579 Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841220}
-
Mike Dougherty authored
CRWJSInjectionManager is deprecated and translate is one of the few remaining features using it. Migrating it off of this dependency will help to cleanup existing JavaScript feature code in preparation for new JavaScript features. Bug: 949178 Change-Id: If43c46b39cbced45c985f43ad853c5f1d009d4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590748Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#841219}
-
Andrew Grieve authored
No noticeable behavior change that I can see, but removes the message: A new version of dependency-check is available. Consider updating to version 6.0.5. Bug: None Change-Id: Ie30c3783a662e10c7a29a8c142ceb89d1a27d004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611981Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#841218}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/603d14ec2a26..070ef598892a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia19c19cebd5dcfadf2708ee7fcbf185919af8bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615309Reviewed-by:
-
Thomas Guilbert authored
This CL converts SyncFileSystemService::DumpFilesCallback and SyncFileSystemService::ExtensionStatusMapCallback to base::OnceCallbacks. Bug: 1152272 Change-Id: Idf277ff8057df61849f5f4ec701f94b8ed0c8a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607651 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#841216}
-
Elly Fong-Jones authored
This reverts commit 5c56345b. We've decided to rework part of the UI for this feature after some testing, so we're flipping it back to default-disabled and targeting another launch in M90. Bug: 1138688 Change-Id: Id897f593f0e1bbed079508a29adb8ebf4aa1be38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615325 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Daniel Murphy authored
This test is flaky because sometimes the port is bound to already. Hopefully this port is less-randomly-chosen? Bug: 1162285 Change-Id: I03fff905afe05a6235be452aeb3223007b32aa45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611752 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Phillis Tang <phillis@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#841214}
-
Rune Lillesveen authored
Style computation requires active style to be up-to-date. Make sure it is before serializing scroll anchors because the layout code may compute ::first-line styles to compute offsets. Fixes fuzzer crash. Bug: 1162037 Change-Id: Ia86c906ed8d1601ee7acf59e4616dc34fdd54259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615259Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#841213}
-
Connie Wan authored
Grouping was originally causing two tab movements: one to unpin the tab, then another to group. Reducing this to a single movement reduces the potential for race conditions when rapidly pinning and grouping/unpinning tabs. Tested manually and via existing unit tests: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/tabs/tab_strip_model_unittest.cc;l=3175 Bug: 1163504 Change-Id: Id2dd3a682afe0d6c8798a7f8f287c5431cd22805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613520Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#841212}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/61704b4db5d7..e79039e774fb 2021-01-07 brcui@microsoft.com Restore missing 'Add folder to workspace' button text in Filesystem sub-pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1162019 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5de3e7ad008bcd80438f5c0cb40f1a455f91a176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615939Reviewed-by:
-
Mila Green authored
Bug: 1108975 Change-Id: I2ce60fb3a3b3f35f30dd122ab304a748d9246d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612266 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#841210}
-
Evan Stade authored
Bug: 1158969 Change-Id: Icbf7391b764b776682336fb1398d9f141c9eb21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601641 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841209}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc6b87192db6..ec9b281bbc14 2021-01-07 titovartem@google.com Add ability to specify random seed when creating built it network emulation 2021-01-07 danilchap@webrtc.org Introduce CopyOnWriteBuffer::MutableData() function 2021-01-07 alessiob@webrtc.org SSE2 and NEON kill switches for AGC2 2021-01-07 philipp.hancke@googlemail.com video_engine: fix logging 2021-01-07 perkj@webrtc.org Move setting of encoder bitrate allocation callback type to VideoSendStream 2021-01-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e2c7dc77..25be8f6b (840733:840938) 2021-01-07 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-07T04:03:27). 2021-01-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6504b345..e2c7dc77 (840589:840733) 2021-01-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 24b4cef3..6504b345 (840473:840589) 2021-01-06 mbonadei@webrtc.org Add hta@ to rtc_base/ and api/ WATCHLISTS. 2021-01-06 mbonadei@webrtc.org Remove kwiberg@ from WATCHLIST. 2021-01-06 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-06T04:02:29). 2021-01-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 49b7dc5e..24b4cef3 (840329:840473) 2021-01-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c87d4517..49b7dc5e (840164:840329) 2021-01-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4ae11810..c87d4517 (840025:840164) 2021-01-05 terelius@webrtc.org Add static constexpr type to RTC event log events. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4db24386b3e5cbba55794fe608293ff33f19e904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615982Reviewed-by:
-
Andre Vincent authored
Returns string from the Drive Handler. Fixed: 1161315 Change-Id: I4dbf393f8792cb5fc49d744cc3270086fa622f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601258 Commit-Queue: Andre Vincent <andrevincent@google.com> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841207}
-
Chris Palmer authored
It's a subtle and platform-specific concept. Thanks to wez@ for pointing this out. Bug: None Change-Id: Ia3017e096dd5d92e00cf267cbeb4c2d7977c76c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611335Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#841206}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610009713-6f95aef060564dd70c8d09ec603d31a9c7b42ed0.profdata to chrome-win64-master-1610042255-9fb87833d682e7ab89f65b59b49fe1c3c9960d61.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I164d198110b1967ff9cfb990c5fc96abc2442e6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615943Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1da011f..edfb3b4d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5fbc83582d5151364fa3139449596966609339fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615580Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841204}
-
Thomas Guilbert authored
This CL converts RemoteChangeProcessor::PrepareChangeCallback from base::Callback to base::OnceCallback. Bug: 1152272 Change-Id: I3c0ff1e629ed476c8a5f2258f129258d13c7797c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606666 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47a632b2ab93..7a13b94a1d4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cmumford@google.com,tmartino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cmumford@google.com,tmartino@google.com Change-Id: Ic1c78605689754b5308992f68090b828c9768b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615301Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841202}
-
dpapad authored
- Add an |enable_pdf| assertion in c/b/r/pdf/BUILD.gn - Add an |enable_print_preview| assertion in c/b/r/print_preview/BUILD.gn - Fix all newly found violations. The new assertions reveal a few places where the above mentioned BUILD.gn files are unnecessarily evaluated. For example unnecessary work has happening for the |is_chromecast| case. Bug: None Change-Id: Ide832f251de493c1ab87ace8ee5ff46bc6c383e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615498 Auto-Submit: dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841201}
-
John Lee authored
This CL removes the `three-line` CSS class and related CSS variables and updates the one subpage they were used in. Using the CSS class `cr-padded-text` instead keeps padding consistent with other row-like UI in WebUI and also keeps the heights the same as they were before with the `three-line` CSS class. https://imgur.com/a/MPYDcHY Bug: 686905 Change-Id: I5fdcbe9f98655ba87f08ea093279abbeb34b5830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612393Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841200}
-
spdonghao authored
Bug: 1155757 Change-Id: Iadce101e501f1a9355b7dd479ba7aed38864a599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605870 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841199}
-
