GitLab

Bubble windows sometimes had drawing artifacts. It looks like this was caused by the blur filter we added to those windows.

This CL removes the blur filter (partial revert of r134795 and r147628).

BUG=138761
TEST=Ran and verified that bubble windows looked ok on external display.


Review URL: https://chromiumcodereview.appspot.com/10833009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139069
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10820022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148450 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148449 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148448 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10832014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148446 0039d316-1c4b-4281-b951-d872f2087c98

Cancel/OK should be consistent between Create, Manage, and Delete dialogs.
 
BUG=138590
TEST= Manual testing 

Review URL: https://chromiumcodereview.appspot.com/10827011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148445 0039d316-1c4b-4281-b951-d872f2087c98

(1) Bail immediately when BEST_MATCH is requested (as is the case for the AutocompleteClassifier) as the ShortcutsProvider does not currently allow matches to score highly enough to be "best".
(2) Check for input text that's a prefix of the shortcut in question, and mark the whole prefix as a match at once.  This reduces the number of cases where we have both lots of input words AND a long unclassified chunk of output string (the case where things are slow).
(3) Rewrite the general-case matching algorithm to be noticeably faster.  (Not sure of the complexity analysis but I think the worst case is more like O(n*n) than the previous O(m*n*n) and the average case should be much faster than that.  With the test profile and disabling the above two optimizations, typing a letter in my debug build resulted in a hang of about 2 seconds as opposed to several minutes.)

We could probably still do better; in particular, one optimization we could make for all the providers would be to provide them a conservative estimate of how many total characters would be visible in the omnibox dropdown and then have them trim the contents and description fields accordingly before matching.  However, a true conservative estimate -- which would assume that we had e.g. a string of 'i's -- would in the worst case still be several thousand characters wide, I don't want to do the plumbing work, and this optimization seems unnecessary at the moment anyway.

BUG=138242
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10831004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148444 0039d316-1c4b-4281-b951-d872f2087c98

Commit this instead of http://codereview.chromium.org/10834009/

R=jvoung@chromium.org,arthurhsu@chromium.org
BUG=none
TEST=nacl_integration
CID=104221

Review URL: https://chromiumcodereview.appspot.com/10828019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148443 0039d316-1c4b-4281-b951-d872f2087c98

With this change, if launched from shell as root, the uninstaller will:
* Not show any confirmation UX
* Not prompt for admin elevation

Also in this cl, cleanup some of the shared Mac constants by pushing
more into into constants_mac and fixing up the naming style. This
required minor updates to the prefpane and daemon controller.

BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10807061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125863
TEST=Tested change on linux build /w chromeos=1


Review URL: https://chromiumcodereview.appspot.com/10796115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148441 0039d316-1c4b-4281-b951-d872f2087c98

 * cracks isolated path in FileSystemURL ctor
 * FileUtils no longer need to crack the isolated path by themselves
 * Make IsolatedFileUtil inherit from LocalFileUtil
 * Have a separate FileUtil for DraggedFileUtil, which inherits from IsolatedFileUtil

BUG=134078,138022
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/10810053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148440 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=try


Review URL: https://chromiumcodereview.appspot.com/10823015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148439 0039d316-1c4b-4281-b951-d872f2087c98

Converts SearchViewController to use live NTP content using views::WebView
instead of placeholder solid rect views::View.

TEST=Launch CrOS/Aura with --enabled-instant-extended-api, observe interactive "Most Visited" section on NTP
BUG=133529
R=sky@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10787028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148438 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=3
CID=(104210, 104215),104237,104238
BUG=
TEST=
TBR=jln,bolms,brettw

Review URL: https://chromiumcodereview.appspot.com/10825016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148437 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122913
TEST=None
TBR=acolwell@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148436 0039d316-1c4b-4281-b951-d872f2087c98

These files (included in chrome.dll on Windows) have the same contents as the
corresponding .pak files. Aside from wasting space, this indirectly caused bug
137715 (the Windows resources take precedence over .pak file resources even
when not at default_100_percent).

Some day we may consider using Windows resources instead of paks (for all
scales), but right now we don't need these RC files.


BUG=137715,137917
TEST=trybots, visual inspection

Review URL: https://chromiumcodereview.appspot.com/10820003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148435 0039d316-1c4b-4281-b951-d872f2087c98

CID=104002
BUG=
TEST=
TBR=ben

Review URL: https://chromiumcodereview.appspot.com/10822022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148434 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=6
CID=102321,102647,102678,102810,103294,103381
BUG=none
TEST=none
R=tbreisacher@chromium.org
TBR=mirandac@chromium.org, jam@chromium.org,dcheng@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10833013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148433 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=6
CID=103934,104157,[104037,104088,104089,104091],104223,104241,104263
BUG=none
TEST=none
R=tbreisacher
TBR=brettw

Review URL: https://chromiumcodereview.appspot.com/10830013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=manual
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10815087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148431 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=12
CID=104349,104361,104373,104374,104399,104420,104421,104422,104466,104476,
    104532,104538
BUG=none
TEST=none
R=groby
TBR=brettw,satorux,mnissler

Review URL: https://chromiumcodereview.appspot.com/10833006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148430 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rogerta@chromium.org
BUG=137834
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10829017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148429 0039d316-1c4b-4281-b951-d872f2087c98

The original CL broke win_aura, which is fixed in this CL.

This reverts commit b36e6617.

TBR=ben@chromium.org
BUG=124222
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10824023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=
TBR=ben@chromium.org
ben for ui/gfx OWNERS

Review URL: https://chromiumcodereview.appspot.com/10790063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148427 0039d316-1c4b-4281-b951-d872f2087c98

Try renabling IndexedDBLayoutTest.RegressionTests now that those tests run under content_browsertests.

BUG=123685
Review URL: https://chromiumcodereview.appspot.com/10821020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148426 0039d316-1c4b-4281-b951-d872f2087c98

Delete duplicate chrome/test/data/media files that were copied in r148190 in preparation for r148349.

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10828015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148425 0039d316-1c4b-4281-b951-d872f2087c98

CID=104376
BUG=
TEST=


Review URL: https://chromiumcodereview.appspot.com/10821018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148424 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116317
TEST=none

This adds code for the NaCl untrusted build of the PPAPI proxy. The NaCl IRT can't
create threads that call back into user code, so the Audio thread must be created
using a special NaCl API.
Review URL: https://chromiumcodereview.appspot.com/10809079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148423 0039d316-1c4b-4281-b951-d872f2087c98

Delete chrome/test/data/workers since it's not used anymore. It was copied in r148205 in preparation for r148349.

BUG=90448
Review URL: https://chromiumcodereview.appspot.com/10821016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148422 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148421 0039d316-1c4b-4281-b951-d872f2087c98

Also changed the type of |count_| to size_t since it's a size variable.

CID_COUNT=1
CID=13504
BUG=none
TEST=none
R=brettw


Review URL: https://chromiumcodereview.appspot.com/10834006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148420 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tomhudson@chromium.org
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10833015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137140


Review URL: https://chromiumcodereview.appspot.com/10808094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138883

Review URL: https://chromiumcodereview.appspot.com/10829015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148417 0039d316-1c4b-4281-b951-d872f2087c98

Added the search feature to the samples page, and also added icons next to the
samples.

BUG=131095

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148260

Review URL: https://chromiumcodereview.appspot.com/10809062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138880

Review URL: https://chromiumcodereview.appspot.com/10823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148415 0039d316-1c4b-4281-b951-d872f2087c98

Add droppedFrameCount, totalPaintTime, and totalRasterizeTime to chrome.gpuBenchmarking.renderingStats().

BUG=chromium:130790, chromium:137756
TEST=Launch Chrome with --enable-gpu-benchmarking and per-tile painting, open a tab to a composited page, and type chrome.gpuBenchmarking.renderingStats(). All the above fields should be present.

Review URL: https://chromiumcodereview.appspot.com/10823023

TBR=dtu@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10827023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148414 0039d316-1c4b-4281-b951-d872f2087c98

Add droppedFrameCount, totalPaintTime, and totalRasterizeTime to chrome.gpuBenchmarking.renderingStats().

BUG=chromium:130790, chromium:137756
TEST=Launch Chrome with --enable-gpu-benchmarking and per-tile painting, open a tab to a composited page, and type chrome.gpuBenchmarking.renderingStats(). All the above fields should be present.

Review URL: https://chromiumcodereview.appspot.com/10823023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148413 0039d316-1c4b-4281-b951-d872f2087c98

R=tommi@chromium.org
BUG=None
TEST=None


Review URL: https://chromiumcodereview.appspot.com/10826014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148412 0039d316-1c4b-4281-b951-d872f2087c98