- 02 Aug, 2019 40 commits
-
-
Lucas Gadani authored
Also record a crash key with the error so it's easier to debug. Bug: 881099 Change-Id: I79e44c0331fcb0a7924cb86efc88f72ece73be82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731669 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#683694}
-
Hazem Ashmawy authored
- Add methods to CrashFileManager to list files with certain upload states: forced uploads, skipped upload or ready for upload but not forced. - These methods match the suffix of file names which is used to record minidump file upload state. - Add UnuploadedFilesStateLoader which get the upload state of Unuploaded crash files. It uses the newly added methods in CrashFileManager. - This info should be combined with info collected from other logs then used in WebView crash UI. Bug: 964392 Change-Id: Id31013de2dd45235a4a1147591ef3636389b9e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617766 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#683693}
-
Min Qin authored
interrupt reasons for background mode This CL adds more UMA to analyze why download is interrupted in background mode. It also changes the target determination logic to generate a new file path in case the original target is no longer accessible. During target determination, chrome will try to preserve the existing target path and file name, and use public download storage as a backup. BUG=989670 Change-Id: I21ed2d65ce813f1537f5a92a011d6414171a1bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729834 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#683692}
-
about://flagsAran Gilman authored
Cross-platform access to "forced dark mode" and its config options is currently available via the --blink-settings flag. This change simply provides easy access to specific sets of config options for testing. Bug: 985961 Change-Id: I733c2e7b896e8a5d5fffc1b9d783473db4056c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721002 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683691}
-
Carlos Caballero authored
MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor instead. This CL was uploaded by git cl split. R=nharper@chromium.org Bug: 891670 Change-Id: Ife2524ad96a7a7c3c7df99d996f6d101a3afa88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733587 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#683690}
-
Gang Wu authored
TBR=sky@chromium.org Bug: 990214 Change-Id: I551f7832f6345b854d33c3517d4675acab3a20b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732741Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Auto-Submit: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#683689}
-
Clark DuVall authored
Also removes the kNavigationLoaderOnUI feature. We can do more cleanup of the throttles/interceptors in separate CLs. chrome/ usages removed in http://crrev.com/c/1731919 Bug: 824840 Change-Id: I1038900a4f97449ceab152df24c49f0719a195d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732409 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683688}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/825233007c7d..ad77f55e0183 git log 825233007c7d..ad77f55e0183 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 syoussefi@chromium.org Vulkan: Remove finish calls before BufferVk::mapImpl Created with: gclient setdep -r src/third_party/angle@ad77f55e0183 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: If078e165555d3d6c70304597e8465fc196531339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733571Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683687}
-
Sophie Chang authored
Bug: 986387 Change-Id: I482a439b8609a116a96c231b8a63ac891d6ea067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724578 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#683686}
-
Matt Menke authored
It's the only implementation (Other than a test-only subclass that this CL removes). To avoid a circular dependency, this CL also moves HttpServerPropertiesManager::PrefDelegate into HttpServerProperties. TBR=rohitrao@chromium.org TBR=seantopping@chromium.org Bug: 984996 Change-Id: I00b6d3633b16afb47b5f00738ea0e128f9dc69db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724586Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#683685}
-
Jimmy Gong authored
- Displays a message to users if there is no connection to the internet. - This CL adds cloud off icons for settings printers landing page. - Fixes a bug where cupsPrinters wasn't correctly checking for connectivity status. - Updates browserTests. - Updates fake network api's for testing. - This CL is hidden behind the enableUpdatedUi feature flag. Bug: 965721 Test: End to End manual, browserTests Change-Id: Ic0cec85aeba408a02d7ec1bb864a8ae00c31c915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715731 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683684}
-
Chris Sharp authored
Test appears to be flaky. TBR: alemate@chromium.org Bug: 990362 Change-Id: Ifff26b1242e3d2621426d10a3c0cb808d16b345c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732736 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#683683}
-
Elly Fong-Jones authored
This change adds a new top-level menu to the system menu, used to manipulate and select tabs in the current window. This menu contains some static items, moved from the Window menu, and then a list of entries corresponding to open tabs in the current window. Specifically, this change: 1) Adds a new class, TabMenuBridge, which binds a TabStripModel to a NSMenu; 2) Adds a new menu item to the main menu named "Tab"; 3) Creates a TabMenuBridge for any tabbed browser window in the app controller. The motivation for this change was twofold: first, to allow easier access to commands that are currently only present in the tab's context menu, and second, to allow easier access to tabs in crowded tabstrips. The first purpose is well-defined and understood but the second is very much experimental. Testing: Build, run, and enjoy the new Tab menu :). There are some unit tests in TabMenuBridgeTest.* as well. Future work: * Renaming the static items to better fit their new context. This was not done here to avoid breaking existing user key equivalents, which identify items by their full name. * Exploring other orderings of tabs in this menu. * Adding other tab actions to this menu, like "Bookmark" or possibly page actions. * Adding a search bar to search within tab titles/origins? * Adding key equivalents for the static actions (which will resolve the actual accessibility bug this commit is for) Bug: 818261 Change-Id: I790cc2c5a4468719e42b782a318864ecd81bd1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728718 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#683682}
-
Avery Musbach authored
When you press the Escape key, OverviewSession::OnKeyEvent checks for split view mode with no overview windows, to avoid ending overview then. This check is unnecessary because OverviewController::ToggleOverview will bail out. It will hide the virtual keyboard first, but when you press the Escape key in the first place, you must have an external keyboard and therefore no virtual keyboard. FALLTHROUGH between case ui::VKEY_BROWSER_BACK and case ui::VKEY_ESCAPE is also unnecessary, and is inconsistent with between case ui::VKEY_RIGHT and case ui::VKEY_TAB. Test: ash_unittests OverviewSessionTest.ExitOverviewWithKey Change-Id: I26e5d6ae752d040aaf1bc40c798f00548c4730fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733727Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#683681}
-
Brian White authored
Updates the expires_after attribute for 229 histograms that show frequent access in the past 90 days. These are the 30% most frequently used histograms over that time that do not already have a date later than or within 30 days of 2020-01-26. Change-Id: Ia73aa2bdbff267afa756fe663a2fbaac187ec762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732331 Commit-Queue: Brian White <bcwhite@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#683680}
-
Chris Sharp authored
This was causing flaky compile failures on Linux ChromiumOS Full bots. Example failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/139037 TBR=xiaohuic@chromium.org Change-Id: I60b94045b5d55ff9c627351e25aa5bf25c199ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732745Reviewed-by:
-
Daniel Rubery authored
Similar to the TwoPhaseUploader, add a factory for MultipartUploadRequest, so that consumers of the MultipartUploadRequest can mock out the network operations. This CL also fixes two minor problems with the MultipartUploadRequest, changing the callback structure and fixing tests. Bug: 980784 Change-Id: Iba9ebb1d985fd9df697c5b9f96e1b6d57bd1cbc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728541Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#683678}
-
Nate Fischer authored
WebView needs to add variations-specific headers to the CORS-exempt headers list, otherwise we may trigger excessive CORS preflight checks. Bug: 990072 Test: Enable "OutOfBlinkCors", WebView still seems to work Change-Id: I9ad69dd52fc53bbbce01a33724050322b642a70a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731555 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#683677}
-
Carlos Caballero authored
MessageLoopForIO is going away soon. Use SingleThreadTaskExecutor instead. This CL was uploaded by git cl split. R=lambroslambrou@chromium.org Bug: 891670 Change-Id: Id1c49577b98d4adc705d1eec6a164382fb5aba77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731848 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#683676}
-
Findit authored
This reverts commit 76c1237a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 683650 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzc2YzEyMzdhYTBmY2RkZDA1MzZmZTE5OWQzMTBlNjVjM2JiOGY0M2EM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/win-archive-rel/3564 Sample Failed Step: compile Original change's description: > Remove "chrome" and "chrome_renderer" services > > This eliminates the existence of the "chrome" and "chrome_renderer" > services as well as general support for embedder-provided process-wide > browser and renderer Service Manager services. > > Remanining browser<->renderer interfaces which used these services have > been migrated to use direct receiver binding via > content.mojom.ChildProcess or content.mojom.ChildProcessHost messages. > > Change-Id: I74f012aafe77fdcbbba8d93d193d3ded8d63d445 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729968 > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#683650} Change-Id: I797753e6cb96874ca92a245bcb493b669689a981 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733026 Cr-Commit-Position: refs/heads/master@{#683675}
-
Sophie Chang authored
This is moving here as this top host provider is what is approved for users with Lite Mode enabled rather than just Previews enabled. It may be confusing to consumers if this was still tied to Previews anyway. Bug: 969558 Change-Id: I698638a3583744f9fb4dd8d5ef4cc1eae2b0554f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731451 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
The following UMA metrics are removed: Webapp.Splashscreen.Icon.Size Webapp.Splashscreen.Icon.Type Webapp.Splashscreen.BackgroundColor Webapp.Splashscreen.Duration Webapp.Splashscreen.ThemeColor This CL extends the expiry of: Webapp.Splashscreen.Hides R=hartmanng@, dominickn@, rkaplow@ TBR=yfriedman@ for WebappSplashUmaCache.java BUG=975052 Change-Id: Id6b7ae9e7d7e05170bd0474a9da8f239783afeab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716136 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683673}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/31899ec2ac04..4af1fe027b83 git log 31899ec2ac04..4af1fe027b83 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 tomhughes@chromium.org docs: Copy dev server docs from Chromium sites Created with: gclient setdep -r src/third_party/chromite@4af1fe027b83 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3104dc15ca1ff799a7fab5a958c222daa767328a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733569Reviewed-by:
-
Dan Beam authored
R=pkotwicz@chromium.org BUG=953962 Change-Id: Id13ea7145bc302da3ff427098648517be48b2964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730258Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#683671}
-
Philip Rogers authored
Non-fast scrollable regions are regions on a cc::Layer where the compositor should not handle scroll events. These are primarily for non- composited scrollers but are also used for resize handles and plugins. This patch paints non-fast scrollable regions for resize handles. The interesting code change is in ScrollableAreaPainter::PaintResizer where we now emit a ScrollHitTestDisplayItem for resizers. This fixes a class of bugs such as non-fast regions being on the wrong cc::Layer (https://crbug.com/968691) and having the wrong offset (https://crbug.com/989038). Design doc: https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw/view#heading=h.rrlzkp4v3huj Bug: 864567, 968691, 989038 Change-Id: I8193077279617418433306912d712c31d99149f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730521Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683670}
-
Ahmed Mehfooz authored
We do not need any bottom inset for the separate message center bubble. Also, need to clip scroller height based on clear all button visibility. Bug: 958020 Change-Id: Ie4f0966f2de97f841cf975fcc7810c82761b2de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730091 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#683669}
-
Tomasz Śniatowski authored
Make the metadata machinery on Android use output_extension in shared_library and similar targets if it is set, so the gathered metadata matches the actual names of built binaries. GN shared_library targets can set a custom 'output_extension' (for example, to explicitly always have a .so extension and never .cr.so) and the Android metadata machinery should work with that. Test: set output_extension on a solib and build Android Bug: 980569 Change-Id: I12fb2b31e753adf81bac86c07e10aa913de51969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730155 Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#683668}
-
Michael Thiessen authored
Fixes handling of intent URLs in touchless mode. window.open('intent://...'); should now fire the BROWSABLE intent as expected. We do this by special casing the 'new window opens in CCT' logic to ignore intent:// schemes, and handle the resulting New Tab View Intent with the ExternalNavigationHandler. Bug: 983699 Change-Id: Ic28930db53686ae46c55496554e7388d12aa937c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733458Reviewed-by:Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#683667}
-
Robbie McElrath authored
This moves Feature set up in SSLErrorHandlerDateInvalidTest to the constructor rather than the SetUp method to make sure it gets set before things start checking for Features. Bug: 989225 Change-Id: If4b781ee37534bb8100a781aa99cecab8ad7f06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732151Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#683666}
-
Richard Knoll authored
While we check the native notification platform bridge for the currently shown notifications, new ones might be added to the database. This will ignore all entries that are added after we started querying the OS. Bug: 988376 Change-Id: I5931a50fc5756987e095a19dbaed62045997f8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732100Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683665}
-
Wez authored
Tests use //ui/aura/test/test_screen.cc, which under Fuchsia calls InitializeViewTokenAndPresentView(), which creates a token and invokes fuchsia.ui.policy.Presenter.Present(). This may cause the presenter service to be started, if not already running, which may lead to crashes or logspam. Bug: DX-1801 Change-Id: I65f1ff5e86557d236de8df58cea351b265627a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729514 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#683664}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01915c0dd073..149f3f197897 git log 01915c0dd073..149f3f197897 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 halcanary@google.com tools/sk_app: fWindowContext is unique_ptr<> 2019-08-02 mtklein@google.com add vbroadcastss(Ymm, GP64, int) 2019-08-02 halcanary@google.com sk_app, editor: cursor blink Created with: gclient setdep -r src/third_party/skia@149f3f197897 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I5a590d56efea8d18df082ffc10083240670d0968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733474Reviewed-by:
-
Evan Stade authored
Bug: 268984 Change-Id: Ie41cb913d29ad690b9364d9c478c7a3c4771f607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730591Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I45dcee4561a33901f8c505629d933585662feccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733570Reviewed-by:
-
Sam Maier authored
Binary-Size: We were mistakenly not doing this Bug: 965189 Change-Id: I03f64ec6b81ab9da97b3ef9258c7dec17706f91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730845 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#683660}
-
Ken Rockot authored
r680551 landed a partial fix which corrected the issue specifically for single-process mode, but the more general bug is that a UtilityProcessHost can still call UtilityProcessHost::Client::OnProcessTerminatedNormally() even if a process was never launched. This fixes the bug in all cases by ensuring that |launch_state_| is |kLaunchComplete| before invoking OnProcessTerminatedNormally(). This state is only set once process launch has successfully completed. Bug: 987448 Change-Id: I5c419cdb16b8f8b67058fdad0385b499552354e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733011Reviewed-by:
-
Tim Volodine authored
Move files that are still used in the network service code path to the /network_service directory. The idea is that the old /net directory is going to eventually disappear. BUG=989842,989104 Change-Id: I28a39353a9b4f4d6cecf04fb78df328272cfdefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733547 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#683658}
-
rbpotter authored
Bug: 965770 Change-Id: I9e78f603d8649bd05ccff37c59a5a3f18c2c1623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714324Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#683657}
-
Ian Wells authored
Refresh suggestions in the background with more urgency to bring Feed's background fetching in line with Zine's. Bug: 988165 Change-Id: I412ad34a7ec6c1b6c3ec3bf5e089ee2a0854e77f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730090 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683656}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 989638 Change-Id: I15558b826884ba4762f8d2e30bf3556798cfbb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730526Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#683655}
-
