- 07 Mar, 2018 40 commits
-
-
jdoerrie authored
TBR=creis Bug: 819541 Change-Id: I5b36ae92c2706f71fc80b7f63504c01d2479eb7e Reviewed-on: https://chromium-review.googlesource.com/951687Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#541469}
-
jdoerrie authored
TBR=brucedawson Bug: 819641 Change-Id: I5a24cba7a89ef43e0c0ce762680eaf9e2ab6aa0a Reviewed-on: https://chromium-review.googlesource.com/951689Reviewed-by:
-
Justin Cohen authored
Bug: 805638 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I690310beb94b0fed2cb228df37e9b60143119fc3 Reviewed-on: https://chromium-review.googlesource.com/952489Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541467}
-
Jared Saul authored
Bug: 789645 Change-Id: I1ec5fe2ab55858e826cac09cec4cbd2c7ca05903 Reviewed-on: https://chromium-review.googlesource.com/950412Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#541466}
-
Lily Houghton authored
This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/836927 and renames most references to "proxy scripts" and to "pac files", including renaming ProxyResolverScriptData to PacFileData. TBR=mmenke@chromium.org,avi@chromium.org,halliwell@chromium.org,stevenjb@chromium.org,sky@chromium.org Bug: 613655 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3b172834c1281be2f554d96f37ebbf69d7291f4b Reviewed-on: https://chromium-review.googlesource.com/909654 Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541465}
-
Steven Bennetts authored
Providing correct initial values reduces the noise when the complete set of properties loads. Bug: 808694 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7f15e0965491376eb2c8e2403b55192f597a4dbd Reviewed-on: https://chromium-review.googlesource.com/951853Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#541464}
-
Justin Cohen authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/941441, as hiding blur will hide the entire toolbar. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b051fc0573e45922d35bb695bfd3cdff289b3e8 Reviewed-on: https://chromium-review.googlesource.com/951748Reviewed-by:
-
Dominik Röttsches authored
Taking on important fixes to hb_set_union/subtract/difference. Bug: 819624 Change-Id: I41088581a41565cbbd99a430425e2ab9be6ee939 Reviewed-on: https://chromium-review.googlesource.com/951736Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#541462}
-
Ian Vollick authored
This feature is not currently supported, though we hope to add support soon. This work is tracked in crbug.com/779126 Bug: 818012 Change-Id: Ib677f7ea62b9f681ba494c27367b286a122dd10f Reviewed-on: https://chromium-review.googlesource.com/944543 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541461}
-
erikchen authored
The method is only well defined on Windows, but its presence in base/ makes it appear to be well defined on other platforms. There were only 2 consumers: A metrics reporting call in remoting/ and a debug log in v8/. This CL updates remoting/ to fetch the metric directly on Windows and leave it empty on other platforms. This CL updates v8 to remove the field from the debug log. Bug: 819289 Change-Id: Id44c2efd345318dce9734566b4696c947b0fd617 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/951745 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#541460}
-
Steven Bennetts authored
Bug: 796118 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2e239ddd5430350d8a76a33f1dd5ffbaf4d3317f Reviewed-on: https://chromium-review.googlesource.com/952523Reviewed-by:
-
Jamie Madill authored
Unblocks the Vulkan roll (issues with http://crbug.com/643346). Bug: angleproject:2393 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Tbr: kbr@chromium.org No-Try: True Change-Id: Icd41d0ba9abbbdd5a8d52e9f391716dbef674a34 Reviewed-on: https://chromium-review.googlesource.com/951648Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#541458}
-
Steven Bennetts authored
Bug: 816864 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia0c8b5c098bfb649175f1f87e5895f85dad98cb0 Reviewed-on: https://chromium-review.googlesource.com/947043 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Etienne Pierre-Doray authored
This CL changes the way target delta is computed. Introduces OffsetMapper used to map offsets (targets) from old to new image in both gen and apply. Previous: - old label associated with old target is retrieved - delta is applied to label - new target is retrieved from label New: - old target is projected to estimated new target - estimated new target is indirected into a key - delta is applied to key - new target is retrieved from key This removes the need for UnorderedLabelManager. Bug: 729154 Change-Id: If32f7db8f424fd59275f583860b38ba9740ee594 Reviewed-on: https://chromium-review.googlesource.com/627188 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#541456}
-
Steven Bennetts authored
Bug: 804258 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I865bc4cf3fa00572775227e9b6ce455cfae57c85 Reviewed-on: https://chromium-review.googlesource.com/952464Reviewed-by:
-
Elly Fong-Jones authored
This change: 1) Has LocationBarBubbleDelegateView close itself when the WebContents is hidden or closed; 2) Removes matching logic that was already in two of its subclasses; 3) Fixes the browser tests for one of those subclasses to allow for async window closure. Bug: 780131 Change-Id: I2362c82c89be1356356663789e97b51b3b2362f8 Reviewed-on: https://chromium-review.googlesource.com/919308 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#541454}
-
Matthew Cary authored
It is failing on health-plan-webview-low-end-phone. Bug: 777355 TBR: perezju@chromium.org Change-Id: I8da34a031a91685afaee95833c58296528a21579 Reviewed-on: https://chromium-review.googlesource.com/951686Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#541453}
-
Alexandr Ilin authored
This CL enables predictions for URLs that have non-standard port. This is done because some performance tests that use URLs with a custom port number show regression when the predictor is enabled. Now we're trying to confirm that this is the case. This restriction was overly cautious to begin with to make sure we don't put garbage in the database. In the future we can prohibit such URLs to be written in the database but allow preconnecting to them. Bug: 808036 Change-Id: I2a41795cb584db2ed164fc6b62c31a90d5ecb483 Reviewed-on: https://chromium-review.googlesource.com/939381Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541452}
-
Maks Orlovich authored
This in particular targets the case where it's likely getting stuck (defined as taking >= 60s per entry), but also includes cases where it fails, since that's basically same spot. Bug: 809199, 808286 Change-Id: Id7f2157e352914dc7aa163938d260362c14afba6 Reviewed-on: https://chromium-review.googlesource.com/951925Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#541451}
-
Sylvain Defresne authored
Add overload for GetToolbarSearchButtonImage taking the search engine icon type (as an enum) to allow the provider to return different image for different search engine. Bug: none Change-Id: I142aa9d2a5a9a97a7c66b773d6afd9ebc1bd867f Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/952448 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Tommy Martino authored
Adding the capability to display icons (e.g., Visa logo) in Autofill dropdown reimplementation. Screenshots: https://docs.google.com/presentation/d/1869xYStqAIyVODBlUTi5Gf4ct6hevSdCGiJpFuOOVw8/edit?usp=sharing Bug: 768881 Change-Id: I659a2dcffe01f3390e187fd969f62570fe7cb850 Reviewed-on: https://chromium-review.googlesource.com/912401Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#541449}
-
Nico Weber authored
Shipping Chrome/Wins are now always built with clang, so the Compiler: line is no longer needed. This part reverts https://codereview.chromium.org/1404063002 (and some follow-ups). We do want to switch the linker eventually, so add a "Linker:" line instead. Bug: 82385,530785,792131 Change-Id: I0ecee267e468e04ee10590e1396df8c49110e595 Reviewed-on: https://chromium-review.googlesource.com/952486Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#541448}
-
Simeon Anfinrud authored
This fixes a bug in CastWebContentsActivity where any call to finish() would trigger a startActivity(). Also: Hooray! A CastWebContentsActivityTest! Bug: 36777136 Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: Iea5da06f34a35267294acdbda5371b37e15045a2 Reviewed-on: https://chromium-review.googlesource.com/952571Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541447}
-
Mihai Sardarescu authored
This CL changes the title of the sign-in error dialog when Desktop Identity Consistency is enabled to "Can't sync to ..." Bug: 817123 Change-Id: I1c19d9f9e3e963a444a2a701515ab17504fa1785 Reviewed-on: https://chromium-review.googlesource.com/951790Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#541446}
-
Troy Hildebrandt authored
The ExternalNavigationHandlerDelegateImpl gets passed a Tab as a parameter when we create an ExternalNavigationHandler, and this doesn't change for its lifespan. The Tab in question is passed in from the call to Tab#attach, which creates a brand new InterceptNavigationDelegate which in turn ends up creating the ExternalNavigationHandlerDelegate. Bug: 651205 Change-Id: Iba4cfb154c5374ff931b35211246975f9cdd7892 Reviewed-on: https://chromium-review.googlesource.com/952274Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541445}
-
Elad Alon authored
BrowserMainLoop still creates the instances of these two globals, but no longer owns them, meaning that they're allowed to leak when Chrome terminates, undoing concerns about WebRtcEventLogManager's internal task queue during teardown. Bug: 775415 Change-Id: I4f75cb31a84e2110ebc33daf50aa58c093a34a86 Reviewed-on: https://chromium-review.googlesource.com/909429 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#541444}
-
Greg Thompson authored
This fixes a bug on macOS when using a Cocoa-based browser, whereby the bubble was not attached to the browser window. BUG=819546 Change-Id: Ia465a0ba9251e33b3b6fc9c6756445d1399ff79a Reviewed-on: https://chromium-review.googlesource.com/952926Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#541443}
-
Nick Peterson authored
Any extension automaticaly installed using the ExtensionSettings policy must download it from the Chrome Webstore unless enterprise managed. If the policy attempts to install from a non-Chrome webstore location that part of the ExtensionSettings policy will be invalid and stripped out before the rest of the policy is applied. Bug: 809004 Change-Id: I2167dd1e067b9a5e4c9905a0a128e79546d7ca6f Reviewed-on: https://chromium-review.googlesource.com/905982 Commit-Queue: Nick Peterson <nrpeter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#541442}
-
https://webrtc.googlesource.com/src.git/+log/7dbb701076f3..db4fa4b94442 $ git log 7dbb70107..db4fa4b94 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I04ab801bcdd66c8e648fdef7b71b54073c844a43 Reviewed-on: https://chromium-review.googlesource.com/952049 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541441}
-
erikchen authored
The tool is unmaintained, has not been finding bugs, and no one wants to maintain it. Bug: 819346 Change-Id: I348fe7d014f7d669465efe271ec435e0e18a7524 TBR: sky@chromium.org Reviewed-on: https://chromium-review.googlesource.com/951932 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#541440}
-
https://skia.googlesource.com/skia.git/+log/8bac928009b8..461ef7af88cc $ git log 8bac92800..461ef7af8 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 fmalita Revert "add tiler for SkDraw" 2018-03-07 kjlubick Experiment with different settings for Pixel SKP bench 2018-03-07 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 28060c436..7618eaf9a (3 commits) 2018-03-06 egdaniel Make GrReleaseProcHelper an SkWeakRefCnt 2018-03-07 angle-skia-autoroll Roll skia/third_party/externals/angle2/ d2cb7cec4..28060c436 (7 commits) 2018-03-06 amidlash [SkSVGDevice] Add support for image shaders. 2018-03-02 halcanary Viewer/Amdroid: universal build, resources in APK 2018-02-28 caryclark use safe math for growForRepeatedVerb 2018-03-06 herb Revert "Centralize mask byte calculations" 2018-03-06 brianosman Cleaning up SkColorSpaceXform a bit 2018-02-28 herb Centralize mask byte calculations 2018-03-06 reed add tiler for SkDraw 2018-03-06 mtklein support 888x, 1010102, and 101010x in SkPixmap::erase() 2018-03-06 robertphillips Add SkSurfaceCharacterization::createResized 2018-03-06 caryclark remove canvas internal private 2018-03-06 bungeman Add "--nonativeFonts" to public.bzl for running dm. 2018-03-06 angle-skia-autoroll Roll skia/third_party/externals/angle2/ e05ffdd19..d2cb7cec4 (1 commit) Created with: roll-dep src/third_party/skia BUG=803034 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I7928450c1eb8746b96ac4acd0f6b39b39d081f19 Reviewed-on: https://chromium-review.googlesource.com/952546 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541439}
-
Theresa authored
When the search box view isn't attached to the NTP, we use Integer.MIN_VALUE to translate the search box bounds. For modern, we use a negative lateral inset to make the search box bounds match the toolbar height. When applied to Integer.MIN_VALUE, we exceed the lower bounds for ints, turning the bounds.top from a very low negative integer to a very high positive integer. Only apply the inset if we aren't using Integer.MIN_VALUE for the bounds translation.y. BUG=818848 Change-Id: Icbf3a55ffd03df2eb3c26e07b732398417f7e915 Reviewed-on: https://chromium-review.googlesource.com/951900Reviewed-by:
-
Stephen McGruer authored
This is a reland of 91310914 Now that the WPT test infra has been pulled from upstream, the hope is that changing tests from reftest to jsharness won't cause the bots to fail horribly. Original change's description: > Port another set of sticky tests to JS rather than reftests > > Change-Id: Idf6dd882d2d50b1ec349f245d76717553ee266b3 > Reviewed-on: https://chromium-review.googlesource.com/882002 > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532966} Bug: 699244 Change-Id: Ib8c16d08f1327765e0bd322a708452373db8581c Reviewed-on: https://chromium-review.googlesource.com/951662 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#541437}
-
https://chromium.googlesource.com/angle/angle.git/+log/065aa863f706..7618eaf9ad45 $ git log 065aa863f..7618eaf9a --date=short --no-merges --format='%ad %ae %s' 2018-03-07 oetuaho Fix incorrect path in run_code_generation.py Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Iae45f88ce316ad9bf44568ad60b5c677aec8d5f0 Reviewed-on: https://chromium-review.googlesource.com/953027Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541436}
-
jdoerrie authored
TBR=jrummell Bug: 819620 Change-Id: I06e3f62d70614ffe247ec23b27fe57b4d9582fe4 Reviewed-on: https://chromium-review.googlesource.com/951727Reviewed-by:
-
Amirhossein Simjour authored
The touch events that are generated based on the controller state should not have touch size. This CL sets the pointer type to stylus to make sure that disambiguation popup won't show up in VR. BUG=817055 Change-Id: I903c9d19f331b59cd55c7ade0f5d3e26faae672a Reviewed-on: https://chromium-review.googlesource.com/949622Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#541434}
-
Dave Tapuska authored
Remove code to log histogram that isn't used anymore. BUG=819059 Change-Id: I6141aec67fa44ea1c7883659f1b88274ddaa2c26 Reviewed-on: https://chromium-review.googlesource.com/951710Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#541433}
-
Tsuyoshi Horo authored
Bug: 803774 Change-Id: I9c888a507913c54e11f3f6b3014001586151eed9 Reviewed-on: https://chromium-review.googlesource.com/920803 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#541432}
-
Mikel Astiz authored
In tests (I believe the scenario cannot be reproduced otherwise), there are situations where DisableSync() is exercised before the model is ready to sync. Hence, the bridge should propagate the readiness state to the newly created processor during DisableSync(), without making the assumption that it must have been ready. The proposed implementation is not elegant, because the semantics of IsTrackingMetadata() are somewhat abused to assume it reflects model readiness (which is the case for the only production change processor). However, we will replace this is in a follow-up patch anyway, so it's best to keep the changes as small as possible. Bug: 819233 Change-Id: Idecf65ade939120fc89bace63b1844176cde9eb3 Reviewed-on: https://chromium-review.googlesource.com/951786Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#541431}
-
David Roger authored
For some accounts (hosted domains), Chrome had long-lived tokens, whereas cookies for these accounts are short-lived (~2 weeks). As part of Dice, the cookies are re-created when they expire as long as the refresh token is still valid. This is a problem, because this would lead to these accounts staying logged in on the web for longer than intended. The Gaia server now correctly issues short-lived tokens for these accounts, but a lot of tokens that were issued before the change are still in use. This CL revokes of all the hosted domain tokens before migrating to Dice, to ensure that there are only new tokens going forward. Bug: 810092 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I35eceb02dd9337ae479143d8b1cabb504b800d3a Reviewed-on: https://chromium-review.googlesource.com/926006 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#541430}
-
