- 21 Aug, 2020 40 commits
-
-
Eleonora Rocchi authored
This CL adds tests to verify the number of compromised credentials is correctly updated: if the status is IDLE the count should be updated, otherwise the count should be null. Bug: 1117543, 1092444 Change-Id: I1f5a63745bc20789fc7df7bb5b5672df97e3b5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367719Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#800536}
-
Mohamed Amir Yosef authored
... DatabaseCompromisedCredentialsObserver. This is similar to OnCompromisedCredentialsChanged(), but also receives the originating PasswordStore as a parameter. Bug: 1108422 Change-Id: I76fffc36c65554bbe3e812c9e21ab229437f20a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368554 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#800535}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/12ffc2536244..c153394161f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1115567 Tbr: mxcai@google.com Change-Id: I69d01e6985fe8d4c24c945227d10488057df24e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368546Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800534}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d93c7e06451..d7508751f4e1 2020-08-21 patrick.brosset@microsoft.com Grid: Transform grid lines and labels based on the current writing mode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096971 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I96147e0515c03dfb66f28fcbdf9db251b680a6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368923Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800533}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4909d08c1410..a2c33e3fa098 2020-08-21 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from cbfd396756c6 to 44e1791f100c (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ib7262936b7d170cce9dd20f38b60d742b4bbd991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368478Reviewed-by:
-
Igor authored
Currently three links from feedback form don't work properly on login screen, by opening invisible incognito windows only. This CL removes the links until the problem can be fixed on login screen. screen and click on the links for privacy/terms of service. Nothing is expected to happen, the links are disabled. Bug: chromium:1116383 TEST: Manually verified on device by pressing alt+shift+I on login Change-Id: Ieffd4cccbc8fbac52f45890761783cadb29cd3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362797 Commit-Queue: Igor <igorcov@chromium.org> Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Auto-Submit: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#800531}
-
Leszek Swirski authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/899af242..f8fa384f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I336d80b56df8dff866a47b0796a7cebf3ad038d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366276Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#800530}
-
Maggie Cai authored
This reverts commit f5cdac12. Reason for revert: This might be the cause of test failure virtual/threaded/external/wpt/feature-policy/experimental-features/vertical-scroll-disabled-scrollbar-tentative.html for https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64/48699 (and some builds after this). Revert to see if this fixed the test. Original change's description: > Don't trigger main-thread overlay scrollbar animations if composited > > There are already hit tests and animations entirely in the impl thread > for such scrollbars. > > Bug: 1116800 > > Change-Id: I2714258717c89e0ea41232eb86abe12570526d28 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364972 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800302} TBR=bokan@chromium.org,chrishtr@chromium.org Change-Id: Ided42e8aa3339e93f85d9f73f3737197864b493d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369076Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800529}
-
Friedrich Horschig authored
After this CL, CrOS tests will only execute 2 more tests from this test suite but the flakiness has reached a frequency of 1 failure per run (not the same test though). The failure reason is not easy to track down but the error log is pretty much always show the same DCHECK being hit: Check failed: casting_session_count_ > 0 (0 vs. 0) #0 0x561ba221ecab in __interceptor_backtrace /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:4176 #1 0x561ba221ecab in ?? ??:0 #2 0x561bb683aea9 in base::debug::CollectStackTrace(void**, unsigned long) ./../../base/debug/stack_trace_posix.cc:840 #3 0x561bb683aea9 in ?? ??:0 #4 0x561bb656d143 in StackTrace ./../../base/debug/stack_trace.cc:206 #5 0x561bb656d143 in StackTrace ./../../base/debug/stack_trace.cc:203 #6 0x561bb656d143 in ?? ??:0 #7 0x561bb65cd766 in logging::LogMessage::~LogMessage() ./../../base/logging.cc:543 #8 0x561bb65cd766 in ?? ??:0 #9 0x561bb65cee7e in logging::LogMessage::~LogMessage() ./../../base/logging.cc:537 #10 0x561bb65cee7e in ?? ??:0 #11 0x561bc20145a9 in ash::ProjectingObserver::OnCastingSessionStartedOrStopped(bool) ./../../ash/display/projecting_observer.cc:50 #12 0x561bc20145a9 in ?? ??:0 #13 0x561bc1fe0c33 in ash::Shell::OnCastingSessionStartedOrStopped(bool) ./../../ash/shell.cc:404 #14 0x561bc1fe0c33 in ?? ??:0 #15 0x561bb6cc6e86 in MediaCaptureDevicesDispatcher::UpdateMediaRequestStateOnUIThread(int, int, int, GURL const&, blink::mojom::MediaStreamType, content::MediaRequestState) media_capture_devices_dispatcher.cc:? #16 0x561bb6cc6e86 in ?? ??:0 #17 0x561bb6cc9822 in Invoke<void (MediaCaptureDevicesDispatcher::*)(int, int, int, const GURL &, blink::mojom::MediaStreamType, content::MediaRequestState), MediaCaptureDevicesDispatcher *, int, int, int, GURL, blink::mojom::MediaStreamType, content::MediaRequestState> ./../../base/bind_internal.h:498 #18 0x561bb6cc9822 in MakeItSo<void (MediaCaptureDevicesDispatcher::*)(int, int, int, const GURL &, blink::mojom::MediaStreamType, content::MediaRequestState), MediaCaptureDevicesDispatcher *, int, int, int, GURL, blink::mojom::MediaStreamType, content::MediaRequestState> ./../../base/bind_internal.h:637 #19 0x561bb6cc9822 in RunImpl<void (MediaCaptureDevicesDispatcher::*)(int, int, int, const GURL &, blink::mojom::MediaStreamType, content::MediaRequestState), std::__1::tuple<base::internal::UnretainedWrapper<MediaCaptureDevicesDispatcher>, int, int, int, GURL, blink::mojom::MediaStreamType, content::MediaRequestState>, 0, 1, 2, 3, 4, 5, 6> ./../../base/bind_internal.h:710 #20 0x561bb6cc9822 in RunOnce ./../../base/bind_internal.h:679 #21 0x561bb6cc9822 in ?? ??:0 #22 0x561bb6702dd1 in Run ./../../base/callback.h:99 TBR: mfoltz@chromium.org Bug: 822231 Change-Id: I1780e4f0be20361bded9d38a070e6dfacdfdd45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367676Reviewed-by: -
Mugdha Lakhani authored
Bug: 1119726 Change-Id: If3a82e7718590e51bafeee191e2176cd2a3f2a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366754 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#800527}
-
Maggie Cai authored
This reverts commit 029e171b. Reason for revert: This CL is likely the causes of failed test QRCodeGenerator.GenerateVersionSelection since build https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20302 Original change's description: > qr: add support for selecting the mask. > > The QR standard says that the mask should be auto-selected, not fixed to > three, and specifies a fitness function for choosing the best mask for > each QR code. > > This change adds support for that and lets the caller specify a mask if > it really wants … say if it wanted to cycle through a series of QR codes > for the same data with a dancing dinosaur on top. > > Change-Id: Ief4dedce236aa2ae13cc94b2248a17a0488f88ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365222 > Commit-Queue: Adam Langley <agl@chromium.org> > Auto-Submit: Adam Langley <agl@chromium.org> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#800326} TBR=agl@chromium.org,martinkr@google.com Change-Id: Iacd4ff5dd235bbd54992061589ac93d73c76a708 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368658Reviewed-by:
-
Yuki Yamada authored
This is a reland of 351529d8 The previous CL was reverted since M86 branch cutoff was coming, so let's reland it again :) Update summary from the original CL: - Made WebSocketChannelImpl::ProcessSendQueue() not called when the execution context is already destroyed. https://crrev.com/c/2362042 - Add kForceWithoutContextObserver parameter to VibrationController::vibration_manager_ to avoid automatic reset. https://crrev.com/c/2355638 - Check IsContextDestroyed() before calling Abandon() in PrerenderHandle::remote_handle_. https://crrev.com/c/2355357 - Check sensor_remote_.is_bound() before accessing it from SensorProxyImpl::RemoveConfiguration(). https://crrev.com/c/2352588 These ware all related to HeapMojoWrapper's ContextDestroyed() because the original CL broke the order of callbacks invoked from ExecutionContext::NotifyContextDestroyed(). Original change's description: > Change HeapObserverList to HeapObserverSet > > The previous CL for HeapObserverList https://crrev.com/c/2060348 > addressed two things: changing HeapObserverList to HeapObserverSet and > allowing removal while iteration, and was reverted for performance > reasons. This CL only does the former and avoids performance > implications of the latter. > > This CL is for migration of NewLinkedHashSet. > See: https://crrev.com/c/2134039 Bug: 1100257 Change-Id: Ib8d21b44bf1447326428e0976f39e4c53677f838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369012Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Yamada <yukiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#800525}
-
Nela Kaczmarek authored
This change covers adding change_password_url field to Facet and adding a RequestInfo struct that enables caller to set Affiliation Fetcher request mask. Change-Id: I544e5ab0d9f07d0b711e4b8775a40f1130ba1563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362590 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#800524}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a711c594b8cc..b79773a35d52 2020-08-20 dnovillo@google.com CCP should mark IR changed if it created new constants. (#3732) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I7b9d99754553c859342a3fd48553b74b3d09b9fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368918Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97ff660720cd..5d93c7e06451 2020-08-21 alexrudenko@chromium.org Move Layout pane to the 3rd position in the sidebar 2020-08-21 alexrudenko@chromium.org Show grid elements across iframes 2020-08-21 nsatragno@gmail.com Update webauthn OWNERs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1109177 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I12b3ea8365c75d34a73c45f4b61438c03744eab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368917Reviewed-by:
-
Marc Treib authored
The default timeout values are 10s without interaction, or 3s after mouseover. That's a bit short for this IPH bubble, so this CL changes the values to 30s/10s, and also makes the configurable via a variation param. Bug: 1115476 Change-Id: Ifa80371e4126c9ba21f0651e64ec68f18f9f36c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363755 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#800521}
-
Clemens Arbesser authored
With this CL, the controller will remember the last successful user data options, such that subsequent actions can refer to it. This allows the ShowDetails action to only surface the information that was requested in the preceeding CollectUserData action. Screenshots of the resulting UI are in the linked bug. Bug: b/160214328 Change-Id: I31cd5fa13257ff6f1f10cfaef75ebb7de5099df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367036Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#800520}
-
Jeremie Boulic authored
When trying to open an encrypted archive with a wrong password, display an 'Invalid password' message, and prefill the password input field with this previous password. BUG=chromium:912236 TEST=browser_tests --gtest_filter="FileManagerJsTest.FilesPasswordDialog" Change-Id: I11ceb75bc824c550fbb0c96ec516f2b6d391d615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366515 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#800519}
-
Alexey Baskakov authored
The WebAppProvider system couldn't download it given the url from the manifest: chrome://media-app/system_assets/app_icon_48.png It would be nice to have some offline integrity checks for SWAs metadata. Fixed: 1110768 Change-Id: Ie8fb1b2bc06bb9f64fdc2d0c22bafc3cb43da4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367589Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#800518}
-
Reda Tawfik authored
This Cl adds |AllPasswordsBottomSheetView| which implements |BottomSheetContent| and chnge its visibility state from the controller. Adds a junit test. This Cl skips adding screenshots for string resources. The UI is in early stages and taking a screenshot for it does not help for translation. Will be added when the UI gives helpful context. Bug: 1104132 Skip-Translation-Screenshots-Check: True Change-Id: If6be6f9dbea93489b69b367d4d997cec595fb7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320171Reviewed-by:
-
Aya ElAttar authored
- Changed Web-originated clipboard access to set the destination trying to access the clipboard data if possible. - Renamed EndpointType::kVm to kGuestOs Bug: 1103614 Change-Id: I895ea000e985611896f842274ea6849a822753d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346288Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800516}
-
Karel Král authored
Create a tool to enable developers to annotate large amount of code with tracing. This is an MVP which just adds tracing of the method name. Bug: 1111787 Change-Id: I7a6fd7f51b9a3887074b1f53f005f1c0c8671a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332401 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#800515}
-
Jana Grill authored
Replace the word "device" with the actual device name in ADB sideloading notifications texts by adding a placeholder to the affected strings and replacing it with the corresponding device type when displaying the notifications. Bug: 1115444 Change-Id: I6aadf09594bbf19a31dc62a2aab81d855f81fcab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367041Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#800514}
-
Maggie Cai authored
This CL extends the app-service-intent-handling flag to 87 because it was just turned on by default for one milestone. BUG=853604 Change-Id: I6838130f223d1487610d193f9257635bcdaf009e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367426Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800513}
-
dizg authored
This is the client side implementation of go/gaiafe-dice-fallback. The Gaia server will send parameter no_authorization_code in the Dice header, when there is a OAuth outage. When this happens and the feature kSupportOAuthOutageInDice is enabled, Chrome disable the reconcilor temporarily, so that the user can stay signed in on the web. After some time, the reconcilor is restarted, and at this point the user is signed out, and will need to sign in again. Also added unit tests. Bug: 1115247 Change-Id: Ib71f55f26f50c185175a1abeec58edd4d7d72605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362757Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Diana Zagidullina <dizg@google.com> Cr-Commit-Position: refs/heads/master@{#800512}
-
Maggie Cai authored
This reverts commit 2576e02f. Reason for revert: This CL is likely the cause of the build failure for test external/wpt/webdriver/tests/release_actions/sequence.py>>test_no_release_mouse_sequence_keeps_dblclick_state, in buildes first occurs in: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/91045 and https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/14964 Original change's description: > [ChromeDriver] Support triple click in Chromedriver PerformActions > > When we are using PerformActions from ChromeDriver to simulate three > mouse click, it only set the click count to 2, not 3, so this test fails > third_party/blink/web_tests/external/wpt/webdriver/tests/perform_actions > /pointer_tripleclick.py. > > PerformActions should keep the mouse click count and decide if we should > increase the count or set to 1 when we have a mouse press based on the > interval of two mouse presses and difference between the current mouse > positions and the last one. > > Bug: 1119679 > Change-Id: I2b941c5d295cdd457109c8866c55e02bb2360555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366655 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800201} TBR=lanwei@chromium.org,johnchen@chromium.org Change-Id: Ie57866e4aef6ac88eca708a05459032c1fee2128 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368620Reviewed-by:
-
Frédéric Wang authored
Bug: None Change-Id: I4162ef32a633124905a9ee8e1713d42c044c3654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366798Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#800510}
-
Olga Sharonova authored
Change-Id: I00bb410f08027040b1adc7a7d7f5ebe33314fe97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228536Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#800509}
-
Tsuyoshi Horo authored
Bug: 1120246 Change-Id: Ib7b2f8d6196e64d7f7a740c8382686d9e7dc59ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367260 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#800508}
-
Maggie Cai authored
This reverts commit 81e8107c. Reason for revert: This CL is likely the cause for the build failure with test PrintBackendCupsHelperTest.TestPpdParsingResolutionNoResolution since https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/25158 Original change's description: > Add Linux support for printer resolutions > > Add Linux support for PPD resolution options. > > Test: ./printing_unittests > Change-Id: I15d2245567e37938633c72daa2edc66cfa6f4b22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360472 > Commit-Queue: Pranav Batra <batrapranav@chromium.org> > Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800424} TBR=thestig@chromium.org,dhoss@chromium.org,batrapranav@chromium.org Change-Id: I77598a213e4af7ff5a47ba815350ba907ea4631a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368656Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/87a7605160fd..bfb423d26610 2020-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I1de169ff791d933e41d3be82b031c825cc569e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368110Reviewed-by:
-
Aleks Totic authored
Legacy tables code does two style adjustments that need to be modified for TablesNG. 1) Legacy cannot handle position:relative/fixed on Section/Rows, but TablesNG can. In Legacy, style used to be modified in style_adjuster.cc:AdjustStyleForDisplay AdjustStyleForDisplay does not know if style is layout object is legacy, or ng. Therefore, style adjustment cannot be done here. The adjustment code was moved to LayoutObjectFactory, which knows type of object being created. 2) Legacy cells cannot handle orthogonal writing modes. Cell writing mode is reset to parent's writing mode. This one was tricky, because neither AdjustStyleForDisplay, nor LayoutObject factory have data needed to modify the style. AdjustStyleForDisplay does not know if layout object is legacy or ng. LayoutObjectFactory does not have parent's writing mode. One option is to plumb parent's style to LayoutObjectFactory. There is a lot of layers here, and feels like an unnecessary complexity just to support temporary table weirdness. My solution was to modify cell's style in LayoutTableRow::AddChild. It is hacky, but I believe it is safe. Bug: 958381 Change-Id: I77dd9c7a253282d0f8647c9add0b5c1fc908d8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356849 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#800505}
-
Martin Robinson authored
I no longer need this particular watchlist and I am the only participant. Change-Id: Ic34c9d7dc234cbdfd488dc72b86a770094ce1df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328969Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#800504}
-
Will Cassella authored
This is a reland of cb9cdc66 Original change's description: > Give blink::CueTimeline a timer for precisely handling cue events > > Cue-related events (enter, exit, cuechange) are fired up to 250ms late, > and there is a similar latency in their display which is quite > noticeable. > > The underlying problem is that we only update cues alongside the > `timeupdate` event, which is fixed at 4 Hz. > > My solution is to add a separate timer to CueTimeline > (`CueTimeline::cue_event_timer_`) which is given a timeout for the > next cue event based on the current playback position and rate. This > allows for significantly more precise cue timing accuracy without a > significant performance penalty. > > Additionally, several web tests were written with the expectation that > the 'time marches on' algorithm is run before video playback begins > (ie, upon loading text track cues). This behavior is not in accordance > with the spec (as outlined in crbug/1050767), so this CL fixes those > expectations and adds a new test to prevent regressing. > > Bug: 576310, 1050767 > Change-Id: I675f5f030a68ba9cee10e12b3e79a9b174048193 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008079 > Commit-Queue: Will Cassella <cassew@google.com> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#800148} Bug: 576310 Bug: 1050767 Change-Id: I735f5344005798b8d1543e020ba3920c9d2134dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368079 Auto-Submit: Will Cassella <cassew@google.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#800503}
-
Jacobo Aragunde Pérez authored
AT-SPI sets up a number of ATK event listeners. If Chromium emits events too early, they won't be detected by AT-SPI. The initialization of AT-SPI listeners happens at spi_atk_register_event_listeners in the at-spi2-atk library. It also sets up a key event listener, which is registered by Chromium at AtkUtilAuraLinuxAddKeyEventListener. We use the registration of the key event listener as an indication of AT-SPI being ready, due to our internal knowledge of the internals of the AT-SPI/ATK bridge. If there are no key event listeners, we consider AT-SPI is not ready, so window activated events are queued. As soon as a key event listener is registered, events will be run and never queued again. A window deactivated event would cancel the queued activated event. Bug: 1062755 Change-Id: I2d1a1516bed2b8437df664d69399b72af02eb4a8 AX-Relnotes: Linux: send Chromium's first window activation event. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312818Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#800502}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/27bbbaa9714f..97ff660720cd 2020-08-21 paulirish@chromium.org update .npmignore for "third_party" 2020-08-21 alexrudenko@chromium.org Fix suggest color for certain color combinations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf1a2591fc535ada8d43c6d9e07d4c54592b3367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368108Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
- Fix spelling typo - Add missing final - Complete type in generic classes - Remove redundant type info There should be no functional changes. Bug: None Change-Id: Ia07950f3858e1f4b0f4e1c7d17c35187edc1940b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363877 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800500}
-
Yoshifumi Inoue authored
This patch changes |NGLineBreaker| not to clear |LayoutObject:: NeedsLayout()| when it is called from |ComputeMinMaxSizes()|. Background: The issue was caused by finding |NGInlineItem| from previous |NGFragmentItem| because of |NGFragmenItems:: TryReuseFragmentsFromCache()| failed to make dirty for |LayoutText| because of |ComputeMinMaxSizes()| clears |NeedsLayout()| flag before actual layout. Bug: 1116713 Change-Id: Ia3b08ae7295ccf62bbe38a1ed8d3cd6f6209faa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367259 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800499}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5e8b16af30f4ca8d13f9a17a7522c0c7be53c14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368814Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7f343135480a..7a2e3f83964f 2020-08-21 jleconte@google.com WebRtcTest quest needs a longer execution timeout. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024246 Tbr: eseckler@google.com Change-Id: I890eabaf50920f623819d8536b0ce31923dc2e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368812Reviewed-by:
-
