- 22 Jan, 2021 40 commits
-
-
Joel Hockey authored
The FileSystemURL from ConvertPathInsideVMToFileSystemURL will be used with the clipboard to copy and paste files between VMs and FilesApp. It needs to be valid with the real FilesApp Origin in order for this to work. Bug: b/162602338 Change-Id: I3ac2961e762dd26104b5f2461997b3175a5f7367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643737 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#845950}
-
Ye Kuang authored
Bug: 1141780 Change-Id: I2c3dc3a97b6c6a3ba70744e4b38475144b406897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639435 Commit-Queue: Ye Kuang <yekuang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#845949}
-
Yoshifumi Inoue authored
This reverts commit 8e907715. Reason for revert: Build failed on mac-arm64-rel bot. https://ci.chromium.org/p/chromium/builders/ci/mac-arm64-rel/3537 ../../third_party/swiftshader/third_party/marl/include/marl/pool.h:236:27: error: aligned deallocation function of type 'void (void *, std::align_val_t) noexcept' is only available on macOS 10.14 or newer MARL_NO_EXPORT inline ~Storage(); ^ Original change's description: > Roll SwiftShader from 1d5174b9dc3b to 5b36fbc5ed2b (3 revisions) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/1d5174b9dc3b..5b36fbc5ed2b > > 2021-01-21 capn@google.com Target macOS 10.12 when building LLVM > 2021-01-21 capn@google.com Use aligned allocation for classes with aligned members > 2021-01-21 nicolascapens@google.com Enable and require C++17 compilation > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: I986f61efb56c3c3ca18b0100ae6ca3dfee2fed7b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643117 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#845830} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I318bd80475234a7b9b7b5ef3d61602182f2f6dc8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644401Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845948}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I66bf05e42815ba0bd51b0769b784a2aefe2f9570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643169Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845947}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ife65dd1f215e0bb5afaa22ef0763644f8acc2c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644002Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845946}
-
Austin Tankiang authored
This is part of the plumbing to allow DriveFS to display confirmation dialogs in Files App. Now, when DriveFS calls into Chrome to display a dialog, this called is plumbed via DriveFsEventRouter to the Files UI as a fileManagerPrivate API event. This also exposes an interface, notifyDriveDialogResult, for the UI to send the result of the dialog back to DriveFS. Bug: 1166058 Change-Id: I25d1bc97eafb38e140cd20af152b53929550eb47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637124 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#845945}
-
Joel Hockey authored
Refactor only change. Refactor GetFilenames to return internal FileInfo struct which includes FilePath and FileSystemURL so that it can be reused by CreateClipboardFilenamesPickle in crrev.com/c/2638967. By keeping the FileSystemURL in addition to the FilePath, it saves duplicating the code to crack the URL from the path. Bug: b/162602338 Change-Id: I91356840303bc6f15e11fcf43cad75c06e29fe7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643736 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
dpapad authored
- Delete testOpenCloseBookmarks() test case in basic_test.js (bookmarks no longer shown in a popup). - Make testToolbarDropdownShowHide() test case only run on CrOS in material_elements_test.js, since viewer-toolbar-dropdown will only be included on CrOS as a dependency of viewer-annotations-bar. - Remove references to the "pdf-viewer-update-enabled" HTML attribute. Bug: 1164004 Change-Id: Ic88fad7d01266a007005a18d37e4f3d3c39fb04e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642128 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#845943}
-
Nancy Wang authored
This is the follow up for CL:2624273. Move icon_standardizer* from c/b/ui/app_list to c/b/apps to prevent spaghetti code. BUG=1083331 Change-Id: I16d983966a6100786c539cfc20e2a708fb055373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636897 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#845942}
-
Hidehiko Abe authored
In order to make crosapi more isolated from actual ash/lacros implementations, this CL renames AshChromeService and its corresponding variables to Crosapi. Also, AshChromeServiceImpl is renamed to CrosapiAsh, following the common naming convention in Chrome that it is the crosapi implementation in Ash. BUG=1148448 TEST=Launch lacros on a device. Change-Id: I600188445949a4de60325f5419f137f61360d0e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640523 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#845941}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37d16f135265..c09761f57605 2021-01-21 jmbetancourt@google.com [SkottieView] handle calls to setSource after first animation initialization 2021-01-21 brianosman@google.com Update particle system to use skvm, rather than ByteCode 2021-01-21 johnstiles@google.com Remove unnecessary _out pointer in Metal. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: If4e59cab861b232ceb73636052aa8fd5ec5ff7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644001Reviewed-by:
-
Varun Khaneja authored
Fixed: 1140100 Change-Id: I7652027e47f71321002875eb511db5af666697ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591709 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#845939}
-
Timothy Loh authored
- Add missing enum values from plugin_vm_installer.h and plugin_vm_metrics_util.h - Fix PluginVm.DlcUseResult to use enum= instead of units= Change-Id: I81fb268cb31e1be63310dd1ad25906cfbfcdbc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640315 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#845938}
-
Lukasz Anforowicz authored
Extension operating in "split mode" has a separate background page for the regular profile VS the incognito profile. This CL adds a test that shows that currently (unexpectedly / undesirably) an ActiveTab permission granted to an origin in an *incognito* tab will not only affect CORS permissions in an incognito background page, but may also affect CORS permissions granted to the an extension background page of the *regular* profile. Bug: 1167262 Change-Id: Ica6f27efc989a0171819fef7211dc1190c9647d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633783Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#845937}
-
Ye Kuang authored
I will use this in https://crrev.com/c/2639435. Bug: 1141780 Change-Id: I4dc8b43cd364e7c3aaee74d2184736a15b26270c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642643Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7c153a21c203..be163e76ce9c 2021-01-22 annabelzhou@google.com Basic rendering and click handler unit tests for AccessibilityNode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:887173 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16695189f14875dbef08142f039daf31742c15be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644278 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Andrey Kosyakov authored
This reverts commit dabacbb8. Reason for revert: broke downstream CDP tests again (please see crbug.com/1164610 for details) Original change's description: > Reland "Cleanup for LayoutView overflow clips" > > This reverts commit 17de3187. > > Reason for revert: the root cause of crbug.com/1164610 has been fixed > by https://chromium-review.googlesource.com/c/chromium/src/+/2636883. > > This is a clean reland of the original CL. > > Original change's description: > > Revert "Cleanup for LayoutView overflow clips" > > > > This reverts commit 49dd6b58. > > > > Reason for revert: The scale of the devtool override frame size seems > > incorrect, causing crbug.com/1164610. > > > > Original change's description: > > > Cleanup for LayoutView overflow clips > > > > > > 1. Move the code checking requirement of overflow clip for printing > > > from PaintPropertyTreeBuilder into LocalFrame::ClipsContent(). > > > > > > 2. Combine LocalFrameView::ClipPaintRect() into > > > LayoutView::ViewRect(), so that all code paths calling ViewRect() > > > (e.g. LayoutView::OverflowClipRect()) can be dev tool viewport > > > overriding aware. This means that the overriding viewport is > > > reflected in the paint property tree, and > > > CompositedLayerMapping::RecomputeInterestRect() no longer needs to > > > apply the viewport clip separately. > > > > > > Change-Id: Ib743a891e4d4fc0749ff799a04ed0f09757e9f5b > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613388 > > > Reviewed-by: Stefan Zager <szager@chromium.org> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#841701} > > > > Bug: 1164610 > > > > TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Change-Id: I18249c79339935b381ae3a05984d5f139d5194a7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622514 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Stefan Zager <szager@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Stefan Zager <szager@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#842140} > > # Not skipping CQ checks because original CL landed > 1 day ago. > > TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com > > Bug: 1164610 > Change-Id: I38bd98f55387ac85e441ab3cfa4dc7a310e1c9e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628315 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845804} TBR=szager@chromium.org,wangxianzhu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6f95c387914a55e7588bc881378327d4567e050d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1164610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644496Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845934}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6031b74664d0..e4fd1ba31989 2021-01-21 danilchap@webrtc.org Delete mutable rtc::CopyOnWriteBuffer::data If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9613ce0845b162ca281c45d88c0e77f8c861705e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643460Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ibe85c253a84f75e9a9c393ca159a92dcaadf3dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644280Reviewed-by:
-
John Delaney authored
Removes instances of master/slave. Bug: 1169441 Change-Id: I3f937efb0c1a4f49d31514c0c5db5e8e0037d146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643630 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#845931}
-
Giovanni Ortuño Urquidi authored
Manifest install was replaced by WebApplicationInfo install. This CL removes all the macros to parameterize tests and run them with both install paths. Two of the three remaining macros use a single argument, so we could replace them with a two classes than tests inherit from. We don't do that in this CL to keep the size reasonable. Bug: 1158686 Change-Id: Id59984d48e462011c5c179601b0a8cc002f3f19c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637096Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#845930}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/79b1b0af2eb9..dc8ef8034344 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3b32d48a2a6ac957f5795b79761cbd6735c99a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642834Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/beb8370c49f2..957dfeae2968 2021-01-21 smaier@chromium.org Timeout for ADB commands increased If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1168280 Tbr: wenbinzhang@google.com Change-Id: Ib3bbf0d6bb3801afcf11efc3c1bafe3201e008c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643458Reviewed-by:
-
Chris Thompson authored
Bumps the expiration for the Security.SecurityLevel.DownloadStarted, Security.SecurityLevel.FormSubmission, and Security.PageInfo.TimeOpen metrics for another six months. Fixed: 1160748,1160749,1160769,1160773,1160774,1160775,1160776,1160777,1160778 Change-Id: If251de68098a0009b710dc941540e8b4657ad897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644069 Commit-Queue: Chris Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Chris Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845927}
-
Zach Trudo authored
Bug: b:159750481 Change-Id: Ie159965cb3911fd6c4effeb601f98af7ab517114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616321 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#845926}
-
Ian Kilpatrick authored
This is only truly correct for parallel min/max content contributions which are inside indefinite track(s). Things which are wrong: - parallel min/max content contributions need to use the correct percentage resolution sizes. - orthogonal min/max content contributions need to determine the available/percentages sizes based on base/used row/column tracks (if available). - minimum contributions are all wrong. Bug: 1045599 Change-Id: I196efc81dbb44077217135aa59619567120da761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630626Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#845925}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b349f3ea9c0..dc8ef8034344 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iefa9d674d4d9c71114e3370e944b583ad9334d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643484Reviewed-by:
-
Findit authored
This reverts commit bdb876e8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 845919 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JkYjg3NmU4ZThmZmFiMmU1MGMyMDZiODUxYjA5M2NlMWVkZmU1MDkM Sample Failed Build: https://ci.chromium.org/b/8857436794807907248 Sample Failed Step: compile Original change's description: > PDF Viewer: Make toolbar manager support zoom toolbar only > > No more need to manage a top toolbar, so support only a zoom toolbar > in the toolbar manager. > > Also move toolbar manager to Print Preview build only, and move the > corresponding test to c/t/d/webui/print_preview/ > > To avoid needing to read isPrintPreview in the simplified toolbar > manager, also remove isPrintPreview property from the zoom toolbar and > related styles. > > Bug: 1164004 > Change-Id: Ifccb1481af314dcef7054fde189be2a6769a006f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641805 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845919} Change-Id: I2f980c53ae368c31df4bfa25241b1a44ac657fb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1164004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643108 Cr-Commit-Position: refs/heads/master@{#845923}
-
Katie Dillon authored
This CL is a follow-up to this CL[1]. It adds some methods to MainThreadTaskQueue such that anywhere where we need to pass a pointer to the task queue when doing thorottling logic happens on the MainThreadTaskQueue. This change moves us towards removing access to the raw pointer to the task queue outside of MainThreadTaskQueue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2453591 Bug: 1143007 Change-Id: Ie5f1ace08cc3329a89e5784010cc936d00832499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521443 Commit-Queue: Katie Dillon <kdillon@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845922}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/07a24ad5b02e..212d6814bec1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yosin@google.com,hesen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1150968,chromium:1155587,chromium:1164189,chromium:1166878 Tbr: yosin@google.com,hesen@google.com Change-Id: Icc0c6b711e7508d2683423e8e541db0b7330ecce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644279Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845921}
-
Tommy Steimel authored
This CL refactors the System Media Controls to use the product name from media::AudioManager::GetGlobalAppName() instead of inferring the product name from branding buildflags. Bug: 942114 Change-Id: Idd1c77ae90b7a89d676e391f83623ab8c4d33a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607504 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#845920}
-
rbpotter authored
No more need to manage a top toolbar, so support only a zoom toolbar in the toolbar manager. Also move toolbar manager to Print Preview build only, and move the corresponding test to c/t/d/webui/print_preview/ To avoid needing to read isPrintPreview in the simplified toolbar manager, also remove isPrintPreview property from the zoom toolbar and related styles. Bug: 1164004 Change-Id: Ifccb1481af314dcef7054fde189be2a6769a006f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641805 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845919}
-
Sophie Chang authored
Bug: 1146151 Change-Id: I551d3ca08377836d6354fc6034b7938f6ac9408c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643222 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#845918}
-
James Vecore authored
This change points Nearby to the Phone_Hub_M89_V2 branch which has the following cherry picked cls: cl/351271597 cl/351272707 - slightly modified to not have the timeout Bug: 1163991 Change-Id: I95b0ab091e3dbe63f73fa582b1d5bedc5dddbbc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628082 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#845917}
-
Xing Liu authored
Keep both read/unread section header in reading list UI when there is only 1 reading list item. Also add a 15dp padding between. Bug: 1166394 Change-Id: Iac54ed461c0610045427825ac1b888cfd041239c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628447 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#845916}
-
Alex Newcomer authored
Update the enum 3 to have a human readable label. Bug: 1164526 Change-Id: Ic716ceff4128c4778f61e98eb70d46d837288bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643414 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845915}
-
Hui Yingst authored
Currently PDFiumEngine::GetNamedDestination() uses the public API FPDFDest_GetView() to get a named destination's view, which outputs 0 if a parameter is null. However, for the x and y coordinates from an XYZ named destination, 0 is a valid input while null should be treated as an empty input. This CL adds a string `xyz_params` in PDFEngine::NamedDestination so that null parameters can be passed to the viewport and get treated differently from 0 for x and y coordinates. Bug: 1157061, 1163701 Change-Id: I81a5a7c4b9c895263e580473a68a070e8b7965dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634130 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#845914}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bba017b4..12aab80c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia83fcb38db85e4d08fc742ded7077b9cd69b2571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643221Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845913}
-
Joel Hockey authored
Ensure URL starts with 'file://', not just 'file:'. Disallow invalid URLs such as file:path or file:/path. When testing clipboard file copy, I noticed some linux apps that send '/path' rather than 'file:///path'. Originally I planned to relax checking in order to support this invalid format, but I changed my mind when I saw that it also sends corrupted values for the path which makes me think that it is just plain buggy. I now prefer to be strict. Using std::string for URL rather than StringPiece since we only deal with UTF8 input. Bug: b/162602338 Change-Id: I12c90adcb4b295219b570ca470fd6631942321a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642660 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d600abac. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I8100542494356e0437adbc7e818ed7a9f635f6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644216Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845911}
-
