GitLab

Ping does not have a particular success URL -
it just redirects back to the "returnurl" on success.

We can detect this if we listen for a POSTed request
to the password change URL, and then for a response that
redirects us to the returnurl, and not back to the
password change URL again.

This involves listening for redirects, not just URLs -
since visiting the returnurl normally would not mean
success.

I have modified all such success detection attempts to
listen for redirects - even when we have a success URL
to listen for eg "?status=0" - it is a bit more certain
to listen for a redirect *from* the password change URL
*to* the success URL, instead of just listening for a
visit to the success URL by itself.

Bug: 930109
Change-Id: Idfd081a603ca402367de774f6253e4af9b84bbdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878489Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711235}

Sync paused:
- Show text "Not signed in" instead of email
- Remove "Manage your Google Account" button

Signin or sync disallowed:
- Remove sync info section

Bug: 1020146
Change-Id: I853d52f3e586a74414b7e368e4cb73f9e617b172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893277Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711234}

The root cause here was that the UIImage returned from the
qr_scanner_app_interface was nil on iOS 12, even though it was non-nil
in iOS 13. I'm not sure why this happened.

In the end, just passing the icon's accessibility label worked and is
probably better for the test, so I switched to that.

I could reproduce the failure, and the tests now pass locally, so
it should be fixed.

TBR=eugenebut@chromium.org

Bug: 1019211
Change-Id: I70e63d5143b8fd7f02ca4b0f62f845196590f282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893253
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711233}

https://chromium.googlesource.com/devtools/devtools-frontend/+log/c7284e19a2..736b04307a

TBR=aerotwist@chromium.org

Change-Id: I2cbca164dd59c9a361b708094dd0261cb98147d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893153Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711232}

DevTools will soon support block coverage again, and this
metric tracks how often it gets used.

Bug: chromium:1004203
Change-Id: I002d48361d5c8b5a130b3d444f89e8b7edae3d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891295Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711231}

ScopedTempDirs must outlive anything that holds file(s) open within
them; otherwise, they are unable to delete their backing directories.

BUG=546640


Change-Id: I9a47962d2f4fae44da1882d25383af6b6b3839a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893274
Auto-Submit: Greg Thompson <grt@chromium.org>
Commit-Queue: Tommi <tommi@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711230}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26f97a5e96ce..8cd154b2c0ca


Created with:
  gclient setdep -r src-internal@8cd154b2c0ca

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ie3477f364b9708720e6e681a78da87f9110dfc28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893173Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711229}

Request and Response's formData() urlencoded parsing uses "UTF-8 decode
without BOM" which should not strip BOMs.

Bug: 796192
Change-Id: I76491af9a3331268d28375169d2c22dd31b7a4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669298
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711228}

This patch changes |NGOutlineUtils::ShouldPaintOutline| to
support FragmentItem. This fix is needed to compute ink
overflow (WIP crrev.com/c/1771360).

This patch also discovered a bug in |NGInlineCursor| where
|MoveTo(const LayoutObject&)| does not work if the root is
not given, when FragmentItem is enabled. This patch adds a
test for the case and fix this.

This patch fixes ~260 tests and regresses ~80. The ~80 used
to pass accidentally, revealing these failures is a progress.
I will update FlagExpectations separately to avoid conflict
as the change is large.

Bug: 982194
Change-Id: Ia4cf6b15624c0ef73bb90c76a57ef326d19c5d26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890374Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711227}

https://webrtc.googlesource.com/src.git/+log/32913c128aec..de365955dc6a

git log 32913c128aec..de365955dc6a --date=short --no-merges --format='%ad %ae %s'
2019-10-31 yura.yaroshevich@gmail.com Added new Apple devices.

Created with:
  gclient setdep -r src/third_party/webrtc@de365955dc6a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I57a5b66b65895c0e1ecafd8fa1ddc507bf30de0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893171Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711226}

The fixes to the Rec.601 and Rec.709 matrices affect a handful
of layout tests.

See also: https://skia-review.googlesource.com/c/skia/+/251771/

Bug: skia:9543
Change-Id: Ia6ffa7742e945348bc7af68d6c2214fd66a50a96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890956
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#711225}

CSP: Allow port upgrade when the both expression's scheme and port is 'http' and '443' when the scheme is upgradable

<meta http-equiv="Content-Security-Policy" content="script-src 'unsafe-inline' http://example.com:443;">
<script src="https://example.com"></script>

In the above example, the source should be allowed because the URL is matched to the CSP expression because all the rules are satisfied including the port-part matching rule.

See https://www.w3.org/TR/CSP3/ section 6.6.2.6. "Does url match expression in origin with redirect count?" and 6.6.2.9 "port-part matching".

Chromium's current CSP implementation blocks the source because scheme-part matching function returns 'kMatchingUpgrade' but port-part matching function returns 'kMatchingExact' not 'kMatchingUpgrade'.

This fix the port-part matching function to return 'kMatchingUpgrade' where both expression's scheme and port is equal to "http" and "443" when the scheme is upgradable(http->https).

Bug: 892084
TEST: build and run blink_unittests
Change-Id: Ic611b6b1e298a9c4f0457ba4a474475ae0b66250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890451Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711224}

Using wpt-import in Chromium 43ca4361.
With Chromium commits locally applied on WPT:
1d5b803f "Add WebVTT support for inline styling - Web Platform Tests"
f701be68 "[css-pseudo] Restrict the properties allowed in ::marker"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: I6f709f11246eba8e16d1528dcb8dba5b4863ac65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892913Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711223}

TBR=sadrul@chromium.org

Bug: 1020136
Change-Id: I978673a0da380eac20df2dea2fa8361b48341d9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893154Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711222}

This reverts commit 65bc021c.

Reason for revert: This is breaking Mac too (https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/44138)

Original change's description:
> Reland "WebApp: Check pixel at the center of the generated icon."
> 
> This is a reland of 5a0adcbe
> 
> Let's exclude Win platform for now. This is a useful finding which
> requires investigation.
> 
> Original change's description:
> > WebApp: Check pixel at the center of the generated icon.
> >
> > We generate an icon placeholder using a letter with some solid
> > background color.
> >
> > Let the test check if letter_color is actually presented in the icon.
> >
> > This is a follow up test enhancement for the previous CL:
> > https://chromium-review.googlesource.com/c/chromium/src/+/1888234
> >
> > Bug: 1019102
> > Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816
> > Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> > Reviewed-by: Alan Cutter <alancutter@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#711143}
> 
> Bug: 1019102
> Change-Id: I2d01c2a9f5eb94107a4dfc4fea041bdb18871fc3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892651
> Commit-Queue: Alexey Baskakov <loyso@chromium.org>
> Reviewed-by: Alan Cutter <alancutter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#711164}

TBR=alancutter@chromium.org,loyso@chromium.org

Change-Id: I99a31ce879eed7ef5e79d6e1a68e119ff2e8f153
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1019102
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893275Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711221}

Unittests are added for incognito poolsize, when dynamic quota feature
is enabled or disabled.

Bug: 1017120
Change-Id: Ib0ef8528cc4550c1556645d39312451b0fa3a58b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890055
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711220}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I70427b411668bc2fff803983f74199c4291e7bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892677Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711219}

Moves default Crostini configuration steps from CrostiniManager to
AnsibleManagementService. Introduces test helper class so that
crostini_manager_unittest.cc and ansible_management_service_unittest
don't duplicate code.

--gtest_filter="Ansible*" && manually via deploying Chrome to DUT

Test: unit_tests --gtest_filter="Crostini*" and unit_tests
Bug: 998124
Change-Id: Ie7b1d185fe556a416abde5cb0e3979d0b4adc010
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884851Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org>
Commit-Queue: Olya Kalitova <okalitova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711218}

Using libxml directly in the browser process is strongly discouraged.

Bug: 699306
Change-Id: I82a976bfa578cc89e855079aadcfed95abdffe95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890819Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711217}

During sheriffing I have attempted to determine the reason for failing for two
tests in SafetyTipPageInfoBubbleViewBrowserTest but did not manage. I am
hence disabling for later further investigation.

TBR=estark@chromium.org

Bug: 1020109
Change-Id: I78419a0101cfbcad04f9b4c09553de6ea442c18c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891175Reviewed-by: Armando Miraglia <armax@chromium.org>
Commit-Queue: Armando Miraglia <armax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711216}

This CL moves all but one header from t_p/blink/public/web/modules/peerconnection
to t_p/blink/renderer/modules/peerconnection.

The only remaining one is peer_connection_dependency_factory.h that
is still being included from
content/renderer/renderer_blink_platform_impl.cc

BUG=787254, 919392
R=guidou@chromium.org, haraken@chromium.org

Change-Id: Ia21ecc977363fd03734e63a809cba3187279c633
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876488Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#711215}

Bug: 1014899
Change-Id: Ib93a32e91b1fb6fb4dff5e3501e8289dc9271a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868872
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711214}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/185ae4c0..ac12db7d

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib8721109747d4d83c1da36e07cb2a78f3684627d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892831Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711213}

https://chromium.googlesource.com/angle/angle.git/+log/6946043676e7..133be10311f8

git log 6946043676e7..133be10311f8 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader e1cda3916cee..fda994c63075 (2 commits)

Created with:
  gclient setdep -r src/third_party/angle@133be10311f8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@google.com

Bug: chromium:None
Change-Id: If2f9d9c874323c237764e244c70dec87009f1e1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892757Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711212}

With this CL, credentials in the autofill dropdown will have an
additional, right-aligned G logo if they originate from the account
store.
Screenshots are in the linked bug.
The order of suggestions and the signed-out/no-flags experience are
untouched.

Bug: 1018699, 1018700
Change-Id: I84894614665ea18546f9c686f5dad477d418b59e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881562
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711211}

This reverts commit 2de3b7e6.

Reason for revert: root cause should be fixed by CL:1868769

Original change's description:
> Disable flaky AssistantOptInFlowTest.WAADisabledByPolicy
> 
> TBR=updowndota
> 
> Bug: 1013824
> Change-Id: Ibbeb425fe2511f0dadaa93bb4dd3cbfde476877b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857130
> Reviewed-by: David Roger <droger@chromium.org>
> Commit-Queue: David Roger <droger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#705491}

TBR=droger@chromium.org,updowndota@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1013824
Change-Id: I0cd2c2b8119876ff2ed7b1866236783611b65a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892593Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711210}

Calling IsGlobalEmpty on a worklist while there are cocurrent markers
will result in a data race. Introducing IsLocalViewEmpty to replace it.
IsLocalView checks only the local segment and the global pool (i.e.
whether the worklist is empty from the context of the current task).
It does not access segments of other tasks.

Bug: 986235
Change-Id: I94fa5026df580235630acbc59d597ece5a3f5c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890441
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711209}

Converts the keyboard_commands_egtest for eg2 compatibility.

- Ports GetRegisteredKeyCommandsCount to an app interface method.
- Makes //net:test_support a public dep of eg_test_support+eg2, to match
  the test_support target and prevent annoying linker errors from other
  code that doesn't cleanly specify dependencies.
- Factors table view constants into a separate target so eg2 tests can
  use them safely.


Bug: 987646
Change-Id: I5c7dcaa6bd29ee1cb1aa507c5386ec92d1c93a0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889977
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711208}

Bug: 1015805
Change-Id: Ibd55ca25e03fd9ab7889fe791f714efcbef6e671
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891194Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711207}

Moving kMeanGravity constant to header file.
Fixing sign according to constant in other files using it.

Bug: 1018705
Change-Id: I08edc8cfbb12faed5d90b2395b97c8a0ea3c587b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883571Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com>
Cr-Commit-Position: refs/heads/master@{#711206}

If the node needs a LayoutObject on the next lifecycle update, we will
trigger the re-attach going from null to non-null ComputedStyle in
RecalcStyle.

Had to remove the DisallowTransitionScope because it relied on the
lifecycle state being kVisualUpdatePending, so that the dirtying below
didn't change that. However that might not be true anymore since the
SetForceReattachLayoutTree() no longer does that for null
ComputedStyle.

Bug: 972752
Change-Id: I18a192d6303faccf400beacfa008384051a6f4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886856
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711205}

As part of the ProfileInfoInterface deprecation, we remove
|SetAuthInfoOfProfileAtIndex| and |GetUserNameOfProfileAtIndex|.
Afterwards, setting the auth info and getting the username should be
done through |ProfileAttributesEntry::SetAuthInfo| and
|ProfileAttributesEntry::GetUserName|.

Change-Id: I2ccfc2260127546984f7ed4aa058b5f0cd28e9fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892773Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711204}

https://dawn.googlesource.com/dawn.git/+log/64a3bb93dcea..9ec47a0bca27

git log 64a3bb93dcea..9ec47a0bca27 --date=short --no-merges --format='%ad %ae %s'
2019-10-31 jiajie.hu@intel.com Validate texture component type in BGL against its shader module declaration

Created with:
  gclient setdep -r src/third_party/dawn@9ec47a0bca27

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: Ide00eb1c32801012658873c0dc07a9e7dbe14dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892755Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#711203}

Bug: 1018248
Change-Id: I82dc9af8d17059f014180e7e8daf08a2f0b72499
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887691Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#711202}

base::ProtectedMemory is being deprecated because it's not widely used
enough to make a security impact and justify its maintenance burden.
Replace use of base::ProtectedMemory with raw function pointers and add
an attribute to disable CFI-icall checking.

Bug: 1018834
Change-Id: Id6d956b02758aecaa0710aee56715429f5ffc267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884819
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711201}

The reasons why the back-forward cache is not used is obtained from
BackForwardCacheImpl::CanStoreDocument, and this should be the ground
truth.

Bug: 1004676
Change-Id: Ibff1eb26665dfbb29635181353657a871bb7e0b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1889890Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711200}

Both types are identical so we can merge them into one.
Leaving MarkingItem as an alias for readability.

There are a few cases where we had a TraceDescriptor which
we had to unbox to create a new MarkingItem. Making MarkingItem
and TraceDescriptor the same type avoids this.

Bug: 986235
Change-Id: Ie5e596abed358c2663ae32ac1b9e279757f57e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890436
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711199}

SyncEncryptionKeysTabHelper::EncryptionKeyApi::SetEncryptionKeys() should pass gaia_id to AddTrustedVaultDecryptionKeys()

SyncUserSettings::AddTrustedVaultDecryptionKeys() expects gaia_id as per the implementation
https://cs.chromium.org/chromium/src/components/sync/driver/sync_service_crypto.cc?l=324&rcl=6b95460e56dc3cf417134e8eb1baed68daa55a34
It should not be getting a CoreAccountId object.


Change-Id: I1e3dddd14539d256e0083c8cb59e81ffeda45d24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886827Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711198}

IIUC, the iframe content is fetched from another resource, not
written inline. Make it clear that we're presenting a
devtools-like view of the frame content.

Change-Id: I43adb622bcc03ef1d51429386f11966de0171dc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890476Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711197}

This adds no BOM decoding option to TextResourceDecoderOptions which
disabled BOM checking in the decoder.

Bug: 796192
Change-Id: Id0eb00dca451c4898d9ae00f11bf08e7fbb33a1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796366Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Cr-Commit-Position: refs/heads/master@{#711196}