GitLab

Standalone & Trichrome WebView now unconditionally includes
LauncherActivity (defined in DeveloperUiLauncherManifest), and
conditionally set the enabled state to true/false based on GN args
(webview_devui_show_icon, which is configured by android_channel).

This is a step toward resolving https://crbug.com/1047824, although this
is not a complete solution since this doesn't change the monochrome
behavior.

Fixed: 1140741
Bug: 1047824
Test: aapt dump xmltree TrichromeWebViewGoogle.apk AndroidManifest.xml | grep -A 2 'LauncherActivity'
Test: Same for TrichromeWebViewGoogleBeta, TrichromeWebViewGoogleStable, SystemWebViewGoogle, SystemWebView
Test: adb shell pm enable com.google.android.webview.debug/org.chromium.android_webview.devui.LauncherActivity
Test: adb shell pm disable com.google.android.webview.debug/org.chromium.android_webview.devui.LauncherActivity
Change-Id: Id996965643a6fea31a34ebe39fb5b2b8ac5f5c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500435Reviewed-by: Hazem Ashmawy <hazems@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822231}

Change-Id: I84ce57f72aafe561e677def149316b16e3d37f8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507258Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822230}

This CL was uploaded by git cl split.

R=peter@chromium.org

Bug: 1142671
Change-Id: Ic6195d837cd85a2b62b52d5bc27f24d59a996c1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500704
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822229}

This change is behind the kReadLater flag and allows read later items to
sync cross device. This also adds a 'Reading List' option to
chrome://settings/syncSetup/advanced on Desktop when the flag is
enabled.

Bug: 1109316
Change-Id: I676a3ffaf565095eb02b95ea1d86577c60dc652f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504271
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822228}

For context please see crbug.com/1138535#c6. This CL brings back the
code in the ModelTypeProcessor implementations to actually compute the
counts, as well as the associated plumbing. Some differences between
this and the original code however:
- Most methods are made const.
- Previously ModelTypeController::Get*() was only called when the
state was different from NOT_RUNNING and the method had a DCHECK
for its ModelTypeControllerDelegate. ProfileSyncService doesn't check
for the state now, so an TypeEntityCount with 0 values is sent in case
the delegate is null.
- ProfileSyncService used to send count notifications individually for
each data type. They are now aggregated in a single batch. Since
calls for each type are async, this requires some smartness in
PSS::GetEntityCountsForDebugging().

Bug: 1138535
Change-Id: If29f64892dd0ad63300dfd099a991b4a118dbc38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505810
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822227}

Still recording the old histogram will allow an apple-to-apple comparison
with the data from the past.

Otherwise, it will be hard to distinguish the effect of a new feature VS
the effect of changing the trigger when we compare the data of the new
histogram with the data of the old histogram.

Bug: 1141737
Change-Id: Ia5af11ed644d8be403528728782f45dbb2684538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505595Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@google.com>
Cr-Commit-Position: refs/heads/master@{#822226}

This was enabled by finch. Now enable it by default.

Bug: 949839
Change-Id: Ib0f417bacde686d43193a58c1b3a9b0cc0c6b999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506570Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822225}

ClientAndroid and RuntimeManager are both owned by web contents. When
web contents is destroyed order of destruction of these components is not
guaranteed. So we can end up in the state where pointer to
RuntimeManager is not valid anymore. So instead of sending raw pointer
to Controller, we send WeakPtr and check its validity before calling
the method.

Bug: 1140959
Change-Id: I2b618bea04cc09dcc71cb90f4d166234e8704704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503554
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#822224}

We build raster queues for both pending layers and active layers when
checking IsReadyToActivate() in issuing signals. If there is no pending
tree from the TileManageClient, we can save the CPU time by skipping
IsReadyToActivate().

Bug: 880190
Change-Id: Iac2e162ffb1d462cd3a3168cfed7c22363013537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505115Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822223}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: I63b5e2d0007a574b80046fbdb864eb6c7d328f31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507910Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#822222}

Now that R8 supports ignoring checkdiscard, we no longer have to split
files by whether or not they have checkdiscard flags.

Change-Id: I065c3b5987851471e07b3bca868f5ec52dd358df
Bug: 1143257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503633
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822221}

We will need this flag until we have completed the uprev of SKL-Y and
SKL-U Chrome OS systems to their new kernels.  It's unclear exactly when
this will be done, but my best guess right now is around M92.

BUG=b:144308685

Change-Id: I45b7b86641628184645912d4fdf3d616b6fd2c3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506301
Commit-Queue: Ross Zwisler <zwisler@google.com>
Auto-Submit: Ross Zwisler <zwisler@google.com>
Reviewed-by: David Munro <davidmunro@google.com>
Reviewed-by: Nic Hollingum <hollingum@google.com>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822220}

I noticed this while doing some other cleanup.

Bug: none
Change-Id: I6cb9ccdd85d5f0f1a935d757dd3d17e5f919e2bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506244
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822219}

Bug: 1088682
Change-Id: I7d4f647befb2e5b6a99442612e63ab7351e64522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495268
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822218}

https://dawn.googlesource.com/dawn.git/+log/a584311a6a73..af64c73c174c

2020-10-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 4dd5665502ad to c55fc39acba8 (1 revision)
2020-10-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 62bbc6f6c050 to 4dd5665502ad (1 revision)
2020-10-29 cwallez@chromium.org Fix RPDesc::occlusionQuerySet not defaulting to nullptr
2020-10-29 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from d2fa57d26dff to 62bbc6f6c050 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC rharrison@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: rharrison@google.com
Change-Id: I56d2d0803d966b8aaab92649dc38a0ed312c8dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507531Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#822217}

https://skia.googlesource.com/skia.git/+log/83c38a8fd6b1..1a364c273e28

2020-10-29 egdaniel@google.com Fix gl copyTexSubImage format requirements.
2020-10-29 nigeltao@google.com Fix s/NULL/nullptr/ in src/codec/SkWuffsCodec.cpp
2020-10-29 johnstiles@google.com Revert "Replace pooling mechanism with GrMemoryPool."
2020-10-29 nigeltao@google.com Have SkWuffsCodec speak kRGB_565_SkColorType
2020-10-29 egdaniel@google.com Remove old uma logging from Skia.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jcgregorio@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: jcgregorio@google.com
Change-Id: If98ef9d585291fa763040f477eb33a421f1d890b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507533Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#822216}

This will be used when a user selects a composite command but decides
to back out of it (backspace over the indicator chip, for example).

Bug: 1014639
Change-Id: I97178425e6f7eb26221e403c0de1ad0487439c20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505735Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822215}

Roll ChromeOS Orderfiles from 88-4296.0-1603709458-benchmark-88.0.4303.0-r1 to 88-4296.0-1603709458-benchmark-88.0.4304.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Ia687739aabee0a68f119e185599fae00ee991279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507541Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#822214}

Some files were renamed but the OWNERS file didn't get updated, this is
just restoring the property that the accessibility team is also owners
of the accessibility-related event handlers / event rewriters.

Bug: none
Change-Id: Iac759f85fc774570b61bce7adc6947f2cbb6b417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505783Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822213}

This patch fixes an issue where |NGInlineCursor| for a column
box starts returning |nullptr| for |GetLayoutBlockFlow| since
r822068 <crrev.com/c/2505354>.

This patch fixes flaky crash locally seen in:
virtual/layout_ng_block_frag/fast/multicol/layers-in-multicol.html

Bug: 1131405, 1061423
Change-Id: I1db14a39917fc97fc7a136cc9fa8df0064bdbccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507309
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822212}

SkiaRenderer (especially when we remove ES2 downgrade) changes more
state then before. This CL adds missed state tracking to
ScopedAppGLStateRestorer and AwGLSurfaceExternalStencil.

Bug: 1136975
Change-Id: I55be2bec69c18bff33a3cb18a313a93da10ba088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506116Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822211}

Bug: b:168650771
Change-Id: Iee395f07b4a2f76bcca092cbec37e036e5669e7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456313Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Piotr Pawliczek <pawliczek@chromium.org>
Reviewed-by: Brian Malcolm <bmalcolm@chromium.org>
Commit-Queue: Matt Menard <mattme@google.com>
Cr-Commit-Position: refs/heads/master@{#822210}

This is to support moving print driver interactions to the operating
system outside of the browser process.  This improves stability so that
crashes related to misbehavior with third party drivers can be contained
in a utility process instead of taking down the browser.

Start off the interface with the query to get the current default
printer.  This is a common initial first query when starting the
printing sequence.

Bug: 809738
Change-Id: I819ecf71c889494f2aa05cf150359e68f799553c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422820Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822209}

I need these constants in an upcoming lacros metrics CL, so move them
to a shared location.

Bug: 1142646
Change-Id: I09ef199bfdba9f28705974ff5e6001062824abee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506153Reviewed-by: Darin Fisher <darin@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822208}

We assume ScheduleOverlays() will be called for every frame, so we
can release not reused overlay backing for ever frame. However
ScheduleOverlays() are not called for some cases. So the DCHECK() crash
happends, fix the problem by releasing not used render pass overlay
backings in SwapBuffers().

Bug: 1135399
Change-Id: I634a254e98d086f7799d76af5d5a82ad2010f854
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507450
Commit-Queue: Peng Huang <penghuang@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822207}

TabSearchButton is-a WidgetObserver and uses a ScopedObserver to
observe its associated bubble Widget.

Currently TabSearchButton removes itself as an observer of the
Widget in the OnWidgetClosed() WidgetObserver method.

However this is not called when the operating system deletes the
window and the ScopedObserver causes a heap use-after-free error
when it goes out of scope.

This CL fixes the issue by removing itself as an observer of the
Widet in the OnWidgetDestroying() method which is always called
when the widget is deleted.

See:
https://source.chromium.org/chromium/chromium/src/+/master:ui/aura/window.cc;l=130;drc=f7600fd0b168f7c7ebefbb27a91cbefb0d090c0c

Similar usage of a ScopedObserver observing Widgets:
https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/frame/browser_view.cc;l=2572;drc=f7600fd0b168f7c7ebefbb27a91cbefb0d090c0c

Bug: 1143448
Change-Id: I7e88d5cb64800e6fb2a7c88b2233fc628e7d6d80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506561Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822206}

When generating a link to text, remove existing fragments before
appending the new one(s) to the URL.

Bug: 1143676
Change-Id: Ie49818130219aa9cf1adfc06d5b919c713c58055
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507629
Commit-Queue: sebsg <sebsg@chromium.org>
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Sebastien Lalancette <seblalancette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822205}

Restore the callee-save registers now provided in the V8 API when
unwinding. This is a necessary condition to support unwinds of
functions that use dynamic stack allocation, which is failure mode
1 in the corresponding bug.

Bug: 1122124
Change-Id: Ifb30bbdd9df343251a7c215e5a5fc140754ac216
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500453Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822204}

Bug: None
Change-Id: Ibbf4d41ff940c785b3c14965063f6258d183cedf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506183
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822203}

This reverts commit d655a4cc.

Reason for revert: KeyPermissionManagerBrowserTests broken on linux-chromeos-rel : https://bugs.chromium.org/p/chromium/issues/detail?id=1143713

Original change's description:
> KeyPermissions: Add key permissions manager
>
> This CL introduces KeyPermissionsManager (KPM). KPMs are responsible for
> managing platform keys permissions by reading and writing permissions
> into chaps keys' attributes.
>
> Bug: 1113115, 1127284, 1082459
> Change-Id: I5d242604fe784566d086d2012313f77ca0fdbc44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435386
> Commit-Queue: Omar Morsi <omorsi@google.com>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Edman Anjos <edman@chromium.org>
> Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Pavol Marko <pmarko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#822131}

TBR=stevenjb@chromium.org,battre@chromium.org,asvitkine@chromium.org,emaxx@chromium.org,pmarko@chromium.org,edman@chromium.org,omorsi@google.com

Change-Id: I1a4bf6572bdfaf56701aaa8c66e9515a85be32ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1113115
Bug: 1127284
Bug: 1082459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507465Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Omar Morsi <omorsi@google.com>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822202}

Since cl/337200290, the Nearby Share server returns both Google contacts
and device contacts in the ListContactPeople RPC response. That update
labels every contact with a Google-, device-, or unknown-contact type.
The burden is on the client to filter by type if desired.

We update the proto here, but do not make use of the new contact type
field.

Bug: 1143680
Change-Id: Icae01e5066f89debe80ea7e66bb5ebd022cae0ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507452
Auto-Submit: Josh Nohle <nohle@chromium.org>
Commit-Queue: James Vecore <vecore@google.com>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#822201}

This allows SubresourceFilterAgent::GetInheritedActivationState() to
avoid unnecessary conversions to url::Origin.

Bug: 1134740
Change-Id: I74d15db49de14d7e9b6017fb131d2976b727edc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495923Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822200}

The new setting allows admins to "force pin" an extension to the
toolbar next to the Omnibar, so it always shows the extension icon. The
user cannot unpin it.

This doesn't include any UI changes, so the "Unpin" icon in the
extensions menu is still "interactible", i.e. it will show hover
effects and a ripple for now. It doesn't actually unpin the extension
when you click on it.

PRD: http://go/cbe-extensions-menu-pinning

TEST=Set the policy to pin an extension, then installed it. Verified
     that clicking the "Unpin" button doesn't unpin the extension

Bug: 1071314
Change-Id: I24c8e542b36375e3caf18eec356c5fedc055d3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424838Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822199}

Bug: None
Change-Id: Ie1dffb756ad1c391f728abe5a55f3ce5b5d0ae4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505553Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822198}

Bug: 11297512
Change-Id: I9283feaa8578df3cfd749831e9d48c9151fe9c71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505986
Auto-Submit: Anton Bikineev <bikineev@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822197}

List of passed tests should be parsed for interrupted builds. However,
crrev/c/2473499 interpreted interrupted builds as "not started" and thus
made it not parsing the list, causing unnecessary retries.

.xcresult folder should not be used as indicator that tests didn't start
because it's created at the end of tests. output_path should serve the
purpose because it's created at the beginning of tests.

Bug: None
Change-Id: Icce037c12383e86356a6bdcc95188d22f97bc0b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505757Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822196}

This also converts the recorded enum to be a scoped enum, which allows:

- clang to enforce kMaxValue correctness
- autodeduction of the max value by UMA_HISTOGRAM_ENUMERATION.

Bug: 742517, 1047547
Change-Id: Ib8acb900fd919945e220bae7f674ea57df062c86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506245
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822195}

Bug: 1140063
Change-Id: I75ed31301df82036f1f9d6b59f642c54d3d38071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506557Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822194}

Bug: 1096986
Change-Id: Ic4d55f8b041a09db22baea5ae49a0d5c3afe78d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505753Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/master@{#822193}

Bug: 1108692
Change-Id: I475a0123987f69ab4ba749d8bf7bf775033b3ab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502612Reviewed-by: Milica Selakovic <selakovic@google.com>
Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822192}