GitLab

Review URL: https://codereview.chromium.org/432053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287464 0039d316-1c4b-4281-b951-d872f2087c98

 ToolkitDelegateViews will be moved to components/renderer_contenxt_menu in a separate CL so that athena can use it.

BUG=397320

Review URL: https://codereview.chromium.org/417063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=399362
NOTRY=true

Review URL: https://codereview.chromium.org/434403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287462 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/437313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375497

Review URL: https://codereview.chromium.org/440703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287460 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287459 0039d316-1c4b-4281-b951-d872f2087c98

Revert 287325 because it breaks smoothness benchmarks on windows: "ValueError: LatencyInfo has no begin component"

> Implement scroll handler latency tracking
> 
> Since scroll handlers do not block composited scrolling, the existing
> input latency metric will only report the response time for the
> compositor when scrolling a page with a handler. This is not accurate
> for pages that implement scroll-synchronized effects, because the
> scroll handler needs to be invoked so that the page contents are
> updated with the new scroll offset.
> 
> This patch fixes the problem by forwarding latency information from the
> impl to the main thread when we are scrolling a layer that has an active
> scroll event handler.
> 
> In the case the scroll handler is no-op, the latency information will be
> terminated as a failed commit.
> 
> Sample trace:
> https://drive.google.com/file/d/0ByyxMXB38gLDRE40bkU5TVd0U00/edit?usp=sharing
> 
> BUG=347366
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282117
> 
> Review URL: https://codereview.chromium.org/365463003

TBR=skyostil@chromium.org

Review URL: https://codereview.chromium.org/436413004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287458 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179480:179488&mode=html
TBR=pdr@chromium.org,enne@chromium.org,rjwright@chromium.org
BUG=

Review URL: https://codereview.chromium.org/433163008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287457 0039d316-1c4b-4281-b951-d872f2087c98

DnsTCPAttempt doesn't handle when read returns 0, which is EOF.
It keeps reading over and over, which will peg the CPU.

Fix it so it stops reading with ERR_CONNECTION_CLOSED,
and add unit tests for both ways the connection can close.

BUG=393923

Review URL: https://codereview.chromium.org/422323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287456 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes some minor issue on error handling: ignoring error and a bug on error handling.

BUG=none
TEST=none
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/439223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287455 0039d316-1c4b-4281-b951-d872f2087c98

TCMalloc is very slow in debug mode. Testing this out on Linux demonstrates
clear wins, so I'm hopeful Windows will similarly improve. This change mostly
copies the same configuration from ffmpeg, which unifies the setting of the
optimization level variables in target_defaults.

BUG=388949

Review URL: https://codereview.chromium.org/437163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287454 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362679

Review URL: https://codereview.chromium.org/435463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287453 0039d316-1c4b-4281-b951-d872f2087c98

The flag itself will be removed in a separate patch.

BUG=305511
TEST=manually tested
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/442613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287452 0039d316-1c4b-4281-b951-d872f2087c98

This adds translation from Annex B to AVCC format along with decoding
frames and binding them to textures.

It seems that kVTDecodeFrame_EnableTemporalProcessing is just a
suggestion to VideoToolbox, and one that it ignores. That means that,
for now, this code only outputs frames in the correct order for I-frame
only video.

BUG=133828

Review URL: https://codereview.chromium.org/397883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386033

Review URL: https://codereview.chromium.org/437113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287450 0039d316-1c4b-4281-b951-d872f2087c98

Use overlay scrollbars in athena, for both views and content.

BUG=398883
R=oshima@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/428583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287449 0039d316-1c4b-4281-b951-d872f2087c98

Before this CL, to check if the window is minimized, !IsActive() was
used. This function returns false when the bubble window is focused on
Windows or Chrome OS. Therefore, the bubble was not updated when the
bubble is already shown.

This CL fixes this bug by replacing !IsActive() with IsMinimize() to
check the state of Window properly.

BUG=393136, 389014 (the original CL about the bug around minimized window)
TEST=manual

Review URL: https://codereview.chromium.org/428583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287448 0039d316-1c4b-4281-b951-d872f2087c98

There are three main changes being made with the overall goal of
improving the smoothness of the video coming out of the tab capture
pipeline:

1. A new AnimatedContentSampler has been added that identifies which
frames were rendered due to animated content (e.g., a video or Flash
widget).  VideoCaptureOracle is then informed of exactly which subset of
frames should be captured from the compositor and provided near-perfect
frame timestamps for downstream consumers.

2. Additional plumbing in the FrameSubscriber interface to provide the
damage region of each frame.  This is used by AnimatedContentSampler.
Also, impls now provide true vsync-based presentation timestamps.

3. Raised the VideoCaptureController buffer pool count from 3 to 5.
This value is based on the logical capacity of the capture pipeline, and
not on hardware performance.  Testing revealed that more buffers are
needed to account for both multiple pipelined GPU readbacks as well as
those frames undergoing video encoding dowstream.

Testing: Tested mirroring using the usual self_mirroring.zip test
extension as well as the Google Cast extension to a Chromecast device.
Tested lock-in/out scenarios with a number of well- and ill- behaving
video playbacks.  Observed dramatic improvement in end-to-end smoothness
scores in the lab.  New unit tests to cover new code, and made sure all
relevant existing unit tests still pass.

BUG=258630

Review URL: https://codereview.chromium.org/418283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287447 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287435 0039d316-1c4b-4281-b951-d872f2087c98

Revert of sync: Add non-blocking type encryption support (https://codereview.chromium.org/423193002/)

Reason for revert:
Both LSAN and Valgrind complains about leaks in the tests.

Original issue's description:
> sync: Add non-blocking type encryption support
> 
> Introduces the framework for dealing with sync encryption in
> non-blocking types.  Unlike directory sync types, non-blocking type
> encryption only encrypts data before it is sent to the server.
> Encrypting the data on-disk is a separate problem.
> 
> Adds code to the ModelTypeSyncWorker so it can access the directory's
> cryptographer (through a CryptographerProvider interface) and use it to
> encrypt entities before it sends them to the server.  If the
> cryptographer is unable to encrypt with the desired key, the worker will
> not commit until the cryptographer returns to a good state.
> 
> Adds the concept of a "desired encryption key" to the data type state.
> When the cryptographer key to be used to encrypt a type changes, this
> will be reflected in the data type state.  The ModelTypeSyncProxy is
> responsible for ensuring that all items which have not yet been
> encrypted with this desired key are enqueued for commit.
> 
> Makes the ModelTypeSyncWorker, EntityTracker, and ModelTypeSyncProxy
> collaborate on the management of undecryptable (inapplicable) updates.
> The EntityTracker keeps track of their version numbers and content, and
> prevents the committing of new items to the server until the
> inapplicable update has been dealt with.  The ModelTypeSyncProxy is
> responsible for saving inapplicable updates across restarts.
> 
> This CL alone is not enough to enable encryption support for
> non-blocking types.  It requires additional code to hook up the
> ModelTypeSyncWorkers to receive cryptographer events.  This will be
> added in a future commit.  In the meantime, this CL includes plenty
> of unit tests to verify the functionality that's being added.
> 
> BUG=351005
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287428

TBR=zea@chromium.org,stanisc@chromium.org,rlarocque@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351005

Review URL: https://codereview.chromium.org/442623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287433 0039d316-1c4b-4281-b951-d872f2087c98

BUG=299804,400547
NOTRY=true
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/441803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=30346,30633,31985,124500
NOTRY=true
TBR=groby@chromium.org

Review URL: https://codereview.chromium.org/435323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287431 0039d316-1c4b-4281-b951-d872f2087c98

Discoved while running media_perftests on a local debug build.

Review URL: https://codereview.chromium.org/441673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287429 0039d316-1c4b-4281-b951-d872f2087c98

Introduces the framework for dealing with sync encryption in
non-blocking types.  Unlike directory sync types, non-blocking type
encryption only encrypts data before it is sent to the server.
Encrypting the data on-disk is a separate problem.

Adds code to the ModelTypeSyncWorker so it can access the directory's
cryptographer (through a CryptographerProvider interface) and use it to
encrypt entities before it sends them to the server.  If the
cryptographer is unable to encrypt with the desired key, the worker will
not commit until the cryptographer returns to a good state.

Adds the concept of a "desired encryption key" to the data type state.
When the cryptographer key to be used to encrypt a type changes, this
will be reflected in the data type state.  The ModelTypeSyncProxy is
responsible for ensuring that all items which have not yet been
encrypted with this desired key are enqueued for commit.

Makes the ModelTypeSyncWorker, EntityTracker, and ModelTypeSyncProxy
collaborate on the management of undecryptable (inapplicable) updates.
The EntityTracker keeps track of their version numbers and content, and
prevents the committing of new items to the server until the
inapplicable update has been dealt with.  The ModelTypeSyncProxy is
responsible for saving inapplicable updates across restarts.

This CL alone is not enough to enable encryption support for
non-blocking types.  It requires additional code to hook up the
ModelTypeSyncWorkers to receive cryptographer events.  This will be
added in a future commit.  In the meantime, this CL includes plenty
of unit tests to verify the functionality that's being added.

BUG=351005

Review URL: https://codereview.chromium.org/423193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287428 0039d316-1c4b-4281-b951-d872f2087c98

This is a preparation for Bug 329732. The actual fix for the bug
will come in the next separate patch.

The current changes forces GetAboutResource to wait for the result of
running UpdateAboutResource task if any.

BUG=329732

Review URL: https://codereview.chromium.org/439643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287427 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the entire account picker would reload and lose state
whenever a device-local account's policy changed. With this CL, only the
contents of the pod affected by the policy change is updated, no reload
is done and no state is lost.

BUG=398511
TEST=New browser test

Review URL: https://codereview.chromium.org/427053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287426 0039d316-1c4b-4281-b951-d872f2087c98

Supports GN build of //jingle, though its targets won't be linkable
until its dependency //third_party/libjingle is properly supported.

TBR=ajwong
BUG=

Review URL: https://codereview.chromium.org/431423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287425 0039d316-1c4b-4281-b951-d872f2087c98

When gn's desc command is used with --tree, it prints a dependency tree. But recursively printing the dependency tree of a high-level target in Chrome prints too much output to be useful because it's printing, e.g. base and it's deps over and over (//chrome/browser-s --tree is 3210166 lines).

With this patch, a target will be recursed into the first time it's printed, but subsequent times the children will be elided with "..." This brings down //chrome/browser to 2050 lines. The previous behavior is still available (it could be useful in certain cases) via "--tree --all".

This also updates an optimization comment in the the optimization setup (optimize_max isn't just Windows-only).

R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/437033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287424 0039d316-1c4b-4281-b951-d872f2087c98

This should work whether or not --google-profile-info is turned on.

BUG=399678
TEST=Flip --new-avatar-menu (but not --google-profile-info). You should
be able to choose your Gaia avatar from the manageProfile dialog.

Review URL: https://codereview.chromium.org/417043008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287423 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390911

Review URL: https://codereview.chromium.org/437613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287422 0039d316-1c4b-4281-b951-d872f2087c98

When attaching to a static page, it may not produce new frames, thus
rendering screencast useless. Forcing a frame helps in this case.

BUG=none

Review URL: https://codereview.chromium.org/441623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287421 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Partially move history_types.{cc,h} to //components/history (https://codereview.chromium.org/439713004/)

Reason for revert:
Missing OWNERS LGTM.

Original issue's description:
> Partially move history_types.{cc,h} to //components/history
> 
> Move all types from //chrome/browser/history/history_types.{cc,h} that do
> not depends on content types to //components/history.
> 
> BUG=371816
> TBR=msw@chromium.org
> TBR=jochen@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287333

TBR=msw@chromium.org,jochen@chromium.org,jhawkins@chromium.org,jif@chromium.org,brettw@chromium.org,sky@chromium.org
BUG=371816

Review URL: https://codereview.chromium.org/428253008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287420 0039d316-1c4b-4281-b951-d872f2087c98

Fix header guard and include for the whispernet_client public interface.

R=ckehoe@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/438163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78368
R=estade@chromium.org
TEST=moar emailz

Review URL: https://codereview.chromium.org/437393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287417 0039d316-1c4b-4281-b951-d872f2087c98

This ports https://codereview.chromium.org/430383002/ to gn.
Patch from brettw in https://codereview.chromium.org/385823002/ , this just
activates it.

BUG=360311
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/426533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287416 0039d316-1c4b-4281-b951-d872f2087c98

The /U__STDC_VERSION__ option was necessary when using VS2012 headers,
which didn't include nan(), but we're on 2013 now.

BUG=82385
TBR=cpu

Review URL: https://codereview.chromium.org/443453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287415 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes the previous reverted CL#437603002.
To fix, removed ExtensionRegistryObserver from TearDownOnMainThread instead of destructor.

R=kalman@chromium.org
BUG=354046
TEST=browser_tests

Review URL: https://codereview.chromium.org/429173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287414 0039d316-1c4b-4281-b951-d872f2087c98

Add a --target-arch argument to the browser finder options. This is used by the
backend to pass the correct arch to the stack symbolization script on crashes.

BUG=399896,385125

Review URL: https://codereview.chromium.org/443443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400002

Review URL: https://codereview.chromium.org/441643007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287412 0039d316-1c4b-4281-b951-d872f2087c98

It allows SSLConnectJob waiting even in the case of false start. Additionally, it groups all of the functions for communicating between SSLConnectJobs into one object, the SSLConnectJobMessenger.

R=mmenke@chromium.org,rsleevi@chromium.org,wtc@chromium.org
TBR=mek@chromium.org,asargent@chormium.org,thestig@chromium.org
BUG=398967

Review URL: https://codereview.chromium.org/353713005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287408 0039d316-1c4b-4281-b951-d872f2087c98