Commits · 6d4c4ff9cc7becb3c1075cc26dc149689c8a41f4 · eriksson monteiro / tangled

17 Dec, 2013 40 commits

michaelbai@chromium.org authored Dec 17, 2013

Using one system TLS to implement multiple chrome's TLS slots.

BUG=264406

Review URL: https://codereview.chromium.org/60743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241144 0039d316-1c4b-4281-b951-d872f2087c98

6d4c4ff9

Convert Extension* to extension id in AppLaunchParams. · 7d501ce0

koz@chromium.org authored Dec 17, 2013

Having raw Extension pointers is problematic because an extension may be
reloaded during the lifetime of AppLaunchParams, which will invalidate the
pointer.

This also converts CommandLine* to CommandLine and lets the empty command
line represent "no command line".

BUG=323220

Review URL: https://codereview.chromium.org/114263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241143 0039d316-1c4b-4281-b951-d872f2087c98

7d501ce0

Clean up empty directories after install and on errors · 2e2c529b

sorin@chromium.org authored Dec 17, 2013

BUG=327880

Review URL: https://codereview.chromium.org/113533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241142 0039d316-1c4b-4281-b951-d872f2087c98

2e2c529b

Revert 241126 "[SyncFS] Add verbose logging to SyncEngineInitial..." · a2099403

tzik@chromium.org authored Dec 17, 2013

> [SyncFS] Add verbose logging to SyncEngineInitializer
> 
> BUG=240165
> R=kinuko@chromium.org, nhiroki@chromium.org
> 
> Review URL: https://codereview.chromium.org/94003004

TBR=tzik@chromium.org

Review URL: https://codereview.chromium.org/117023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241141 0039d316-1c4b-4281-b951-d872f2087c98

a2099403

Fix a CSS to hide the cancel button for non-cancelable progress items. · 200b2f2c

hirono@chromium.org authored Dec 17, 2013

This CL fixes a CSS selector of the progress center to hide the cancel button for non-cancelable progress items.

BUG=none
TEST=manually

Review URL: https://codereview.chromium.org/105433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241140 0039d316-1c4b-4281-b951-d872f2087c98

200b2f2c

WinAura: don't create tooltip on hide · 7dc57050

cpu@chromium.org authored Dec 17, 2013

The tooltip code is executed via timers from
TooltipController::UpdateIfRequired()

Which say a browser startup with no user intervention creates the tooltip
window only for the purposes of hiding it.

This fires in Ash on Windows creating a tooltip window in the wrong
side, it is hidden but it is something we want to avoid.

BUG=none
TBR=sadrul

Review URL: https://codereview.chromium.org/103143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241139 0039d316-1c4b-4281-b951-d872f2087c98

7dc57050

testrequest is ignored. Also added wow64 attribute. · f5343ef7

sorin@chromium.org authored Dec 17, 2013

BUG=314521

Review URL: https://codereview.chromium.org/113633006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241138 0039d316-1c4b-4281-b951-d872f2087c98

f5343ef7

[rAc] Add a test to verify that enough space is reserved for the credit card icon. · 7c7f4df4

isherman@chromium.org authored Dec 17, 2013

BUG=327511
TEST=unit_tests
R=estade@chromium.org

Review URL: https://codereview.chromium.org/113533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241137 0039d316-1c4b-4281-b951-d872f2087c98

7c7f4df4

Rework how webcrypto tests are disabled for inprogress OpenSSL implementation. · f82c5b6c

eroman@chromium.org authored Dec 17, 2013

Rather than preventing compilation of the test code, mark the test as disabled.

BUG=245025

Review URL: https://codereview.chromium.org/106873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241132 0039d316-1c4b-4281-b951-d872f2087c98

f82c5b6c

Move c/c/e/extension_set to top-level extensions/ · 289c44bb

rdevlin.cronin@chromium.org authored Dec 17, 2013

Move extension_set.h/cc and extension_set_unittest to extensions/common/.
Remove unused includes.
Add includes where transitive includes were used.
Update DEPS.
No functional changes.

BUG=162530
TBR=sky@chromium.org (c/b/autocomplete, c/b/ui, c/test)
TBR=jam@chromium.org (c/b/automation)
TBR=atwilson@chromium.org (c/b/background, c/b/sync, c/b/policy)
TBR=bauerb@chromium.org (c/b/browsing_data, c/b/content_settings, c/b/managed_mode)
TBR=satorux@chromium.org (c/b/chromeos)
TBR=yurys@chromium.org (c/b/devtools)
TBR=thestig@chromium.org (c/b/media_galleries)
TBR=stevenjb@chromium.org (c/b/notifications)
TBR=battre@chromium.org (c/b/profile_resetter)
TBR=dmazzoni@chromium.org (c/b/speech)
TBR=kinuko@chromium.org (c/b/sync_file_system)
TBR=pkotwicz@chromium.org (c/b/themes)

Review URL: https://codereview.chromium.org/102103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241131 0039d316-1c4b-4281-b951-d872f2087c98

289c44bb

Polish VK show/hide animation · 3184a8e6

bshe@chromium.org authored Dec 17, 2013

This CL did:
1. add opacity animation for VK when show/hide
2. reduce animation time to 100 ms


BUG=327462

Review URL: https://codereview.chromium.org/114803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241130 0039d316-1c4b-4281-b951-d872f2087c98

3184a8e6

QUIC - minor cleanup changes found while merging chromium code into · a174d2ec

rtenneti@chromium.org authored Dec 17, 2013

internal code.

R=rch@chromium.org

Review URL: https://codereview.chromium.org/111323006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241129 0039d316-1c4b-4281-b951-d872f2087c98

a174d2ec

Cosmetic change for disk flush interval in Files.app file copying. · 1c9d3741

kinaba@chromium.org authored Dec 17, 2013

Previously, we have issued a big single flush at the end of the copy
operations. However, the progressbar UI corresponding to it for large
(> 100M) files is "quickly progress to 99%, and keep the user waiting
for dozens of seconds".) This is surely not cool.

This CL changes the behavior to run flush every 10MB progress, which
makes the progress bar to extend more uniformly.

BUG=276276
R=kinuko@chromium.org

Review URL: https://codereview.chromium.org/108323004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241128 0039d316-1c4b-4281-b951-d872f2087c98

1c9d3741

suppress memory leaks from net::NSSProfileFilterChromeOS::IsCertAllowed · 55621f53

zhaoqin@google.com authored Dec 17, 2013

TEST=waterfall
TBR=mattm@chromium.org
BUG=329104

Review URL: https://codereview.chromium.org/100823014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241127 0039d316-1c4b-4281-b951-d872f2087c98

55621f53

[SyncFS] Add verbose logging to SyncEngineInitializer · d5be04f9

tzik@chromium.org authored Dec 17, 2013

BUG=240165
R=kinuko@chromium.org, nhiroki@chromium.org

Review URL: https://codereview.chromium.org/94003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241126 0039d316-1c4b-4281-b951-d872f2087c98

d5be04f9

Revert of https://codereview.chromium.org/68713009/ · 06cb23b4

jww@chromium.org authored Dec 17, 2013

Reason for revert: Led to a URL bar display error, issue 324208.

TBR=benwells@chromium.org,creis@chromium.org,sky@chromium.org
NOTREECHECKS=true
NOTRY=true

BUG=324208

Review URL: https://codereview.chromium.org/99853005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241125 0039d316-1c4b-4281-b951-d872f2087c98

06cb23b4

Disable ability to show passwords when running in Metro. · 2ada4ed3

wfh@chromium.org authored Dec 17, 2013

BUG=326493

Review URL: https://codereview.chromium.org/107023009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241122 0039d316-1c4b-4281-b951-d872f2087c98

2ada4ed3

GetDefaultProfile fixit for Chrome OS network & power settings. · eb42b637

michaelpg@chromium.org authored Dec 17, 2013

BUG=322682

Review URL: https://codereview.chromium.org/99133022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241121 0039d316-1c4b-4281-b951-d872f2087c98

eb42b637

Allow re-enabling of DISABLE_NOT_VERIFIED extensions if appropriate · 68e5cc78

asargent@chromium.org authored Dec 17, 2013

This fixes a problem where once an extension gets disabled because the
webstore verification check fails, there was no way to re-enable it. Now
we'll re-run the verification check and if it succeeds then we can
proceed with the re-enabling.

BUG=321230
R=finnur@chromium.org

Review URL: https://codereview.chromium.org/93513006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241119 0039d316-1c4b-4281-b951-d872f2087c98

68e5cc78

Introduces a CHECK to analyze the crash reason. · 92a3e0eb

mukai@chromium.org authored Dec 17, 2013

BUG=322320
R=dewittj@chromium.org
TEST=none

Review URL: https://codereview.chromium.org/115353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241118 0039d316-1c4b-4281-b951-d872f2087c98

92a3e0eb

Disable flaky VideoCaptureDeviceTest.GetDeviceSupportedFormats in Android. · ac771152

mcasas@chromium.org authored Dec 17, 2013

To be reenabled.

BUG=327043
NOTRY=true

Review URL: https://codereview.chromium.org/116403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241117 0039d316-1c4b-4281-b951-d872f2087c98

ac771152

Remove Chrome Frame quick-enable. · 194b074f

grt@chromium.org authored Dec 17, 2013

BUG=316496
NOTRY=true

Review URL: https://codereview.chromium.org/103253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241116 0039d316-1c4b-4281-b951-d872f2087c98

194b074f

Linux sandbox: allow clock_getres() in renderers. · 4f4167c1

jln@chromium.org authored Dec 17, 2013

BUG=329053
R=jorgelo@chromium.org

Review URL: https://codereview.chromium.org/116853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241115 0039d316-1c4b-4281-b951-d872f2087c98

4f4167c1

Make sure the dragged window is smaller than work area in the target display. · 2816c246

oshima@chromium.org authored Dec 17, 2013

- makes sure that minimum amount of window is visible when dropped.

- When moving a window to another due to display disconnect, try to keep relative position in the work are, rather than absolute position to the root window.

BUG=321702
TEST=covered by test
RootWindowController::MoveWindows_Basic
DragWindowResizerTest::WindowDragWithMultiDisplays

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240542

R=mukai@chromium.org, varkha@chromium.org

Review URL: https://codereview.chromium.org/93873013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241114 0039d316-1c4b-4281-b951-d872f2087c98

2816c246

$ optimize_png_files.sh -o2 -r 232777 win8/metro_driver webkit/ · 99e8d2d2

oshima@chromium.org authored Dec 17, 2013

Processed 3 files (out of 27 files) in 00:09:01s Result : 4253 => 4244 bytes (9 bytes : 0 %)

TBR=jamesr@chromium.org, cpu@chromium.org,
BUG=313730

Review URL: https://codereview.chromium.org/116983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241113 0039d316-1c4b-4281-b951-d872f2087c98

99e8d2d2

Move common prerender_loader code into prerender_events_common.js. · ad867371

davidben@chromium.org authored Dec 17, 2013

Some of the loaders on disabled tests have bitrotted. Also use MouseEvent
constructor. It's far more readable than the old initMouseEvents.

BUG=none

Review URL: https://codereview.chromium.org/116483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241112 0039d316-1c4b-4281-b951-d872f2087c98

ad867371

Optimize png files in ui/webui · 2525aeb3

oshima@chromium.org authored Dec 17, 2013

$ optimize-png-files.sh -s -o2 -r 232777 ui/webui/
Processed 4 files (out of 58 files) in 00:15:13s
Result : 820 => 815 bytes (5 bytes : 0 %)

TBR=xiyuan@chromium.org,
BUG=313730

Review URL: https://codereview.chromium.org/111683007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241111 0039d316-1c4b-4281-b951-d872f2087c98

2525aeb3

[rAc] [OSX] Use vertically compact text to show suggestions, when it fits. · 0e1b12f2

isherman@chromium.org authored Dec 17, 2013

BUG=279563
TEST=Shorter addresses should fit on a single line; longer addresses should
     still span many lines.
R=groby@chromium.org

Review URL: https://codereview.chromium.org/115753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241110 0039d316-1c4b-4281-b951-d872f2087c98

0e1b12f2

Fix linux/gcc compiler warnings in tools/ipc_fuzzer. · 78ce8755

tsepez@chromium.org authored Dec 17, 2013

It's really sad when your ASCII art breaks the compilation, but ending
a //-style comment line with a \ means the comment continues and this is
flagged as a bad thing (tm).

The other change is a signed/unsigned comparison, which is OK because it
is range checked prior to casting.

BUG=

Review URL: https://codereview.chromium.org/115673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241109 0039d316-1c4b-4281-b951-d872f2087c98

78ce8755

Optimize png files under content · 9934a3f3

oshima@chromium.org authored Dec 17, 2013

$ optimize-png-files.sh -s -o2 -r 232777 content/

Processed 10 files (out of 25 files) in 00:12:47s
Result : 14425 => 12509 bytes (1916 bytes : 13 %)

TBR=tedchoc@chromium.org
BUG=313730

Review URL: https://codereview.chromium.org/109653008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241108 0039d316-1c4b-4281-b951-d872f2087c98

9934a3f3

[SyncFS] Add NULL check to SyncFileSystemService::DidInitializeFileSystemForDump · dba7b86c

tzik@chromium.org authored Dec 17, 2013

BUG=240165
R=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/111963006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241107 0039d316-1c4b-4281-b951-d872f2087c98

dba7b86c

Support mouse cursor in DesktopCaptureDeviceAura. · cc1cc99c

hshi@chromium.org authored Dec 17, 2013

Perform an in-place alpha blending of an ARGB cursor bitmap on a YUV420 video frame.

BUG=326000
R=oshima@chromium.org, sergeyu@chromium.org
TBR=ben@chromium.org
TEST=mouse cursor rendered correctly (position, shape and scale) during destkop sharing on Chrome OS.

Review URL: https://codereview.chromium.org/108193015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241106 0039d316-1c4b-4281-b951-d872f2087c98

cc1cc99c

drive: Split entry removal code from ChangeListProcessor::ApplyEntry · 0248ee87

hashimoto@chromium.org authored Dec 17, 2013

BUG=None
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/112713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241105 0039d316-1c4b-4281-b951-d872f2087c98

0248ee87

$ optimize-png-files.sh -s -o2 -r 232777 chrome/browser/resources chrome/renderer/resources/ · 4d1e5ae5

oshima@chromium.org authored Dec 17, 2013

Processed 21 files (out of 49 files) in 00:22:34s
Result : 255162 => 234159 bytes (21003 bytes : 8 %)

TBR=nkostylev@chromium.org,
BUG=313730

Review URL: https://codereview.chromium.org/115933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241104 0039d316-1c4b-4281-b951-d872f2087c98

4d1e5ae5

cc: Use Skia information about whether pictures have bitmaps · 2b65462d

enne@chromium.org authored Dec 17, 2013

This information allows us to early out of functions around gathering
and iterating through pixel refs.

BUG=316196

Review URL: https://codereview.chromium.org/115273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241103 0039d316-1c4b-4281-b951-d872f2087c98

2b65462d

Add support for setting OPUS header gain. · 3c6ab1df

dalecurtis@chromium.org authored Dec 17, 2013

BUG=178302
TEST=gain is correct in bug test cases.
NOTRY=true

Review URL: https://codereview.chromium.org/104873011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241102 0039d316-1c4b-4281-b951-d872f2087c98

3c6ab1df

Update .DEPS.git · 708cbb02

chrome-admin@google.com authored Dec 17, 2013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241101 0039d316-1c4b-4281-b951-d872f2087c98

708cbb02

Renamed NativeMessagingHost to Me2MeNativeMessagingHost. · 67c96ab4

weitaosu@chromium.org authored Dec 17, 2013

Also excluded remoting/host from the _checkSpamLogging PRESUBMIT check.

BUG=
TBR=joi@chromium.org

Review URL: https://codereview.chromium.org/103053006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241100 0039d316-1c4b-4281-b951-d872f2087c98

67c96ab4

Get rid of the old angle checkout · 82055641

zmo@chromium.org authored Dec 17, 2013

BUG=319527
TEST=bots
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/101543007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241099 0039d316-1c4b-4281-b951-d872f2087c98

82055641

Optimize png files under ash/resources, ui/resources · bd084b98

oshima@chromium.org authored Dec 17, 2013

$ /tmp/optimize-png-files.sh -s -o2 -r 232777 ash/resources/ ui/resources/

Processed 35 files (out of 159 files) in 00:10:29s
Result : 38333 => 24386 bytes (13947 bytes : 36 %)

BUG=313730
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/114003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241098 0039d316-1c4b-4281-b951-d872f2087c98

bd084b98