GitLab

LayoutBox::scrollRectToVisible will return if the new rect to be scrolled is
empty after clipped by layerBounds. However, the rect to be scrolled might be
an empty rect originally. A common case is empty <a> elements used as named
anchors for navigation. This patch sets the size of the empty rect to 1 so that
it can still be scrolled.

BUG=646738

Review-Url: https://codereview.chromium.org/2339653003
Cr-Commit-Position: refs/heads/master@{#418856}

Also while here:
 - const scoped_refptr<>& => scoped_refptr<> + std::move
   (helps avoiding unnecessary refcount bumps:
    https://groups.google.com/a/chromium.org/d/topic/chromium-dev/TlL1D-Djta0/discussion)

BUG=646443

Review-Url: https://codereview.chromium.org/2338363002
Cr-Commit-Position: refs/heads/master@{#418855}

BUG=646443

Review-Url: https://codereview.chromium.org/2344593003
Cr-Commit-Position: refs/heads/master@{#418854}

This API can be used from any task from which
SequencedTaskRunnerHandle::Get() returns a SequencedTaskRunner (i.e. in
particular, it can be used from SINGLE_THREADED and SEQUENCED tasks
running in base/task_scheduler). As opposed to the existing API which
is only available from single-threaded tasks running in a
MessageLoopForIO.

Threads that want to support this API must instantiate a
FileDescriptorWatcher. The constructor of FileDescriptorWatcher takes
as argument a MessageLoopForIO to use to watch file descriptors for
which callbacks are registered on the thread on which it is invoked. The
MessageLoopForIO does *not* have to run on that thread. When the
MessageLoopForIO detects that watched file descriptors are readable
and/or writable without blocking, it posts a task to run the callback on
the sequence on which it was registered.

Design doc:
https://docs.google.com/document/d/1F5CjON2JNtCtdEug3LOL8-avj188k_xOgqzdv288Q_s/edit?usp=sharing

Discussion on chromium-dev:
https://groups.google.com/a/chromium.org/d/msg/chromium-dev/voOAab4mV9A/S9xXdpPkBgAJ

BUG=645114

Review-Url: https://codereview.chromium.org/2332923004
Cr-Commit-Position: refs/heads/master@{#418853}

This cl splits the big CL with changes to net/ folder and
has changes only to net/cert_net according to the
changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Committed: https://crrev.com/a74d3cbc572fa1c85cc2c0434a9f8e2f9cba0cd9
Review-Url: https://codereview.chromium.org/2330873002
Cr-Original-Commit-Position: refs/heads/master@{#418014}
Cr-Commit-Position: refs/heads/master@{#418852}

R=mbarbella@chromium.org, ochang@chromium.org
BUG=643275

Review-Url: https://codereview.chromium.org/2340813002
Cr-Commit-Position: refs/heads/master@{#418851}

The RunsTasksOnCurrentThread() method of a SequencedTaskRunner returned
by a SequencedWorkerPool returns true iff the current task is part of
the sequence associated with the SequencedTaskRunner.

This CL changes SchedulerSequencedTaskRunner to match the behavior of
SequencedWorkerPool.

BUG=553459,646905

Review-Url: https://codereview.chromium.org/2340793002
Cr-Commit-Position: refs/heads/master@{#418850}

BUG=none
R=noyau@google.com

Review-Url: https://codereview.chromium.org/2342833002
Cr-Commit-Position: refs/heads/master@{#418849}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
TBR=gab@chromium.org, mattm@chromium.org, haven@chromium.org, phajdan.jr@chromium.org, gene@chromium.org, reillyg@chromium.org

Review-Url: https://codereview.chromium.org/2321573002
Cr-Commit-Position: refs/heads/master@{#418848}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/06fda3c9..3fc897f5

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2339333002
Cr-Commit-Position: refs/heads/master@{#418847}

BUG=646288

Review-Url: https://codereview.chromium.org/2342663002
Cr-Commit-Position: refs/heads/master@{#418846}

Currently there are const char* and std::string varieties of strings in
RTCStatsMember objects ("StaticString" and "String"). The const char*
version is going away so that we don't have two string types.

This CL removes references to the "StaticString" types so that a WebRTC
CL can remove it without breaking Chromium. Only rtc_stats.cc have to
be updated, not affecting any code because rtc_stats is not used yet
(a CL is in the works that will use it and add unittests for it that is
blocked on a WebRTC CL that is under review).

BUG=chromium:627816

Review-Url: https://codereview.chromium.org/2340603004
Cr-Commit-Position: refs/heads/master@{#418845}

Revert of Disabled the v8.todomvc reference build due to missing clock sync markers (patchset #2 id:20001 of https://codereview.chromium.org/2340033002/ )

Reason for revert:
Root issue should be fixed.

Original issue's description:
> Disabled the v8.todomvc reference build due to missing clock sync markers
>
> TBR=nednguyen@chromium.org
> BUG=646925
>
> Committed: https://crrev.com/2c1a2b054e002dd463cdf88df02b3e20d550d0dd
> Cr-Commit-Position: refs/heads/master@{#418632}

TBR=nednguyen@chromium.org,oysteine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=646925

Review-Url: https://codereview.chromium.org/2347493004
Cr-Commit-Position: refs/heads/master@{#418844}

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599

Review-Url: https://codereview.chromium.org/2321453002
Cr-Commit-Position: refs/heads/master@{#418843}

After https://codereview.chromium.org/2317203002 and
https://build.chromium.org/p/chromium.fyi/builders/Browser%20Side%20Navigation%20Linux/builds/21220

BUG=607205,575210
TBR=clamy@chromium.org

Review-Url: https://codereview.chromium.org/2336393002
Cr-Commit-Position: refs/heads/master@{#418842}

This CL adds a browser test for desktop geolocation where persistence is
toggled off, ensuring that the underlying content setting isn't changed.
Additional checks of the content setting are added to the existing grant
and block tests.

This CL also simplifies the feature list setting used in the
PermissionContextBase test.

BUG=632269

Review-Url: https://codereview.chromium.org/2338173002
Cr-Commit-Position: refs/heads/master@{#418841}

A third go at https://crrev.com/3c64df1fc98aa06eabfc18d1f5c2f2b0aec1a658

Although I still can't reproduce the clusterfuzz reports locally I'm confident
this will cure the specific crashes because I'm no longer transforming the
first line's text unless it has a distinct first-line style (:/).

BUG=129669,644733

Review-Url: https://codereview.chromium.org/2339683004
Cr-Commit-Position: refs/heads/master@{#418840}

If it's an exclusive end offset, we need to know this, so that we map to the
former column set, rather than the latter, if the offset is at a column set
boundary.

Review-Url: https://codereview.chromium.org/2340213003
Cr-Commit-Position: refs/heads/master@{#418839}

The spec (https://drafts.csswg.org/css-tables-3/#repeated-headers) tells us that
we shouldn't bother repeating headers if a row of content doesn't fit. It's not
clear what to do in the situation where it's just the first page that the row
doesn't fit. I think we ultimately want to do the same as Edge/IE and still
repeat the headers on subsequent pages.

That would require a second layout pass to achieve so for now just drop the
repeating headers if we can't fit a row on the first page.

BUG=624814
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2326303002
Cr-Commit-Position: refs/heads/master@{#418838}

IFrame Scrollbar needs reconstruction. In the updateWidgetGeometry set
frameview needs layout if frameview scrollbars needsreconstruction.

BUG=492785

Review-Url: https://codereview.chromium.org/2314593003
Cr-Commit-Position: refs/heads/master@{#418837}

BUG=604851

Review-Url: https://codereview.chromium.org/2342793002
Cr-Commit-Position: refs/heads/master@{#418836}

This CL replaces EventSender in HTMLLinkElement with postTask():
Instead of calling HTMLLinkElement::dispatchPendingLoadEvents() in
Document::implicitClose() to enforce <link>'s onload events to be executed
before the document's onload event, this CL blocks document's onload until
<link>'s onload event using IncrementLoadEventDelayCount.

This CL also modifies SimTest:
This CL potentially makes onload events of <link> and documents async and
delayed, and thus SimTest can be destructed before document's onload event,
which cause assertion failure.
This CL calls testing::runPendingTasks() in ~SimTest() to flush scheduled
onload events to make Document to be loaded before SimTest's destruction.

BUG=624697

Review-Url: https://codereview.chromium.org/2275493002
Cr-Commit-Position: refs/heads/master@{#418835}

Make cc::SoftwareImageDecodeController, cc::GpuImageDecodeController, cc::ResourcePool, and cc::StagingBufferPool MemoryCoordinatorClient.

- implement OnMemoryStateChange for background renderer's purge +
  suspend. So the method reduces memory only when state == SUSPENDED.
- intent-to-implement-and-ship of background renderer's purge + suspend is
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4
- one of the documents attached in the above intent is
  https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit?usp=sharing

BUG=635419
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2286583002
Cr-Commit-Position: refs/heads/master@{#418834}

There are a large number of mechanical changes of usages of WrapUnique()
to MakeUnique(). The blame information for these is not useful as it
does not reflect the people responsible for the code.

Add the relevant commits to .git-blame-ignore-revs so that they will be
skipped by git hyper-blame.

R=mgiuca@chromium.org
BUG=637812

Review-Url: https://codereview.chromium.org/2288683002
Cr-Commit-Position: refs/heads/master@{#418833}

It takes 1-3 seconds on Release and ~10 seconds on Debug.

TBR=brucedawson@chromium.org
BUG=647192
NOTRY=true

Review-Url: https://codereview.chromium.org/2342803002
Cr-Commit-Position: refs/heads/master@{#418832}

This is a refactoring patch which stores the definite/indefinite height
detection in a new attribute m_hasDefiniteLogicalHeight in LayoutGrid.
That way we just only call LayoutBlock::hasDefiniteLogicalHeight() once,
from LayoutGrid::layoutBlock(). Then in LayoutGrid::gridTrackSize()
we reuse the cached value.

No new tests, no change of behavior.

BUG=624301

Review-Url: https://codereview.chromium.org/2334133002
Cr-Commit-Position: refs/heads/master@{#418831}

This test consistently takes 2 seconds on Release and 10 seconds on
Debug, thus it meets the bar of Slow tests.

TBR=brucedawson@chromium.org
BUG=647192
NOTRY=true

Review-Url: https://codereview.chromium.org/2342043002
Cr-Commit-Position: refs/heads/master@{#418830}

This cl splits the big CL with changes to net/ folder and
has changes only to net/nqe and some url_request tests
according to the changes to URLRequest API.

What the big cl does:
It modifies net/ clients that use URLRequest API as long as
URLRequest::Read returns int net errors and
URLRequest::Delegate and NetworkDelegate methods
(for example, OnResponseStarted or OnCompleted) have int
net_error in the arguments now.

The reason behind splitting the CL into small one is that
an android bot started to be unstable and unittests became
flaky. It was not possible to locate the problem and the
decision was to split the CL and upload small parts with a
6+ hours interval in order to make it possible to locate
the problematic code.

The big CL is located here -
https://codereview.chromium.org/2265873002/

BUG=423484

Review-Url: https://codereview.chromium.org/2332643002
Cr-Commit-Position: refs/heads/master@{#418829}

This CL introduces seven new fuzzers for WebAssembly which test the
decoding of single sections in the WebAssembly module decoder.

R=mmoroz@chromium.org

Review-Url: https://codereview.chromium.org/2344823002
Cr-Commit-Position: refs/heads/master@{#418828}

This CL renames '-webkit-clip-path' to 'clip-path', and makes the former
an alias of the latter.
For LayoutSVGRoot, clip-path is now applied only by the PaintLayer and
not by SVGPaintContext.

Intent-to-ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/FBE05hzCmPo

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2312713002
Cr-Commit-Position: refs/heads/master@{#418827}

This patch adds UMA to measure time to open hyphenation dictionary.

The previous CL[1] added UMA that includes IPC as "Hyphenation.Open",
but this metric measures the time of the file task without the IPC.

[1] 2113933003

BUG=605840

Review-Url: https://codereview.chromium.org/2340613002
Cr-Commit-Position: refs/heads/master@{#418826}

This exercises webview state save/restore, and also makes using the
shell as a testing/demonstration tool easier, because the current URL
is retained and reloaded when you switch webview providers.

BUG=
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2330013002
Cr-Commit-Position: refs/heads/master@{#418825}

TransparentButton has state-change animations enabled despite being invisible,
which causes a bunch of spurious repaints of the combobox on mouse enter/exit.

BUG=645266

Review-Url: https://codereview.chromium.org/2327673003
Cr-Commit-Position: refs/heads/master@{#418824}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/5148bd4b2be6..3cc40b373729

$ git log 5148bd4b2..3cc40b373 --date=short --no-merges --format='%ad %ae %s'
2016-09-15 perezju Revert of "[telemetry] Wire TsProxy through telemetry's network stack." (patchset #1 id:1 of https://codereview.chromium.org/2335403003/ )

BUG=639632

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2341723004
Cr-Commit-Position: refs/heads/master@{#418823}

There's no longer any WebSocket files under content/common/.

R=yhirano@chromium.org,jochen@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2344613005
Cr-Commit-Position: refs/heads/master@{#418822}

Previously, internals.isPreloaded() depends on |ResourceFetcher::m_preloads|,
which is cleared by ResourceFetcher::clearPreloads().
This caused internals.isPreloaded() to turn false after around document's
load event.

This CL makes ResourceFetcher to keep a set of preloaded URLs (separately
from |m_preloads|) if a blink::Internals object is created, and use the set
to calculate internals.isPreloaded().

BUG=643621

Review-Url: https://codereview.chromium.org/2332333003
Cr-Commit-Position: refs/heads/master@{#418821}

This patch converts "editing/inserting/insert-at-end-0[12].html" to use w3c test
harness to simplify test script, and consolidates into "insert_at_end.html"
since these scripts use similar sample, for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2339853002
Cr-Commit-Position: refs/heads/master@{#418820}

Some EGL drivers do not support binding one component textures to an
EGL image. One component textures are used for YUV video frames, so
to support those drivers in WebView, we need to do YUV to RGB
conversion in software, and then upload an RGB texture instead of a
set of 3 Y,U,V textures.

BUG=579060, 632461
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2242453002
Cr-Commit-Position: refs/heads/master@{#418819}

The Android policy cache was originally created to avoid Strict Mode
violations, but doesn't do so in Webview. Actually, although reading
the app restrictions on the UI thread is a strict mode violation it
is unlikely to cause UI visible delays, As such the solution is to
simply to allow file reads in this component.

BUG=628627

Review-Url: https://codereview.chromium.org/2322963002
Cr-Commit-Position: refs/heads/master@{#418818}

BUG=498716

Review-Url: https://codereview.chromium.org/2316263002
Cr-Commit-Position: refs/heads/master@{#418817}