GitLab

This class uses two buffers to decode mutiple frames. It will be used
by the chromoting client OpenGL renderer.

BUG=385924

Review-Url: https://codereview.chromium.org/2156713002
Cr-Commit-Position: refs/heads/master@{#407233}

Adds a missing class to properly space the Cancel button on the
Disconnect dialog in the People section.

BUG=630189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2161363006
Cr-Commit-Position: refs/heads/master@{#407232}

Check in event_sender.cc to avoid sending flingsgesturestart events with velocity of zero.

BUG=628525

Review-Url: https://codereview.chromium.org/2158173002
Cr-Commit-Position: refs/heads/master@{#407231}

The public PGO builders do not do chrome-branded builds, so
can't reuse the existing 'official' mixin and need to split out
is_official_build from is_chrome_branded.

TBR=sebmarchand@chromium.org
NOTRY=true
BUG=595947

Review-Url: https://codereview.chromium.org/2180513002
Cr-Commit-Position: refs/heads/master@{#407230}

The test is marked as failing, but the baseline right now is clearly wrong,
so maybe it's actually passing. TestExpectations may need to be re-added if
it turns out to still be flakey.

TBR=chrishtr@chromium.org
BUG=526594

Review-Url: https://codereview.chromium.org/2178553002
Cr-Commit-Position: refs/heads/master@{#407229}

Revert of Cancel image loads if decoding failed. (patchset #8 id:140001 of https://codereview.chromium.org/2108033003/ )

Reason for revert:

Likely cause of failures:

webkit_tests webkit_tests:
http/tests/images/restyle-decode-error.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3384

---
10:19:32.937 5109 worker/0 http/tests/images/restyle-decode-error.html started
10:19:32.953 5111 worker/2 accessibility/animation-policy.html passed
10:19:32.955 5111 worker/2 accessibility/anonymous-render-block-in-continuation-causes-crash.html started
10:19:32.999 5109 renderer crash, pid = None, error_line = #CRASHED - renderer
10:19:33.000 5109 killed pid 5357
10:19:33.000 5109 worker/0 http/tests/images/restyle-decode-error.html crashed, (stderr lines):
10:19:33.000 5109   Received signal 11 <unknown> 000000000000
10:19:33.000 5109    [0x0001196ef23e]
...
10:19:33.002 5109   [end of stack trace]
10:19:33.002 5109   [5358:13319:0722/101932:598964195783:ERROR:node_controller.cc(1099)] Could not be introduced to peer C9E4F59A639F0E59.C2F8E762ADA8C89E
10:19:33.006 5084 [4832/40217] http/tests/images/restyle-decode-error.html failed unexpectedly (renderer crashed)
10:19:33.003 5109 worker/0 killing primary driver
10:19:33.004 5109 worker/0 killing secondary driver
10:19:33.004 5109 worker/0 http/tests/images/restyle-decode-error.html failed:
10:19:33.004 5109 worker/0  renderer crashed
---

Also same failure on other bots such as
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/21244

(ignore other webkit failures on this bot; those all have a known cause with a fix incoming)

Original issue's description:
> Cancel image loads if decoding failed.
>
> 'Cancel' isn't really the right word for what this change does.
> In the event of an image decoding failure, ImageResource will
> synthesize a call to ResourceLoader::didFinishLoading, killing
> the actual network request but reporting it as a successful
> completion to the rest of blink. This matches our traditional
> behavior of decoding errors looking like a successful
> resource load (for the most part).
>
> This requires some plumbing changes to image decoding, because
> the decoder selection logic doesn't report why it wasn't able to
> create an ImageDecoder. It might be because insufficient data has
> been received to sniff the image type, or it may be that we
> definitely don't have a valid image type. This change exposes enough
> information to tell the difference.
>
> BUG=471272
>
> Committed: https://crrev.com/520519605b961a7d979bc0eaa3c057a973dc26f1
> Cr-Commit-Position: refs/heads/master@{#407171}

TBR=pdr@chromium.org,peter@chromium.org,japhet@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471272

Review-Url: https://codereview.chromium.org/2173603003
Cr-Commit-Position: refs/heads/master@{#407228}

The preload scanner currently waits for the Application Cache to be
initialized before sending out any preloads. This is less important for link
rel preloads, which are directives to send a fetch as soon as possible.

This patch bypasses the fetch queuing for these preloads.

For link preloads in headers, we can issue these as early as the commit
point (for those which don't have a media attribute).

BUG=629420

Review-Url: https://codereview.chromium.org/2165653004
Cr-Commit-Position: refs/heads/master@{#407227}

The Android Nougat release is 7.0.

Review-Url: https://codereview.chromium.org/2172073002
Cr-Commit-Position: refs/heads/master@{#407226}

This patch adds a single 'search:portal' story (both desktop and
mobile) which does the following:

  1. Open google.co.uk.
  2. Type 'what is science' and hit return.
  3. Scroll down to the Wikipedia result.
  4. Click on the Wikipedia result and wait until it loads.

This is a prototype of the SH stories with same origin and cross-origin
navigtation (see
https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kwQEHMwI/#gid=712129109).
Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
will follow shortly (in subsequent CLs).

BUG=589726
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2148843002
Cr-Commit-Position: refs/heads/master@{#407225}

This patch makes it possible to view and revoke permission to access a
USB device by going to an origin's "site settings" page.

This is a reland of r405887.

BUG=430999,601627

Review-Url: https://codereview.chromium.org/2170123002
Cr-Commit-Position: refs/heads/master@{#407224}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1852b91a..0cea24e0

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2172283002
Cr-Commit-Position: refs/heads/master@{#407223}

https://chromium.googlesource.com/skia.git/+log/cbecb082d15d..4c6e47a8a827

$ git log cbecb082d..4c6e47a8a --date=short --no-merges --format='%ad %ae %s'
2016-07-22 jvanverth Recycle small uniform buffers.
2016-07-22 brianosman Connect dst color space in a few places (removing TODOs)
2016-07-22 mtklein Revert of Add SkRasterPipeline blitter. (patchset #18 id:340001 of https://codereview.chromium.org/2146413002/ )
2016-07-22 vjiaoblack Creating framework for drawShadowedPicture GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2146073003

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2171423002
Cr-Commit-Position: refs/heads/master@{#407222}

The new channel will be used with WebRTC protocol to send video stats to
client to make it possible to measure round-trip latency.

BUG=621691

Review-Url: https://codereview.chromium.org/2176443002
Cr-Commit-Position: refs/heads/master@{#407221}

BUG=none

Review-Url: https://codereview.chromium.org/2178483002
Cr-Commit-Position: refs/heads/master@{#407220}

Revert of grit: Automatically replace ... with … (patchset #10 id:180001 of https://codereview.chromium.org/2112653003/ )

Reason for revert:
Likely cause of failures:

---
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/67858

unexpected_failures:
fast/forms/color/color-suggestion-picker-appearance-zoom125.html
fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
fast/forms/color/color-suggestion-picker-appearance-zoom200.html

all with the message
image diff
---

since it appears to replace "..." with a proper ellipsis, which all the three
tests show differences from:

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67858/layout-test-results/results.html

also failures for

also some other bots for tests
fast/forms/color/color-suggestion-picker-appearance.html
fast/forms/color/color-suggestion-picker-one-row-appearance.html
fast/forms/color/color-suggestion-picker-two-row-appearance.html
appear on other bots.

And, for what it's worth,
the bot
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3384
started showing a renderer crash in
http/tests/images/restyle-decode-error.html
in a blamelist that includes this change as well.  Hopefully this revert will fix that too. :-)

Original issue's description:
> grit: Automatically replace ... with … (U+2026)
>
> Android lint tool pointed out that ... should really be … (U+2026).
> Tested that this glyph renders well on Mac + Win as well, so
> applying to all OS's by default.
>
> TBR=flackr
> BUG=621772
>
> Committed: https://crrev.com/e82c4e1b9de3b189c85bccff63d4ef3046e44d43
> Cr-Commit-Position: refs/heads/master@{#407182}

TBR=flackr@chromium.org,asanka@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=621772

Review-Url: https://codereview.chromium.org/2176663003
Cr-Commit-Position: refs/heads/master@{#407219}

This CL changes NotificationPromo's HandleViewed/HandleClosed methods to
not update the current instance variables and just save the updated
values to prefs. This is needed because HandleViewed can be called
in the middle of the chain of CanShow calls made during layout of the
NTP, causing some CanShow calls to return true while others to return
false during the same layout. By not saving the updated values to the
current instance variables, the CanShow calls will remain consistent
during the same layout. To facilitate this change, this CL also changes
the return type of HandleViewed to void since the return value is never
used.

BUG=625192

Review-Url: https://codereview.chromium.org/2140173009
Cr-Commit-Position: refs/heads/master@{#407218}

This CL makes the separator line and hover color shared for MD.
It also shares the [actionable] styling.

BUG=521040
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2169603002
Cr-Commit-Position: refs/heads/master@{#407217}

This will make it easy for different parts of the ash wm code to
register accelerators.

BUG=612331
TEST=none
R=ben@chromium.org

Review-Url: https://codereview.chromium.org/2171973003
Cr-Commit-Position: refs/heads/master@{#407216}

Currently, an app can exceed the number of decoders that vendor backends
support (for example, by creating multiple video elements), leading to
unpredictable behaviour including crashes.  While most apps don't do
this, we have seen some problems crop up e.g. when ads are injected into
an existing page.

For now, restrict to 1 video decoder and 2 audio decoders.

BUG=internal b/26910920

Review-Url: https://codereview.chromium.org/2173593002
Cr-Commit-Position: refs/heads/master@{#407215}

For iframes, we don't want to use the source url for determining the
associated extension because it starts out with an about:blank context
that is scriptable by its parent.

BUG=573131

Review-Url: https://codereview.chromium.org/2151693002
Cr-Commit-Position: refs/heads/master@{#407214}

Also adds a unit test using the function that is used downstream to
prevent this from happening again.

BUG=630260

Review-Url: https://codereview.chromium.org/2173873002
Cr-Commit-Position: refs/heads/master@{#407213}

BUG=590369
R=yosin,esprehn

Review-Url: https://codereview.chromium.org/2144673003
Cr-Commit-Position: refs/heads/master@{#407212}

Before this patch, when root layer scrolling was enabled, both FV and PLSA would
perform scroll anchoring. FV doesn't need perform scroll anchoring for the main
frame because PLSA will do the right thing.

This issue was found because the following tests failed when ScrollAnchoring was
turned on by default:
virtual/rootlayerscrolls/fast/scrolling/scroll-into-view-collapsed-div.html
virtual/rootlayerscrolls/fast/scrolling/fractional-scroll-offset-document.html

BUG=597479,558575

Review-Url: https://codereview.chromium.org/2176523003
Cr-Commit-Position: refs/heads/master@{#407211}

This is sufficiently different from regular accelerated video decode
that we want to be able to blacklist it separately.

BUG=616318
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2167423002
Cr-Commit-Position: refs/heads/master@{#407210}

DevTools: keep widgets in widget hierarchy upon hide, split attach/detach cycle from show/hide (reland)

TBR=dgozman

Review-Url: https://codereview.chromium.org/2168223002
Cr-Commit-Position: refs/heads/master@{#407209}

Database data loss is a non-standard extension to IDBVersionChangeEvent
(https://www.w3.org/Bugs/Public/show_bug.cgi?id=22370). This state only
needs to be persisted as part of the database open. So moving this value
from IndexedDBCallbacks (used for any IDB call) to
IndexedDBPendingConnection (only used during database open).

BUG=627484

Review-Url: https://codereview.chromium.org/2140193002
Cr-Commit-Position: refs/heads/master@{#407208}

BUG=None

Review-Url: https://codereview.chromium.org/2179523002
Cr-Commit-Position: refs/heads/master@{#407207}

We used to return null on bind and avoid connecting in custom tabs
service if FRE is not completed. This change allows bind and connection
but returns false on any code that require network or browser UI
interaction. This way the client can still register a new session and
get callbacks.

BUG=630339

Review-Url: https://codereview.chromium.org/2174453002
Cr-Commit-Position: refs/heads/master@{#407206}

BUG=553459

Review-Url: https://codereview.chromium.org/2116163002
Cr-Commit-Position: refs/heads/master@{#407205}

Revert of Remove platform/text/ParserUtilities.h (patchset #2 id:20001 of https://codereview.chromium.org/2176623003/ )

Reason for revert:
Likely cause of failures:

---
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/67858

unexpected_failures:
fast/forms/color/color-suggestion-picker-appearance-zoom125.html
fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
fast/forms/color/color-suggestion-picker-appearance-zoom200.html

all with the message
image diff
---

---
also bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3384

http/tests/images/restyle-decode-error.html

in which case there is a renderer crash in this test
---

also some other bots for tests
fast/forms/color/color-suggestion-picker-appearance.html
fast/forms/color/color-suggestion-picker-one-row-appearance.html
fast/forms/color/color-suggestion-picker-two-row-appearance.html

Original issue's description:
> Remove platform/text/ParserUtilities.h
>
> platform/ParsingUtilities.h caters to the same needs, so transition
> users of skipString(...) to skipToken(...) and remove
> platform/text/ParserUtilities.h.
>
> Committed: https://crrev.com/39cc523b5dbf9d2ddad9483cb27fab8b97e53ec1
> Cr-Commit-Position: refs/heads/master@{#407187}

TBR=schenney@chromium.org,pdr@chromium.org,fs@opera.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2179563002
Cr-Commit-Position: refs/heads/master@{#407204}

https://chromium.googlesource.com/webm/libvpx.git/+log/18c7f46c125c..4b073bc39a39

$ git log 18c7f46c1..4b073bc39 --date=short --no-merges --format='%ad %ae %s'
2016-07-21 yunqingwang Add back header in threading.h
2016-07-14 yunqingwang Revert "Amend and improve VP8 multithreading implementation"

R=johannkoenig@google.com

Review-Url: https://codereview.chromium.org/2168253002
Cr-Commit-Position: refs/heads/master@{#407203}

FileReader.readAsBinaryString() was removed from the spec after typed
arrays became a thing. But all browsers kept shipping it, and it looks
risky to remove, so it was added back to the spec. Remove the use
counters and TODOs in the IDL files.

R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2171953002
Cr-Commit-Position: refs/heads/master@{#407202}

In current code, some of the DCHECKs are having multiple conditions.
It's difficult to identify the failures if DCHECK fails due to one
of those conditions. Now moved the conditions to separate DCHECKs, so
that failure can identify at correct point.

BUG=

Review-Url: https://codereview.chromium.org/2168093002
Cr-Commit-Position: refs/heads/master@{#407201}

Not enough coverage for the asserts at the moment (hopefully, we will
get them back with the newer android toolchains eventually), and this
seems like an important enough one to special case.

Context:
https://codereview.chromium.org/2165333002/#msg9

BUG=

Review-Url: https://codereview.chromium.org/2177473004
Cr-Commit-Position: refs/heads/master@{#407200}

This eliminates some accesses of ash::Shell inside the shelf code, which is
necessary for porting the shelf to mus/mustash.

* ShelfModel now owns the ShelfItemDelegates
* Explicitly delete the ShelfItemDelegates during shutdown, because some of
the subclasses reach into ShelfModel during their destructors
* Move AppListShelfItemDelegate earlier, to WmShell::Initialize phase
* Fix ShelfAppBrowserTest.LauncherContextMenuVerifyCloseItemAppearance to use
the actual shelf ID of the browser shortcut, rather than using the magic
number "1" that can sometimes mean the app list item.

This also simplifies some of the unit tests for ChromeLauncherController
because they don't need to construct their own ShelfItemDelegateManager.

BUG=629990,429870
TEST=ash_unittests, chrome unit_tests, manually test shelf pin/unpin/etc.

Review-Url: https://codereview.chromium.org/2171813004
Cr-Commit-Position: refs/heads/master@{#407199}

AcceleratorDelegate now trivially forwards to AcceleratorRouter, which
is now in terms of ash/common types.

BUG=612331
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2171983002
Cr-Commit-Position: refs/heads/master@{#407198}

We have an off-by-one error now that the mOptionLayout can have multiple children in it above the actual options.

* Use the correct index when indexing into the options layout.

* Add a test that checks for the crash and additionally checks that the "merchant doesn't accept address" string is
correctly displayed.

* Plumbs a new callback that indicates that the client has finished
checking the selection.

BUG=630348

Review-Url: https://codereview.chromium.org/2170603006
Cr-Commit-Position: refs/heads/master@{#407197}

Has never passed since it was introduced.  Disabling on low end
for now.

BUG=626289

Review-Url: https://codereview.chromium.org/2170183004
Cr-Commit-Position: refs/heads/master@{#407196}

https://chromium.googlesource.com/skia.git/+log/d50e2401787d..cbecb082d15d

$ git log d50e24017..cbecb082d --date=short --no-merges --format='%ad %ae %s'
2016-07-22 csmartdalton Allow GrReducedClip to take non-integer query bounds
2016-07-22 mtklein Add SkRasterPipeline blitter.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2171393002
Cr-Commit-Position: refs/heads/master@{#407195}

Raises an NSInvalidArgumentException if call setObject for NSMutableDictionary
with a nil value. Dictionary uses NSNull instead of nil.
Selected text marker range may be nil sometimes
(see BrowserAccessibilityCocoa::selectedTextMarkerRange), that leads to a crashe
in BrowserAccessibilityManagerMac::GetUserInfoForSelectedTextChangedNotification().

R=aboxhall@chromium.org, dmazzoni@chromium.org, dtseng@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2161623002
Cr-Commit-Position: refs/heads/master@{#407194}