- 01 Aug, 2018 40 commits
-
-
Marc Treib authored
"IsSyncDisabled" described neither what the method was trying to do, nor what it actually did. This CL flips it to "IsSyncEnabledByUser" (yay less negation), and also fixes its implementation to actually check that. This was exposed as an actual problem by https://crrev.com/c/1148392. Bug: 856179 Change-Id: I4219b5fa8d596edc80ed649983bc59198051c521 Reviewed-on: https://chromium-review.googlesource.com/1156599 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579747}
-
Keishi Hattori authored
PSA: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9YCeDToqDU8 Bug: 757440 Change-Id: Id13ec3a8aa0c6a134a83acffd9811e2eee99fd2b Reviewed-on: https://chromium-review.googlesource.com/1125892Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#579746}
-
Oscar Johansson authored
Building //media takes around 23 CPU minutes. A experimental branch showed that this could be reduced, by using jumbo, to around 9 CPU minutes. media/capture is the fifth largest part of media and takes around 2 CPU minutes to compile without jumbo. This commit enables jumbo for media/capture. Bug: 867350 Change-Id: Ib53497ecde8a096b4436b4c60069e9e24e482a68 Reviewed-on: https://chromium-review.googlesource.com/1154922Reviewed-by:
Chrome Cunningham (In Paris) <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#579745}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/53d4f0a4526e..d4906e83d313 git log 53d4f0a4526e..d4906e83d313 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 thestig@chromium.org Combine date/time format methods in CFXJSE_FormCalcContext. 2018-08-01 thestig@chromium.org Fix a nullptr crash in CXFA_LocaleValue::ValidateValue(). Created with: gclient setdep -r src/third_party/pdfium@d4906e83d313 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868271 TBR=dsinclair@chromium.org Change-Id: If30315876994c44b83e73e920811987e45fd323b Reviewed-on: https://chromium-review.googlesource.com/1158127Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579744}
-
Benoit Lize authored
Adds a tool that: - Reads a file from disk - Compresses and decompresses it using {zlib,snappy} Example output (Android Go, Gobo): Gzip Size = 4096 Compression Compression ratio = 2.46154 Throughput = 4.97989MB/s Latency (size = 4096) = 822.508us Decompression Throughput = 41.4281MB/s Latency (size = 4096) = 98.87us Size = 8192 Compression Compression ratio = 3.3166 Throughput = 7.32629MB/s Latency (size = 8192) = 1118.16us Decompression Throughput = 63.3125MB/s Latency (size = 8192) = 129.39us Size = 16384 Compression Compression ratio = 4.73937 Throughput = 13.3032MB/s Latency (size = 16384) = 1231.58us Decompression Throughput = 80.3413MB/s Latency (size = 16384) = 203.93us Size = 32768 Compression Compression ratio = 5.51279 Throughput = 10.4441MB/s Latency (size = 32768) = 3137.45us Decompression Throughput = 108.485MB/s Latency (size = 32768) = 302.05us Size = 65536 Compression Compression ratio = 5.36828 Throughput = 15.3562MB/s Latency (size = 65536) = 4267.71us Decompression Throughput = 113.76MB/s Latency (size = 65536) = 576.09us Size = 131072 Compression Compression ratio = 5.42517 Throughput = 10.1509MB/s Latency (size = 131072) = 12912.4us Decompression Throughput = 114.958MB/s Latency (size = 131072) = 1140.17us [...] Snappy Size = 4096 Compression Compression ratio = 1.78787 Throughput = 53.2261MB/s Latency (size = 4096) = 76.9547us Decompression Throughput = 161.323MB/s Latency (size = 4096) = 25.39us Size = 8192 Compression Compression ratio = 2.44246 Throughput = 63.8232MB/s Latency (size = 8192) = 128.355us Decompression Throughput = 130.052MB/s Latency (size = 8192) = 62.99us Size = 16384 Compression Compression ratio = 3.49339 Throughput = 70.1383MB/s Latency (size = 16384) = 233.596us Decompression Throughput = 173.762MB/s Latency (size = 16384) = 94.29us Size = 32768 Compression Compression ratio = 4.24566 Throughput = 88.4845MB/s Latency (size = 32768) = 370.325us Decompression Throughput = 194.561MB/s Latency (size = 32768) = 168.42us Size = 65536 Compression Compression ratio = 4.16339 Throughput = 91.1387MB/s Latency (size = 65536) = 719.08us Decompression Throughput = 183.827MB/s Latency (size = 65536) = 356.51us Size = 131072 Compression Compression ratio = 4.16009 Throughput = 87.5235MB/s Latency (size = 131072) = 1497.56us Decompression Throughput = 171.56MB/s Latency (size = 131072) = 764us Bug: 860693, 837659 Change-Id: I9887dd4b470ab1acf6d56b717fb73d33439ad453 Reviewed-on: https://chromium-review.googlesource.com/1127991 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko (futex_wait(&secret))) <pasko@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#579743}
-
Toshiki Kikuchi authored
Changing network settings is not allowed in lock screen. In previous implementation, network button is enabled and able to click even in lock screen. TEST=manual BUG=865333 Change-Id: I1986b353d1cdbe698a5390a7861cdf804cc5990d Reviewed-on: https://chromium-review.googlesource.com/1156189Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Toshiki Kikuchi <toshikikikuchi@google.com> Cr-Commit-Position: refs/heads/master@{#579742}
-
tanvir.rizvi authored
Member function SetSelectionAndEndTyping() was never used, instead FrameSelection SetSelectionAndEndTyping was used directly. So this is removed as a DeadCode Bug: 867563 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7d45dd28597e66cfb4ce35db28474136b5283356 Reviewed-on: https://chromium-review.googlesource.com/1158109 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579741}
-
Ramin Halavati authored
Preferences related to ChromeOS Thethering are removed from the persistent storage list for incognito mode. After this CL, if these preferences are changed from incognito mode, they are only stored in memory and won't affect user profile. Bug: 861722 Change-Id: I3faa7ad982ace7347a894f3f3225332d0a437ed0 Reviewed-on: https://chromium-review.googlesource.com/1158068Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579740}
-
stkhapugin@chromium.org authored
Just swaps the assets. Bug: 868962 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4ae13a5361766f91a44e7473109a6ac18bab13be Reviewed-on: https://chromium-review.googlesource.com/1157007Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#579739}
-
Sylvain Defresne authored
This is to keep WebStateUserData API in sync with WebContentsUserData (see https://crrev.com/c/1093015). Bug: 589840 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77db9c05167e91acafa15881ce85e43a9068c28e Reviewed-on: https://chromium-review.googlesource.com/1151326Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#579738}
-
stkhapugin@chromium.org authored
Prevents the focusing animation when the popup is displayed. Also resets alpha levels of the edit and steady view post animation to ensure correct behaviour if the non-animated focusing/defocusing is triggered multiple times rapidly (more of a theoretical scenario). Bug: 866882 TBR: marq@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib00aa7d4a5ffe871260b4272ad9b2ca8494ba952 Reviewed-on: https://chromium-review.googlesource.com/1151347 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#579737}
-
stkhapugin@chromium.org authored
Avoids caching the inline autocomplete color in UI Refresh, and uses _displayedTintColor instead of self.tintColor (which can be transparent when the textfield is hidden behind inline autocomplete or preedit). Bug: 865497 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I358cd0b10694271d4d0514b3dfe9b7415c1c9106 Reviewed-on: https://chromium-review.googlesource.com/1152985Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579736}
-
Hans Wennborg authored
For some reason, the ```shell stuff is getting output in the html. TBR=thakis Bug: none Change-Id: Idecf83e029e5bca4cf969c2145a458193aa5df56 Reviewed-on: https://chromium-review.googlesource.com/1158238Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579735}
-
Dan Elphick authored
Use the Context variant of BooleanValue since BooleanValue() is deprecated and will be removed soon. Change-Id: I425db1b31740586579cba22ebd394648a71b9bf5 Reviewed-on: https://chromium-review.googlesource.com/1152814Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#579734}
-
Yuta Kitamura authored
The main thread's WebThread is currently owned by each embedder, but we plan to have it owned by Platform and eventually stop exposing WebThread to non-Blink directories. Currently, Platform::CurrentThread() is used for two purposes: (1) to obtain the pointer to the main thread WebThread object, and (2) to return the current thread's WebThread object in thread-local storage. This patch gets rid of (1) and move it to Platform::Initialize()'s argument, so we can easily shift the ownership of WebThread in the future. TBR=eroman@chromium.org,kinuko@chromium.org,dalecurtis@chromium.org,jcivelli@chromium.org Bug: 826203 Change-Id: I93608b13f6b84a47112865da486647afc46ab039 Reviewed-on: https://chromium-review.googlesource.com/1154854Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#579733}
-
Michael Lippautz authored
Bug: chromium:843903 Change-Id: Ifeb9aa280b76cb894ff5ccdcdf5dd9390f2ee367 Reviewed-on: https://chromium-review.googlesource.com/1158204Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579732}
-
Rune Lillesveen authored
Measure style recalc and layout tree building separately. We now don't create samples for UpdateStyle() calls where both style and layout trees are clean. Bug: 851782 Change-Id: Icfa94f5a231775cbd9ea0aa80b8b693502b3ca42 Reviewed-on: https://chromium-review.googlesource.com/1156512Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#579731}
-
Gauthier Ambard authored
Tweaks the animation when focusing the fakebox in NTP. Bug: 867455 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I44a7c799e6269a1fdf6806b2cd54cdcdfc46336f Reviewed-on: https://chromium-review.googlesource.com/1156697 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579730}
-
Kent Tamura authored
registered_event_listener.h is used in many popular headers such as node.h and document.h. This reduces their pre-processed size by 0.55MB. If this CL causes performance regression, it should be reverted. This CL also adds a comment on RegisteredEventListener class. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id37380734d2600bc58a9b6d70672c61eff8f5c71 Reviewed-on: https://chromium-review.googlesource.com/1158104Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#579729}
-
Eric Stevenson authored
This is a reland of df22b814. The CL now forwards proguard_jar_path properly. Original change's description: > Use proguard version 6.0.3 for monochrome_public_apk. > > MonochromePublic.apk release builds are very close to the main dex limit > and updating proguard reduces the number of methods by about 3000. > > 6.0.3 cannot be used for all APKs yet due to a bug which causes > cronet_test_instrumentation_apk to fail. > > The version mismatch should be temporary as we plan to switch to R8 in the > future (https://crbug.com/868770). > > Bug: 857572 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester > Change-Id: I3676a42908c5046dc3f3831e282150702038140d > Reviewed-on: https://chromium-review.googlesource.com/1154366 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Eric Stevenson <estevenson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579250} Bug: 857572 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia52b36e04623c5b72e668bb6c07be018ac9210b5 Reviewed-on: https://chromium-review.googlesource.com/1156004Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#579728}
-
Alexander Hendrich authored
Moved logic for network->IsManagedByNetwork() and network->blocked_by_policy() to NetworkState, which gets set and updated by the NetworkStateHandler. The ManagedNetworkConfigurationHandler updates the NetworkStateHandler if any network blocking policy changes. Bug: none Change-Id: Iad25d242c7a5d191912ba3a15181da987d6bb6e0 Reviewed-on: https://chromium-review.googlesource.com/1122396 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579727}
-
Kinuko Yasuda authored
TBR=kinuko@chromium.org Bug: 869773 Change-Id: I9d38fcdc57d7e240653f85f9df32a964826cd6f4 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1158114Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579726}
-
Kinuko Yasuda authored
Because they seem to be flaky on Linux Xenial. TBR=tbansal Bug: 869781 Change-Id: I8a396d51256b67e6ef3d5d6e9d4ae4cda365ad1b No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1158120Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579725}
-
Jan Wilken Doerrie authored
This change implements more fine grained error handling for reading and writing Gatt Characteristics on WinRT. Appropriate tests are enabled. Bug: 821766 Change-Id: If2d8eae67620122f3b0273d9d387790bec2f3ee8 Reviewed-on: https://chromium-review.googlesource.com/1154789Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#579724}
-
Christos Froussios authored
They are flaking with timeout Bug: 856601 No-try: true No-Presubmit: true Change-Id: I40e09e6b8aed3cb2014a284d012abc8122d614b7 Reviewed-on: https://chromium-review.googlesource.com/1158228Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#579723}
-
Yoichi Osato authored
This patch rewrites a test expectation on each Node with |std::string DumpSelectionInfo()| so that we can check a SelectionStatus tree with text diff. The test skipped the flaky state LayoutObject about invalidation which is a containing block. However, since we don't invalidate containing blocks,there is no flakiness. Plus, it is the last user of the old test harness so we can clean it up all. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4a72fa4ee5f1b956e2fd1b7dea7175d14da0b331 Reviewed-on: https://chromium-review.googlesource.com/1157949Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#579722}
-
Yeol authored
So it replaced AddHeadersFromString, AddHeaderFromString with SetHeader in ../chrome. Bug: 862175 Change-Id: Ifec193eaf09ff75907ed4f0b0c7b29a3a724183b Reviewed-on: https://chromium-review.googlesource.com/1154852Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#579721}
-
Kent Tamura authored
- Remove unnecessary #include - Remove unused |capture| member - Update comments Bug: 869257 Change-Id: Ia16c39bd31be1a0d38f67efe6823cb62229fe0c8 Reviewed-on: https://chromium-review.googlesource.com/1157947Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#579720}
-
Christos Froussios authored
It is mostly failing (timeout) Bug: 856601 No-try: true No-Presubmit: true Change-Id: Ic8785e8bf5237d4e252c94a48a00302ce6e0303a Reviewed-on: https://chromium-review.googlesource.com/1158144 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#579719}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/54af9559..6c5ad298 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I62959eaf59618e31c2dcf439f25021e3c6867976 Reviewed-on: https://chromium-review.googlesource.com/1157921Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579718}
-
tzik authored
This CL flips `use_once_callback` flag on the Mojo code generator for Mojo tests, and fixes all compile errors after that. After this CL, Mojo interfaces there service starts using base::OnceCallback instead of base::Callback on its return value handling. Bug: 714018 Change-Id: Iaa9566292500cefd92ecedd137ed4ba4bfec502e Reviewed-on: https://chromium-review.googlesource.com/1156190Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#579717}
-
Koji Ishii authored
Re-ran rebaseline-cl. Somehow this produced different results from the last run in CL:1142048. Bug: 866785 Change-Id: I02c9ebc5fd206a20ff5c8bf919bd51eaeaef3e10 Reviewed-on: https://chromium-review.googlesource.com/1156338 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#579716}
-
yoshiki iguchi authored
message_center::UiController and UiDelegate were used by both the platform with only popup and with the message center and popup. This CL is the first CL of refactoring to split them into two for simplification. The current dependency: CrOS: UiController --UiDelegate--> NotificationTray/UnifiedSystemTray Old Win/Linux: UiController --UiDelegate--> PopupsOnlyUiDelegate Old Mac: UiController --UiDelegate--> MessageCenterBridge The new dependency: CrOS: UiController --UiDelegate--> NotificationTray/UnifiedSystemTray Old Win/Linux: PopupsOnlyUiController(new) --::Delegate(new)--> PopupsOnlyUiDelegate Old MacMac: PopupsOnlyUiController(new) --::Delegate(new)--> MessageCenterBridge I will move the existing UiController and UiDelegate to ash/ and refactor them in following CLs. Bug: 869278 Test: Notification works on Linux Change-Id: I8ab077f0339cb55cf25633aa481509f1775d43dd Reviewed-on: https://chromium-review.googlesource.com/1154617 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#579715}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1a9c02850686..da3dbe83a352 git log 1a9c02850686..da3dbe83a352 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 buildbot@webrtc.org Roll chromium_revision bf3721ae..4dd959af (579581:579686) Created with: gclient setdep -r src/third_party/webrtc@da3dbe83a352 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I36ea10cafca8e5778d74ef3febbe55c7c9332b67 Reviewed-on: https://chromium-review.googlesource.com/1158044Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579714}
-
Anand K. Mistry authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/2e6185093997..6d8535d43743 $ git log 2e6185093..6d8535d43 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 xiaochu add LoadDlcImage constant 2018-07-28 allenwebb service_constants: Added constant for IsUsbguardEnabled dbus method. 2018-07-26 benchan cros-disks: remove unused kDriveIsRotational constant 2018-07-26 benchan cros-disks: add constant for IsAutoMountable property Created with: roll-dep src/third_party/cros_system_api Change-Id: I766e02d42e2e6a2afe9195ba255a98db214810eb Reviewed-on: https://chromium-review.googlesource.com/1157953Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#579713}
-
Christopher Cameron authored
This is not an appropriate long-term solution, but is a solution that has a minimal diff and can be merged fairly easily. The appropriate fix is to: - make BridgedNativeView have a DisplayLink - update that DisplayLink when the NSWindow is moved between monitors - ensure that the VSync parameters are updated "reasonably frequently" to avoid skew - RWHVMac will poke the DisplayLink every time the renderer displays a new frame - at each poke, the DisplayLink will update its parameters if it has not done so in the last 10 seconds - this scheme will need to be revisited both for BridgedNativeView (because it rarely gets new frames compared to the renderer) and for OOP-D (because RWHVMac will no longer be informed of frames) Such a fix is a bigger undertaking than should be merged to a branch, so just push the VSync parameters from RWHVMac (that we would ordinarly send to the web-contents-only ui::Compositor) to the parent ui::Layer's compositor instead. This will only "fix" windows that have web contents in them (which is almost everything that will have an animation). Bug: 869129 Change-Id: Ie5949798aa4d1f42e73197326bca5e6e574f0843 Reviewed-on: https://chromium-review.googlesource.com/1157027Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#579712}
-
Hayato Ito authored
Add FlatTreeTraversal section. TBR=rakina Bug: 742715 Change-Id: I42cee6b8940f07cd65adb1932de59c844fcdace1 Reviewed-on: https://chromium-review.googlesource.com/1158084 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#579711}
-
Ramin Halavati authored
Preferences defined in: 'components/component_updater/pref_names.h' are removed from the persistent storage list for incognito mode. This means that after this CL, these preferences are only stored in memory in incognito mode. Bug: 861722 Change-Id: I390ffc5b63aff52d197cd0ad1ef47a6b6b4c683c Reviewed-on: https://chromium-review.googlesource.com/1145269Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579710}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c5287309..54af9559 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I37d32f5dcc230070e173e3adffc4c0d49ccf8fc4 Reviewed-on: https://chromium-review.googlesource.com/1157905Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579709}
-
Matt Falkenhagen authored
The comment is obsolete. "current architecture" meant pre-PlzNavigate. Bug: 789577 Change-Id: Ib53714275a7f54503e415f3a1986cb2f498dd37d Reviewed-on: https://chromium-review.googlesource.com/1156184 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#579708}
-