GitLab

Since MediaCodec::release() can hang, this CL moves more cases of
it to a separate thread when needed.  Previously, we did this only
during AVDA destruction.  This CL adds support for other cases in
which we replace or clear |media_codec_|.

BUG=613238

Review-Url: https://codereview.chromium.org/2116573002
Cr-Commit-Position: refs/heads/master@{#403345}

BUG=

Review-Url: https://codereview.chromium.org/2029343002
Cr-Commit-Position: refs/heads/master@{#403344}

This jar is a dependency for Robolectric 3.0.

BUG=522043

Review-Url: https://codereview.chromium.org/2045583006
Cr-Commit-Position: refs/heads/master@{#403343}

The notifications are shown at most once per hour, or whenever the severity of the notification changes.

BUG=622590
TEST=./out/Release/unit_tests --gtest_filter=LowDiskNotificationTest.*

Review-Url: https://codereview.chromium.org/2082363004
Cr-Commit-Position: refs/heads/master@{#403342}

This jar is a dependency for Robolectric 3.0.

BUG=522043

Review-Url: https://codereview.chromium.org/2047843002
Cr-Commit-Position: refs/heads/master@{#403341}

BUG=624958
NOTRY=true

Review-Url: https://codereview.chromium.org/2113813003
Cr-Commit-Position: refs/heads/master@{#403340}

App information is a subset of system information, so link both
to chrome://system

BUG=b:29875183

Review-Url: https://codereview.chromium.org/2114573002
Cr-Commit-Position: refs/heads/master@{#403339}

We were previously declaring two different classes with the name
blink::TestExtraData, which is an ODR violation. As it happens,
their implementations compiled to the same machine code, which
allowed the tests to pass in most normal circumstances. However,
the ODR violation causes test failures in CFI mode (e.g. [1]) as a
result of stricter type checking. The fix is to move both classes to
an anonymous namespace which makes them internal to their TUs.

[1] https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux/builds/5924/steps/webkit_unit_tests/logs/WebURLResponseTest.ExtraData

BUG=464797
R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2119683002
Cr-Commit-Position: refs/heads/master@{#403338}

- Before, deepActiveElement() returned the deepest shadow root's
activeElement. Now, it returns the deepest activeElement (which may not be in
the deepest shadow root)
- Buttons 'Add pattern', 'Add custom device', 'Add custom profile' in the
Blackboxing, Devices, and Throttling settings tabs now have default focus
- Now that Dialog's keydown handler is on the body, pressing Esc now closes the
settings dialog, even after the document blurs

BUG=614902

Review-Url: https://codereview.chromium.org/2094873002
Cr-Commit-Position: refs/heads/master@{#403337}

The MR dialog will always be opened when starting a PresentationRequest,
even if there are no sinks that support the presentation url.  The
default cast mode will then be some form of mirroring.  This means that
whether the user selects a device in the dialog or not, the promise from
start() will be rejected with an AbortError.  Instead, a NotFoundError
should be used if there were no devices which supported the presentation
url.

BUG=621161

Review-Url: https://codereview.chromium.org/2108973002
Cr-Commit-Position: refs/heads/master@{#403336}

This reverts commit 9a07dc6b. Broke styling of
paper-item.

BUG=624680
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2119733002
Cr-Commit-Position: refs/heads/master@{#403335}

Enables using NV12 textures as video decoder picture buffers on systems
where that's supported - those that use D3D11 video decoding, support
NV12 texture sharing, and can use NV12 as video processor outputs.

The additional copy uses extra power over the new zero-copy DXGI path,
but should work on systems where that hits driver issues, either due to
sharing of the decoder device with ANGLE or with using decoder output
textures as shader resources.

BUG=574292

Review-Url: https://codereview.chromium.org/2111043002
Cr-Commit-Position: refs/heads/master@{#403334}

BUG=b:29824233

Review-Url: https://codereview.chromium.org/2109213004
Cr-Commit-Position: refs/heads/master@{#403333}

Using update-w3c-deps in Chromium 7b1c45ee.

BUG=

Review-Url: https://codereview.chromium.org/2113733002
Cr-Commit-Position: refs/heads/master@{#403332}

Implement BroadcastChannel as specified in https://html.spec.whatwg.org/multipage/comms.html#broadcastchannel

BUG=161070

Review-Url: https://codereview.chromium.org/2004643002
Cr-Commit-Position: refs/heads/master@{#403331}

BUG=None

Review-Url: https://codereview.chromium.org/2107573002
Cr-Commit-Position: refs/heads/master@{#403330}

This allows Chrome to render at the native resolution on each display on
Windows 10.

BUG=426656,624672

Review-Url: https://codereview.chromium.org/2114503002
Cr-Commit-Position: refs/heads/master@{#403329}

In line with
https://security.googleblog.com/2015/10/sustaining-digital-certificate-security.html
this CL requires that all Symantec-issued certificates
after 1 June 2016 be CT qualified, as defined by the
Certificate Transparency in Chrome Policy -
https://www.chromium.org/Home/chromium-security/certificate-transparency

Any certificates that are not CT qualified will cause
an interstitial with ERR_CERTIFICATE_TRANSPARENCY_REQUIRED.

BUG=620178

Review-Url: https://codereview.chromium.org/2109913004
Cr-Commit-Position: refs/heads/master@{#403328}

Introduces a new RuntimeEnabledFeature "MediaSourceNewAbortAndDuration"
which enables new behavior corresponding to the recent MSE spec change
[1], fixing cross-platform spec ambiguities. New behavior:
* abort() gives error if there is a remove() in progress. abort() is
  intended to only abort in-progress appends, not removals.
* setting MediaSource.duration to a value which would truncate currently
  buffered media will now result in error. Apps can use explicit
  remove() to perform the desired buffered media truncation prior to
  lowering the duration.
Note that both of these behavior changes are intended to fix
previously ambiguous spec text related to asynchronous range
removals. There is no other strong reason why these two behavior
changes are included in the same CL (other than to reduce some
process redundancy.)
If "MediaSourceNewAbortAndDuration" is not enabled, then the old
behavior remains along with emission of new deprecation messages.
This change only enables that flag in 'experimental' status (see [2]).

Intent to implement thread is at [3].

[1] https://github.com/w3c/media-source/pull/65
[2] http://www.chromium.org/blink/runtime-enabled-features
[3] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oboI-rINUt0

BUG=623729,398130
TEST=Updated many of http/tests/media/media-source/* and added SBSTest.GetHighestPresentationTimestamp
R=chcunningham@chromium.org, dcheng@chromium.org, holte@chromium.org, tkent@chromium.org

Review URL: https://codereview.chromium.org/2102323002 .

Cr-Commit-Position: refs/heads/master@{#403327}

SM_CXSIZEFRAME from GetSystemMetrics is based off of the primary monitor's DPI.
GetSystemMetricsForHwnd accounts for the system metrics taking into account the
DPI of the HWND.

BUG=426656

Review-Url: https://codereview.chromium.org/2110323002
Cr-Commit-Position: refs/heads/master@{#403326}

CompositorViewHolder hides keyboard on switching tabs. We found that it
is causing a StrictMode violation error in KK (due to a flaw in Android
framework).

But CVH removes ContentView, which eventually calls
ImeAdapter#onViewFocusChanged(false) and then we hide the keyboard anyways.

Therefore, removing the redundant code from CVH and adding a test to
future-proof the behavior.

BUG=623256
TBR=dtrainor@chromium.org

Review-Url: https://codereview.chromium.org/2108203003
Cr-Commit-Position: refs/heads/master@{#403325}

This CL adds the implementation and tests for GetServiceRecords.
The DBus API used here is out for review at,
https://chromium-review.googlesource.com/#/c/354473/

R=mcchou@chromium.org, xiyuan@chromium.org
BUG=619699

Review-Url: https://codereview.chromium.org/2102093003
Cr-Commit-Position: refs/heads/master@{#403324}

BUG=624626
R=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2119643002
Cr-Commit-Position: refs/heads/master@{#403323}

Transformed content is snapped to pixel boundaries to reduce aliasing
so we need to pixel snap the paint offset transform created before
transform paint property nodes. Any leftover subpixel value is analagous
to the subpixel accumulation on PaintLayer.h and is passed through to
the transformed content.

Review-Url: https://codereview.chromium.org/2112753002
Cr-Commit-Position: refs/heads/master@{#403322}

http://crrev.com/2008913002 replaced the unrenderable case with an
assert, on the assumption that higher-level logic should ensure a
renderable rrect.

But in certain cases we compute the background rrect by shrinking the
border rrect - and this can yield degenerate/unrenderable results when
some radii are not large enough to accomodate the requested inset.

E.g.

 width: 100
 left radius: 0
 right radius: 100
 border-width: 10

We attempt to inset and shrink all radii by 5 (half border-width), but
we can only reduce the right radius since the left one is already zero.
So we end up with

 width: 90
 left radius: 0
 right radius: 95

which is not renderable.

This CL restores the clip-based fallback for unrenderable rrects.

BUG=614825
R=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2112643002
Cr-Commit-Position: refs/heads/master@{#403321}

This is a preparation step to migrate away from WTF::String in v8_inspector.
To avoid copying the global, this patch moves V8DebuggerScript to the heap.

BUG=580337

Review-Url: https://codereview.chromium.org/2104063002
Cr-Commit-Position: refs/heads/master@{#403320}

Incorporate comments in Dbus code and add Eol icon

BUG=611816
TEST=manual and browsertest
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2081873002
Cr-Commit-Position: refs/heads/master@{#403319}

BUG=620462

Review-Url: https://codereview.chromium.org/2114453005
Cr-Commit-Position: refs/heads/master@{#403318}

BUG=622468,605761

Review-Url: https://codereview.chromium.org/2096363003
Cr-Commit-Position: refs/heads/master@{#403317}

- Renamed PresentationModeController to FullscreenToolbarController
- Removed Lion fullscreen methods
- Updated comments and variable names

BUG=579259

Review-Url: https://codereview.chromium.org/2110983002
Cr-Commit-Position: refs/heads/master@{#403316}

Whenever user tries to extend an existing text selection by dragging the mouse
(left button hold) with shift key pressed, Blink enters drag-n-drop mode.

This behavior does not match common editing behavior out there, including other
engines' (WebKit, Gecko/Firefox, Opera/Presto and IE).

Patch changes Blink so that whenever one extends a selection with mouse
and shift key pressed off of a #text node, it does not enter drag-n-drop mode.

Additionally, patch also adds some further tests to ensure that when
selection is extended off of either a link or an image, drag-n-drop does
get triggered, no matter if shift key is pressed.

Associated WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=155314.

BUG=142023

Review-Url: https://codereview.chromium.org/2048733002
Cr-Commit-Position: refs/heads/master@{#403315}

The toolbar action for Media Router has a context menu option to "Remove from
Chrome...", which doesn't show a confirmation dialog like other extension icons
with the same option do (and ellipsis usually suggests a confirmation). Also,
since the removal merely removes the icon and none of the MR functionalities,
the use case is different from the removal of other extensions on the toolbar.
This CL replaces the text with "Remove icon".

BUG=624104

Review-Url: https://codereview.chromium.org/2112623002
Cr-Commit-Position: refs/heads/master@{#403314}

ash::Shell still calls ShellDelegate::CreateMediaDelegate.

BUG=619636
TEST=Compiles; unit tests; no behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2113023002
Cr-Commit-Position: refs/heads/master@{#403313}

Foreign fetch used to completely ignore the skipServiceWorker flag. Just skipping
foreign fetch whenever skipServiceWorker is true would not be correct as the flag
is both set in situations where a request needs to bypass service workers, but
also when the renderer doesn't believe the client making the request is controlled
by a service worker. In that second case foreign fetch would still need to process
the request.

To fix this, this changes skipServiceWorker to an enum with three states, in
order to distinguish between skipping all service workers (for CORS preflight,
dev-tools skip service worker, force-refresh, etc) and skipping just the
controlling service worker.

This also makes sure that (for now) any request that requires a CORS preflight
will not get intercepted by foreign fetch.

BUG=540509,604084

Review-Url: https://codereview.chromium.org/2105503002
Cr-Commit-Position: refs/heads/master@{#403312}

Since the window can be dismissed and then reappear, the user needs more
context.

BUG=b/29439306
TEST=simulated a failure, saw the new strings

Review-Url: https://codereview.chromium.org/2111283002
Cr-Commit-Position: refs/heads/master@{#403311}

For HW encoders, we discovered deadline_utilization is not an
appropriate benchmark metric; and we plan to test a few alternatives.
Before landing those code changes, this change renames the variables and
cleans up comments to reflect the new more-abstract meaning.

R=xjz@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2103043005
Cr-Commit-Position: refs/heads/master@{#403310}

BUG=

Review-Url: https://codereview.chromium.org/2104413002
Cr-Commit-Position: refs/heads/master@{#403309}

Since we now route Gesture events directly to the guest renderer, there
is no longer any event to focus the BrowserPlugin in the embedder
renderer, meaning that even though touch/gesture events work properly,
the guest may not receive keyboard input.

This CL provides a temporary fix by sending a synthetic GestureTapDown
to the embedder on TouchStarti, in parallel with sending the TouchStart
directly to the guest. The synthetic event focuses the BrowserPlugin.

This CL also fixes two tests that were still sending Gestures to the
embedder.

When BrowserPlugin is removed, this code will disappear along with
RenderWidgetHostViewGuest.

BUG=619906
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2101663002
Cr-Commit-Position: refs/heads/master@{#403308}

This enables us to keep track of how often WebAPKs are launched from a
notification vs from the home screen.

BUG=623216

Review-Url: https://codereview.chromium.org/2094113002
Cr-Commit-Position: refs/heads/master@{#403307}

chrome_browser_ui_ash_non_chromeos was
already removed from .gypi files by an earlier patch.

BUG=

Review-Url: https://codereview.chromium.org/2087373004
Cr-Commit-Position: refs/heads/master@{#403306}