- 06 Mar, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e68767e2fe2..0668403dfdd6 git log 7e68767e2fe2..0668403dfdd6 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 sergiyb@chromium.org Also redirect stderr from the browser since Chrome recently started using it too Created with: gclient setdep -r src/third_party/depot_tools@0668403dfdd6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If6a08283417a5f61fbe48987c0ebe5e417b6c53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638213}
-
Tien Mai authored
- Linked agains gdi+ to use their image converting tools. - Now when downloading the profile picture, the largest downloaded picture will also be converted into .bmp and saved into the same directory. - Override the GetBitmapValue of the credential to read this bmp file and return it. Bug: 936847 Change-Id: Ie36b99e167c828ed7b46b88c400465f5fca44fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497192 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#638212}
-
Jarryd authored
The purpose of this change is to make it easy to reason about the thread safety of QuotaTemporaryStorageEvictor. Change-Id: I6dc9c684f9e1d0c70a8f8703ed2e7ac5ec8bd15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503901Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638211}
-
Sami Kyostila authored
Some of the tasks are posted before native is initialized. In order to read the flag value before native is initialized we make use of FeatureUtilities. This patch just adds the flag, there will be many follow ups making actual use of it. Original patch by Carlos Caballero <carlscab@google.com>. Bug: 863341 Change-Id: If95542568c9074b9031250fb7c702aaf033114c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503416Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#638210}
-
chrome://autofill-internalsAnne Lim authored
Created a page which is empty for now, but will be used to help diagnose tricky Autofill bugs. Bug: 928595 Change-Id: I841a568eaeb24d312c26965d52265b948be7a1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497283Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#638209}
-
Karolina Soltys authored
I created a new class, BrowserThreadUtils, in content_public/browser. It has all of the functionalities of base/ThreadUtils that we want to retain, but uses PostTask. Running blocking tasks has been moved to a new class TestThreadUtils, because it is not supposed to be used by production code. This is part of an ongoing effort to unify Java and C++ scheduling: http://go/migrating-threadutils-to-posttask Bug: 863341 Change-Id: Id7da815b63dd2f5c57b01a093401e1c73a5d57db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489243 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638208}
-
Stephen Martinis authored
Most of these merge scripts lived in tools/build. These are moving source side so that: * Devs can find it easily * Tryjobs can test changes to it * Different trigger scripts can share and re-use code Bug: 928577 Change-Id: I6a78164a3b5dfe142983ec111756bd60f838b2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479171Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#638207}
-
Martin Robinson authored
When using WORD_BOUNDARY, the boundaries are defined by the start of the word and then the start of the next one (including whitespace in between them). Have SENTENCE_BOUNDARY work similarly including inside a sentence all punctuation and whitespace before the start of the next one. This is what ATK expects. Bug: 866337 Change-Id: I4abcda7f70756bf34dcb9dc91941a6bd64f8f8ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476992 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#638206}
-
Adam Langley authored
Change-Id: Iad0ce2343f2ce115a0f8539f9cce5dfc8f9ffc8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496235 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam (slow; perfing) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#638205}
-
Varun Khaneja authored
Change-Id: Icb99781d30ec3561f9e2fbde67d9abf8c6aa663b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505842 Commit-Queue: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#638204}
-
Elly Fong-Jones authored
Bug: 780980 Change-Id: Icc5248b5f37b6c8bb2605a88016a523a5e8fb756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1457096Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638203}
-
Antonio Gomes authored
R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I52b5eba4ca69746597318b84f5499bb0fdb93ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506152 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638202}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c854c371c89b..5abc126b0795 git log c854c371c89b..5abc126b0795 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 fmayer@google.com Use emplace_back over push_back to support unique_ptr. Created with: gclient setdep -r src/third_party/perfetto@5abc126b0795 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I710f940a12279f7e953c9ec0344b734d29b19dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505856Reviewed-by:
-
Stepan Khapugin authored
This is useful when you only have the shortcuts, but no results, and you can't see them all (in landscape). Bug: 931210, 906054 Test: 1. Enable Shortcuts flag. Navigate to any URL. Scroll the popup area. Keyboard should be dismissed. 2. Same steps, but clear the text field (see issue 906054) before scrolling. The omnibox should be empty, the Cancel button should be visible, the keyboard should be dismissed. Change-Id: Ibd1637d17536e13352ec0a3b1f872b6df8aed714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491272 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#638200}
-
Ethan Jimenez authored
1. Implementing `ShowContextMenu`, which is the only method that should be provided for the `IRawElementProviderSimple2` interface. 2. Adding cross-platform browser test for the `kShowContextMenu` action. Unit tests for `IRawElementProviderSimple2::ShowContextMenu` and its error handling are introduced in `AXPlatformNodeWinTest`. 3. Replacing `long` type definitions with `LONG` for consistency with the rest of the code in `AXPlatformNodeWinTest`. 4. Refactoring `AXPlatformNodeWinTest::InitListBox` to match other similar helper methods in `AXPlatformNodeTest::BuildListBox`. Bug: 847971 Change-Id: I3d42421c119c41c6fae68eebc813a3e6a67558ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493815Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#638199}
-
Long Ly authored
The issue is that session->capabilities is not available W3C mode since it was moved to 'body' object when session is initiated. Therefore, when GET /sessions is called, session->capabilities will trigger errors. Bug: chromedriver:2798 Change-Id: Ifc7dbc69d00485a53a150a96a7b6c94b9578bdb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504760Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Long Ly <loly@microsoft.com> Cr-Commit-Position: refs/heads/master@{#638198}
-
Nicolas authored
Bug: 934992 Change-Id: I1a16b600e4ccbe5d690d0e8a433da97c427e6351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504263 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#638197}
-
Ovidio Henriquez authored
This change adds the ability for device_unittests to run with resource strings in order to test the BluetoothDevice::GetAddressWithLocalizedDeviceTypeName() method. Bug: 506415 Change-Id: I598181822d5b7101b6f2a3dc04d7e39a605c87f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497323Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#638196}
-
Colin Blundell authored
This CL takes a step toward the elimination of FakeAccountFetcherService by eliminating the need for it to override AccountFetcherService network fetches with a do-nothing implementation. In a testing context, AccountFetcherService does not do network fetches by default. One somewhat-surprising consequence of this policy is that refresh token revocation does not result in AccountTrackerService firing the corresponding expected notification that the account was removed. Some tests *require* that flow to work as expected in order to be able to test their clients' production flow. In order to facilitate such tests, AccountFetcherService has a testing method that enables network fetches. This method is typically used by tests in conjunction with a FakeAccountFetcherService instance, which subclasses AccountFetcherService and overrides the methods that do the actual network fetches to do nothing. As detailed in crbug.com/935998, we are looking to eliminate FakeAccountFetcherService. This CL changes the way that the above flow works: instead of these tests enabling network fetches and then using FakeAccountFetcherService to short-circuit out of the actual network fetches, AccountFetcherService now provides the facility to simply enable processing of account removal for tests. That is in fact all that these tests need. We can then eliminate the overrides of the above-mentioned methods in FakeAccountFetcherService, moving one step closer to FakeAccountFetcherService not being necessary. The one necessary usage of AccountFetcherService::EnableNetworkFetchesForTests() is in the AccountTrackerService unittest. Here this usage is deliberate as the test in fact tests the actual interaction with the network, supplying a TestURLLoaderFactory to the production AccountFetcherService instance that it uses. This CL adds comments to the two testing methods to clarify when to use one vs. the other. TBR=sdefresne@chromium.org Bug: 935998 Change-Id: I5106a85cf20874b48aa38bc3935df9a08018ea72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489241Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638195}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b085fa9c8c19..cb4eb612f02f git log b085fa9c8c19..cb4eb612f02f --date=short --no-merges --format='%ad %ae %s' 2019-03-06 kjlubick@google.com [canvaskit] Remove additional copies of CanvasKit when testing 2019-03-06 borenet@google.com [infra] Remove bookmaker bots 2019-03-06 reed@google.com change gm to use srgb (not linear) so srgb and legacy draw the same 2019-03-06 jvanverth@google.com Fix stencil setup in Metal 2019-03-06 kjlubick@google.com [canvaskit] Add particles integration Created with: gclient setdep -r src/third_party/skia@cb4eb612f02f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Iaa0424baaa2fd46ee4f7dd448a58bef96c290f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505980Reviewed-by:
-
Lorne Mitchell authored
There are severals places in the DevTools frontend UI where we need to update existing strings to ensure that they are localizable. 1. Updated strings that are conditionaly plural into their singular and plural forms. 2. Updated strings that use concatenation to instead use variable substitution. 3. Fixed a couple other minor issues. Regarding the use of variable substitution instead of concatenation. Consider: Common.UIString(palette.colors[i] + '. Long-click to show alternate shades.'); Here, the location of the color isn't captured, instead the actual hex value is. What we really need is a string with a marker for the variable substitution. Instead, we should do the following: Common.UIString('%s. Long-click to show alternate shades.', palette.colors[i]); Or, ls`${palette.colors[i]}. Long-click to show alternate shades.`; Change-Id: Ica7253f7c69e9a2478452d0a944147680b4ca8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504254 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#638193}
-
Henrik Boström authored
Based on https://github.com/w3c/webrtc-pc/pull/2112. Bug: 937844 Change-Id: I7ad149f47fb394f15055cc8fd77e79b4e5e0f317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499613 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#638192}
-
Daniel Bratell authored
Code generated by grit depends on //base (base/stl_util.h) so the build target will need to depend on //base as well. Found when gn check was taught to look at generated files and not just at files in the source tree. Bug: 938933 Change-Id: I566d8c1f0c6b8d16ec21eb7cc864f86b4ed08370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505943 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#638191}
-
Lucas Tenório authored
This feature is already mostly renamed but unfortunately the tests lagged behind in the migration. Bug: 933530 Change-Id: Iae6114bb33f9ae8372f729bbb1777565795f00cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496216 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#638190}
-
Tomasz Wiszkowski authored
This change will allow us to share feature flags currently defined explicitly for CrOS omnibox (kEnableZeroStateSuggest in particular). Change done to avoid cluttering ash with unnecessary code, and to prevent pollution of flag namespace with duplicates that aim at achieving same goal. Reasoning behind the change: 1. create a shared space for flags used by the omnibox and the CrOS launcher. 2. Move the kEnableZeroStateSuggest flag into components/omnibox/common/omnibox_features. 3. Reference kEnableZeroStateSuggest in Android code. Bug: 934922 Change-Id: Ib920f3a0616cf1b1e54399a27af656da6ba74a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484856 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638189}
-
sczs authored
- InfobarCommands will be used by the LocationBar badge button to communicate with the InfobarContainer and display the InfobarModal whenever the button is tapped. Bug: 911864 Change-Id: Ib0126ce8d8de9378d91606f9a76855ff882cbc9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500605 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638188}
-
Peter E Conn authored
Bug: 938836 Change-Id: I389403bd798e1712441acdba149d1941f4881da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506079Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#638187}
-
Long Ly authored
By default, all commands are accessible. However, once user specifies session in W3C mode, all JWP commands will return as "Unknown Command". Other commands such as "unknown origin", "ChromeDriver extentions" won't be affected by the PR since they are used by Selenium binding and internal python tests. Bug: chromedriver:2060 Change-Id: I1e09fd6f06e290f374ffde5bc3507defe9fb52cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504977Reviewed-by:
-
Nicolás Peña Moreno authored
This CL adds code in LayoutSVGImage::WillBeDestroyed to notify ImageElementTiming, similar to how it's done in LayoutImage. This should prevent null dereferences in ImageElementTiming. Bug: 879270 Change-Id: Idac6339b548ae59f971861a76367c082e55ca87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506100Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#638185}
-
Eyor Alemayehu authored
This is a flag guarded feature for sending the screen context as a text query. For more information, see go/screen-context-dialog. Bug: b:123037261 Change-Id: Ibf6315450aad2f7ab89b04c37c47684e76be82f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493371 Commit-Queue: Eyor Alemayehu <eyor@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#638184}
-
Arthur Hemery authored
This patch reintroduces DidCommitProvisionalLoadInterceptor (removed in https://chromium-review.googlesource.com/c/chromium/src/+/1455470), renamed as DidCommitNavigationInterceptor, to work with the new NavigationClient interface. It does so by adding an interceptor to the RenderFrameHostImpl, called directly after entering the callback. Bug: 784904 Change-Id: I7cbba4e9220017625676c7679c8606ad425712e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477028 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638183}
-
Cathy Li authored
Bug: 937430 Change-Id: Ibf7ac59bb75ba37c4bfca66bd55211b9cf01071e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492934 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638182}
-
Roman Sorokin authored
Suppored on Chrome OS, Linux and Mac OS only. Related CL:1479962 BUG=chromium:930019 TEST=newly added tests Change-Id: I51933d47625f4cb19f006dad5218658d0d484280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486331Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638181}
-
arthursonzogni authored
This is a continuation of: https://chromium-review.googlesource.com/c/chromium/src/+/1503133/5 where the condition before running |MaybeCreateLoaderForResponse| was removed by mistake. This restores the condition and adds an explanation about why it is useful. Bug: 873269 Change-Id: Ieda17fca7baacfeec00468e01eb67332802ee905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505938Reviewed-by:
-
Nikita Podguzov authored
Bug: 848942 Change-Id: Icf6d930686264edf14970d38f58485c4310f5ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474750 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638179}
-
Anders Hartvoll Ruud authored
This CL implements the syntax string parser according to the new spec. The parser operates on the "preprocessed input stream" described by css-syntax, and while it reuses some algorithms used by the tokenizer, it does not rely on actual tokens. Overview of this CL: * Added CSSSyntaxStringParser, which can parse the syntax string into a CSSSyntaxDescriptor. Usage: auto descriptor = CSSSyntaxStringParser("<color>").Parse(); * The previous syntax string parser functions were mixed together with functions for parsing a token stream against a registered syntax, which was a little confusing. Hence this CL splits the syntax string parsing into a separate class. * Moved a few parser algorithms from CSSTokenizer to css_parser_idioms, to make them usable without a tokenizer. * Unit tests: there is some overlap between the unit tests and WPT. However, the unit tests can (and do) check the resulting internal structure of the CSSSyntaxDescriptors, so they do add additional value over just WPT. R=futhark@chromium.org, ikilpatrick@chromium.org Change-Id: I2d671ca0e58cd123a7809a24a4e83aec3883b175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503755Reviewed-by:Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#638178}
-
Lukasz Anforowicz authored
Bug: 938589 Change-Id: I400f8421ad95e14f781bc6555dd185898d19faa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506101Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#638177}
-
Mike Reed authored
This flag unleashes changes to how skia blits into colorspace-tagged surfaces. The gist is that we try harder to stay in the legacy code-paths (for speed), even though those might differ from the more correct rasterpipeline path. Thus we can expect to see some image diffs with this CL, but in general they should be very small. Change-Id: I2441fe0249d4d358ea5adb844bcdbbeffd3baa07 Bug: skia:8793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496304 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#638176}
-
Alexandre Frechette authored
Bug: 850947 Change-Id: I4745016ce722df5d2664215b16a5ab2a2ab69150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505999 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#638175}
-
David 'Digit' Turner authored
This CL reduces the size of each base::Value instance by carefully controlling the layout of the internal tagged union declared by the class, i.e.: - Moving the |is_alive_| field just after the |type_| one, and changing their sizes to 24 and 8 bits respectively. - Using a union of anonymous structs to control the padding of |double_value_| relative to the start of base::Value. See the technical note in base::Value's declaration for more details. This saves 8 bytes on x86, x86_64 and arm64, and 16 bytes (!) on arm. Comparisons of size/alignment pairs for various data types: arm arm64 x86 x86_64 double 8/8 8/8 8/4 8/4 std::string 12/4 24/8 12/4 24/8 ListStorage 12/4 24/8 12/4 24/8 DictStorage 12/4 24/8 12/4 24/8 BlobStorage 12/4 24/8 12/4 24/8 Value (before) 32/8 40/8 20/4 40/8 Value (this CL) 16/8 32/8 16/4 32/8 + Add a unit-test to check that we don't regress in the future un-intentionally. BUG=646113 R=dcheng@chromium.org, pasko@chromium.org, lizeb@chromium.org, mattcary@chromium.org, jdoerrie@chromium.org Change-Id: I46b95f4478cc0a6978968fc1a877b5a92937352c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472716 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638174}
-
