- 28 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/923c30fba116..625f5b2fbd89 git log 923c30fba116..625f5b2fbd89 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 jmadill@chromium.org Cleanup angle_libs_suffix in BUILD.gn. Created with: gclient setdep -r src/third_party/angle@625f5b2fbd89 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I6b55444c19af2b6d7d38f2d86cc99b571874e86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673311}
-
Boris Sazonov authored
Change-Id: I789945c4befe43d2a44bbc6959e2873528f6ca4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680619Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#673310}
-
Kurt Horimoto authored
BrowserViewController.currentWebState is not guaranteed to be non-nil, so the OverscrollActionsTabHelper should not be accessed without checking the WebState first. Bug: 978008 Change-Id: Ic0fd90219c130d704d21d49debf7584982fc9afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674884 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#673309}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It adds OAuth2AccessTokenManager::Delegate::OnAccessTokenInvalidated() and ProfileOAuth2TokenService that inherits from OAuth2AccessTokenManager::Delegate implements it. Bug: 967598 Change-Id: Ifb1b27ff9d1c798223fa03cb48f5f4d293acaa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680269Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#673308}
-
Sergey Poromov authored
TBR=miu@chromium.org Bug: 974427 Change-Id: I6494184be2bca254d5cf240572cf7e1d33978142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681888Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#673307}
-
Colin Blundell authored
In preparation for the code restructuring of //components/signin, this CL moves mutable_profile_oauth2_token_service_delegate* from the //components/signin/core/browser target to the //components/signin/core/browser:internals target where it belongs. This change has the ripple effect of requiring //components/signin/core/browser/webdata to be separated out of //components/signin/core/browser in GN, as MutablePO2TS depends on the webdata. That change is also conceptually correct as webdata is conceptually layered below all of the rest of //components/signin. Bug: 952788 Change-Id: I309512f4904157b1881ec9860bdec2c17f371245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681701Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#673306}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b851469b8e96..afd2c10c989c git log b851469b8e96..afd2c10c989c --date=short --no-merges --format='%ad %ae %s' 2019-06-28 fmalita@chromium.org [skottie] Use hybrid bounds for custom Shaper VAlign modes 2019-06-28 fmalita@chromium.org [skottie] Use explicit font ascent in Shaper Created with: gclient setdep -r src/third_party/skia@afd2c10c989c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=djsollen@google.com Change-Id: I97e1ee26d55385a96bd00bf00a5e1978eab774c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680836Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It adds OAuth2AccessTokenManager::Delegate with CreateAccessTokenFetcher(), FixRequestErrorIfPossible(), and GetURLLoaderFactory() moved from OAuth2TokenServiceDelegate. OAuth2TokenService implements OAuth2AccessTokenManager::Delegate and be passed to OAuth2AccessTokenManager. OAuth2AccessTokenManager keeps still OAuth2TokenServiceDelegate as it's in the middle of moving the APIs from OAuth2TokenServiceDelegate to OAuth2AccessTokenManager::Delegate. Bug: 967598 Change-Id: I93ca88e49ab6b60a3812e953cd07eb3343762038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677425 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
-
Johannes Kron authored
WebRTC stats PR: https://github.com/w3c/webrtc-stats/pull/450 Bug: webrtc:10775 Change-Id: I9513f99d2f04ed5b876c4298bac923be31ce2f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681704Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#673303}
-
Yuki Shiino authored
Minor refactoring of IdentifierIRMap.find_by_kind. Bug: 839389 Change-Id: I60269a84db28d921d6a0ce8d537e37a623f884d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681721Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#673302}
-
Yutaka Hirano authored
In preparation to removing AddChannelRequest, rename AddChannelResponse to OnConnectionEstablished. OnFinishOpeningHandshake has been confusing because it doesn't mean successful handshake finish (i.e., connection establishment). Rename it to OnResponseReceived. Rename OnStartOpeningHandshake to OnOpeningHandshakeStarted for consistency. Bug: 967524 Change-Id: I629fb5d144c3abe49bfb0fdc3c25ba62b4d26520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680676Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#673301}
-
Alex Ilin authored
The ReachedCodeProfiler feature is controlled by the finch experiment but the feature is in practice enabled with a lag. To track the sessions in which the profiler is actually enabled, we register a synthetic field trial. The one disadvantage of this approach is that the synthetic trial was recorded for 100% of users, making hard the comparison between control and enabled groups. This CL modifies recording of the synthetic trial so that it records the exact finch trial group that was selected in a previous session. Bug: 916263 Change-Id: I7a7668667861175cdc0b2068a99b1fe619dd7c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543398 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#673300}
-
Eugene But authored
Starting from iOS 13, document.write() can change the origin or the URL without calling didStartProvisionalNavigation didFinishNavigation: WKNavigationDelegate callbacks if page is about:blank. This executes code path which changes URL without document change. That code path has DCHECK to verify that origin does not change. This CL relaxes DCHECK to allow origin change on iOS13 if current document URL is about:blank. Bug: 978969 Change-Id: I1435d43e008f9f03c6352b0c39f3acaa941282a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681078 Commit-Queue: Ali Juma <ajuma@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#673299}
-
Eric Stevenson authored
This reverts commit 632c08d1. Reason for revert: Depends on 5a2cccc8, which broke the webrtc roller. Original change's description: > Fix locales for ChromeBrowserTestsActivity. > > Other test activities call setNoAvailableLocalePaks() and the > ChromeBrowserTestsActivity was missed since it is not in the CQ or > waterfall yet. > > This fixes the problem introduced by > https://chromium-review.googlesource.com/c/chromium/src/+/1627638 > > R=sky@chromium.org > > Bug: 961849 > Change-Id: I13f1046068326fc27a1b71410427a73ffdbdd40b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680511 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Eric Stevenson <estevenson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673166} TBR=sky@chromium.org,danakj@chromium.org,estevenson@chromium.org Change-Id: Ic718d4ba741caf82d0a78a1597b25e8bdbbfd432 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681947Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#673298}
-
Edward Jung authored
config Bug: 978002 Change-Id: I5e0500ff1ba385bef86fa19a239c3c2b5a66d96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672862Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
-
Rayan Kanso authored
Bug: 979235 Change-Id: I7f9ddf6c80f0e13707beec1f8827357cf2b21daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680469 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#673296}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b91d18594fa..c272b7eda7b3 Created with: gclient setdep -r src-internal@c272b7eda7b3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=peria@google.com,poromov@google.com,eirage@google.com Change-Id: Ifc422b619fec5f71bb9afad87f0b7d150843748e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681867Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673295}
-
Robbie Gibson authored
This CL adds dark mode support for all the settings submenus except for the collection view cell catalog. It also removes all references to non-dark mode UIColors ios/chrome/browser/ui/table_view/cells except for a few different blues, which will be removed soon. Bug: 976668 Change-Id: Ie2c954dd824cb6739a254cfae9a86d0079285293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672861 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#673294}
-
Alex Clarke authored
(Fix was to make SingleRejectPrerequisitePolicyALLModified not use RunUntilIdle) Original patch: https://crrev.com/c/1640639 The idea (thanks Etienne) is to not retain any prerequisites (including curried ones) until they've settled. This fixes ref counting cycles while ensuring results are retained for dependencies. This patch also changes the way curried promises are handled which was necessary to break refcounting cycles. Now when a promise resolves or rejects with a promise, its dependents are modified to use the curried promise as their prerequisite instead. TBR=fdoray@chromium.org Bug: 968302, 906125 Change-Id: I1532faff6fe4f55dc236210389db62eb6a03212f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680264Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#673293}
-
Alex Chau authored
- This caused EncryptMessage to be called with empty string - Added test to ensure payload in SendWebPushMessage can be decrypted Bug: 966037 Change-Id: Ibb1e3ee41c92ca81c67008878714c4f76f6d2cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679766 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#673292}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/50d40acd7be1..f51c389d79a4 git log 50d40acd7be1..f51c389d79a4 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 khokhlov@google.com Output traces recorded as artifacts in chartjson format Created with: gclient setdep -r src/third_party/catapult@f51c389d79a4 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:972025 TBR=crouleau@google.com Change-Id: Ife54f33a72acae76e01fa673cd7525c357158fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681277Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f32fd633. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." bc7ec548 "MSE: Test addSourceBuffer and changeType relaxed type strictness and allowance for implicit changeType" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I917d6365a368efaa59b7abf8cd66c600ddb9b709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680692Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673290}
-
Mario Sanchez Prada authored
Remove public interface WebDatabaseObserver from blink/public/platform and its implementation at content::WebDatabaseObserverImpl, and move the logic into four additional methods in blink::WebDatabaseHost, along with the methods implemented in CL 1669941 [1], and update clients. Additionally, remove the Platform::DatabaseObserver() method and its specific implementation from RendererBlinkPlatformImpl, as well as any reference to WebDatabaseHost in there, so that we effectively finish Onion Souping WebDatabase out of //content/renderer. [1] https://crrev.com/c/1669941 Bug: 933873 Change-Id: Ib510b8a98d42682eb9f3bf68272fe5aab3d1f193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1675356 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#673289}
-
Javier Ernesto Flores Robles authored
There is no reason to hold the view controller in memory. A new view controller is creater everytime this coordinator presents. Bug: 972093 Change-Id: I4ca9c2cbb8064492791f76cfe2ce7bd8270c9f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680181 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#673288}
-
Anders Hartvoll Ruud authored
It is generally working, with the following omissions: * Unregistering properties is not implemented. This means we can't cascade @property rules. The temporary behavior is that the first @property rule seen wins (forever). It also means mutating the rule via CSSOM is not supported (as it effectively re-registers the property). * TreeScope is ignored (and untested). * CSSPropertyRule::cssText() returns an empty string, for now. Implementing this in a nice way requires a medium-ish refactor, so it's better to do this in a separate CL. Also, in my proposed PR for @property, the CSSPropertyRule interface contains a name, and a CSSStyleDeclaration with the descriptors, and this CL matches that approach. After some GitHub discussion, I expect that this will change such that the CSSPropertyRule contains a name, syntax, inherits (bool) and initialValue instead. I would prefer to make the corresponding change in Blink separately, however. I2I=https://groups.google.com/a/chromium.org/d/msg/blink-dev/qoJkuLOMKqI/I3DGDTCRBQAJ BUG=973830 Change-Id: I813ce53bc279a2c0e40fe6ed3ec6ed3084004d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1303340Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#673287}
-
Fredrik Söderquist authored
This test was updated upstream, and should hopefully no longer exhibit the previous font fallback issue. Tbr: schenney@chromium.org Bug: 978436 Change-Id: I8bb05da8d7d78a928bb1b2dec964c63aaa862aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680267Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#673286}
-
Yuichiro Hanada authored
Android side should wait for completion of all operations, so there is no need to cache the value of composing text. Test: unit_tests --gtest_filter=InputConnectionImpl.* Bug: b/118364941 Change-Id: I87beee3ba6b39618f705aa734974a460a3f9c214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681624 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#673285}
-
Sergey Poromov authored
This reverts commit 44af1fd2. Reason for revert: DefaultKeyboardExtensionBrowserTest.LayoutTest is flaky on linux-chromeos-rel. Bug: 979459 Original change's description: > Plumb resources serviced from memory cache to PLM > > Byte metrics in page load metrics should be indicative of all bytes loaded > by the page. UMA shows that large numbers of resources (~45% of JS > resources) come from the memory cache. To provide a better picture of > everything loaded by the page, we should make memory cache resources > visible to observers. > > This change plumbs information about resources loaded via the blink > memory cache into PageLoadMetrics. This is done though the existing > SendTiming mojo, and these resources are included in the existing > OnResourceDataUseObserved callback for PageLoadMetrics observers. This > was added to the existing interface so that an observer that wants to > look at all bytes loaded on the page does not need to implement two > separate interfaces. > > Because we modify the existing mojo, all existing observers need to be > updated to either discard resources loaded by the memory cache, or need > to have their relevant histograms versioned. > > Observers whose metrics are updated: > - CorePageLoadMetricsObserver > - TabRestorePageLoadMetricsObserver > - MediaPageLoadMetricsObserver > - UkmPageLoadMetricsObserver > > Observers whose metrics would be affected but are modified to ignore > MemoryCache resources: > - ResourceMetricsObserver > - AdsPageLoadMetricsObserver > - DataReductionProxyMetricsObserver > > Only the histograms versioned in this CL should change. For all histograms > not versioned in this change, this should be a no-op. > > Bug: 968141 > Change-Id: I67ed0977f8532616815ba0fbe6e1eb3f3b70e36f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633190 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#672925} TBR=kinuko@chromium.org,bmcquade@chromium.org,csharrison@chromium.org,johnidel@chromium.org Change-Id: I6139ba2fea9b915cff2fdfb143216be14a3ea6e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 968141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681887Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b170a323ac..3b91d18594fa Created with: gclient setdep -r src-internal@3b91d18594fa The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=peria@google.com,poromov@google.com,eirage@google.com Change-Id: I3b43344d51338491504c29cb30ee74efad3edbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681600Reviewed-by:
-
Mario Sanchez Prada authored
As part of the Onion Soup process for WebDatabase, create a new blink::WebDatabaseHost singleton class hosting a mojo::SharedRemote that will be used to communicate directly with the synchronous methods provided by the implementation of mojo::WebDatabaseHost, in the browser process (see content::WebDatabaseHostImpl). This class will now make the Platform::Database*() methods no longer needed, so let's remove those (and their overrides) along with this CL, and update callers in Blink's webdatabase module to rely on this new blink::WebDatabaseHost class instead. Bug: 933873 Change-Id: I159f1f3730c8fa5c17042e07e29d17804af2f049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669941 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#673282}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/120409a9..f5a4989c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I961428ed8679684b2fb912d807e3b637ba8d5fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681420Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673281}
-
Juan Antonio Navarro Perez authored
Sometimes stories get disabled or removed, causing averages to shift due to the different workloads of the stories that remain. This CL specifies a fixed set of stories to use when computing averages over the entire timeseries. Note: To recompute averages for values in the past one needs to remove the file _cached_data/pinboard/aggregated.pkl and run pinboard again. Bug: 958736 Change-Id: I3b5ec9ca57c74f61f16466c387b3b99b6edb687d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680186 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#673280}
-
Maksim Ivanov authored
Add the support of the challenge-response keys to the code that makes MountEx requests to the cryptohomed daemon from the CryptohomeAuthenticator class. This completes the implementation of the most basic scenario of the online smart card based user login. Bug: 826417 Change-Id: I1e543d6521ea9b204b56127634250986b53a6cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678561Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#673279}
-
Pâris Meuleman authored
This reverts commit a1dbeba4. Reason for revert: The root cause was fixed in https://crbug.com/976192#c4 Original change's description: > devtools>Security: Fix display for trusted non-https pages (chrome://) > > This CL is a quick-fix for the issue detailed in the attached bug. > Devtools' Security tab does not handle properly resources from secure, > non-https, origins, this leads to an attempt to display a certificate > that does not exist and a crash (CHECK). The issue stems in Blink, where > the resources' responses (|ResourceLoader|) are not equal to documents' > responses (|DocumentLoader). This response is then handled differently > by the security tab. The solution proposed here addresses the problem on > Devtools UI side by checking the content of the Response's > SecurityDetails. > > Bug: 973744 > Change-Id: I8714f4d30f8a8d42cb54e42347dfcf5ca0c3a9c8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658470 > Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> > Commit-Queue: Alexei Filippov <alph@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#668903} TBR=alph@chromium.org,pmeuleman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 973744 Change-Id: I3f97c03606aae872b397ec381985e062c98af921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676634 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#673278}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/71809c67ce0a..825aad13dcf4 git log 71809c67ce0a..825aad13dcf4 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 nisse@webrtc.org Delete almost all includes of platform_file.h 2019-06-28 nisse@webrtc.org Delete method ReadableWav::Eof, which was used incorrectly. Created with: gclient setdep -r src/third_party/webrtc@825aad13dcf4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6afa928612eeafe9f1c82ad070a8ac0b4c71a9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681652Reviewed-by:
-
Maksim Ivanov authored
Add HTML and JavaScript stubs into screen_gaia_signin for the PIN dialog shown during login. This dialog will, in the beginning, be used for requesting the smart card PIN from the user during smart card based SAML sign-in. This CL alone brings no behavior changes, since it doesn't add any C++-side code that will show the PIN dialog. Bug: 964069 Test: manual Change-Id: I16f29591f54d58750daa467c2191e5bdcc2bf78a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632434Reviewed-by:
-
Lutz Justen authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/33a144a0bdb9..c2d20d35a549 $ git log 33a144a0b..c2d20d35a --date=short --no-merges --format='%ad %ae %s' 2019-06-25 ljusten kerberos: Add modes to ClearAccounts call 2019-06-19 ljusten kerberos: Add KerberosTicketExpiring signal Created with: roll-dep src/third_party/cros_system_api BUG=chromium:952245 TEST=Compiles Change-Id: Icc036c9e787a4ff0a74e87019e924c0af7ef3e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680474Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#673275}
-
Wei Lee authored
This CL fixes the potential memory leaks which introduced by CrosImageCapture API. On CCA side, we use singleton to avoid creating duplicate mojo requests. On Chrome side, we use strong bindings for mojo request so that the interface implementation and the binding will be destroyed once the interface proxy on CCA side is garbage collected. Bug: 978149 Test: Manually Change-Id: Id35ef1fceeb82a4e97085f396583aaec2bf6453b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676044 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#673274}
-
Hitoshi Yoshida authored
In compiling Web IDL, it's a common task to look for an IDL definition with its identifier. And in compiling IDLs, the target definition may change depending on the compilation phase. IdentifierIRMap is a support tool to make it easy to find the target definition(s) in complation. Bug: 839389 Change-Id: I42c4a0cc1730b920eba63418ade7a0bbb185d52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680262Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#673273}
-
Shik Chen authored
Bug: chromium:978149 Test: Open CCA and check it detects webcam plug/unplug events properly. Change-Id: I0943a92269e846f6acafe5a1a27b4af0b0adedf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680725Reviewed-by:
Wei Lee <wtlee@chromium.org> Reviewed-by:
-
