- 04 Nov, 2020 40 commits
-
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604426269-8f05fba2f9491fbe2e5ad2e4e4fb4bee6873c7ad.profdata to chrome-mac-master-1604447854-0203f3947ee8f5c9986d886d20c69f4a07395a41.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4511d1b9653dc2ce26bfa4012aa2492864ea20a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823854}
-
Victor Vasiliev authored
The binary size impact appears to be about 4 kilobytes, which is much less than I've feared. Change-Id: Ib85806f7fffe809f24692f24f3811447b8400c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412627Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#823853}
-
Mei Liang authored
This is a follow up for crrev.com/c/2483031. StartSurfaceLayout implements StartSurface.OverviewModeObserver#finishedShowing and overrides Layout#doneShowing. These two methods have similar names, and doneShowing() depends on finishedShowing(). It is hard to reason about without a dive in investigation. This CL avoids the confusion between these two methods by modifying StartSurfaceLayout to stop implementing StartSurface.OverviewModeObserver. Instead, StartSurfaceLayout instantiates a StartSurface.OverviewModeObserver member and attaches that member instance to StartSurfaceController directly. Change-Id: I5904513b5fcd72fef3b571ecb513c334bd4a2d06 Bug: 1108496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503392 Commit-Queue: Mei Liang <meiliang@chromium.org> Auto-Submit: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823852}
-
Victor Fei authored
Consider the following ax tree and ax positions representing an editable search box <input type="search">: ++1 kRootWebArea ++++2 kSearchBox editable editableRoot=true ++++++3 kGenericContainer ++++++++4 kGenericContainer editable ++++++++++5 kStaticText editable "Hello" ++++++++++++6 kInlineTextBox "Hello" ++++7 kButton ++++++8 kStaticText "X" ++++++++9 kInlineTextBox "X" TextPosition1 anchor_role=inlineTextBox text_offset=5 annotated_text=Hello<> TextPosition2 anchor_role=searchBox text_offset=5 annotated_text=Hello<> Or similarly for <input type="number"> we have similar ax tree: ++1 kRootWebArea ++++2 kSpinButton editable editableRoot=true ++++++3 kGenericContainer ++++++++4 kGenericContainer editable ++++++++++5 kStaticText editable "12345" ++++++++++++6 kInlineTextBox "12345" The above equivalent text positions are at the end of the search box point to the same position in the text field but with different anchors. Calling AXPosition::CompareTo on these positions should return that they are equal. However, CompareTo returns the result that TextPosition1 is logically less than TextPosition2; which is incorrect. This is due to the following: On TextPosition1 anchor_role=inlineTextBox, we have the following call sequence: 1. AXPosition::CompareTo 2. AXPosition::SlowCompareTo 3. AXPositionInstance::CreateAncestorPosition 4. AXPosition::CreateParentPosition 5. AXNodePosition::IsEmbeddedObjectInParent 6. AXNode::IsDescendantOfPlainTextField 7. AXNode::GetTextFieldAncestor In step 4 CreateParentPosition we call IsEmbeddedObjectInParent, but incorrectly evaluates text field's immediate child (generic container, id=3) as embedded object and returns true, due to in step 7 we cannot retrieve the search box node as the text field ancestor. This results in a position with wrong offset created in step 4 CreateParentPosition, and eventually resulting in wrong comparison in step 1 CompareTo. This CL fixes the above issue, by correctly handling search box case in IsEmbeddedObjectInParent. AX-Relnotes: Narrator cursor on Bing.com's search input now properly follows text cursor as backspacing and left/right arrow key is pressed and correctly announcing the correct character. Bug: 1141171 Change-Id: Ic43a5630773bc506d43be1c16499a8b54f3ab4a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504698 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823851}
-
Aaron Krajeski authored
RecordIdentifiabilityMetric used a lambda callback this function and it was not immediately clear that CanvasAsyncBlobCreator could get garbage collected before the callback was run. The garbage collection would free image_ and result in a UAF. Now the callback is in a separate function and the caller is bound to be persistent, matching the pattern of other callback functions in this class. The dispose method also needs to be moved. Prior to this change it was always called before the RecordIdentifiabilityMetric finished. It worked because the callback kept a pointer to the image, that had already been destroyed, a bit of a Mr Burns situation: https://www.youtube.com/watch?v=aI0euMFAWF8 Bug: 1137104 Change-Id: Iccfaf9cc15352ee3b002dad1e4241c0683fbc8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505460Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Yi Xu <yiyix@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#823850}
-
Toni Barzic authored
Moves responsibility for validating that holding space items restored from persistence delegate to file system delegate. The persistence delegate just de-serializes items from the persistent storage and adds them to the model as partially initialized items. File system delegate handles file path validity for non-finalized items, and removes items whose backing file path cannot be found from the model. This results in a simpler restoration flow where file validity checks can be unified. This CL updates the logic for file existence verification when items are restored from persistence to better items from mount points that are not immediately mounted very on startup (for example drive fs). The file system delegate will leave items whose file system URL cannot be resolved in partially initialized state until a mount point that parents the item is mounted. Note that the items will not remain in partially initialized state indefinitely - they will be cleaned up if the volume has not been mounted soon after startup. Renames ScopedTestDownloadsMountPoint into ScopedTestMountPoint and makes is a bit more customizable by tests - for example, enables tests to set up mount point state when the mount point is added to the external mount points. BUG=1140150 Change-Id: I924b9b932039d1f1a1498dc3ce4b73ddeac0ddbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490259Reviewed-by:
Josh Nohle <nohle@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#823849}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7af8df82..f014ab92 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I11d8520ed02ae1bb5b9e3c9c0607571f4f57a78b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518425Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823848}
-
spdonghao authored
Bug: 1143164 Change-Id: Iada70f9d6651de1f0bb2797a65880ec3b4fe41b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511718Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Shimi Zhang authored
Records if a GestureScrollBegin is used as cursor control. Bug: 1126778 Change-Id: Id0e9a8aec1c20f1eaf21d9a44dbfcb622b919fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517900 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823846}
-
Hans Wennborg authored
Otherwise MSan complains about use-of-uninitialized values in the window. This happens in both regular deflate's longest_match and deflate_rle. Before crrev.com/822755 we used to suppress those reports, but it seems better to fix it properly. That will also allow us to catch other potential issues with MSan in these functions. The instances of this that we've seen only reproduce with fill_window_sse(), not with the regular fill_window() function. Since the former doesn't exist in upstream zlib, I'm not planning to send this patch upstream. Bug: 1137613, 1144420 Change-Id: I2b1801cd2a63fef48a0072b2d2c8fc1f8a7bb920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517520 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#823845}
-
Liquan (Max) Gu authored
Changes: * Refactored the PaymentRequest UI showing logic into showAppSelector(). Going forwards, this method will have an interface with PRService and will have a WebLayer counterpart. * Moved the ChromeActivity null-check so that the showAppSelector() and triggerPaymentAppUiSkipIfApplicable() interfaces will not depend on ChromeActivity. Bug: 1144527 Change-Id: I2aedd77f8aa128aee27112fb4f855bd847bf30af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516020 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823844}
-
Evan Stade authored
Bug: 1057099 Change-Id: Iffdc448dcba998cc4b4f3fab3b3f3f9602bdec59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518137 Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#823843}
-
Adam Langley authored
If an FCM transactions triggers but then one happens to plug in a USB cable, the mobile side hits this DCHECK. But it's fine to cancel the FCM transaction if the user has taken action to try another channel. Also, drop the notification if the FCM transaction is deleted. BUG=1002262 Change-Id: I857016e31a0a3d56ee17f54ca4eecb4e6b3f9fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511974Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#823842}
-
Juanmi Huertas authored
Canvas was not able to create a WebGL context when it was a canvas located in a frameless html (as in a template). This CL adds a way for the Html Canvas Element to check the global dom settings. Bug: 1137551 Change-Id: I986cc3ef294cd460b63c46abfeac900cba2bcc35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516884 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#823841}
-
Gayane Petrosyan authored
Starting Android 11, setGravity is a noop for text toasts. Create toast with custom view for cases when setGravity should be called. This is a short term solution as setView is also deprecated. Bug: 1135597 Change-Id: I1dfabad0a9249ee5d8aefa5d5a7c41507007ebac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481242 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#823840}
-
Rafael Cintron authored
Separating the public mojom interface into vr_service and isolated_xr_service components allows us to add dependencies to isolated_xr_service without having a blink variant. The blink variant tends to cause problematic, unresolved externals. Bug: 1141989 Change-Id: I1769d342ccdc1d446485a49d355b1afdf07a74ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518404Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823839}
-
My Nguyen authored
These names are shown in both tray menu and settings page. No point in repeating exactly what the string shows. Cleaning up strings description in preparation for names update in http://go/cros-input-methods following http://go/cros-input-methods-naming proposal Bug: 889763 Change-Id: Ic84230fbf0dab71c8e470643ca24706c2ce943d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518303 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823838}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604350611-23c1a5ed722901de0dc0263a6d25110372347a10.profdata to chrome-win64-master-1604415585-c8905f6123c6046ea03b2e75cc15c5d923d8f1b6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic1451bb285a4d4c813d91a2c754b4734e88a6425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518077Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e7cfaff1817..fbc60b7e9ed2 2020-11-03 egdaniel@google.com Fix viewer last image and zoomer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I034686d3003d788209c58d7ae266657dea6bd84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518930Reviewed-by:
-
Gayane Petrosyan authored
This reverts commit 5d255cb4. Reason for revert: startup.mobile regression Bug: 1143056 Original change's description: > Add share features to testing config > > Add a few share features to the testing config. These features > will be tested in beta soon as the sharing hub is launching. > > Bug: None > Change-Id: I960930af2185b30bb749609084bc1bd76bb03d5d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495403 > Commit-Queue: Kyle Milka <kmilka@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821354} TBR=rkaplow@chromium.org,kmilka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: None Change-Id: I6eab02eb2987264ba11955dcaeda73959402e0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518932Reviewed-by:
-
Victor Costan authored
Before this CL, AppCacheServiceImpl took a QuotaManagerProxy* argument, then stored the value in a scoped_refptr. This CL updates the constructor signature to make it clear that the constructor saves a reference to the QuotaManagerProxy, and propagates this update to ChromeAppCacheService. Change-Id: Iee7d9459e4839a5a0e7b5a454adb593aca2f1e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513231 Commit-Queue: enne <enne@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#823834}
-
mlcui authored
This fixes two issues: - If |has_invalid_dom_key| is set and |item.shortcut_message_id| was missing, the old logic would incorrectly DCHECK instead of displaying the "no mapping" string. - Dynamically changing the length of replacement strings does not change the shortcut message used. This isn't a problem with the current implementation, as the length of replacement strings is static, but may be a problem if replacement strings are dynamically chosen in the future. Change-Id: Idfa355b68e29508125e2278dac83a60f7a215807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513307 Commit-Queue: Michael Cui <mlcui@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#823833}
-
yilkal authored
If access token fetch fails, this cl logs the error and shows the error screen. Bug: 1144327 Change-Id: Ib8c4fbd3226cc05910eb209ba5ead1f47fd097b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511909Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823832}
-
Ahmed Fakhry authored
In this CL, we observe the following events: - A window being recorded gets closed. - A display being fullscreen-recorded gets disconnected. - System shutting down. The above events end video recording. BUG=1142994 TEST=Added new tests. Change-Id: I5f03448d1399297e9589d561d9854b3c8cffc0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516239 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#823831}
-
David Grogan authored
These failed due to firefox and chrome using different default fonts. I avoided that problem by assigning a fixed width to the divs containing the words. These tests now pass when I run them locally in firefox with ./wpt run --binary ~/ff-nightly/firefox firefox css/css-flexbox/gap-006* This was filed in https://github.com/web-platform-tests/wpt/issues/26326 Fixes web-platform-tests/wpt#26326 Change-Id: Ib0795c67bce5f80f7a33e1da74a026c1ed574b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515226Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b5bf82693f85..59eb5dd0e10d 2020-11-03 capn@google.com Set LLVM_ENABLE_ABI_BREAKING_CHECKS for Debug builds only If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1140854 Tbr: swiftshader-team+autoroll@google.com Change-Id: I9b97096aa12031db135e3c855a0eccf8bf9b3dbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518119Reviewed-by:
-
Gyuyoung Kim authored
//extensions/buildflags/buildflags.gni file has been importing build/config/features.gni file. But, it doesn't use any thing defined in build/config/features.gni. So, this CL removes the unneeded import. Bug: None Change-Id: Idd6528a33b0006a226cc2e1aae8ed82de5d51246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516059Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#823828}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I5492665f54e7d5a819f058d0f909d9ae609baa53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518099Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#823827}
-
David Black authored
Previously only horizontal (bottom) shelf was supported. RTL support still needs to be implemented in a follow up CL. Bug: 1142572 Change-Id: I3db767416869bb2c579850e4b8991d8bf1e568ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515094 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#823826}
-
Oleg Davydov authored
Replace std::string with ExtensionId in extension_updater.{cc,h} where applicable. This is a follow-up to https://crrev.com/c/2503690. Bug: None Change-Id: Idff56f4e5f6eb900834e355c62b2c8a8d3044521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516859 Auto-Submit: Oleg Davydov <burunduk@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823825}
-
Ana Salazar authored
As nearby shared files are added to the model, show the item chips in the holding space tray. The recently nearby shared files will show on the Downloads section and will be treated as regular downloads. Bug: 1130625 Change-Id: I082f46945138e487bb926c019a404af31b6871a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514774Reviewed-by:
-
Asanka Herath authored
These two parameters are necessary to partition statistically incompatible reports. Changes in `Generator` signal changes to code that affect how digests are calculated. Meanwhile changes to `Generation` signals that the study parameters have changed in a way that makes data from different `Generations` incompatible with each other. UKM Privacy Review: https://docs.google.com/document/d/15_Rcuc9P0UC26N26K8jM-W9uCsW57xEE83JksbWyZ-g/edit?usp=sharing (Google internal, but pretty much says the above). Bug: 1144225, 973801 Change-Id: I40e2d91e09150126ecbee9479db418a9f58c1193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510534Reviewed-by:
Alex Turner <alexmt@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#823823}
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I0ff55e17f4b2dd73517509b1521297f582113665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518324 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#823822}
-
Evan Stade authored
Bug: 1057100 Change-Id: I1e69334805631fb697d35ef05d611921dc81854b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518138 Commit-Queue: Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
This reverts commit 573667ec. Reason for revert: LocalSyncTest.ShouldStart is failing on Mac bots: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/60761 https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/56727 Original change's description: > Enable roaming profile support on mac and linux. > > Don't add a default roaming profile location, so this feature > will only work when RoamingProfileLocation is set as well. > > BUG:1145172 > > Change-Id: I0353e65127bdb84fc7185201d1908bb4b545db18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507890 > Commit-Queue: Chris Sharp <csharp@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823795} TBR=pastarmovj@chromium.org,csharp@chromium.org,treib@chromium.org Change-Id: I5cd261f409268e2318a27bfbe04e4091767afb6c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517345Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823820}
-
David Van Cleve authored
Document.hasTrustToken is a JS method only available in secure contexts. Its implementation involves getting a Mojo interface from the browser and sending an IPC. In the browser-side code, in RenderFrameHostImpl, where we handle requests from the renderer for this Mojo interface, we perform a security check to make sure we aren't receiving requests for the interface from unexpected places, which could indicate a bad renderer. The current check makes sure that the request is coming from a frame with a potentially trustworthy origin. However, this is not exactly the same thing as a secure context: in particular, allow-scripts sandboxed iframes can be secure but not have potentially trustworthy frame origins. This leads to false positives in the check and unwanted renderer kills. This CL removes the check. R=dcheng Bug: 1144057 Change-Id: I0e57669606effb15c672586297ef7dcf2711bc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511882 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#823819}
-
Jonathan Ross authored
The various GraphicsPipeline.* metrics are deprecated, replaced by the newer CompositorLatency.* metrics, which have more breakdowns from cc and blink. BUG=884851, 1088832 Change-Id: Ice3cd0cf07db8def51263bb080bfacebbaf9aa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120362 Commit-Queue: Jonathan Ross <jonross@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823818}
-
Mason Freed authored
With this CL, file:// URLs will no longer get an exemption to keep using Web Components v0 features. Bug: 1111843, 937746, 1025782 Change-Id: Ifbb8801b3d9eb02e124109c137e64dbbd8dafdf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514672 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823817}
-
Clemens Arbesser authored
An instance of this class will be shared across all trigger scripts to facilitate evaluating static trigger conditions. Bug: b/171776026 Change-Id: I07bef617159ec61f44ef6c96d899d8f3d01b771a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514154 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#823816}
-
Victor Costan authored
Change-Id: I8b65fa141781adc4016563bf54c6f621959ecc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518323 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
