- 07 Oct, 2020 40 commits
-
-
Eric Willigers authored
PendingAppManagerImplBrowserTest no longer uses web app ProviderType. Bug: 1065748 Change-Id: I7628ec04f5f990e37b17cdf4a9823a1e16bde8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454962 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#814740}
-
Eric Willigers authored
PendingAppManagerImplTest no longer uses ProviderType and is no longer parameterized. Bug: 1065748 Change-Id: I8841e10b771797238d91441dab623ac3a930aa5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454433 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Dominic Mazzoni authored
Fixes a regression caused by http://crrev.com/c/2424854 ("Refactor chrome.automation.EventType"), it could have manifested as select-to-speak not updating when the page scrolls. See http://crrev.com/c/2450663 for more context. Bug: 1110367, 1135248 Change-Id: I12e62a18093a0fc2837ec0be312d4f7261c5dc42 AX-Relnotes: none because this just fixes a regression Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454633Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814738}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010070700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/EP5Br5PmtIoxqkHULWlMdCAFh4JkRRBcAK3VRUi-3gwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/162270429,b/165769056 Tbr: media-app@grotations.appspotmail.com Change-Id: If38402881b0249caa72c321089afe3ec8104b1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456016Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814737}
-
Roberto Moura authored
Setting the cells' layer zPosition is necessary for lower rows to be superposed during transitions between grid and horizontal layouts. Change-Id: I335aaedf6eee0dca2e15a94558e58d2c2c48974f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456346 Commit-Queue: Roberto Moura <mouraroberto@google.com> Commit-Queue: edchin <edchin@chromium.org> Auto-Submit: Roberto Moura <mouraroberto@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814736}
-
Jian Li authored
This is a reland of 325dbbc8 Original change's description: > [Feed v2] Allow setting feed stream data in feed internals page > > Bug: none > Change-Id: Iecc0cb44e239c1b4502e81bc50931230732af61a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429930 > Commit-Queue: Jian Li <jianli@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#814073} Bug: none Change-Id: I580f6bcf05f9876db07a966d4ed9af51f924296b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451921Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#814735}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/935a915963e1..b364d20b12d2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2b15752d4abda84e8e760f8f4c0aca135c0806c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456149Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814734}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 347e8861. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mcasas@chromium.org: external/wpt/mediacapture-record NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: If36be818a6c12c6af2779bd823b1af78b5e6a7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456406Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814733}
-
Dominic Mazzoni authored
In http://crrev.com/c/2424854 ("Refactor chrome.automation.EventType"), we simplified the mappings from ax.mojom.Event and EventGenerator events. However, a minor oversight was that the previous code mapped some generated events into automation events with different names. With the new code, they map to an automation event with the same name - but the old names still exist so they didn't generate a compile error. To ensure this was comprehensive, I wrote some code to log all of the event mappings before and after the patch, and did a diff to look for discrepancies. The diff is here - https://paste.googleplex.com/6408048659660800 - but the only relevant ones are: - ariaAttributeChanged - expandedChanged - scrollPositionChanged This patch fixes any instances of those three events in Switch Access in particular. This fixes at regressions with combo boxes and the virtual keyboard. Bug: 1110367, 1135248 AX-Relnotes: none because it just fixes a regression Change-Id: I5e3a3b98edb8d9fcdc3ad55b28ad2ce476da7e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450663 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Also moves the config for this from //base -> //build/config/compiler for symmetry with //build/config/compiler:wexit_time_destructors. Bug: None Change-Id: If117e5963df44fdc2f03e01716e8af16e2c91e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453460Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#814731}
-
Sylvain Defresne authored
With recent change to Multi-Window, the metrics were recorded per window instead of being recorded per BrowserState. Moreover, only the currently displayed window's metrics were sent when the app was backgrounded. To fix this, add a new base::SupportsUserData::Data object that is attached to the ChromeBrowserState. This object, SessionMetrics, stores the session metrics which are updated from events happening in all of the windows. In preparation of adding metrics that are only recorded for the off-the-record ChromeBrowserState, pass a set of flags to the method recording the session metrics to choose exactly which one should be recorded. Add a call to SessionMetrics::RecordAndClearSessionMetrics() for both the main and off-the-record ChromeBrowserState on application background event, and when the off-the-record ChromeBrowserState is destroyed. Bug: none Change-Id: Idee8ef1a1fb0be7153d4ceb78d0a795d589a9848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450052 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#814730}
-
Francois Doray authored
Bug: 982143 Change-Id: I3fc1482aad34db3bc6fc1931ea98f8a8bb4dd7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450738 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814729}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/c9110b93cb8a..a388d56d9968 2020-10-07 dsinclair@chromium.org [spirv-writer] Fixup constructor with bitcast parameters. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:263 Tbr: kainino@google.com Change-Id: I0a76f4f7215a7f8eda1a996d79b01f539dbe6510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456015Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: I929d7a955c9671748b2e7f7a370a39eecf1dbd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446653 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#814727}
-
Nohemi Fernandez authored
UI change that moves all Google Services and Sync options into their respective categories. Ensures that all Sync status updates are respected. Bug: 1125631 Change-Id: I30cc039ca924a856b555b6215c9a25f6bcf07188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445513 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#814726}
-
Majid Valipour authored
R=goto@chromium.org Change-Id: I2ec08e9a5c7610066d04860555e1d9bf03432c26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456147Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#814725}
-
Weilun Shi authored
All new chromium metrics OWNERS need to go through a training process prior to being added as formal owners. Bug: 1133371a Change-Id: I9754559357078d74da73924406ede9c7435c06ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453342 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814724}
-
Yunke Zhou authored
Bug: 1135512 Change-Id: I96d28c6817b8661e9a201d759ee6d6ef620cb1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2455749Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#814723}
-
Richard Knoll authored
I've been working on notifications for a while now so adding myself as an OWNER to reflect that :-) Bug: None Change-Id: I2f185b5a1d6060717d44e8bb67425832f3d01d96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457106 Auto-Submit: Richard Knoll <knollr@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#814722}
-
Boris Sazonov authored
Disables testReject, testRejectBasicCard and testDetails on tablets. Reason: flaky (builder links: https://crbug.com/1136100#c1). TBR=rouslan@chromium.org Bug: 1136100 Change-Id: I818fe70318c063755a7329b473117bbef779b3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456847Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#814721}
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/093cc27604..4b4f9aae75 Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/093cc27604..4b4f9aae75 No .def file changes. Bug: None Change-Id: Ie56604087d635647c9d4dff01aaa7ce332299f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456347Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#814720}
-
Eric Willigers authored
DesktopPWAsWithoutExtensions has shipped. The test no longer needs to be paramaterized. Bug: 1065748 Change-Id: Ie4d7ce9659179e6f925d21533c198f0c0030590d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454595 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#814719}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ifea18890a5bc6144ae6a5581525d1495ff037a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453926Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#814718}
-
Weilun Shi authored
Add /tools/metrics/histograms/histograms_xml/*.before.pretty-print.xml to gitignore to ignore generated before.pretty-print files for split histograms as well as histograms_xml/obsolete_histograms.xml and histograms_xml/histogram_suffixes_list.xml Change-Id: I308bdfe8ff205def461418aca7a527c4ca3998a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437729 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814717}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7e22b1c44fb0..2ee68783068c 2020-10-07 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 488d7a9346ff to c9110b93cb8a (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: I7ad75828c853dd33fd15bd0eb55db1de4ae4a87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456188Reviewed-by:
-
Fabio Tirelo authored
This fixes an issue of UEMs sending empty string for unset policies on Android (issue happening on both GEM and AirWatch). Until all UEMs fix this issue on their side, we should fail gracefully. The proposed approach is simply consider that special case as policy not-set for policies with type list or dictionary. I inspected all list and dict policies, and the only ones for which I expect changes in side-effects are: - DefaultSearchProviderAlternateURLs - DefaultSearchProviderEncodings - ProxySettings The DSP policies are fine, as discussed before. They will in fact prevent other policies from not being set when values are pushed via managed configurations, especially the most basic DefaultSearchProvider ones. The ProxySettings policy should also be OK. When it's unset, values from ProxyMode, ProxyServerMode, ProxyServer, ProxyPacUrl, and ProxyBypassList will be used instead. BUG: 1134739 Change-Id: Ib194b432df0b1f6caba7340bb82496a44ff2c924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443669 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#814715}
-
Anne Lim authored
Adds a footer at the bottom of the InfoBar which spans the InfoBar's whole width. Screenshot where a footer is added to SavePasswordInfoBar: https://screenshot.googleplex.com/AVqcryn4jnEcoT9 Bug: 1135847 Change-Id: I8c3cd9968ced6ee4280b3929671e5e61043d4fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454694Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#814714}
-
Michael Hansen authored
This updates the account row on the Nearby settings subpage to display the user's full name instead of the device name. Screenshot: https://screenshot.googleplex.com/C3uXbjhA2QaDrNQ.png Bug: b:166779043 Change-Id: Icc1eeddc3100bcb78c4ac7c9699972d67eec9f2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454094Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#814713}
-
Dylan Cutler authored
identifiability study. This API leaks information about users' machines' GL implementation which could be used to identify users across different origins. The instrumentation reports digests of the value returned by this method when the study settings are enabled. For a similar CL that instruments WebGLRenderingContext.getShaderPrecisionFormat() see: https://chromium-review.googlesource.com/c/chromium/src/+/2431782 Bug: 973801 Change-Id: Ib7dea35f5a3d87591fea9f83a9c8cc0a11570797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441021 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814712}
-
Jeffrey Young authored
Construct ambient widget when two images are in memory to prevent burn in. BUG=b:167332126 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I520ada00429125d35bda9ef66089ca9a9c8d4440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440306 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#814711}
-
Elly Fong-Jones authored
This change makes it clearer that the window title can never change once this dialog is shown, and removes a bunch of now-unneeded overrides of WidgetDelegate methods. Bug: 1075649 Change-Id: I3f720f92e9e4ca4a6cdd1cade48bd53c861d2252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453189Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#814710}
-
Maks Orlovich authored
It may not be available, making the test flake. Bug: 1135894 Change-Id: I5b4a2db692c7bc25c39d8eea0776e6fdb447982f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456290Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#814709}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/10d329d9803b..a51c2a0b4243 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 63cc22d645ba to fc8264854c53 (1 revision) 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 14289452a832 to 1abaced34b84 (1 revision) 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from afe6ca45b6da to 635de036d766 (3 revisions) 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from c7d7610581df to e171d8431cfa (1 revision) 2020-10-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from 3610ce9fa2d8 to a638f3acae94 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ie0d91b7164ffb324d2e77072cdeda41a8d5e436e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456326Reviewed-by:
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We rewrite below tests fast/scroll-behavior/main-frame-interrupted-scroll.html, fast/scroll-behavior/overflow-interrupted-scroll.html and fast/scroll-behavior/subframe-interrupted-scroll.html into browser tests because we cannot guarantee that the scroll arrives before the animation completes. TBR=bokan@chromium.org Bug: 1047176 Change-Id: I46a6cb0697b8a74ff260aafbc2fc60a7d65ae1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446534Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#814707}
-
Simeon Anfinrud authored
Chromecast internal code was making use of this. Added an exhaustive list of internal chromecast's android dependencies that should be checked by gn gen to prevent similar situations from arising in the future. Bug: Internal b/169779668 Test: build internal chromecast apk with this patch and chromium-review.googlesource.com/2425010 cherry-picked. Change-Id: I9c32af013a718e44f1f79e7465f4d6c2c185c671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453433Reviewed-by:Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#814706}
-
Wei Lee authored
This CL fixes a bug that will cause camera failed to play the preview. Bug: b/166850715 Test: Launch Chrome Camera app and preview is shown Change-Id: If61d74dc9478bc6138389b9fa6c0dded5a6e8359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454592 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814705}
-
Matthias Körber authored
This CL adds concurrent experiments for stable and beta to the field trial configuration. Change-Id: I83a0afef311d3df2f8881ce2684cf86847660372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452474 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#814704}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4af799c5156f..e66f55b48608 2020-10-07 mulherje@gmail.com Switched to empty string for live expression preview during creation 2020-10-07 szuend@chromium.org [ts] Type-check network/RequestInitiatorView.js with TypeScript 2020-10-07 szuend@chromium.org [ts] Type-check network/NetworkTimeCalculator.js with TypeScript 2020-10-07 szuend@chromium.org [ts] Type-check network/SignedExchangeInfoView.js with TypeScript 2020-10-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-10-07 sigurds@chromium.org Revert "Disable new resource loading mechanism to debug flaky test" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1069378,chromium:1126033 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib445bb08aaec91ad29d6ec543056aee45b32930c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2456010Reviewed-by:
-
Peter Kasting authored
This also reorders the definitions in one file to match the declarations. Bug: 772945 Change-Id: I74f04421cdab8acd02e380a317155bd1bdcc2a62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454789 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#814702}
-
Yi Gu authored
There are UMA metrics to measure the duration from when the API is called to when the SMS is received / a user clicks "Allow" to complete the flow. We want to add corresponding UKMs to help with the feature adoption. Note that the UKM that records the duration from when the API is called to when a user clicks "Deny" to abort the flow will be added in a follow up patch after crrev.com/c/2428825. UKM collection review: https://docs.google.com/document/d/15orQiLx06QSuZr4ShBaozY0dvPzXiTWwJZ9Xk5cgzAA/edit?usp=sharing Bug: 1127402 Change-Id: I204bd469ca203182eba6a37f3522d7a492cc937d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429236Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814701}
-
