GitLab

Sync: `make update`

Run the tests: `make test`

R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/462973002

git-svn-id: svn://svn.chromium.org/blink/trunk@180082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Removed part of the check related to the type of agent. This test was important when the engine used another JS engine.

ScriptState no longer participates in check. And now only used to obtain the ID of context.

The method createScriptCallStackForConsole now uses a method call createScriptCallStack forming a stack which is able to receive an empty stack and not adds a fake frame.

NOTRY=true

Review URL: https://codereview.chromium.org/460743003

git-svn-id: svn://svn.chromium.org/blink/trunk@180081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change removes all the following errors

CONSOLE MESSAGE: Invalid name for preference: foobar

by removing 2 tests that were the only users of some invalid
preference and removing some unneeded override in the css3/filters/
directory. It also adds a presubmit hooks so that we don't let
more errors creep into our tests.

Review URL: https://codereview.chromium.org/457893003

git-svn-id: svn://svn.chromium.org/blink/trunk@180080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

handleDidCancel() doesn't handle m_loader->cancel() in internalAbort().
It's for handling cancellation coming from other components.

BUG=none

Review URL: https://codereview.chromium.org/467593002

git-svn-id: svn://svn.chromium.org/blink/trunk@180078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The rebaseline at https://codereview.chromium.org/453923002 used system fonts.
Test fonts are once more being used.


git-svn-id: svn://svn.chromium.org/blink/trunk@180077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use tighter typing in editing/ to increase code readability and to avoid
unnecessary type checks. This CL focuses on ReplaceSelectionCommand.

R=leviw@chromium.org, yosin@chromium.org

Review URL: https://codereview.chromium.org/423413005

git-svn-id: svn://svn.chromium.org/blink/trunk@180076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The affected tests have returned to normal, remove suppressions.


git-svn-id: svn://svn.chromium.org/blink/trunk@180075 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove autogenerated patterns instead of just disabling them to avoid cluttering.

BUG=267592
R=vsevik

Review URL: https://codereview.chromium.org/458583004

git-svn-id: svn://svn.chromium.org/blink/trunk@180074 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Skia GPU and software do not appear to agree in this case.
The GPU is more correct, the tracking bug is investigating software.


git-svn-id: svn://svn.chromium.org/blink/trunk@180073 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This events will be used to figure out if given worker thread is started by the page being profiled and if so we will show messages in the worker on the same Timeline.

BUG=401895

Review URL: https://codereview.chromium.org/460363002

git-svn-id: svn://svn.chromium.org/blink/trunk@180072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

SVGRenderSupport::layoutChildren() determines whether the size of the
nearest viewport has changed upfront, and then uses this information to
force a re-layout of relative-length children.

But the relative-length flag is always propagated up the ancestor chain
(see SVGElement::updateRelativeLengthsInformation), so we can
immediately tell whether there are any relative-length descendants. If
there aren't, we can skip the viewport change crawl and related logic.

R=pdr@chromium.org,schenney@chromium.org,fs@opera.com,ed@opera.com

Review URL: https://codereview.chromium.org/458833002

git-svn-id: svn://svn.chromium.org/blink/trunk@180071 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=383813

Review URL: https://codereview.chromium.org/463633004

git-svn-id: svn://svn.chromium.org/blink/trunk@180070 bbb929c8-8fbe-4397-9dbb-9b2b20218538

    
Custom validation message, to use for main message first character direction. For subMessage, if direction is auto, then first character direction is applied, else RTL/LTR values are applied.    
 
* HTMLFormControlElement.cpp:
Helper function for custom message, for the main message determineDirectionality is used. Sub Message uses element direction, if element direction is not present, then style direction is used.
* ValidationMessageClientImpl.cpp
Change of direction to web direction.   
* ValidationMessageClient.h
  ValidationMessageClientImpl.h
Pass direction and sub message information. 
* WebViewClient.h
Header file that will be used by chrome side and includes extra direction for subMsg. Old function is kept as placeholder till landing patch.

BUG=91638
R=tkent, leviw

Review URL: https://codereview.chromium.org/389343002

git-svn-id: svn://svn.chromium.org/blink/trunk@180069 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We need to clear preprocessor when disabling inspector.

LeakExpectations : remove fixed bugs of inspector 

BUG=301515, 364408, 376188
R=haraken@chromium.org
R=kouhei@chromium.org

Review URL: https://codereview.chromium.org/458933002

git-svn-id: svn://svn.chromium.org/blink/trunk@180068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://src.chromium.org/viewvc/blink?view=rev&revision=180040 introduced
the WebCredentialManager interface, but neglected to create default
constructor/destructor implementations. This trivial patch corrects that
oversight.

BUG=400674
TBR=tkent@chromium.org

Review URL: https://codereview.chromium.org/466713002

git-svn-id: svn://svn.chromium.org/blink/trunk@180067 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The following sources are added:
- Node
- Array.prototype
- Date.prototype
- Object.prototype
- String.prototype

BUG=391593

Review URL: https://codereview.chromium.org/455343002

git-svn-id: svn://svn.chromium.org/blink/trunk@180066 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also add a nice paper expand button.

BUG=399717
R=ojan@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/458473003

git-svn-id: svn://svn.chromium.org/blink/trunk@180065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402801
TBR=timloh@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/463823003

git-svn-id: svn://svn.chromium.org/blink/trunk@180064 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Runtime.prototype.registerModule() should not be available publicly,
as changes in the configuration require the devtools restart.

R=eustas, pfeldman, vsevik

Review URL: https://codereview.chromium.org/460323002

git-svn-id: svn://svn.chromium.org/blink/trunk@180063 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
Android Builder failed to compile

Original issue's description:
> Oilpan: fix build after r180052.
> 
> TBR=haraken,oilpan-reviews
> BUG=383813
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180061

TBR=haraken@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=383813

Review URL: https://codereview.chromium.org/461963002

git-svn-id: svn://svn.chromium.org/blink/trunk@180062 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken,oilpan-reviews
BUG=383813
NOTRY=true

Review URL: https://codereview.chromium.org/460983002

git-svn-id: svn://svn.chromium.org/blink/trunk@180061 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/458313005

git-svn-id: svn://svn.chromium.org/blink/trunk@180060 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previous implementation did not block mixed content when the srcset attribute was empty.
This CL fixes that.

BUG=402792

Review URL: https://codereview.chromium.org/467533002

git-svn-id: svn://svn.chromium.org/blink/trunk@180059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch [1] removed the global capabilities set. The power profiler depends on whether
there exists a power service and it has a valid data provider. If these are met, only then
the devtools can do power profiling.

The checkbox "Power" should only be visible if the capability exists. Restoring the required
checks.

[1] https://codereview.chromium.org/388963004

Review URL: https://codereview.chromium.org/463853002

git-svn-id: svn://svn.chromium.org/blink/trunk@180058 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In method createScriptCallTackFromConsole we can get current execution context in function body without passing it in arguments.

Removed canGenerateCallStack argument from InspectorConsoleMessage cstor which uses the transmitted stack.

Review URL: https://codereview.chromium.org/458253002

git-svn-id: svn://svn.chromium.org/blink/trunk@180057 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now context menu item for documentation is not created if WebInspector.DocumentationURLProvider cannot provide a URL for selected property.

BUG=391593

Review URL: https://codereview.chromium.org/458983002

git-svn-id: svn://svn.chromium.org/blink/trunk@180056 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Since this file is associated with the Editing module, this should
be kept in core/editing instead of core/page.

BUG=402417

Review URL: https://codereview.chromium.org/467503002

git-svn-id: svn://svn.chromium.org/blink/trunk@180055 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes the functions:
- lastMatchedRulesPosition
- sortMatchedRulesFrom
- sortAndTransferMatchedRulesWithOnlySortBySpecificity
from ElementRuleCollector as they are unused (and the latter two don't
even have definitions).

Review URL: https://codereview.chromium.org/460263002

git-svn-id: svn://svn.chromium.org/blink/trunk@180054 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It's not a good idea to use global variables in PrivateScriptRunner.js
because they are exposed to all window objects of the private scripts.
This CL reduces the number of global variables used in PrivateScriptRunner.js.

Also this CL removes a |global| parameter from installClass()
since the |global| is always equal to the window object of the JS file.

BUG=341031

Review URL: https://codereview.chromium.org/466623002

git-svn-id: svn://svn.chromium.org/blink/trunk@180053 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/GLl6aWs9-EM/uTqxEmM4iGcJ

The API is only enabled for testing, to allow the recent spec changes
to be implemented with tests for the new API: http://crbug.com/402376

This does not add support for the :fullscreen pseudo-class, which is
tracked by a dedicate issue: http://crbug.com/402378

BUG=383813

Review URL: https://codereview.chromium.org/395633011

git-svn-id: svn://svn.chromium.org/blink/trunk@180052 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds the flag 'inherited' to CSSProperties.in, replacing the
existing switch statement in CSSProperty.cpp. The primary use for
isInheritedProperty appears to be as part of the MatchedPropertiesCache
optimisation.

I've added the inherited flag to overflow-wrap and paint-order, which
are inherited in the code and specs[1][2] but were not returning true
in the switch. As far as I can tell, this has no difference aside from
making us still use the MatchedPropertiesCache if these are explicitly
set to inherit. I also added a fixme indicating that the property
resize shouldn't inherit by default.

[1] http://dev.w3.org/csswg/css-text/#overflow-wrap-property
[2] https://svgwg.org/svg2-draft/painting.html#PaintOrder

BUG=396992

Review URL: https://codereview.chromium.org/450103005

git-svn-id: svn://svn.chromium.org/blink/trunk@180051 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/463043003

git-svn-id: svn://svn.chromium.org/blink/trunk@180050 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are may well be several threads with same name, e.g. all worker threads will be called "WebCore: Worker". Such threads should be displayed as separate threads on tracing based timeline.

BUG=401895

Review URL: https://codereview.chromium.org/463033002

git-svn-id: svn://svn.chromium.org/blink/trunk@180049 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true

Review URL: https://codereview.chromium.org/460953002

git-svn-id: svn://svn.chromium.org/blink/trunk@180048 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402805
TBR=pfeldman@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/464783002

git-svn-id: svn://svn.chromium.org/blink/trunk@180047 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Like [1] and [2]. We should do it in general.

[1] http://src.chromium.org/viewvc/blink?view=revision&revision=180023
[2] http://src.chromium.org/viewvc/blink?view=revision&revision=180029

BUG=398342

Review URL: https://codereview.chromium.org/459353002

git-svn-id: svn://svn.chromium.org/blink/trunk@180046 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=None

Review URL: https://codereview.chromium.org/467523002

git-svn-id: svn://svn.chromium.org/blink/trunk@180045 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/453393002

git-svn-id: svn://svn.chromium.org/blink/trunk@180044 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to the spec the ::first-line pseudo-element do not apply to
grid containers (neither to flexboxes).

Modified RenderBlock::findFirstLetterBlock() to use isRenderBlockFlow()
instead of isFlexibleBox(). This change has been already made before in
several parts of the code, but there was one missing case here.

Fix issue in RenderBlock::updateFirstLetter() that applies to both grids
and flexboxes. Basically if the grid's or flexbox's container was
defining the ::first-line pseudo-element and the grid or flexbox itself
too, the value from the grid or flexbox was being applied to the items.
Add the proper check to avoid this.

Added two new tests for grid and modified flexbox test to cover the
issue explained above.

TEST=css3/flexbox/flexbox-ignore-container-firstLetter.html
TEST=fast/css-grid-layout/grid-container-ignore-first-letter.html
TEST=fast/css-grid-layout/grid-item-first-letter-valid.html

BUG=395788

Review URL: https://codereview.chromium.org/440233002

git-svn-id: svn://svn.chromium.org/blink/trunk@180043 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=402801
TBR=zerny@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/467553002

git-svn-id: svn://svn.chromium.org/blink/trunk@180042 bbb929c8-8fbe-4397-9dbb-9b2b20218538