Commits · 6e5d813b27ade2b24522e371f1443ca3cd315486 · eriksson monteiro / tangled

04 Jun, 2020 40 commits

[tools/perf] Fix power metric in the case of counter overflow · 6e5d813b

Mikhail Khokhlov authored Jun 04, 2020

Change-Id: I11d1608458710b2a5ef91322dc65c7ade9645cf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228620Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#775069}

6e5d813b

[multiball] Add button to switch to blocking scene. · 64506e4b

Stepan Khapugin authored Jun 04, 2020

Adds a button to the blocking overlay that switches to the scene that
is currently showing the blocking UI.
For this, a new protocol is created, and a new, app-level dispatcher
is added to AppState.

Bug: 1072408
Change-Id: Icfce6ea5607270726654e5910a24d924eb3d8ba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219896
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775068}

64506e4b

Check device policy when enabling sideloading toggle · cc562fdb

Jana Grill authored Jun 04, 2020

Retrieve the value of the device policy and use it when deciding
whether to enable or disable the adb sideloading toggle in settings

managed device and account when feature flag is enabled

Bug: 1073928
Test: unit tests, passing different policy values using YAPS on a
Change-Id: I9c04c49ac985706c387dee3c8bc57c32598c4d3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199114
Commit-Queue: Jana Grill <janagrill@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775067}

cc562fdb

Rename HasExplicitlyInheritedProperties to ChildHasExplicitInheritance · c50c815a

Anders Hartvoll Ruud authored Jun 04, 2020

The name is misleading, because it's actually a flag set on the parent
style when some child uses explicit inheritance.

This CL renames the flag such that name makes sense, and also because
we need to free up the current (approximate) name for a new flag
(in a subsequent CL).

Change-Id: Ie960dccf961b49b716824c44de9d3233522f96d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228879Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775066}

c50c815a

Handle ShortcutItem in multiwindow · d28dc35f

Olivier Robin authored Jun 04, 2020

As a completionHandler has to be called after handling the item, it is
not clear how to do just set an item in SceneState and call the
observers.

Bug: 1069748
Change-Id: I02b8e5e4031323cbe7b60bea5045da16aab7c9d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228533
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775065}

d28dc35f

Roll ANGLE from 989c790d4b8b to cabedcafaa77 (3 revisions) · f75a6e46

chromium-autoroll authored Jun 04, 2020

https://chromium.googlesource.com/angle/angle.git/+log/989c790d4b8b..cabedcafaa77

2020-06-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 78a3c915a1d7 to 232ba0d848d1 (1 revision)
2020-06-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from d43f5107400d to 4685ffce93ad (5 revisions)
2020-06-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 3ad285a60d82 to 0711869b5f20 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ynovikov@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: ynovikov@google.com
Change-Id: I5978155b98d11fdd77743712c270d8e9d82ba84a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230879Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775064}

f75a6e46

OOR-CORS: Add virtual/cors suite to maintain both CORS code paths · 6736c623

Takashi Toyoshima authored Jun 04, 2020

Bug: 1091139
Change-Id: I9cd3e5f9f93fb82b5d026a54d4ef5dbcc2e91459
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230581
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775063}

6736c623

[ios] add origin to scene state for multi-window · c448a701

David Jean authored Jun 04, 2020

Bug: 1084905
Change-Id: I10f69d7156d42f30ec277dff55f90f0f13463b4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219887
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775062}

c448a701

Fix a webkit TestExpectations lint error · 2d6ac63d

Martin Šrámek authored Jun 04, 2020

By removing line 5921 which is redundant given line 5343.

Bug: None
Change-Id: I3f5edf7756a53586c48023980921c5aa3bc0246a
TBR: jonross@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230623Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775061}

2d6ac63d

[iOS] Change URL blocking check · 543ebe41

Gauthier Ambard authored Jun 04, 2020

The URL blocking check should actually check if the URL might be blocked
instead of checking for the feature being enabled.

Bug: 1073932
Change-Id: Idd3cc76fa04e6db45fb2eab3e3ee9dc674705834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230480
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775060}

543ebe41

Roll DevTools Frontend from 292a49b80b32 to 722db7ecd0fb (1 revision) · 96ce7602

chromium-autoroll authored Jun 04, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/292a49b80b32..722db7ecd0fb

2020-06-04 bmeurer@chromium.org [wasm] Remove left-over TODO in E2E test.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1043047
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ibaa2b7f0de26c25c4eecd5787f0b56aecc22c0b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230880Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#775059}

96ce7602

Prepare test for error message change in WebRTC. · 61cf284f

Yura Yaroshevich authored Jun 04, 2020

The error messages will be updated by CL:
https://webrtc-review.googlesource.com/c/src/+/176448

Bug: webrtc:10139
Change-Id: I1c68fdbe030b2c46bdd52d83a45fff11b70e9526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228545Reviewed-by: Tommi <tommi@chromium.org>
Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com>
Cr-Commit-Position: refs/heads/master@{#775058}

61cf284f

Update view_source tests to handle same-site BrowsingInstance swap · 892d4174

Rakina Zata Amni authored Jun 04, 2020

With crrev.com/c/2121522, some main-frame same-site navigations will
result in a new BrowsingInstance, SiteInstance, RenderFrameHost,
RenderView, etc. This CL updates expectations of view_source tests
that didn't expect a change of RenderFrameHosts etc. on same-site
navigations.

This CL does not include fixes for other tests in chrome/ content/,
components/, and layout tests (they're fixed in other CLs)

For more details, see doc: https://docs.google.com/document/d/1lHdkKLUe8H6ZP6ALwj-dsus7oYcuc93HkSCHCcerItg/edit?usp=sharing

Bug: 977562
Change-Id: Idc7b35c7cb01bacdcc0c13b083b2263b3a07dd14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212225
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775057}

892d4174

Remove X11 deps from accessibility · 26eaf07d

Maksim Sisov authored Jun 04, 2020

This fixes pure ozone/wayland build on systems where
X11 is not available

Change-Id: Ib4e41c2fd149b48586623183d8fa656591415361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228649Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#775056}

26eaf07d

Adds ChangeTabSwitcherPosition to Field Trial Testing Configuration · 62ef43a9

Ewann authored Jun 04, 2020


Bug: 1073826
Change-Id: I378c67f926df54bd4bd75d0a64f7b241534238a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208971
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775055}